From patchwork Tue Jun 16 14:08:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 2rd bunji X-Patchwork-Id: 20426 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 5C65C4492AA for ; Tue, 16 Jun 2020 17:24:02 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E7AF68B78D; Tue, 16 Jun 2020 17:24:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-oln040092254097.outbound.protection.outlook.com [40.92.254.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 690BF68B0D5 for ; Tue, 16 Jun 2020 17:23:55 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n3+jSi7NDDTwOMZRvAPoSXa23OG7uxYZFFKl8geYssbiA/OiZcRW1/ZJIDq8KnHV3v9RdQqOsiJk53B70fVhiGTLBINuE63skK8j0lfKtf6De8sfNx0fj+L+BBJn5FEoPo6VagNheefudLP1gwCR/nWbwIdZRcvKfDci/Y8lN8vFSMZkS1ImAyz6xxl6nXtz4FATfpxzhewBvaGZhtxlQ01J9PoQsraM3g710fVnkut1yUitrdJsVNBbU4dm8CgF4ssJbHkkjbk6HyGj/ObKG2A9gKaMdYm992VS87vnCZH9sUaXJNir3TW12beKwZgMCok8ptiEiabCjHdHAZ82kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8DcPNvmz5GsfUylcMkhay+kqTKUizxR7QYfky4BdNA=; b=XBs/v/lnmJUEhI9mWOd9/iqG7DZBz1QPDmxXMZAio/Lqo1vk1yJMNKV+wyG4sCCpSQIxeHrKb5AONbihGJBHODyOP/NQt2yVyzEeU1q+cq1fUYIhCMuLKV09/gpbOddVCW2fx27xFc1g/A++uIYgbyASUeF5f324UA8G8QespjJ3JSRfsMMuiQbCqcFg8ys+yjiXZkvl6FXhPtUuk0k77U0V5t0LPkQDFtfCSqzOahqA/kOtIBhzkGGp4hgYGB1PFJiiLlmMVaSF806La9DVL+ExJ5VOgTdafz9vcjSMKZX/rqw7Os6mTzqgoPzR7yO7CR3im0CTFyMaFEn6At3ADw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8DcPNvmz5GsfUylcMkhay+kqTKUizxR7QYfky4BdNA=; b=WB6YSezJRPHQnF9MkR4FMqEa6cUH3POzGpBPfzOxDj+I6N/HM2HaYA2MNQVt69xWLzCvrq8aNTQt4+nhzGM/ECr5i29Q9jiv1A6pro9Zb9BMEI3Ot8gA4yN0fibRUpWv3nHZBrdlKCdJWbmP9n/6dMTrG1YbneRIYdKy5GhS5lLjmyqdDAHQXKrkRiVrqulueW5gI6kr99eXJ/YEVEpuSHZQzfFW4uVHrESCjnkPJul+U8PYVlnFEx2Kn2+dbUtOjiePEWDvUuK3xPgeAjCp2xcqtPg4ge1wIo2YiXnKpJEXj+F1o57/rUeBlpfoCc2EyNnGAk8KEFS6g8AtGWHv3Q== Received: from HK2APC01FT047.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::53) by HK2APC01HT217.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::396) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Tue, 16 Jun 2020 14:09:01 +0000 Received: from HK0PR02MB3458.apcprd02.prod.outlook.com (2a01:111:e400:7ebc::53) by HK2APC01FT047.mail.protection.outlook.com (2a01:111:e400:7ebc::342) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Tue, 16 Jun 2020 14:09:01 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:3EC81221F2D9807CE414AD74B6E4948EB83BCD34B56D5DE9463BD3BBEE30C538; UpperCasedChecksum:4BB837420F07C7305A86A5D9E921EE337D59FCCED1C10C4232491B2EEC480969; SizeAsReceived:7458; Count:47 Received: from HK0PR02MB3458.apcprd02.prod.outlook.com ([fe80::7de7:d504:5335:3e63]) by HK0PR02MB3458.apcprd02.prod.outlook.com ([fe80::7de7:d504:5335:3e63%7]) with mapi id 15.20.3088.029; Tue, 16 Jun 2020 14:09:01 +0000 From: Lu Jiao To: ffmpeg-devel@ffmpeg.org Date: Tue, 16 Jun 2020 22:08:19 +0800 Message-ID: X-Mailer: git-send-email 2.27.0 X-ClientProxiedBy: HK2PR02CA0217.apcprd02.prod.outlook.com (2603:1096:201:20::29) To HK0PR02MB3458.apcprd02.prod.outlook.com (2603:1096:203:7d::22) X-Microsoft-Original-Message-ID: <20200616140819.1878-1-sourpotato@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (180.167.199.182) by HK2PR02CA0217.apcprd02.prod.outlook.com (2603:1096:201:20::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.19 via Frontend Transport; Tue, 16 Jun 2020 14:09:00 +0000 X-Mailer: git-send-email 2.27.0 X-Microsoft-Original-Message-ID: <20200616140819.1878-1-sourpotato@live.com> X-TMN: [ykx6WNF4l+fj7Rkzk18FSuzuLXawHSe0AX2BzuychTY=] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 3f40b9fd-1081-43d1-d6f7-08d811fed155 X-MS-Exchange-SLBlob-MailProps: 28a0PtNssKlhXsb8TmvAiizxMErHDzgaf+T1do8rGTSR1CykKMa4ddzsXZlo+VpMbJeDorssHlDclkZH4Q9ayApqcho5Qv4XIV0PnUATaC0KfjikXufCtldSzpCz0naYZHN3jclhWRfxZySkm1YoYt9LNuQKWIafxDHRqEXXGZVOxDdYspzywycXZLahYTVTPOOlS52NBrgzILOBVZDcDcnwrEsPZL2n0lPzP0BdkiQ8jJpgtKH2Z9JaHXkuwRXfzPyfYYoXX5H4ShzMiF/U1BztIX7JBM/97vTys16GMMxuNJaSsEHKC5xhRx+m+Eqo7a68K9ur88FUYPYPM2t0GrcU4GzpI2ID/eu6MxPCQ6l+Y/MHlAck8svCK8oHmQ/dW1J43CP/jN4OsVIp4rixPfyd4dpJnN8BaNbcUy/cNSYnj8AgPlvMLMcBITsvFg0OsL5iS2xjBc1qHwCMGOpXJ7Fx/ERUzY7KDf7zViLxmIeg1TSwYXGzaBAMQRF37nWvP+159v9vUOwkq5vLcTFAZPfNN4FhYW1MzSuZbgdg8sVeBKv2r8R7SXKg8Ln04vL8L8U62NJMqBqdiwkjpFYwXFlG2S1Nm7qrqYD9jTZVTudyhSBqceOCaZ9N63HMjoRJLgSRcB3lhPol1oZcdqsW4qSdmXT58pSscO2BVNQj9glyBXrgOGGUqAwatYP6IwHmVQZABDkYmuSIFOSnyaGZso94eU/xXHr4Nu23lpRu8alNjhsEmeTQZrpx0YU43UhwuAZEv+hlu3K5TNX3qvczQh6NoHLzDyuOZDFwJ/LDd42Y8e4697Yr1mSOye98LdBNWDXjAc0h3T1k1yNJwd8C4A+XUpA9TYRj7YqpKQCatpYLwdXTYT7X+QKuBzd1kFUnv2FqfvmzGGNN0GKKUpcMZg== X-MS-TrafficTypeDiagnostic: HK2APC01HT217: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IoBmR4+yMquHjpd6vVpPPmqWJMGyKymfJo7w+tpHA80+Eq8J/7DbFudjl1AnULiFPG8HpUQ+CXcsqGGt8MfBh6J3HfmkV1dJt8Cos3yVNbcRncVydfLgWDZHYrzKapBzP7DgYiwaltTe5RqxesOUSk0HdiKc1m5Cz4Ma5Cpeoz4Pf3KE69B3dVHokzgyYmhx7MNXB52YXsHQagWwd/2DIEMpyk4bU0BH5SQ35p6AK9MRjyur1HuVjG9fx/0ZEAU8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR02MB3458.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: ONGFEB9zUm7Tb1C3txnbMFfeke/kKHqCRS7uDXdVaXaFLHxEbZnVO4xYilbMLeOOoSt2cM3oU/WrwNC0U5/OqiS9NjDp36dpL5MZAO31inDfCaN0LFnRb7HiQNEigMHYymeHzQokBau+rhGYiUp8pg== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f40b9fd-1081-43d1-d6f7-08d811fed155 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2020 14:09:01.0660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT217 Subject: [FFmpeg-devel] [PATCH] area changed: hevc_amf set default gops_per_idr 1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lu Jiao Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Previously gops_per_idr default 60 would make amd gpu encoding hevc has erratic seek bar behaviour as descripted in this ticket: https://trac.ffmpeg.org/ticket/7272 --- libavcodec/amfenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c index 77e57d2461..b0cb57cb96 100644 --- a/libavcodec/amfenc_hevc.c +++ b/libavcodec/amfenc_hevc.c @@ -69,7 +69,7 @@ static const AVOption options[] = { { "gop", "", 0, AV_OPT_TYPE_CONST, { .i64 = AMF_VIDEO_ENCODER_HEVC_HEADER_INSERTION_MODE_GOP_ALIGNED }, 0, 0, VE, "hdrmode" }, { "idr", "", 0, AV_OPT_TYPE_CONST, { .i64 = AMF_VIDEO_ENCODER_HEVC_HEADER_INSERTION_MODE_IDR_ALIGNED }, 0, 0, VE, "hdrmode" }, - { "gops_per_idr", "GOPs per IDR 0-no IDR will be inserted", OFFSET(gops_per_idr), AV_OPT_TYPE_INT, { .i64 = 60 }, 0, INT_MAX, VE }, + { "gops_per_idr", "GOPs per IDR 0-no IDR will be inserted", OFFSET(gops_per_idr), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, INT_MAX, VE }, { "preanalysis", "Enable preanalysis", OFFSET(preanalysis), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, { "vbaq", "Enable VBAQ", OFFSET(enable_vbaq), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, { "enforce_hrd", "Enforce HRD", OFFSET(enforce_hrd), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE},