From patchwork Thu Nov 17 11:53:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lynne X-Patchwork-Id: 39320 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp1044657pzb; Thu, 17 Nov 2022 03:54:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf4PNfqKd3VThe1jB+eOqJVfIBtOqTLd9ZKp/zteskp5AMhjQh/TDhyfA7WXaLsC0bMgIxpK X-Received: by 2002:aa7:cb15:0:b0:458:e9c0:3e6f with SMTP id s21-20020aa7cb15000000b00458e9c03e6fmr1908921edt.61.1668686045031; Thu, 17 Nov 2022 03:54:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668686045; cv=none; d=google.com; s=arc-20160816; b=GmUU2OOwa7CUQQgBt08SY/KvU/ZFE6KlrWOaYvb/lWPbtUmf3GeHDITKrccgHy0Lid gYSaEGjvR09Q5gY7OZKNaDcVPnLgUTukEbshYxNl43nDcCWC9f38LUhnvFlvu3G/ktyq HYfZ6HVOtD0fKZyvZG2NoB7FabVVboP1HJ5m7OJJqewWS11oofiik8D7ymjtBpkJkl79 Qnrj/nwDyu/47/sH/oaoWAcmKvPWEyS+JUIxGzC7PXdGQXz4TjpaCJJhopFtHGJKnUj2 XtV1dyzbx0UEYrCIJnsutw6cvvEhCL0gi6fTSzrZb097vzrpxDELhF8BoqA2q6WIgP2L myJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:to:from:date:dkim-signature:delivered-to; bh=4l7iReYwDEKhTmwgCOzi4ZFo1DLve3ED4cWVi0QGzMI=; b=EMsYw63v0g6qmEqwYvsoEmN19rvJNZxCOsK56TwiaiIyGwBvseggf+7dwnPyMaoY9+ aXVxyPCMGxSsUbHF0papTHc+aa4aSaFMw0SjO0KvjNcBDLHe7J/xzKbIkLyftDfPYC4F St3cg3PSxeOG6DjYEKnqeHKPxxbO2MJXhbY0AeEfXAbWrB48sOFJ9Mvp2CkZ1Q4/NNZX Rj8CAqnqdf4E5FoQa3VvvSdh3Aiq+Flu1JPX1udEBKwnnEcVL7HMoj6zHqMU7sn7xtqG TeStOb/AKDIn56S1WaD0MD0Ak3xfr9qL9t5YC5+SpP0tKfeopzFb2YKYCZhkaZfDOwoZ VsYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@lynne.ee header.s=s1 header.b=1K0MPCR3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=lynne.ee Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i22-20020aa7c716000000b00461a7962c26si606626edq.527.2022.11.17.03.54.04; Thu, 17 Nov 2022 03:54:05 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@lynne.ee header.s=s1 header.b=1K0MPCR3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=lynne.ee Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB54268BD9A; Thu, 17 Nov 2022 13:54:00 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 996F368BD36 for ; Thu, 17 Nov 2022 13:53:54 +0200 (EET) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 9F88F1060162 for ; Thu, 17 Nov 2022 11:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1668686033; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=2iE53C6dX8cuSQaEwh6WXpArnpeX2tkJC4bWS7YEmT0=; b=1K0MPCR3oTg71dpJu586O6bEGyWjsNlT9Mldpp6H81Q+zVNHDsabUVy1DsS9kCvJ MrpG8M57ldahqp1Qdrrp9jOV7NZuvDaISsY60lSQcu/hWmsPbOJC5GfX4UcOQc7tjNJ GRpEfQam2NqoSN+e6HSu/zX6erBVvjSrV3c8I3/3tDnhG+UBpwmMJz1ArRZAEqk+R+o 4D8Ht8Dp1rf6b9iQJd+sw8zBe5A7X5HhtvdfG6M7PIgU5N7r/Ua2OphY0npBlGQYslg HwaOHFI6YQC9bYnwwx6GU81JP14RYETtMBvTzYvyr/8c7rQ9xZm1j2TvaXCR9Gf/lBE ZVrJP2m61Q== Date: Thu, 17 Nov 2022 12:53:53 +0100 (CET) From: Lynne To: Ffmpeg Devel Message-ID: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fate/aacenc: increase tolerance for ln-128k test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: pAnvtqrfWuBe The encoder is sensitive to changes in precision, and its test target was a compromise. It was already close to failing on x87 FPUs. ff_mdct_init used double precision entirely from the scale to computing the MDCT exp tables. av_tx_init uses single-precision for the scale, with a small input change which was enough to tip the test into failing on x87 FPUs. Increase the fuzz factor in line with other AAC encoder tests to fix. Patch attached. From 823e5b35893ea6822981dab516159eec50498357 Mon Sep 17 00:00:00 2001 From: Lynne Date: Thu, 17 Nov 2022 12:39:47 +0100 Subject: [PATCH] fate/aacenc: increase tolerance for ln-128k test The encoder is sensitive to changes in precision, and its test target was a compromise. It was already close to failing on x87 FPUs. ff_mdct_init used double precision entirely from the scale to computing the MDCT exp tables. av_tx_init uses single-precision for the scale, with a small input change which was enough to tip the test into failing on x87 FPUs. Increase the fuzz factor in line with other AAC encoder tests to fix. --- tests/fate/aac.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 1743428f54..4f8d1cdcea 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@ -174,7 +174,7 @@ fate-aac-ln-encode-128k: REF = $(SAMPLES)/audio-reference/luckynight_2ch_44kHz_s fate-aac-ln-encode-128k: CMP_SHIFT = -4096 fate-aac-ln-encode-128k: CMP_TARGET = 622 fate-aac-ln-encode-128k: SIZE_TOLERANCE = 3560 -fate-aac-ln-encode-128k: FUZZ = 5 +fate-aac-ln-encode-128k: FUZZ = 10 FATE_AAC_ENCODE += fate-aac-pns-encode fate-aac-pns-encode: CMD = enc_dec_pcm adts wav s16le $(TARGET_SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav -c:a aac -aac_coder fast -aac_pns 1 -aac_is 0 -aac_ms 0 -aac_tns 0 -b:a 128k -cutoff 22050 -fflags +bitexact -flags +bitexact -- 2.38.1