From patchwork Tue Jul 25 09:41:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lynne X-Patchwork-Id: 42971 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:2987:b0:130:ccc6:6c4b with SMTP id f7csp102712pzh; Tue, 25 Jul 2023 02:41:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlHMFGbdcY3nX0lwPAMKE1/ZClNwoktJKuFA4ozbExJF1KI/9rKyKGxZO+cgisYgapKMRjen X-Received: by 2002:a17:906:74cc:b0:98d:e7e3:5ab7 with SMTP id z12-20020a17090674cc00b0098de7e35ab7mr12305979ejl.11.1690278109241; Tue, 25 Jul 2023 02:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690278109; cv=none; d=google.com; s=arc-20160816; b=wVkly10nREqRpnV112QsGl5xdq7d8KinYUu+qX/M0LgjHRCVdw0PZr2d+GdhO5BW6g J+4vJSI+yLw2utruzcn/E6qxIC1HnQli1cQrT37T5MHz4j0SaXrrg1XV7NJWzXYXZ6ha mauRUU+dl1cYkEKpO+JC6hZhKG7mu+xvKYlercw7qvRPOmyEOfqFcnG7HzG0VaMisIkN gIyX9WaOCZOhktErmmga79/+Hb32LX3B+UD2sv7NY+a2mI70JTvQsAOswIrpecnQT4Te F9lT9xJUGQndvP6MWWePRkC2EXV3nJjhOc2IhBBGqgvOD2npcZDC42xUiT2b0xU/iwgp fEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:to:from:date:dkim-signature:delivered-to; bh=CClVwkKp7fGLP2xvTqrbYePt788HkxbT2+NRIoVV+TU=; fh=NIkoTDpgqwsBDY3Ej4pG8uwJcqBS6rd7Vc7bU5x+v0U=; b=DM+MrbK/NPsvjB0jHKJQHVf5b8mTWLgYjs/agZmDV+KN2IX4ZjIy7hhmuW9YsHbGxA Uav5yOIX4gM82+ewL7FU8s6cUayvKqx5f+kmGb+yZPg7i4M05ZiIrGQCTNgnT0pMdZIO HOYjGCujvFDJv8nUka8YuSCRhU/OaslvV1A+wHz7DU+goTgaHBQ1FuaIGzvh1DdtMMpD uBW40b6zz8CXDXK+/algbSCbE1Fi7kapBoGmZ9ja1Wbk/IhwOoT4Mx3xhJ8qkbVncBsk TcE/TVAYAy31ADmASkkfmJGN4HfYn5g3Od9gISbnDX93GrTOLE84sT4UEh0ji/M5h5uX turg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@lynne.ee header.s=s1 header.b=sjsKsKvK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=lynne.ee Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l10-20020a1709061c4a00b00997e71d036csi8096069ejg.678.2023.07.25.02.41.41; Tue, 25 Jul 2023 02:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@lynne.ee header.s=s1 header.b=sjsKsKvK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=lynne.ee Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D0FF68C8B9; Tue, 25 Jul 2023 12:41:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from w4.tutanota.de (w4.tutanota.de [81.3.6.165]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E385E68C548 for ; Tue, 25 Jul 2023 12:41:31 +0300 (EEST) Received: from tutadb.w10.tutanota.de (unknown [192.168.1.10]) by w4.tutanota.de (Postfix) with ESMTP id 30F9910600E8 for ; Tue, 25 Jul 2023 09:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690278090; s=s1; d=lynne.ee; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=3GTuf6QajEt+somql4FGxgLVmRHMNvzn/ldm48NgTTw=; b=sjsKsKvKccCuf+jeTQbfGNUxroFWkLRImNatSsuKKZ8SeHDxGaJPvmsNgdjwElMU /jkYtFSxuIeHcyIjiZMoWAJ4gf0YQA7x4306Jx6loxUvtzAm4ocAZdd0Bdn4Gj/6kyR ATxKze8BNjZBBTsNucf9FdhWxyHqP14CxfA657pEGQ8vrZhUpON3ci9SnAzehvwnR9u oLe9LXHT0bd+gTtylEB0+UIDoInCLO3yTcfM7WGBUkvqr/ufRlSvKt0wp1aB3yLPPpK aAxMjWuLVQya+M/jnUtzAu0gMFM9+cBCnkZECNCSYDrxV7RtK2BZDTflwuEOGsbE8Fn ViNsbePmTg== Date: Tue, 25 Jul 2023 11:41:30 +0200 (CEST) From: Lynne To: Ffmpeg Devel Message-ID: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] lavu/tx: disable odd-length RDFTs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: EVO+Jj/2gavl They're presently broken, and not really needed anywhere. They can be fixed at a later date, but for Patch attached. From 01925c08bcd2073770c0c627fc64232a7593a321 Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 25 Jul 2023 11:01:41 +0200 Subject: [PATCH 1/2] lavu/tx: disable odd-length RDFTs They're presently broken. --- libavutil/tx_template.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c index c4ec9502e0..a4040454db 100644 --- a/libavutil/tx_template.c +++ b/libavutil/tx_template.c @@ -1709,8 +1709,8 @@ static const FFTXCodelet TX_NAME(ff_tx_rdft_r2c_def) = { .type = TX_TYPE(RDFT), .flags = AV_TX_UNALIGNED | AV_TX_INPLACE | FF_TX_OUT_OF_PLACE | FF_TX_FORWARD_ONLY, - .factors = { 2, TX_FACTOR_ANY }, - .nb_factors = 2, + .factors[0] = 2, + .nb_factors = 1, .min_len = 2, .max_len = TX_LEN_UNLIMITED, .init = TX_NAME(ff_tx_rdft_init), @@ -1724,8 +1724,8 @@ static const FFTXCodelet TX_NAME(ff_tx_rdft_c2r_def) = { .type = TX_TYPE(RDFT), .flags = AV_TX_UNALIGNED | AV_TX_INPLACE | FF_TX_OUT_OF_PLACE | FF_TX_INVERSE_ONLY, - .factors = { 2, TX_FACTOR_ANY }, - .nb_factors = 2, + .factors[0] = 2, + .nb_factors = 1, .min_len = 2, .max_len = TX_LEN_UNLIMITED, .init = TX_NAME(ff_tx_rdft_init), -- 2.40.1