From patchwork Mon Jan 22 17:46:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wu Jianhua X-Patchwork-Id: 45720 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:120f:b0:199:de12:6fa6 with SMTP id v15csp130377pzf; Mon, 22 Jan 2024 09:47:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IELQOlQraCwi+IWGGYcjHUqplOuh9/jhgxM+5TKnKP3FRE1f8haL41tWXjJUiRt97j0Eus7 X-Received: by 2002:a17:907:76c6:b0:a2d:9c1e:9bfc with SMTP id kf6-20020a17090776c600b00a2d9c1e9bfcmr1257296ejc.7.1705945651414; Mon, 22 Jan 2024 09:47:31 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id by18-20020a170906a2d200b00a2877da8ed4si10887940ejb.584.2024.01.22.09.47.31; Mon, 22 Jan 2024 09:47:31 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=eJW1bCDV; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E91E568D0CE; Mon, 22 Jan 2024 19:47:07 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2066.outbound.protection.outlook.com [40.92.99.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1C08468D0C9 for ; Mon, 22 Jan 2024 19:47:01 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuglNPIcdswobq1LZR3B7bBn/alyR+bGrgCiZWC1giphQWr/r8Kb1NZQkU6/6BkKm9WQJ9ZX+nlDA25ldxaWstsM4mGHfgg26JpR2/ONHURjufNAfr+YhGxrFERzOUrtufAlc970+mt7LzZilg7n+opMDYkJw9ax4HrCjzRfpBy1/vNw8e3RCtpytG+K3z9GXGi/U5kBi0JiV6ketC3RNdAPuimjUf4zXKcZd2Lzjtksru8Ha1lM7ZWbXm2GQdLESXkNkyZtYRl/g55+nNWncdBihVCg3A5VeoUY+eTJAJP1mD5gJEG1y16sLLtATxqRLJf7nw7IcJ9S5JdPmtXLWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3YWCPE3QJL1q8pUPyPgguKhxWpexD9mZ6X8ITP8r0ec=; b=C7DiRcLD0n7/tEarV3yZfhUDpHLssQkCWIkHtbpZtzs005N9u3ddYl7/oEfNeu3vgxSwOwQXKsM3S0nt0udpgXHC6lq4l+rQ7STJuIRqvzm8dMW9lbthww+6tUIguJ0kf1iNbMkvcNt5WS78WesJsGOR+bjspXQ09shZAWXd68mY61rlZAY8MXXByAV1k6xZOZuNavOnomnu8SSm69GxHL8JBw12FcwH3AJxpr5pv5FBMSdcYL1UuBRw+k7yMGoiLNfFSoIa+B9Z3xGM8k4496cG4WtTprk04VCyHOTRYJqeHwfX+VDVWacKaFijnfmKx4cbIuLqQCB3b7OKXDqq6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3YWCPE3QJL1q8pUPyPgguKhxWpexD9mZ6X8ITP8r0ec=; b=eJW1bCDVet0qHmRxpPzpGrljojiygBg5UTO5PW1YgqCz6q2D36xpGGi7baMiAvG+2P/0G82wNEDpivjed4x2yMxFsD6VWUClz7LMTtDTiwWyhrGtWzqBIhjfBhslHYZrNPBdGUYJd4IjmF7GCQ/uUaBuFqhSUGJUaPhCBc3EW0ZK6LbZf+VixtZxq+Uz7Q0PpR603JXw/B29H8O3iOihtyiA+WRgnzAKMYtAFZiwHRtOsm3X/sMIjaIuAS/B9glVe7dBMUTB4jvq40MAQBLHKlmoMUob+qeG7A8CpWXL1rqRdqPIqJqrcst3giH+cOinnYAaakGGfbp7QQ62+kge+A== Received: from OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:186::5) by TYWP286MB1975.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:164::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.31; Mon, 22 Jan 2024 17:46:47 +0000 Received: from OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM ([fe80::86fc:6255:f4c1:a076]) by OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM ([fe80::86fc:6255:f4c1:a076%3]) with mapi id 15.20.7202.035; Mon, 22 Jan 2024 17:46:47 +0000 From: toqsxw@outlook.com To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Jan 2024 01:46:24 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240122174628.1206503-1-toqsxw@outlook.com> References: <20240122174628.1206503-1-toqsxw@outlook.com> X-TMN: [KPrQ6G7s7jqa9v6ICqk5QchEqKIW4EFD] X-ClientProxiedBy: KL1PR0401CA0027.apcprd04.prod.outlook.com (2603:1096:820:e::14) To OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:186::5) X-Microsoft-Original-Message-ID: <20240122174628.1206503-4-toqsxw@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSZP286MB2173:EE_|TYWP286MB1975:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dba03bc-8ddf-409d-b4df-08dc1b721abc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1qs25E1wEZrYNY7HjUWH1wDaZVSsnDrj/NJQJoZgaCEOBMHepBUCbcI5LP4W+E7p+QcK/ho4+a9dGh2r8JOk3x1D5JR5PUG7+6Df/b/xRcJSQ5kjxj6LqacxNjwNB+J7Od2FGDejLlFiWIdvFusmmtwZWeyaGM20Cd3f/lqOnmzjdY8LHXX8FfoBOiaYS5bYaJ/IkNGxTav3L+GzZn/zsvu7oKBlkDPTRZVP9KL8BWCcRC/1aJuHiMUGbKb9rj8B/L6Eglzfs39T9z01gYHJZhmC5YgwfGwrTzSGYQOejcdLuGbAXiTK+5N2bHIU8rPwrVm3ZK8cNxIcu0jKoJTDQqVvSlkZ72j0Tj4OB6hLjTYCfBMseTCNsHUwcuoz36hzsHb/cEj4dMOcG+zkpTDx1Li81KeTqQd4kPqZ73O1I4WUdHzs1KsG4uDbYCcRrz9TUbNNMuqTw4ffg7XomdlxOcYTUsmuXQ+kj5PZJT2ynPWNw7Rzwnh1fCntaiUAZ1eZOQkwelyUkXCtsJFJLl2SoEaXoVnzmnrED/kfV61PBjWp8nmMbHbDKPHhVA0oT3gt6R/aX/JU6Q2a5HpeGmexgvG9cwHAWIQGRShPpm/XC/ID3dgeecFVsb9Uf6Mgym4o X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4QdL+HrSKTuf/Zh2eCGhO1WPWFQaLGo/bF1Cf4CaKpt7EuVDAxKGCDwBfwxi+SFMrPEGG6O1iLXDyI0/xiYS+gJOO77xmcWz3RjLndgmze9UYRey7qKln+oJiB36UfCWx6EpzmzbDWKntwqg9+7CW3uYLyHDHViwN0n4svGjRh8RgSvtT2eKIJhvm7jORHeokyod8GK8nofWuDDK+tmE+ibMkc8y/GxZj2AN3xskVFt+R3l8LuAMf6FmtwPxyyvq+ihouoWsVWE/IAaN29GAnoKYm8nu8MxAvtWhvZnKahpmevWDMT8U4tuteAJ23v+/CihtanTtW76jbLMYTQ7n1sz8PTHjheWBouMuOuYTPwcKpKyTm0kCVuk+ljOeKF0D/dnOe+5F5j3cUJPTMiAoXVp8TbhU60L57xONVCRP6vZtxkr9wtWy134krtY4SwrPMUMqzxUADoBaeo9hp8Gc6Ps3EFOCFAliCPhs/E82bNPOKMKNE5X052ZiKTnPBLAHmV6kqSgiRm3i6qNg7nygH0S8mpqihjPLy5zP8xIKRdPj0QSTYUHPcP8zFXCW+eZRdebp0g1UH7qDd3JWiHu18NS6T7sCvA+3LiIQZffo/EP9r+H8snubV3Zcpo8BzrejKzTifZQeyLDR8DO4f05S3ApDXdGptStAdzwIV5Ws0zTa6u41bwviAWkNxw0fOQ4Wiv7fK48itF3GyhJMbSnHWN/CrQbimdYaBDci13ERHeBnFuweJhB5TPXptZGEgcogAHiY2SvuGO93cnwxWCjuVxDt2peiskbJzhGlTDKzMX5j9QIEqz7uRyOIckwzYjY8LNcJPVX1bBbnHPdkma58zwni2h0huE5s7rgia3CzPXprU2eD19pylukIV2I9YoKCqWCUS2vfhbLq+5YXIXwU7Gd5J+53rpkrcTBY2Tq5L5+qp66acn0iVsW/3TzckHXYmxmqjtOqeRJMmeuU2PKTNYhGZtlLDmBmTBZgPJy1fO3ynMIJXc1xZaD3GlCu+AUfcSQjkEvOcC3IwmQQzvaihoBJ6nES6MKiXeaG5Pdtlz4j5L4rtPcaJS8OUl6b9/wRhKEqURrvPvvNjQQg9TXwSplLGqnAF2mKbCx/1xRe/GB72XW9lDPXVDObQSHzQjyhuw8bmaignzT2jVcAVF/xv6k7ObMtWyeoHZKTvoehKdPic/iLAjprqh8yJe4fH1X6FSkDCtwsVHNZrWIN0JjBy6Tc899usYI73p3+hzx0j9k= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dba03bc-8ddf-409d-b4df-08dc1b721abc X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2173.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 17:46:47.0863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB1975 Subject: [FFmpeg-devel] [PATCH v3 4/8] avcodec/x86/h26x/h2656_inter: add dststride to put X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Wu Jianhua Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Zw4laQKysjkF From: Wu Jianhua Signed-off-by: Wu Jianhua --- libavcodec/x86/h26x/h2656_inter.asm | 32 ++++++++++++++--------------- libavcodec/x86/h26x/h2656dsp.c | 4 ++-- libavcodec/x86/h26x/h2656dsp.h | 2 +- libavcodec/x86/hevcdsp_init.c | 2 +- 4 files changed, 19 insertions(+), 21 deletions(-) diff --git a/libavcodec/x86/h26x/h2656_inter.asm b/libavcodec/x86/h26x/h2656_inter.asm index aa296d549c..cbba0c1ea5 100644 --- a/libavcodec/x86/h26x/h2656_inter.asm +++ b/libavcodec/x86/h26x/h2656_inter.asm @@ -22,8 +22,6 @@ ; */ %include "libavutil/x86/x86util.asm" -%define MAX_PB_SIZE 64 - SECTION_RODATA 32 cextern pw_255 cextern pw_512 @@ -342,7 +340,7 @@ SECTION .text %endmacro %macro LOOP_END 3 - add %1q, 2*MAX_PB_SIZE ; dst += dststride + add %1q, dststrideq ; dst += dststride add %2q, %3q ; src += srcstride dec heightd ; cmp height jnz .loop ; height loop @@ -539,7 +537,7 @@ SECTION .text ; ****************************** -; void %1_put_pixels(int16_t *dst, const uint8_t *_src, ptrdiff_t srcstride, +; void %1_put_pixels(int16_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t srcstride, ; int height, const int8_t *hf, const int8_t *vf, int width) ; ****************************** @@ -549,7 +547,7 @@ SECTION .text %endmacro %macro MC_PIXELS 3 -cglobal %1_put_pixels%2_%3, 4, 4, 3, dst, src, srcstride, height +cglobal %1_put_pixels%2_%3, 5, 5, 3, dst, dststride, src, srcstride, height pxor m2, m2 .loop: SIMPLE_LOAD %2, %3, srcq, m0 @@ -579,10 +577,10 @@ cglobal %1_put_uni_pixels%2_%3, 5, 5, 2, dst, dststride, src, srcstride, height %endif ; ****************************** -; void %1_put_4tap_hX(int16_t *dst, +; void %1_put_4tap_hX(int16_t *dst, ptrdiff_t dststride, ; const uint8_t *_src, ptrdiff_t _srcstride, int height, int8_t *hf, int8_t *vf, int width); ; ****************************** -cglobal %1_put_4tap_h%2_%3, 5, 5, XMM_REGS, dst, src, srcstride, height, hf +cglobal %1_put_4tap_h%2_%3, 6, 6, XMM_REGS, dst, dststride, src, srcstride, height, hf %assign %%stride ((%3 + 7)/8) MC_4TAP_FILTER %3, hf, m4, m5 .loop: @@ -612,10 +610,10 @@ cglobal %1_put_uni_4tap_h%2_%3, 6, 7, XMM_REGS, dst, dststride, src, srcstride, RET ; ****************************** -; void %1_put_4tap_v(int16_t *dst, +; void %1_put_4tap_v(int16_t *dst, ptrdiff_t dststride, ; const uint8_t *_src, ptrdiff_t _srcstride, int height, int8_t *hf, int8_t *vf, int width) ; ****************************** -cglobal %1_put_4tap_v%2_%3, 6, 6, XMM_REGS, dst, src, srcstride, height, r3src, vf +cglobal %1_put_4tap_v%2_%3, 7, 7, XMM_REGS, dst, dststride, src, srcstride, height, r3src, vf sub srcq, srcstrideq MC_4TAP_FILTER %3, vf, m4, m5 lea r3srcq, [srcstrideq*3] @@ -649,10 +647,10 @@ cglobal %1_put_uni_4tap_v%2_%3, 7, 7, XMM_REGS, dst, dststride, src, srcstride, %macro PUT_4TAP_HV 3 ; ****************************** -; void put_4tap_hv(int16_t *dst, +; void put_4tap_hv(int16_t *dst, ptrdiff_t dststride, ; const uint8_t *_src, ptrdiff_t _srcstride, int height, int8_t *hf, int8_t *vf, int width) ; ****************************** -cglobal %1_put_4tap_hv%2_%3, 6, 7, 16 , dst, src, srcstride, height, hf, vf, r3src +cglobal %1_put_4tap_hv%2_%3, 7, 8, 16 , dst, dststride, src, srcstride, height, hf, vf, r3src %assign %%stride ((%3 + 7)/8) sub srcq, srcstrideq MC_4TAP_HV_FILTER %3 @@ -784,12 +782,12 @@ cglobal %1_put_uni_4tap_hv%2_%3, 7, 8, 16 , dst, dststride, src, srcstride, heig %endmacro ; ****************************** -; void put_8tap_hX_X_X(int16_t *dst, const uint8_t *_src, ptrdiff_t srcstride, +; void put_8tap_hX_X_X(int16_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t srcstride, ; int height, const int8_t *hf, const int8_t *vf, int width) ; ****************************** %macro PUT_8TAP 3 -cglobal %1_put_8tap_h%2_%3, 5, 5, 16, dst, src, srcstride, height, hf +cglobal %1_put_8tap_h%2_%3, 6, 6, 16, dst, dststride, src, srcstride, height, hf MC_8TAP_FILTER %3, hf .loop: MC_8TAP_H_LOAD %3, srcq, %2, 10 @@ -824,10 +822,10 @@ cglobal %1_put_uni_8tap_h%2_%3, 6, 7, 16 , dst, dststride, src, srcstride, heigh ; ****************************** -; void put_8tap_vX_X_X(int16_t *dst, const uint8_t *_src, ptrdiff_t srcstride, +; void put_8tap_vX_X_X(int16_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t srcstride, ; int height, const int8_t *hf, const int8_t *vf, int width) ; ****************************** -cglobal %1_put_8tap_v%2_%3, 6, 8, 16, dst, src, srcstride, height, r3src, vf +cglobal %1_put_8tap_v%2_%3, 7, 8, 16, dst, dststride, src, srcstride, height, r3src, vf MC_8TAP_FILTER %3, vf lea r3srcq, [srcstrideq*3] .loop: @@ -866,11 +864,11 @@ cglobal %1_put_uni_8tap_v%2_%3, 7, 9, 16, dst, dststride, src, srcstride, height ; ****************************** -; void put_8tap_hvX_X(int16_t *dst, const uint8_t *_src, ptrdiff_t srcstride, +; void put_8tap_hvX_X(int16_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t srcstride, ; int height, const int8_t *hf, const int8_t *vf, int width) ; ****************************** %macro PUT_8TAP_HV 3 -cglobal %1_put_8tap_hv%2_%3, 6, 7, 16, 0 - mmsize*16, dst, src, srcstride, height, hf, vf, r3src +cglobal %1_put_8tap_hv%2_%3, 7, 8, 16, 0 - mmsize*16, dst, dststride, src, srcstride, height, hf, vf, r3src MC_8TAP_FILTER %3, hf, 0 lea hfq, [rsp] MC_8TAP_FILTER %3, vf, 8*mmsize diff --git a/libavcodec/x86/h26x/h2656dsp.c b/libavcodec/x86/h26x/h2656dsp.c index 27769f9c55..7ef1234936 100644 --- a/libavcodec/x86/h26x/h2656dsp.c +++ b/libavcodec/x86/h26x/h2656dsp.c @@ -24,7 +24,7 @@ #include "h2656dsp.h" #define mc_rep_func(name, bitd, step, W, opt) \ -void ff_h2656_put_##name##W##_##bitd##_##opt(int16_t *_dst, \ +void ff_h2656_put_##name##W##_##bitd##_##opt(int16_t *_dst, ptrdiff_t dststride, \ const uint8_t *_src, ptrdiff_t _srcstride, int height, const int8_t *hf, const int8_t *vf, int width) \ { \ int i; \ @@ -32,7 +32,7 @@ void ff_h2656_put_##name##W##_##bitd##_##opt(int16_t *_dst, for (i = 0; i < W; i += step) { \ const uint8_t *src = _src + (i * ((bitd + 7) / 8)); \ dst = _dst + i; \ - ff_h2656_put_##name##step##_##bitd##_##opt(dst, src, _srcstride, height, hf, vf, width); \ + ff_h2656_put_##name##step##_##bitd##_##opt(dst, dststride, src, _srcstride, height, hf, vf, width); \ } \ } diff --git a/libavcodec/x86/h26x/h2656dsp.h b/libavcodec/x86/h26x/h2656dsp.h index 8a2ab13607..e31aae6b0d 100644 --- a/libavcodec/x86/h26x/h2656dsp.h +++ b/libavcodec/x86/h26x/h2656dsp.h @@ -30,7 +30,7 @@ #include #define H2656_PEL_PROTOTYPE(name, D, opt) \ -void ff_h2656_put_ ## name ## _ ## D ## _##opt(int16_t *dst, const uint8_t *_src, ptrdiff_t _srcstride, int height, const int8_t *hf, const int8_t *vf, int width); \ +void ff_h2656_put_ ## name ## _ ## D ## _##opt(int16_t *dst, ptrdiff_t dststride, const uint8_t *_src, ptrdiff_t _srcstride, int height, const int8_t *hf, const int8_t *vf, int width); \ void ff_h2656_put_uni_ ## name ## _ ## D ## _##opt(uint8_t *_dst, ptrdiff_t _dststride, const uint8_t *_src, ptrdiff_t _srcstride, int height, const int8_t *hf, const int8_t *vf, int width); \ #define H2656_MC_8TAP_PROTOTYPES(fname, bitd, opt) \ diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 5c19330e19..e0dc82eef0 100644 --- a/libavcodec/x86/hevcdsp_init.c +++ b/libavcodec/x86/hevcdsp_init.c @@ -96,7 +96,7 @@ void ff_hevc_put_hevc_ ## a ## _ ## depth ## _##opt(int16_t *dst, const uint8_t int height, intptr_t mx, intptr_t my,int width) \ { \ DECL_HV_FILTER(p) \ - ff_h2656_put_ ## b ## _ ## depth ## _##opt(dst, src, srcstride, height, hf, vf, width); \ + ff_h2656_put_ ## b ## _ ## depth ## _##opt(dst, 2 * MAX_PB_SIZE, src, srcstride, height, hf, vf, width); \ } #define FW_PUT_UNI(p, a, b, depth, opt) \