From patchwork Wed Jan 5 05:39:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 33078 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp428542iog; Tue, 4 Jan 2022 21:39:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjwgVGxLpd3dRXn3LJgYm2CYJnN3OpSXCNfUnXiP96hTBmBvUKgL+/86hb8NDrBrktr7is X-Received: by 2002:aa7:c3c8:: with SMTP id l8mr51934618edr.378.1641361179349; Tue, 04 Jan 2022 21:39:39 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ji20si20609053ejc.576.2022.01.04.21.39.38; Tue, 04 Jan 2022 21:39:39 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=qLUtGMzZ; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABDA86808C2; Wed, 5 Jan 2022 07:39:34 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075040.outbound.protection.outlook.com [40.92.75.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1786689AFD for ; Wed, 5 Jan 2022 07:39:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g+cjahtz/VYZuRPb5QIXgnx4w0P/bbL5PgOw/ARanRs6+HXpUYigj0CHFZMRM4Em0SaVs8xmLxkGh1b9ey7aSFyCjsePEIj4oFuRqAw84ee3yEILg/xquYHQRryLnKLnd9IqipQgnUxDsRxd4GHmOlGEbiT3z0QjRwb9KduFq/cKWg4WWpYEqDMb7EbzZ+clqLzcFuPdlmQftLcZ43xb7UwruFzxBxmM/vs7yp+34GMsWELEx8srXQF/b6lN/Fo1JKxLRbvX8c0izQ2YLqtuD3OHahPA7gW7O43gUAeS2ytEtsXDnND7gbuqHZh8qBSHSwP9IvYw9kaZyXUEIsz9Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMjAeGaUx8KgmOSL2sDMfB97TMT2hAMRVKA6r4vj4+A=; b=iDGN46GiNPML/bTnafHnNXW5PfvbE+r5bGC/QJROGwfYt8uSGR6gwRA0r6eXgbm8kUIxhcAyMsIP2H2/CZZjVa29E/RpkM8HFYDh2SBBGWxOzrL/Ae2sa4Ro1iqY9zE3ect7RAsAXJg/X1Gg0OvlmPqA0vePjXDAWoACAoYuGgg+jQqOlCA3DbzPDeNv+liU4zfwiMiQbEF3fUpzQaeaNYX3sfblib+Z2csCEEBSTnHA+TOP6hi3/k2C5taE0H34itTxUwvHg2eSICgttgRBU0qJT7Jf2ZHabd4mOZaQ+v5cUksvrgbd3RDh6D2Fgcjyy6BMKL5EnFEko3LeGkDigw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMjAeGaUx8KgmOSL2sDMfB97TMT2hAMRVKA6r4vj4+A=; b=qLUtGMzZqE1k0NcOrNZdmZJBK/Upfy/qqKo3Urbk3TQriU4BpGPnnk29sDlLiygWv7gWU4s045R1CXd1XPBDUixmlz7B10Odqu8Wur3Z49gPdZsscEZE8nJ6xQG3g6sykJd/b3+xys54LZ0nu17Q6pLWBamaVafc8LRLS5Amzh30S5fW1ug1lHPi6B6eUPrdCqXNkDGpL/LrLizPIkH+ZTiPjTSavYKRVS7UGlkwFh5F1P8jOtHu2kLVjSDhIpS821T6iZiUXu4WKCxrJh7e2wMvLbe6+3jWOe6gKIErI3NgqGS7eHS+siSxb4DxgWw+o3ULvsN/ZhHPjKAQH2Thow== Received: from PR3PR03MB6665.eurprd03.prod.outlook.com (2603:10a6:102:7d::6) by PR3PR03MB6636.eurprd03.prod.outlook.com (2603:10a6:102:74::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Wed, 5 Jan 2022 05:39:26 +0000 Received: from PR3PR03MB6665.eurprd03.prod.outlook.com ([fe80::a017:d2ce:40:876d]) by PR3PR03MB6665.eurprd03.prod.outlook.com ([fe80::a017:d2ce:40:876d%5]) with mapi id 15.20.4844.016; Wed, 5 Jan 2022 05:39:26 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 5 Jan 2022 06:39:13 +0100 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [Gu998ELpYvzcuTOdDEjMYmrRKl/fcgif] X-ClientProxiedBy: AS8PR07CA0035.eurprd07.prod.outlook.com (2603:10a6:20b:459::27) To PR3PR03MB6665.eurprd03.prod.outlook.com (2603:10a6:102:7d::6) X-Microsoft-Original-Message-ID: <20220105053913.2200303-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a19dd8ae-c766-4ac4-7599-08d9d00dbc02 X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiR3EehW4kxQzdNcP2D/mG1Jl+osNCrdA6Cjg+cPy5XmSIVxFzVfm4oweIbAOmEW4cxZbenWKqkBUJaKlaoy5RKC4L8+u3XSAOprHBUFMtkZguh5i0076omZdh8MwfU0UVASoehkBn53HLbZIG+a4j/jz7NlHnvddVbbTS1EbpSxwxC4VVi6GwVjFx/l9lOTo8jyGynoQpi2CusvL0ujFYx+9pH94bUhZXo3OeQvCmyGTFFWYXmJ5kJnT20nPRVOWhqR24ABG7iUEtflR2noUf44j2AL6FjyspfLCMpQ4wNdMbq06d8liogH06b+6V/34k4RMq6Y5jqKd9rybOMN/2Yiip3Ef9NJlacu/uJjd6hOz/znPSAcTND3PmhT9mF+iIP85yIN6bCxZnoM3kkoi2EA18il5L3aVIZvS1Hh/07BdgN6IM2oGOdiHfVI5UTxM/brXrRMm/pKLlLQCJ1O49qlIwDb7Jv0JosaCIITeo7ya7rlDqtPD3X8rxDS+kSpmO3x+jqwxbuDmqDoO2h1A/s7wseRtRJ+xRnqLPhqIbyDHTQKAzYVNuSeOsFSmsc1H72wAojtvfDkuZfVZmoGoSef1NP97yn0qE9SGCUCbt1z5JBYzfjrVQYAvni1C7iOjXCHUdHu12WaQkEpwKvjlll18WxUtci1RmMdzmYfZKmgnLueYtdMCzn7O93qis8yy0iGIcao+zcrULrIxfJpsICulPn0tUSfKxQVuvPYGKfWv3G5cZocHAlwLtzK9gwsKHY= X-MS-TrafficTypeDiagnostic: PR3PR03MB6636:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tL0LjoUXa0CpdcRWiBFh2RLkAbBMBEMuWTANYzbYJ/+nsxCJu0KXt/IzJBAu9UpVf6DIHDjhPZn+ARJG3LwoLv8ojD1cd2a6m/e1xjPU3Cb6HyB+E0/EqerEduNvK56f9aogUgKqKRNZ4zWeG+fsSIZhaWZ8TcbjloVc06lG4BvCIczeU+MJgL86RkaXOSdEM0Pw4+U1vAScorc8JX+pTKYIn+rSiXxZkLTkN1KsDELO8ifdHgXbQLY7D3qyxoMsDID50RkVo29rNFvSg3wWF4QK47PRc1CDjLemKXJ7z3XHJvOdo2dhAKZ3ZJegA5AzYuOBl0fCvNWSq/s5elfm6s9W1E3/NqA9wPXNZPVHCQUblS/nYKzhBiCyBXrKKgLImizK76BfvWD8YF4fPfdlF6iJylmsB+6Q7tH4V46mqOfwOVY+tvLeRWdusARnzu3aUYFqCXMBeGq9OlClaSLtaNaJ9lq73+1Aj/WWfU2NxwN1Vz0/STN9hv52MN2wToPVu640blhKVqRR3RQ+WMOGgUxVJWnYAV/sMSWPWxh0KJTIFZ2uOJIf4N/f7YxSH3zKItRepE31aCdVCZU/CvsEEQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QD4O9B++BwRGPwoozyBdYSUHkWQiEiM3Jt+LqLlYOJvY3RNx/zgLUXoRzh96dwMz4trR7YMmiTAPMGG8lxuFhlKU65NjMRv+QF+iq57XgaShOZTyc5yN5Ju+nl9022SZiAhmgSv0kklc2h1vWw+QbBIsTnP9ZAEX3ngc3Jri+VtZI1vmO0EaFOsvJlz3KEmsY4b8RJrZ6dH98jrrEJ/5hkrS3f7hV9l7EpEKKYFOhVea6Ft1EeCPU3Te0bgQQ4YRbcje2FDVO2DN90+I5eI+WzG56UZOk7J39iBecao1Lg2QOXoglV9knOPbkeVTbYsWSnsGK/ecJs+5uZWSfszeabAQway0SUf7PYUuWnvkKcsSSK9Ae+2h2p1ijLhyTOkVShpBZuays++AaAVBt7Ar3tp3xizaU9abIRKRCL+yVHqo7XRzV/uYxTGJg5iFVHzEkVxdvIHwiHWTO4wFtrOCCRCxh7hS0IPYv02tO5n8CwYkVPWouqnBpXRQLHT/kCnJeUyQpuJcn1B71sEFf5yP+MbJifWBDisq6xw/vKZ+vuupSgcC97qh1AbJwW3B3AF4rhk/t+lVdh0tjTbYF8ayoeQm7czEIZ4FTQEm3l4Q0v6sPF38lesqyZbO2lCnYrgn6uthv8yHH3mOxoat7M971xiwBAuJTeL3wki8JWv+Rpb4M4Iheks192NhCssuV9/rFmn3l90ZMG/RmrsG8oHnkNHTynCZunbIP87Cnni6Jt6YQXavi+ttRPdG66oJajHLic4M4NnrUiNmxUxl2UTM9hwy4Qa8bHlUKhlw3lzT9KK1LXm2tBEPYfthYlaRvnpzzdiEXzhAmCimYs3vBWb12KhNK0anp4o0fDZmiwJ8jdoY7XbiNEQy0yJOr51+UvdyjEG236XSxvMdZiL1HWIQhFRs2rs9viI87yWxEIErlrsDe/I/ep8DSLa5GiYHA5brZmfwRLBIomrwlJbdQu1S5w== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a19dd8ae-c766-4ac4-7599-08d9d00dbc02 X-MS-Exchange-CrossTenant-AuthSource: PR3PR03MB6665.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 05:39:25.9721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6636 Subject: [FFmpeg-devel] [PATCH] configure: Make nvenc select atsc_a53 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ZgJrMd0+nnfa It is the common code (that is compiled depending upon CONFIG_NVENC) that uses ff_alloc_a53_sei(), so it is natural to make nvenc itself select atsc_a53. This fixes compilation errors in case nvenc is enabled (e.g. autodected) with both nvenc-based encoders disabled. (This works in case of static linking (nothing pulls in nvenc.o), but it fails with shared builds.) Signed-off-by: Andreas Rheinhardt --- It would also be obviously desirable to disable nvenc if it is not needed if it is only autodetected and not explicitly enabled. Maybe it should even be unconditionally disabled if unused. There is btw a similar issue with crystalhd: If it is enabled, yet all the decoders are disabled and if one uses -O0, then the unused functions in crystalhd.c are not stripped away and linking errors ensue. configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 8392c26015..f76876ceff 100755 --- a/configure +++ b/configure @@ -3153,6 +3153,7 @@ sharpen_npp_filter_deps="ffnvcodec libnpp" amf_deps_any="libdl LoadLibrary" nvenc_deps="ffnvcodec" nvenc_deps_any="libdl LoadLibrary" +nvenc_select="atsc_a53" aac_mf_encoder_deps="mediafoundation" ac3_mf_encoder_deps="mediafoundation" @@ -3168,7 +3169,6 @@ h264_mediacodec_decoder_select="h264_mp4toannexb_bsf h264_parser" h264_mf_encoder_deps="mediafoundation" h264_mmal_decoder_deps="mmal" h264_nvenc_encoder_deps="nvenc" -h264_nvenc_encoder_select="atsc_a53" h264_omx_encoder_deps="omx" h264_qsv_decoder_select="h264_mp4toannexb_bsf qsvdec" h264_qsv_encoder_select="atsc_a53 qsvenc" @@ -3185,7 +3185,6 @@ hevc_mediacodec_decoder_deps="mediacodec" hevc_mediacodec_decoder_select="hevc_mp4toannexb_bsf hevc_parser" hevc_mf_encoder_deps="mediafoundation" hevc_nvenc_encoder_deps="nvenc" -hevc_nvenc_encoder_select="atsc_a53" hevc_qsv_decoder_select="hevc_mp4toannexb_bsf qsvdec" hevc_qsv_encoder_select="hevcparse qsvenc" hevc_rkmpp_decoder_deps="rkmpp"