diff mbox series

[FFmpeg-devel,v1] libavdevice/gdigrab: change hwnd tail check fail logic to !=null

Message ID TYAPR01MB32771EAB1466CFBF9B3698D9DEB82@TYAPR01MB3277.jpnprd01.prod.outlook.com
State New
Headers show
Series [FFmpeg-devel,v1] libavdevice/gdigrab: change hwnd tail check fail logic to !=null | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Cai Eaphone Aug. 7, 2024, 3:58 p.m. UTC 
From: eaphone <cyfdel@hotmail.com>

---
 libavdevice/gdigrab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhao Zhili Aug. 8, 2024, 3:46 p.m. UTC | #1 
> On Aug 7, 2024, at 23:58, cyfdel-at-hotmail.com@ffmpeg.org wrote:
> 
> From: eaphone <cyfdel@hotmail.com>
> 
> ---
> libavdevice/gdigrab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c
> index c91661c556..08a41c304b 100644
> --- a/libavdevice/gdigrab.c
> +++ b/libavdevice/gdigrab.c
> @@ -281,7 +281,7 @@ gdigrab_read_header(AVFormatContext *s1)
> 
>         hwnd = (HWND) strtoull(name, &p, 0);
> 
> -        if (p == NULL || p == name || p[0] == '\0')
> +        if (p == NULL || p == name || p[0] != '\0')
>         {
>             av_log(s1, AV_LOG_ERROR,
>                    "Invalid window handle '%s', must be a valid integer.\n", name);

LGTM.

> -- 
> 2.45.2.windows.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Zhao Zhili Aug. 15, 2024, 12:12 p.m. UTC | #2 
> On Aug 8, 2024, at 23:46, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> 
>> On Aug 7, 2024, at 23:58, cyfdel-at-hotmail.com@ffmpeg.org wrote:
>> 
>> From: eaphone <cyfdel@hotmail.com>
>> 
>> ---
>> libavdevice/gdigrab.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c
>> index c91661c556..08a41c304b 100644
>> --- a/libavdevice/gdigrab.c
>> +++ b/libavdevice/gdigrab.c
>> @@ -281,7 +281,7 @@ gdigrab_read_header(AVFormatContext *s1)
>> 
>>        hwnd = (HWND) strtoull(name, &p, 0);
>> 
>> -        if (p == NULL || p == name || p[0] == '\0')
>> +        if (p == NULL || p == name || p[0] != '\0')
>>        {
>>            av_log(s1, AV_LOG_ERROR,
>>                   "Invalid window handle '%s', must be a valid integer.\n", name);
> 
> LGTM.

Apply, thanks.

> 
>> -- 
>> 2.45.2.windows.1
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c
index c91661c556..08a41c304b 100644
--- a/libavdevice/gdigrab.c
+++ b/libavdevice/gdigrab.c
@@ -281,7 +281,7 @@  gdigrab_read_header(AVFormatContext *s1)
 
         hwnd = (HWND) strtoull(name, &p, 0);
 
-        if (p == NULL || p == name || p[0] == '\0')
+        if (p == NULL || p == name || p[0] != '\0')
         {
             av_log(s1, AV_LOG_ERROR,
                    "Invalid window handle '%s', must be a valid integer.\n", name);