From patchwork Sat Jun 22 04:21:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuo Mi X-Patchwork-Id: 50055 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:ae71:0:b0:482:c625:d099 with SMTP id w17csp917630vqz; Fri, 21 Jun 2024 22:12:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXgRP7s/zuxyNxFsHV5Krw34SjLI1kdnEBwpq231P6f79YWcOWEAnILPTdWTZ2YAnNNUmXUHDwTVFjaXk5WKIaVkuhBf2IrffKY6Q== X-Google-Smtp-Source: AGHT+IHPjVxbHn5snaD8DU3HvdNO9f6S6F7SWoCu8k9o0h481sgs3Z2Qowfzq3QEo9Y9VJqnPTA1 X-Received: by 2002:a05:6402:40d5:b0:57d:432a:582f with SMTP id 4fb4d7f45d1cf-57d432a5e3amr459120a12.1.1719033168393; Fri, 21 Jun 2024 22:12:48 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57d30632bd3si1455291a12.113.2024.06.21.22.12.47; Fri, 21 Jun 2024 22:12:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=RrHu7DBs; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADD7B68D615; Sat, 22 Jun 2024 07:56:05 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01olkn2100.outbound.protection.outlook.com [40.92.107.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3002768D615 for ; Sat, 22 Jun 2024 07:55:58 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7Mdlv0+bMHeJWeknc0cjCCHHXfc64MGKngY4pX/5CbIJe8y1PT7LLQVQuznDykciQYaDqLc7K7S+fIB/slFSF1w7QAyNLwa7dqYxAKj2/HV3FYbtSzu2zfXYVBhg+DCJKqtUL/QhrUVtIyoswdH6xM8yaqOCukNF/ox28Vwt24ET6Ds4Q0fb6Eiyi7nHRR+tihL6cAVjPQsO79bZhP236cUnRELmQh1RaCUoYPzO3KBs3S7IZHoPVTOZZhWYSw4T0UwXWoefUEblsgkcePRl6GyO644hmaL4myRvA96ue+fF/tMw2S1zqa0EG2GfzZXTxcerIbqL/z261pMDtj+Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JXo6PQFC3y8/N/QM07hBI5sk2nBnBK9hRPqoQ+ZMNk0=; b=eaYMHWk4QfYR9xFsXpfAD4FjSV3Idi07eH+1VlCP/QsEv4Ashn3Di93Unb/scO7U8rGbjrF2+x4arkw8auxMdHgImD6bm6UyVHQBQ+tb6iM4yVA5L63KJz3fiX3FlCNyvJJyJfoiRPZ7drYx0QIZGCSEXyl2KjXDrUXComRnq2OSjmLGt1c8q2Klsr8mH5liPxCmD+fsQt3nXzoCNwxnbVBsMmVIyvo0zcqcbXr38b0cp+tDyr7WNgBg8s6wU/6c05ICKB4/1sHieWQEed8RjQhHdP2+dV21ZA2Gq6OOZIwRLA6QNGa7sR5R1m5W236K75Jyzdjdf5zWcbqKRrNWOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXo6PQFC3y8/N/QM07hBI5sk2nBnBK9hRPqoQ+ZMNk0=; b=RrHu7DBszL480RyE5x1uZWi80N6EeFgR2dihbSXDPELeo4VrG0JDqfiATACya7Zf1vWU4qXDBfkszzC4SweO0Op64F6aoH5N0piFB+2QOjIJwjz+mLYO/kBBDBjNoTnnsj9UIGD1knZapQOaewfngkPTjBn6WBHz6jutnwJt2HvJH2TGGzC2L4WIf55b33e645Xr2hI9hGvoY8Rb4daN8fC08QrPYB49wmEcwlmPKI6FscznqwTBy6jFzxZwxYCj1Rqq/8b/+pFPB9ARpNgvfsBMHYGy631JpJupl2RXgYMweyOPH++podFxehE07RN/+UOgFhimKcKMXUmls+tchA== Received: from TYSPR06MB6433.apcprd06.prod.outlook.com (2603:1096:400:47a::6) by TY0PR06MB5494.apcprd06.prod.outlook.com (2603:1096:400:265::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.25; Sat, 22 Jun 2024 04:21:28 +0000 Received: from TYSPR06MB6433.apcprd06.prod.outlook.com ([fe80::81f7:9125:583a:1cca]) by TYSPR06MB6433.apcprd06.prod.outlook.com ([fe80::81f7:9125:583a:1cca%3]) with mapi id 15.20.7698.017; Sat, 22 Jun 2024 04:21:28 +0000 From: Nuo Mi To: ffmpeg-devel@ffmpeg.org Date: Sat, 22 Jun 2024 12:21:12 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240622042114.92873-1-nuomi2021@gmail.com> References: <20240622042114.92873-1-nuomi2021@gmail.com> X-TMN: [PSbSoY3oDOyf9T9WXvXU+SDIheYGheZz] X-ClientProxiedBy: SG2P153CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096::18) To TYSPR06MB6433.apcprd06.prod.outlook.com (2603:1096:400:47a::6) X-Microsoft-Original-Message-ID: <20240622042114.92873-2-nuomi2021@gmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 2 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYSPR06MB6433:EE_|TY0PR06MB5494:EE_ X-MS-Office365-Filtering-Correlation-Id: bc76cb18-885d-4013-cfc3-08dc9272c912 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199025|3412199022|440099025|1710799023; X-Microsoft-Antispam-Message-Info: Sd3s8RG28JL+KIR4avqqmRdlIYLo1sjjwxCoydkSr7gXE+aP4bCfqmRTgdwPbdks1+BNIuF+RIOTlMRfZQaxnlDUt7wbtaKEoSEhsHTQ59AkR3KysnCgYbREvVljE68f2c8ZDurfEkMsA/PexvNTo0jU5NDagZEjbjjofZOT894kryv28Cz/MfUtI3xJLwcG7bfxNDq1CXSN+g3mcYo2BLvgDUHXwoflioe+bp/FRq8/IJNbYd14SPwn6krGoEB/DAHtZO4Fu7noFOmbcd1yyMtWFNegq8q4vI3cIiA6mNFBzum3Ts915CTnJKauUPd7nRi1WGrEtaifu0F8LWG/UscLZpmRULNi4W7PZi/XkAVKD6Dl+yHo/b2TFUzsL4SCjDvWT2O/Qjo4NHzoxwM3L4cVmHK11ESPN6yHQ/OK1OFbx0tyDm0ygIUocAYs7IU5OK/3H2GQ3D+9Ii5SbMEvca/MNVCFFzRqw2mWs4FBLt1sMWti/i16Ylm+beiEcBMfqFl4CUSJpzl8MRprcS+OAuw4zN4iVtstNsl7qFtQgZ8VS7SbS5BVXP3z2LiJJ2NkeMIm++Q9eH8SnmQMsLbprtgzHAVdLvJrLd5/rS4zBMUpi69CY5RCMU5lGMYiEk8F X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: x253GgcfgEc43vzEXJSQeCWnJdvq2O/sqTCfAKjCznynyPV6AN3cv6QMAuOeBHXvFDJXphZdYvKIZd037WC0IE7F8UAgDGDuD4mOEdonWf2HurZlt14Ct2GxR3DIAxvLFCfj1wVWC/YUGCyzeAp0cZ63JOVL7K+aYT+cKI/hClmu6QUy9hzkwMMv+E3E0BdFoWIAjustbqA+DSzHJIjSQcLL3Gv4v8lDw9vlSfJRx+y4NJdzHbr7TdX0rlY25OnhsR6K1/ZDro0FtL6rCtF16V23e0YB69cUejeqOczT+xSqYcAoQCmX5EMa6m0IyT6BMfOC0g3b45WgVTvBEdqUOdZBjnB1cVjxCh0uUyaJyVzFvUHBMCPOraXfl12k04qnsw0dDifefpcj57Vbk7NLUsL/v/s08IM6pC4iDrilwicrvkceqke1Ay68dfzBItVBgV5/AWx4nnbeUtieRVUY9FC4aosotQoIBseNb8TMbfbf2XIB6moh2ydeTDdL1ikzjtmZdjaqbKE8ATGB0Ar4MH7CnNkH1ODpiALy9Mk0pSFklD6CTThfjlOayXX8LPGeliqBH13r3S4619LTHhtIBxqYKmdWlbaW9nk9VaeP/4sitKxzn2/RsQov8egHMxoOK6s3nFtxgWE7BNgpHSb3mgMNcjf27N87lXqn8s50WRA29k8Thjm0jQMztUzYE1zVCxH2JfyWB1NmkdhnW+J9DnatZlmUOUemvkgzjpfR5EoFO1dNVrcQJlP5Kby7S/5D0rGdomOImvRXnG2FytDTaQ50pV0TykANVnMwj5yuu8FDeUV4xsvJrSQgXGwXVsdEjlPSoXDUm0vSYxD+kLluJ3HoqWX5UxijwSlyGiN98ZHe1jBOpWYCt2LTM8W2+mL/bouyYQ/2OFN+199NoeQZK3gF4QlKalugIr/9f1Gp0Ldn11o9GRccEPnffa/IWBfBvlXMJr+okCJ60VYQxncl87H1TpA2tfy7240u6C/rxsPCLndCBQ9ug+Gb4rYX7lnZNk4I6CU9KZUQrS0NmexH4B3uIIZrWDYxqfS3dBHimIrAvCLOu6kLQPyCBls6jnp2UbIatVrJeCGURkBEkAZSqvmKGwqgIl1zv+TmU3Tgk4lEidD9k1Js/jbrrSw+W2MvxzH362hWv+UoPVf4q2IFEUpU4VgVgfMfMZk1of7KLCN0GqQnqmy17sbxkoSDT8Jg6cA8lUjvAZwvcR5uEQu8Jvup/3sDzhju5nEAWTF5sJiee9RqiVODzw37CPVzCyHgXRghS+gJUlswwFmGJqL9kg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc76cb18-885d-4013-cfc3-08dc9272c912 X-MS-Exchange-CrossTenant-AuthSource: TYSPR06MB6433.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2024 04:21:27.8689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5494 Subject: [FFmpeg-devel] [PATCH 2/4] checkasm/vvc_alf: random select alf virtual boundaries position X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: benjamin.bross@hhi.fraunhofer.de, Nuo Mi Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4h9xjfo+M8xL A picture's virtual boundaries will split a CTU into 4 ALF blocks. The ALF virtual boundary may cross or not cross a ALF block. --- tests/checkasm/vvc_alf.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c index 902757aff1..be8b930810 100644 --- a/tests/checkasm/vvc_alf.c +++ b/tests/checkasm/vvc_alf.c @@ -66,6 +66,14 @@ static const uint32_t pixel_mask[3] = { 0xffffffff, 0x03ff03ff, 0x0fff0fff }; } \ } while (0) +static int get_alf_vb_pos(const int h, const int vb_pos_above) +{ + if (h == MAX_CTU_SIZE) + return MAX_CTU_SIZE - vb_pos_above; + // If h < MAX_CTU_SIZE and picture virtual boundaries are involved, ALF virtual boundaries can either be within or outside this ALF block. + return ((rnd() & 1) ? h : MAX_CTU_SIZE) - vb_pos_above; +} + static void check_alf_filter(VVCDSPContext *c, const int bit_depth) { LOCAL_ALIGNED_32(uint8_t, dst0, [DST_BUF_SIZE]); @@ -92,11 +100,10 @@ static void check_alf_filter(VVCDSPContext *c, const int bit_depth) for (int h = 4; h <= MAX_CTU_SIZE; h += 4) { for (int w = 4; w <= MAX_CTU_SIZE; w += 4) { - const int ctu_size = MAX_CTU_SIZE; //Both picture size and virtual boundaries are 8-aligned. For luma, we only need to check 8-aligned sizes. if (!(w % 8) && !(h % 8)) { if (check_func(c->alf.filter[LUMA], "vvc_alf_filter_luma_%dx%d_%d", w, h, bit_depth)) { - const int vb_pos = ctu_size - ALF_VB_POS_ABOVE_LUMA; + const int vb_pos = get_alf_vb_pos(h, ALF_VB_POS_ABOVE_LUMA); memset(dst0, 0, DST_BUF_SIZE); memset(dst1, 0, DST_BUF_SIZE); call_ref(dst0, dst_stride, src0 + offset, src_stride, w, h, filter, clip, vb_pos); @@ -113,7 +120,7 @@ static void check_alf_filter(VVCDSPContext *c, const int bit_depth) //For chroma, once it exceeds 64, it's not a 4:2:0 format, so we only need to check 8-aligned sizes as well. if ((w <= 64 || !(w % 8)) && (h <= 64 || !(h % 8))) { if (check_func(c->alf.filter[CHROMA], "vvc_alf_filter_chroma_%dx%d_%d", w, h, bit_depth)) { - const int vb_pos = ctu_size - ALF_VB_POS_ABOVE_CHROMA; + const int vb_pos = get_alf_vb_pos(h, ALF_VB_POS_ABOVE_CHROMA); memset(dst0, 0, DST_BUF_SIZE); memset(dst1, 0, DST_BUF_SIZE); call_ref(dst0, dst_stride, src0 + offset, src_stride, w, h, filter, clip, vb_pos); @@ -152,7 +159,7 @@ static void check_alf_classify(VVCDSPContext *c, const int bit_depth) for (int h = 8; h <= MAX_CTU_SIZE; h += 8) { for (int w = 8; w <= MAX_CTU_SIZE; w += 8) { const int id_size = w * h / ALF_BLOCK_SIZE / ALF_BLOCK_SIZE * sizeof(int); - const int vb_pos = MAX_CTU_SIZE - ALF_BLOCK_SIZE; + const int vb_pos = get_alf_vb_pos(h, ALF_VB_POS_ABOVE_LUMA); if (check_func(c->alf.classify, "vvc_alf_classify_%dx%d_%d", w, h, bit_depth)) { memset(class_idx0, 0, id_size); memset(class_idx1, 0, id_size);