diff mbox series

[FFmpeg-devel,4/4] checkasm/vvc_alf: ensure right and bottom boundaries are not overwritten by asm

Message ID TYSPR06MB6433CAAEC8D3D359D3891D24AACA2@TYSPR06MB6433.apcprd06.prod.outlook.com
State New
Headers show
Series [FFmpeg-devel,1/4] checkasm/vvc_alf: only check the valid filter and classify sizes | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Nuo Mi June 22, 2024, 4:21 a.m. UTC 
---
 tests/checkasm/vvc_alf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Nuo Mi June 25, 2024, 11:55 a.m. UTC | #1 
Applied.
Thank you Ben for reviewing.

On Sat, Jun 22, 2024 at 12:21 PM Nuo Mi <nuomi2021@gmail.com> wrote:

> ---
>  tests/checkasm/vvc_alf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c
> index be8b930810..15e79289cd 100644
> --- a/tests/checkasm/vvc_alf.c
> +++ b/tests/checkasm/vvc_alf.c
> @@ -108,8 +108,8 @@ static void check_alf_filter(VVCDSPContext *c, const
> int bit_depth)
>                      memset(dst1, 0, DST_BUF_SIZE);
>                      call_ref(dst0, dst_stride, src0 + offset, src_stride,
> w, h, filter, clip, vb_pos);
>                      call_new(dst1, dst_stride, src1 + offset, src_stride,
> w, h, filter, clip, vb_pos);
> -                    for (int i = 0; i < h; i++) {
> -                        if (memcmp(dst0 + i * dst_stride, dst1 + i *
> dst_stride, w * SIZEOF_PIXEL))
> +                    for (int i = 0; i < (h + 1); i++) {
> +                        if (memcmp(dst0 + i * dst_stride, dst1 + i *
> dst_stride, (w + 1) * SIZEOF_PIXEL))
>                              fail();
>                      }
>                      // Bench only square sizes, and ones with dimensions
> being a power of two.
> @@ -125,8 +125,8 @@ static void check_alf_filter(VVCDSPContext *c, const
> int bit_depth)
>                      memset(dst1, 0, DST_BUF_SIZE);
>                      call_ref(dst0, dst_stride, src0 + offset, src_stride,
> w, h, filter, clip, vb_pos);
>                      call_new(dst1, dst_stride, src1 + offset, src_stride,
> w, h, filter, clip, vb_pos);
> -                    for (int i = 0; i < h; i++) {
> -                        if (memcmp(dst0 + i * dst_stride, dst1 + i *
> dst_stride, w * SIZEOF_PIXEL))
> +                    for (int i = 0; i < (h + 1); i++) {
> +                        if (memcmp(dst0 + i * dst_stride, dst1 + i *
> dst_stride, (w + 1) * SIZEOF_PIXEL))
>                              fail();
>                      }
>                      if (w == h && (w & (w - 1)) == 0)
> --
> 2.34.1
>
>
diff mbox series

Patch

diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c
index be8b930810..15e79289cd 100644
--- a/tests/checkasm/vvc_alf.c
+++ b/tests/checkasm/vvc_alf.c
@@ -108,8 +108,8 @@  static void check_alf_filter(VVCDSPContext *c, const int bit_depth)
                     memset(dst1, 0, DST_BUF_SIZE);
                     call_ref(dst0, dst_stride, src0 + offset, src_stride, w, h, filter, clip, vb_pos);
                     call_new(dst1, dst_stride, src1 + offset, src_stride, w, h, filter, clip, vb_pos);
-                    for (int i = 0; i < h; i++) {
-                        if (memcmp(dst0 + i * dst_stride, dst1 + i * dst_stride, w * SIZEOF_PIXEL))
+                    for (int i = 0; i < (h + 1); i++) {
+                        if (memcmp(dst0 + i * dst_stride, dst1 + i * dst_stride, (w + 1) * SIZEOF_PIXEL))
                             fail();
                     }
                     // Bench only square sizes, and ones with dimensions being a power of two.
@@ -125,8 +125,8 @@  static void check_alf_filter(VVCDSPContext *c, const int bit_depth)
                     memset(dst1, 0, DST_BUF_SIZE);
                     call_ref(dst0, dst_stride, src0 + offset, src_stride, w, h, filter, clip, vb_pos);
                     call_new(dst1, dst_stride, src1 + offset, src_stride, w, h, filter, clip, vb_pos);
-                    for (int i = 0; i < h; i++) {
-                        if (memcmp(dst0 + i * dst_stride, dst1 + i * dst_stride, w * SIZEOF_PIXEL))
+                    for (int i = 0; i < (h + 1); i++) {
+                        if (memcmp(dst0 + i * dst_stride, dst1 + i * dst_stride, (w + 1) * SIZEOF_PIXEL))
                             fail();
                     }
                     if (w == h && (w & (w - 1)) == 0)