diff mbox series

[FFmpeg-devel] Use proper header for OpenBSD PPC CPU detection

Message ID YiAbPfc4NqbdblGJ@humpty.home.comstyle.com
State Accepted
Commit beaf172d75da1580532e241be5ff546c806abd41
Headers show
Series [FFmpeg-devel] Use proper header for OpenBSD PPC CPU detection | expand

Checks

Context Check Description
andriy/commit_msg_armv7_RPi4 warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/commit_msg_aarch64_jetson warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
yinshiyou/commit_msg_loongarch64 warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_aarch64_jetson success Make finished
andriy/make_fate_aarch64_jetson success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Brad Smith March 3, 2022, 1:34 a.m. UTC
Use the proper header for PPC CPU detection code. sys/param.h includes
sys/types, but sys/types.h is the more appropriate header to be used
here.

Comments

Brad Smith June 23, 2022, 11:19 p.m. UTC | #1
ping.

On 3/2/2022 8:34 PM, Brad Smith wrote:
> Use the proper header for PPC CPU detection code. sys/param.h includes
> sys/types, but sys/types.h is the more appropriate header to be used
> here.
>
>
> diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c
> index b022149fa0..96b491c716 100644
> --- a/libavutil/ppc/cpu.c
> +++ b/libavutil/ppc/cpu.c
> @@ -28,7 +28,7 @@
>   #include <unistd.h>
>   #endif
>   #elif defined(__OpenBSD__)
> -#include <sys/param.h>
> +#include <sys/types.h>
>   #include <sys/sysctl.h>
>   #include <machine/cpu.h>
>   #elif defined(__AMIGAOS4__)
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer June 24, 2022, 9:02 p.m. UTC | #2
On Wed, Mar 02, 2022 at 08:34:53PM -0500, Brad Smith wrote:
> Use the proper header for PPC CPU detection code. sys/param.h includes
> sys/types, but sys/types.h is the more appropriate header to be used
> here.

will apply

thx

[...]
diff mbox series

Patch

diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c
index b022149fa0..96b491c716 100644
--- a/libavutil/ppc/cpu.c
+++ b/libavutil/ppc/cpu.c
@@ -28,7 +28,7 @@ 
 #include <unistd.h>
 #endif
 #elif defined(__OpenBSD__)
-#include <sys/param.h>
+#include <sys/types.h>
 #include <sys/sysctl.h>
 #include <machine/cpu.h>
 #elif defined(__AMIGAOS4__)