From patchwork Sun Apr 14 18:58:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Strasser X-Patchwork-Id: 48057 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:670b:b0:1a9:af23:56c1 with SMTP id wh11csp1415928pzb; Sun, 14 Apr 2024 11:58:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUtvBeFL/8DUM27fNm9REg2LI+I6Bvgmx6d1qyi3AYRhDb2kcPIw5dQE7PNYciHlLxsDaeE7PCn9t0q5X92+GAgiED45UQaP6vLEw== X-Google-Smtp-Source: AGHT+IECenDefF1KjDXZO2E3cPohiMEawk6S7vqKDyAF4cGXPI9c9yZZmg20DdzpiSmNoFM+sat0 X-Received: by 2002:a17:907:6d27:b0:a52:197b:5f4a with SMTP id sa39-20020a1709076d2700b00a52197b5f4amr10692483ejc.2.1713121110412; Sun, 14 Apr 2024 11:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713121110; cv=none; d=google.com; s=arc-20160816; b=0e8FRuFc2vCENEYYwCTsvD8jKx3Vhk5urDhjqFObPh/IjnUmZ6IasrRhJIINAW8Bsz Qg78U4QdMJOiT1JEe6CwsbVeLLRGH/+Y5uNrrKbO6SWObCy+ioOS6YkQ4RuYvUz1w9Iz 5mF1EKwnVocuPokQ/UnmInghdhiNDrmhw/AxbOVKC2uO0yiMOMh/cS1si+eYB0C8/wss LkhlOzV2q1PgK1AN/z442fIUTTh/jl05ZR0Xg0mvle1ckabbDq5ik4ZY0GsO8saz6j2X ssa2GCEMcP725yPBuTDAKj92sy5nAsc1xzIhS1b/diSAxzEciUKMevws+esUp2SINODY wAIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to:from :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:ui-outboundreport:content-disposition :mime-version:message-id:to:date:delivered-to; bh=+7NAQdteUvHuRITTEQmVKFVD9cqorWJFu0WIg4PZQXY=; fh=12mN4pfzDNzdHyzKFbbDbvwqdgi/dxWu8iEqOdEdeaI=; b=HCJmwQvMSBHyQAffQ5hwIJdx7+giQTBb1jRsTYwXeTNSpb0XIgwFTIX03bYXDkYvpw YSD0wQ9+RPUIQpNchjW4f4kEvOUc2PWRiKcL4rCwsUbULurNfD+KDVpsy68P3oXfqSU8 64+bwPl1ZrYOFio/22Biq1YR/wc9d+r8b6D+ttBu7vexYxJwl7lRp2tjjangY8fd+8yU T4n306TTTDbOJRDE4sJt+22/r1Cf3ruT7G3BwjD3FN2E74noS8OCsv6CdkX75zqof3nl 84GtCcvxaL3TIh52xlN39zPLGj8CduA8KkmZEU3IXghQO1lHLeEStA6Iu32M9HBf9IG1 ZyAg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id p6-20020a170906604600b00a51d113b490si3850891ejj.26.2024.04.14.11.58.29; Sun, 14 Apr 2024 11:58:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C6FC868D29A; Sun, 14 Apr 2024 21:58:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 41FE068BA2D for ; Sun, 14 Apr 2024 21:58:20 +0300 (EEST) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from metallschleimette ([91.12.119.229]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2V4P-1stNJc1bgt-013u2s for ; Sun, 14 Apr 2024 20:58:19 +0200 Date: Sun, 14 Apr 2024 20:58:18 +0200 To: ffmpeg-devel@ffmpeg.org Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Provags-ID: V03:K1:eAeki1Ty3+OvggKtCEyJJ5Su76N/9RQh4eAMVWoFIHuBEYVGHMv bp0FqeE3Oi1M9X8L6MWoitA0vKEBoX0KytPJIC5oADhR+jC2M04Gnkad0DhSUyGBhcb+mrU SN2AQOT+wDxY2Nhp65WPxue8b7QE/zZxA2nV7AikvlG8nqFlFmJIm4IGnEQl7G0Su8kdfTg JwwLm9NpFiTx21lKQ/sYg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Bsd5FY1/BYg=;fNl5i9rj3U/K+8VY0M+HxfpjioO E7peUU5uVs3LNJsUKieou7RH6xl2yhypeN3V6VhW6cBktfWhpoKA02+Pk3BdnCht9NZm2Bdjn 4SttZegHKzwYdjwyQpjQmw2T+3JRyEU8wAmom41sEvNGFWa5r2kQ8Tbi1cXzlrxNe57XCL5qj eqKpjgbUtQfuc9M0Zzw3J25dJrBaBk9aPn+btullQ9vwja2qblFnVH17avFEOl/31c61O1Re7 L0AsjfqlQt32H4T37ITrCfXv/U5FvS7mOUcTZJpVuiGCkXv635TFTwsr7YGibJaKuxl8aP4Nf dkefRbiLJMu+xvuix3/kwydvB0Md4cs/GPm1iFReYofmmEcImnqlhrbckuUXL688aEL8qn+lI UMkywVAv++E4ukdCHgMJCKd7Y88The7taPBPZNOotwnSnPydmV+y/6EpKEjvJe3Sn5gWulQyl kjBlY1y4KjY7IHA2p1wFyuU/njXym2UeTCMeyx9ahk3gdczYhAZ/eNGGCxRXEtpI8K8QkxVXg L0qYCtSKq7PugCw6SwH/rIf5OrnDJDld9ecu3dRIRfdxFRCy30TUhav4vaZrHegNwAxWtcjyD GUuJ+Al1akGBOhvDtBZZI8O7IRLw+oN2BiQ58UON5hhel5S4AJ+zVf/9IsYPrj8RB5Ih1MZpI Sp9X0Xm8Mj7jDeaikXW8sEC4lydvUBpw5q4tl8lsbEtt7fB31qJZfAbcynCAqn+zhDie3bz8l U61XXWB7lUne1rqXCnLQ7j43Zjz9E0wIxIuPZ880Hw/kgjGwI1t45GGbTXTxog5idR79M8Jh9 PDoRR4Mz/Pvz3UYEHp1Rbs6GJ6nWPG7RAW1PZgvm3zN2Y= Subject: [FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alexander Strasser via ffmpeg-devel From: Alexander Strasser Reply-To: FFmpeg development discussions and patches Cc: Alexander Strasser Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Bg+5DOCuZ6gk When piping ffmpeg into ffplay both programs write a status line in the terminal. That causes flickering and invisibility of one or the other status line. As compromise set ffplay log level to warning, so it doesn't show the status line. The user is usually testing ffmpeg command lines and want's a preview of the result. This way the user can see the ffmpeg output and still see errors and warnings from ffplay, should they occur. --- libavdevice/opengl_enc.c | 2 +- libavdevice/sdl2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index 6f7a30ff9e..c50d02870a 100644 --- a/libavdevice/opengl_enc.c +++ b/libavdevice/opengl_enc.c @@ -1067,7 +1067,7 @@ static av_cold int opengl_write_header(AVFormatContext *h) av_log(opengl, AV_LOG_WARNING, "The opengl output device is deprecated due to being fundamentally incompatible with libavformat API. " "For monitoring purposes in ffmpeg you can output to a file or use pipes and a video player.\n" - "Example: ffmpeg -i INPUT -f nut -c:v rawvideo - | ffplay -\n" + "Example: ffmpeg -i INPUT -f nut -c:v rawvideo - | ffplay -loglevel warning -\n" ); opengl->warned = 1; } diff --git a/libavdevice/sdl2.c b/libavdevice/sdl2.c index 779c8e08b0..59e3182df8 100644 --- a/libavdevice/sdl2.c +++ b/libavdevice/sdl2.c @@ -167,7 +167,7 @@ static int sdl2_write_header(AVFormatContext *s) av_log(sdl, AV_LOG_WARNING, "The sdl output device is deprecated due to being fundamentally incompatible with libavformat API. " "For monitoring purposes in ffmpeg you can output to a file or use pipes and a video player.\n" - "Example: ffmpeg -i INPUT -f nut -c:v rawvideo - | ffplay -\n" + "Example: ffmpeg -i INPUT -f nut -c:v rawvideo - | ffplay -loglevel warning -\n" ); sdl->warned = 1; }