From patchwork Tue Sep 19 22:24:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 5194 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.36.26 with SMTP id f26csp59296jaa; Tue, 19 Sep 2017 15:24:35 -0700 (PDT) X-Received: by 10.28.30.139 with SMTP id e133mr2089334wme.8.1505859875524; Tue, 19 Sep 2017 15:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505859875; cv=none; d=google.com; s=arc-20160816; b=hzLqz1BJ0mYPeGwloxg2gHHSPCuo7Ami6IIJdd4p69D5/gwrWZ4SPDbC0uofABIw6w wbPBWekhAXmOQ9FQPqsprjAq3RkaYdrvDoECatOrUaLw0zJatTFiz6H8X9YhHktu6a2R HDKh+JNlBQSQKDsz4t9URD996ubCHdgls4fYbVCq4kQPEOasV7mwRMwcYj83l5jV6Iqd t0uzrV9qystCARqeb03WVUULuilXWbOl78E/atL+GIacSJjWphIuawI2jnoYpOxJSYcs Rj0+4/zRGCGUgacvhLJ0qUqQAcXI6qks57rQm9MK1J66FDL3AqyfIxHCFJbVjX8KS95Y spkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=+zhT8zxPQ6E/Gxn66IYEUb6hHx416RZHZdfBO3HX8vs=; b=FwuqJHhlHmK9qF9I1lZIGGO81IPaZTUMfSrO8SQl7go/9H1tY7mj1ARodb65BD6D9J CaxaqYuw7OiAHH0c15kCCc9QdgSiPPedJ3OpfRKW6WeY5KWOVSHXdzzTvrIPnfBYB0Ar sdZSKOkhi2qG4ukc++4UHgwSNQv5OEPSHs3d6zcob+mmT7HZbuh2qvuRxnHf2CNJRM3J HH/fE4rfNZLFVOViR7jb4Fr7hM1SF0zho1vGwTqmgRb+3loAs7ainfXjk/pVK4oNacMJ sOJhU9ZFk2hru6ImJn01BwU1WpJS/PVKxEk4NkWcYqHbI2vIzJKeD1XQjIzt96t44C0W aCpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=vSn6diG4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f22si284221wrf.172.2017.09.19.15.24.34; Tue, 19 Sep 2017 15:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=vSn6diG4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C72EA6883D7; Wed, 20 Sep 2017 01:24:24 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C98CC6807BF for ; Wed, 20 Sep 2017 01:24:17 +0300 (EEST) Received: by mail-wm0-f44.google.com with SMTP id e71so2525860wmg.4 for ; Tue, 19 Sep 2017 15:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=RjvjCrkAJpGin8VPKqboRjBBUwyMBktBgbLSzKtMGdU=; b=vSn6diG4UCkr1Ee1HRy3E/1DQjo1juhjHvHp9ZhspwQMHlygQyMG0lTUUU9wru5gnh DrHsYR/f+x0r+AqR3kbibfzvqefvwnL5Bt21071T2NmFVU/brqFSlET/3Et1gWOY7vbr wM2Hhfr3jh3wTwUCNmtddVrYcecJAdrOOO3QT8XBX2nF/b5hfOeDgzOHsx7wED9QUYbe bb48sysfPFmLkNGGzeFEbj4Z25m+GJNhlO8eXG4R3L04GVz8ekM7CtkFACoMVKccMZ3P 6CVxwIAV2IxSQ3YZfFknZl7WKmCWP9vJqYI33p/GJrGCZcQ0KwsPVDl4RrgF1geXTIcq 1dgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RjvjCrkAJpGin8VPKqboRjBBUwyMBktBgbLSzKtMGdU=; b=EcW7m1EyJHdIBQQARhrHsz6QXkPdlQmYNabwr917q4W1/tudzSh535OkHIouS3rNS/ nOns/me/5VxJAew9z1FWqWrbGg0FsI9C903P4Pvh+PUIVI1HrB3U6aVgPFtbV0aOAN3i yk+mBVJhSeuQZtPUjZgY6FOtFM1t7FWyJ7GGi5iV7RAa4Rphr2nl14EHy8Hhxw+lDatf NNXUcxw5/A0P+impCNk5RjaxpDdOlvzSC4cFXPTXrp16FJ2djkrQswtajFBKUc5zYA/e XQ7sRTbIERJNE8HPfcuZ6TNs03ZpHUbqyS+Kfl+KTft6rNyU3X+Ox3MyDXEm71L2++Jw Xphg== X-Gm-Message-State: AHPjjUhBu6h1ESpzfugVuKdxfYtqkCQBozI3yHO0fvWn0G1HOd9uxTzD HZA6BNufo9PfII4Zz2B4jJufW/cx X-Google-Smtp-Source: AOwi7QAsjX2m5rptdGRMn3oY4a+YfeAyuGpL3x+qK+hDLPM0ujIfRHILS9Lb5Jf271JTFfGPKP6btQ== X-Received: by 10.28.132.69 with SMTP id g66mr2454273wmd.13.1505859865980; Tue, 19 Sep 2017 15:24:25 -0700 (PDT) Received: from [192.168.0.9] (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id v5sm294714wmb.0.2017.09.19.15.24.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 15:24:25 -0700 (PDT) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org References: <1505396682-24879-1-git-send-email-t.rapp@noa-archive.com> <1505396682-24879-2-git-send-email-t.rapp@noa-archive.com> <20170915204313.GX7094@nb4> <94920373-dab0-fcff-34f8-69690da7bb85@noa-archive.com> Message-ID: Date: Tue, 19 Sep 2017 23:24:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [FFmpeg-devel] [PATCH 2/2] fate: add mxf_dv25/dvcpro50 regression tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 19/09/17 23:13, Mark Thompson wrote: > On 18/09/17 08:34, Tobias Rapp wrote: >> On 15.09.2017 22:43, Michael Niedermayer wrote: >>> On Thu, Sep 14, 2017 at 03:44:42PM +0200, Tobias Rapp wrote: >>>> Signed-off-by: Tobias Rapp >>>> --- >>>>   tests/fate/avformat.mak          |  2 ++ >>>>   tests/fate/seek.mak              |  4 +++ >>>>   tests/lavf-regression.sh         |  8 ++++++ >>>>   tests/ref/lavf/mxf_dv25          |  3 +++ >>>>   tests/ref/lavf/mxf_dvcpro50      |  3 +++ >>>>   tests/ref/seek/lavf-mxf_dv25     | 53 ++++++++++++++++++++++++++++++++++++++++ >>>>   tests/ref/seek/lavf-mxf_dvcpro50 | 53 ++++++++++++++++++++++++++++++++++++++++ >>>>   7 files changed, 126 insertions(+) >>>>   create mode 100644 tests/ref/lavf/mxf_dv25 >>>>   create mode 100644 tests/ref/lavf/mxf_dvcpro50 >>>>   create mode 100644 tests/ref/seek/lavf-mxf_dv25 >>>>   create mode 100644 tests/ref/seek/lavf-mxf_dvcpro50 >>> >>> probably ok >> >> Applied, thanks for the review. >> >> Tobias > > Could this contain some system-dependence or nondeterminism? > > (Debian stable, Skylake x86-64, nothing funny going on that I'm aware of...) > > > $ make V=1 fate-lavf-mxf_dvcpro50 > TEST lavf-mxf_dvcpro50 > /home/mrt/video/ffmpeg/push/tests/fate-run.sh fate-lavf-mxf_dvcpro50 "/home/mrt/video/ffmpeg/fate/" "" "/home/mrt/video/ffmpeg/push/build" 'lavftest' '' '' '' '1' '' '' '' '' '' '' '' '' '' > /home/mrt/video/ffmpeg/push/build/ffmpeg -nostdin -nostats -y -cpuflags all -flags +bitexact -idct simple -sws_flags +accurate_rnd+bitexact -fflags +bitexact -threads 1 -f image2 -vcodec pgmyuv -i /home/mrt/video/ffmpeg/push/build/tests/vsynth1/%02d.pgm -flags +bitexact -idct simple -sws_flags +accurate_rnd+bitexact -fflags +bitexact -threads 1 -ar 44100 -f s16le -ar 48000 -ac 2 -i /home/mrt/video/ffmpeg/push/build/./tests/data/asynth1.sw -flags +bitexact -idct simple -sws_flags +accurate_rnd+bitexact -fflags +bitexact -threads 1 -dct fastint -metadata title=lavftest -b:a 64k -t 1 -qscale:v 10 -r 25 -vf scale=720:576,setdar=16/9 -vcodec dvvideo -pix_fmt yuv422p -b 50000k -top 0 -f mxf /home/mrt/video/ffmpeg/push/build/./tests/data/lavf/lavf.mxf_dvcpro50 > /home/mrt/video/ffmpeg/push/build/ffmpeg -nostdin -nostats -y -cpuflags all -flags +bitexact -idct simple -sws_flags +accurate_rnd+bitexact -fflags +bitexact -threads 1 -i /home/mrt/video/ffmpeg/push/build/./tests/data/lavf/lavf.mxf_dvcpro50 -f crc /home/mrt/video/ffmpeg/push/build/./tests/data/mxf_dvcpro50.lavf.crc > --- /home/mrt/video/ffmpeg/push/tests/ref/lavf/mxf_dvcpro50 2017-09-19 22:46:36.169691617 +0100 > +++ tests/data/fate/lavf-mxf_dvcpro50 2017-09-19 23:07:20.558751142 +0100 > @@ -1,3 +1,3 @@ > -6c9cb62911ac16c3b55f0ad0b052c05b *./tests/data/lavf/lavf.mxf_dvcpro50 > +fe3f278b4deed2b89eba6f31cb092f98 *./tests/data/lavf/lavf.mxf_dvcpro50 > 7430189 ./tests/data/lavf/lavf.mxf_dvcpro50 > ./tests/data/lavf/lavf.mxf_dvcpro50 CRC=0xe3bbe4b4 > Test lavf-mxf_dvcpro50 failed. Look at tests/data/fate/lavf-mxf_dvcpro50.err for details. > ffmpeg version N-87333-gf952edaa73 Copyright (c) 2000-2017 the FFmpeg developers > built with gcc 6.3.0 (Debian 6.3.0-18) 20170516 > configuration: --samples=/home/mrt/video/ffmpeg/fate/ --enable-vaapi --enable-libdrm --enable-gpl --enable-libx264 --enable-shared > libavutil 55. 75.100 / 55. 75.100 > libavcodec 57.106.101 / 57.106.101 > libavformat 57. 82.100 / 57. 82.100 > libavdevice 57. 8.101 / 57. 8.101 > libavfilter 6.105.100 / 6.105.100 > libswscale 4. 7.103 / 4. 7.103 > libswresample 2. 8.100 / 2. 8.100 > libpostproc 54. 6.100 / 54. 6.100 > Input #0, image2, from '/home/mrt/video/ffmpeg/push/build/tests/vsynth1/%02d.pgm': > Duration: 00:00:02.00, start: 0.000000, bitrate: N/A > Stream #0:0: Video: pgmyuv, yuv420p, 352x288, 25 fps, 25 tbr, 25 tbn, 25 tbc > [s16le @ 0x5627ce70f2e0] Estimating duration from bitrate, this may be inaccurate > Guessed Channel Layout for Input Stream #1.0 : stereo > Input #1, s16le, from '/home/mrt/video/ffmpeg/push/build/./tests/data/asynth1.sw': > Duration: 00:00:05.51, bitrate: 1536 kb/s > Stream #1:0: Audio: pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s > Codec AVOption idct (select IDCT implementation) specified for input file #1 (/home/mrt/video/ffmpeg/push/build/./tests/data/asynth1.sw) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. > Please use -b:a or -b:v, -b is ambiguous > Stream mapping: > Stream #0:0 -> #0:0 (pgmyuv (native) -> dvvideo (native)) > Stream #1:0 -> #0:1 (pcm_s16le (native) -> pcm_s16le (native)) > [image2 @ 0x5627ce6f6fa0] Thread message queue blocking; consider raising the thread_queue_size option (current value: 8) > Output #0, mxf, to '/home/mrt/video/ffmpeg/push/build/./tests/data/lavf/lavf.mxf_dvcpro50': > Metadata: > title : lavftest > Stream #0:0: Video: dvvideo, yuv422p(progressive), 720x576 [SAR 64:45 DAR 16:9], q=2-31, 50000 kb/s, 25 fps, 25 tbn, 25 tbc > Metadata: > encoder : Lavc dvvideo > Stream #0:1: Audio: pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s > Metadata: > encoder : Lavc pcm_s16le > frame= 25 fps=0.0 q=-0.0 Lsize= 7256kB time=00:00:01.00 bitrate=59441.5kbits/s speed= 4.6x > video:7031kB audio:188kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.516626% > ffmpeg version N-87333-gf952edaa73 Copyright (c) 2000-2017 the FFmpeg developers > built with gcc 6.3.0 (Debian 6.3.0-18) 20170516 > configuration: --samples=/home/mrt/video/ffmpeg/fate/ --enable-vaapi --enable-libdrm --enable-gpl --enable-libx264 --enable-shared > libavutil 55. 75.100 / 55. 75.100 > libavcodec 57.106.101 / 57.106.101 > libavformat 57. 82.100 / 57. 82.100 > libavdevice 57. 8.101 / 57. 8.101 > libavfilter 6.105.100 / 6.105.100 > libswscale 4. 7.103 / 4. 7.103 > libswresample 2. 8.100 / 2. 8.100 > libpostproc 54. 6.100 / 54. 6.100 > Guessed Channel Layout for Input Stream #0.1 : stereo > Input #0, mxf, from '/home/mrt/video/ffmpeg/push/build/./tests/data/lavf/lavf.mxf_dvcpro50': > Metadata: > uid : adab4424-2f25-4dc7-92ff-29bd000c0000 > generation_uid : adab4424-2f25-4dc7-92ff-29bd000c0001 > company_name : FFmpeg > product_name : OP1a Muxer > product_version : 0.0.0 > product_uid : adab4424-2f25-4dc7-92ff-29bd000c0002 > modification_date: 0-01-02T00:00:00.000000Z > material_package_umid: 0x060A2B340101010501010D001300000000000000000000000000000000000000 > timecode : 00:00:00:00 > Duration: 00:00:01.00, start: 0.000000, bitrate: 59441 kb/s > Stream #0:0: Video: dvvideo, yuv422p(bottom first), 720x576 [SAR 64:45 DAR 16:9], SAR 16:15 DAR 4:3, 25 fps, 25 tbr, 25 tbn, 25 tbc > Metadata: > file_package_umid: 0x060A2B340101010501010D001300000000000000000000000000000000000001 > Stream #0:1: Audio: pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s > Metadata: > file_package_umid: 0x060A2B340101010501010D001300000000000000000000000000000000000001 > Stream mapping: > Stream #0:0 -> #0:0 (dvvideo (native) -> rawvideo (native)) > Stream #0:1 -> #0:1 (pcm_s16le (native) -> pcm_s16le (native)) > Output #0, crc, to '/home/mrt/video/ffmpeg/push/build/./tests/data/mxf_dvcpro50.lavf.crc': > Metadata: > uid : adab4424-2f25-4dc7-92ff-29bd000c0000 > generation_uid : adab4424-2f25-4dc7-92ff-29bd000c0001 > company_name : FFmpeg > product_name : OP1a Muxer > product_version : 0.0.0 > product_uid : adab4424-2f25-4dc7-92ff-29bd000c0002 > modification_date: 0-01-02T00:00:00.000000Z > material_package_umid: 0x060A2B340101010501010D001300000000000000000000000000000000000000 > timecode : 00:00:00:00 > encoder : Lavf57.82.100 > Stream #0:0: Video: rawvideo (Y42B / 0x42323459), yuv422p(bottom coded first (swapped)), 720x576 [SAR 16:15 DAR 4:3], q=2-31, 165888 kb/s, 25 fps, 25 tbn, 25 tbc > Metadata: > file_package_umid: 0x060A2B340101010501010D001300000000000000000000000000000000000001 > encoder : Lavc57.106.101 rawvideo > Stream #0:1: Audio: pcm_s16le, 48000 Hz, stereo, s16, 1536 kb/s > Metadata: > file_package_umid: 0x060A2B340101010501010D001300000000000000000000000000000000000001 > encoder : Lavc57.106.101 pcm_s16le > frame= 25 fps=0.0 q=-0.0 Lsize= 0kB time=00:00:01.00 bitrate= 0.1kbits/s speed=14.3x > video:20250kB audio:188kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown > /home/mrt/video/ffmpeg/push/tests/Makefile:224: recipe for target 'fate-lavf-mxf_dvcpro50' failed > make: *** [fate-lavf-mxf_dvcpro50] Error 1 > Comparing to the right file helpfully supplied by jamrial: $ diff -u right wrong --- right 2017-09-19 23:22:17.906204557 +0100 +++ wrong 2017-09-19 23:22:23.958092926 +0100 @@ -258,8 +258,8 @@ 00001140 32 0b 00 04 00 00 00 00 33 01 00 04 00 00 00 08 |2.......3.......| 00001150 33 02 00 04 00 00 00 02 33 03 00 01 00 32 0c 00 |3.......3....2..| 00001160 01 01 32 0d 00 10 00 00 00 02 00 00 00 04 00 00 |..2.............| -00001170 00 17 00 00 01 4f 32 0e 00 08 00 00 00 10 00 00 |.....O2.........| -00001180 00 09 32 01 00 10 06 0e 2b 34 04 01 01 01 04 01 |..2.....+4......| +00001170 00 17 00 00 01 4f 32 0e 00 08 00 00 00 04 00 00 |.....O2.........| +00001180 00 03 32 01 00 10 06 0e 2b 34 04 01 01 01 04 01 |..2.....+4......| 00001190 02 02 02 02 04 00 06 0e 2b 34 02 53 01 01 0d 01 |........+4.S....| 000011a0 01 01 01 01 3b 00 50 3c 0a 00 10 ad ab 44 24 2f |....;.P<.....D$/| 000011b0 25 4d c7 92 ff 29 bd 00 1a 00 01 48 01 00 04 00 |%M...).....H....|