diff mbox

[FFmpeg-devel] avfilter/extractplanes: add support for 12-bit YUVA formats

Message ID af157c6a-cf59-a100-ee82-e9f06554be8a@gyani.pro
State Accepted
Commit f60fdbc96074a884eaa36d44946415203d3b2b79
Headers show

Commit Message

Gyan Doshi Jan. 17, 2019, 9:47 a.m. UTC
Fixes alpha extraction for sample at

https://08488297638989341201.googlegroups.com/attach/85d30cd6b8095/Circle%20Ink%20Bleed_10.mov

as seen in

     ffplay -i in -vf alphaextract

Gyan
From 122f500e09b2741f3865da5c3f612ee04dcd7e21 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg@gyani.pro>
Date: Thu, 17 Jan 2019 15:01:11 +0530
Subject: [PATCH] avfilter/extractplanes: add support for 12-bit YUVA formats

At present, 16-bit auto-scaled format results in incorrect alpha
extraction.
---
 libavfilter/vf_extractplanes.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Carl Eugen Hoyos Jan. 17, 2019, 7:38 p.m. UTC | #1
2019-01-17 10:47 GMT+01:00, Gyan <ffmpeg@gyani.pro>:
> Fixes alpha extraction for sample at
>
> https://08488297638989341201.googlegroups.com/attach/85d30cd6b8095/Circle%20Ink%20Bleed_10.mov

This is a textfile afaict.

Carl Eugen
Moritz Barsnick Jan. 18, 2019, 11:30 p.m. UTC | #2
On Thu, Jan 17, 2019 at 20:38:44 +0100, Carl Eugen Hoyos wrote:
> > Fixes alpha extraction for sample at
> >
> > https://08488297638989341201.googlegroups.com/attach/85d30cd6b8095/Circle%20Ink%20Bleed_10.mov
> 
> This is a textfile afaict.

The correct download link seems to be
https://groups.google.com/group/qlab/attach/85d30cd6b8095/Circle%20Ink%20Bleed_10.mov?part=0.1

Moritz
Carl Eugen Hoyos Jan. 19, 2019, 12:51 p.m. UTC | #3
2019-01-17 10:47 GMT+01:00, Gyan <ffmpeg@gyani.pro>:
> Fixes alpha extraction for sample at
>
> https://08488297638989341201.googlegroups.com/attach/85d30cd6b8095/Circle%20Ink%20Bleed_10.mov
>
> as seen in
>
>      ffplay -i in -vf alphaextract

> At present, 16-bit auto-scaled format results in incorrect alpha
> extraction.

Does that mean that there is an unreported bug in the colour
space conversion?

Carl Eugen
Gyan Doshi Jan. 19, 2019, 1:22 p.m. UTC | #4
On 19-01-2019 06:21 PM, Carl Eugen Hoyos wrote:
>
>> At present, 16-bit auto-scaled format results in incorrect alpha
>> extraction.
> Does that mean that there is an unreported bug in the colour
> space conversion?
Forcing a manual conversion to the same output format as the auto-scaler 
avoids the error, so looks like a config error rather than the 
conversion itself

I don't have time to trace it at present. Only wanted to get the 
immediate use-case fixed.

Thanks,
Gyan
diff mbox

Patch

diff --git a/libavfilter/vf_extractplanes.c b/libavfilter/vf_extractplanes.c
index f9171572ed..739c2420cb 100644
--- a/libavfilter/vf_extractplanes.c
+++ b/libavfilter/vf_extractplanes.c
@@ -99,6 +99,8 @@  AVFILTER_DEFINE_CLASS(extractplanes);
         AV_PIX_FMT_YUV422P12##suf,                             \
         AV_PIX_FMT_YUV444P12##suf,                             \
         AV_PIX_FMT_YUV440P12##suf,                             \
+        AV_PIX_FMT_YUVA422P12##suf,                            \
+        AV_PIX_FMT_YUVA444P12##suf,                            \
         AV_PIX_FMT_GBRP10##suf, AV_PIX_FMT_GBRAP10##suf,       \
         AV_PIX_FMT_GBRP12##suf, AV_PIX_FMT_GBRAP12##suf,       \
         AV_PIX_FMT_YUV420P9##suf,                              \