From patchwork Thu Dec 1 23:27:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Cadhalpun X-Patchwork-Id: 1652 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.96.68 with SMTP id u65csp1173227vsb; Thu, 1 Dec 2016 15:42:54 -0800 (PST) X-Received: by 10.194.203.5 with SMTP id km5mr40743143wjc.230.1480635774152; Thu, 01 Dec 2016 15:42:54 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z133si305486wmc.158.2016.12.01.15.42.52; Thu, 01 Dec 2016 15:42:54 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE dis=NONE) header.from=googlemail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E174689F57; Fri, 2 Dec 2016 01:42:42 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wj0-f196.google.com (mail-wj0-f196.google.com [209.85.210.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AAE8D689CF1 for ; Fri, 2 Dec 2016 01:42:35 +0200 (EET) Received: by mail-wj0-f196.google.com with SMTP id xy5so28265182wjc.1 for ; Thu, 01 Dec 2016 15:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to; bh=N+NWn9fbuuhCxaZzvltoPCUkBLCSr+E/k0aj80HaAOY=; b=T6OB1Tqv7iD50wp6QDY2covr7Ede200nM23j9gpDVOvIHIopBqBOdsMn6kALo1/WBA J2YhVsXRo6od9lWzQgJRL1vPjsyduvrmhv6vyw4BJaN7YmtUxDhr2ntctRZFvit1GM5F oQHPxFWI3bq4nqCcDQU90l9zU/+wW4uBTACcEQFxBnYWMu3Yoi2wVJ545BojPIQ7CKGq z+r99+D5KKlUWOe32fXOCi8znhhdtW/J3MaYvE/ZQUKkk8xnMp2XVnx6Ft9QYyb1fcxx at3SPyuPQbAn1PUcmhC3Zr/5DwkPL9WsZH2AZwiLeMNFGOmKqWm2Ihv6Eu5ec5eGn7Ft fqfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to; bh=N+NWn9fbuuhCxaZzvltoPCUkBLCSr+E/k0aj80HaAOY=; b=WluZ+7QFhgCJEwaWMhvLjklmDwwm1w38yi3RGWkGFrWCME8x+xx9Vo8ZIYIhl9qNxE O8OOPzPKsbUrc6TCUATH9qqjeU2mqasYtVDDqOlZm6OXKWlts54MupTbu83y/Qgs1487 5c41BNnocN8maLqOGGVP0cq/JwTvLapKFXwNCs6+cbeWlKE72FzVtk+iDbWv3UdPF35K +i6sPMyLp6H7YqBjg4o+IEOaGfZnHhfY6KJCkP2e2djHrghOg78RjQhflVJW27C4yHAN f05sAmj2v3fXtuDx87DyVimnSui8TKPMQMqOx+QozkdQ3t4ZwUPdD6I/odd/O8SzA5O3 ydKg== X-Gm-Message-State: AKaTC00ice2DCT9LjOmGD0cogl3gfe0ysuteS3xdrNaq/i0hnx7ATsMkN4fNW8UTeo66lA== X-Received: by 10.194.115.226 with SMTP id jr2mr34972631wjb.75.1480634835002; Thu, 01 Dec 2016 15:27:15 -0800 (PST) Received: from [192.168.2.21] (p5B0950FE.dip0.t-ipconnect.de. [91.9.80.254]) by smtp.googlemail.com with ESMTPSA id r138sm225579wme.9.2016.12.01.15.27.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2016 15:27:14 -0800 (PST) From: Andreas Cadhalpun X-Google-Original-From: Andreas Cadhalpun To: ffmpeg-devel@ffmpeg.org References: <0509cabe-2a98-cec9-aa71-b4980d39e6b9@googlemail.com> <82837f8e-a5fc-0ed2-7048-42636d335429@googlemail.com> Message-ID: Date: Fri, 2 Dec 2016 00:27:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/3] configure: enable autodetected libraries after option parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 01.12.2016 11:01, Hendrik Leppkes wrote: > If those are enabled after option parsing, doesn't this then prevent > me from turning them off? Good catch, they should only be enabled, if they haven't been disabled. Updated patch is attached. Best regards, Andreas From 88b3c4ffc2b02ca7dad1febda7cd6e3e02b8cf5f Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Wed, 30 Nov 2016 23:49:35 +0100 Subject: [PATCH 2/3] configure: enable autodetected libraries after option parsing And only enable them, if they haven't been disabled. This is needed for the following patch. Signed-off-by: Andreas Cadhalpun --- configure | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 2ce7555..c0f31a7 100755 --- a/configure +++ b/configure @@ -3237,15 +3237,6 @@ enable valgrind_backtrace sws_max_filter_size_default=256 set_default sws_max_filter_size -# Enable platform codecs by default. -enable audiotoolbox - -# Enable hwaccels by default. -enable d3d11va dxva2 vaapi vda vdpau videotoolbox_hwaccel xvmc -enable xlib - -enable cuda cuvid nvenc vda_framework videotoolbox videotoolbox_encoder - # build settings SHFLAGS='-shared -Wl,-soname,$$(@F)' LIBPREF="lib" @@ -3491,6 +3482,13 @@ for e in $env; do eval "export $e" done +# Enable platform codecs by default. +# Enable hwaccels by default. +for lib in audiotoolbox d3d11va dxva2 vaapi vda vdpau videotoolbox_hwaccel xvmc xlib \ + cuda cuvid nvenc vda_framework videotoolbox videotoolbox_encoder; do + ! disabled $lib && enable $lib +done + disabled logging && logfile=/dev/null # Disable all the library-specific components if the library itself -- 2.10.2