Message ID | bb56bae4-9331-f0b9-d104-43f08510dfa3@adam.com.au |
---|---|
State | Superseded |
Headers | show |
On Tue, 31 Jan 2017, Lucas Sandery wrote: > On 2017-01-31 11:28, Marton Balint wrote: >> On Tue, 31 Jan 2017, Lucas Sandery wrote: >>> For a pure video tile effect, and enabling better integration of playback >>> windows into other programs. It would improve the looks in many situations >>> and avoid ugly hacks like this: >>> http://stackoverflow.com/q/31465630/315024 >>> >> >> Could you please add some documentation for the new option to >> doc/ffplay.texi as well? > > The main patch has already been committed to master from my attempt via > GitHub. > > I've attached another patch for documentation. > Do you want your authorship to be Lucas Sandery <lucas-sandery@users.noreply.github.com> as in the patch, or simply Lucas Sandery <lsandery@adam.com.au> ? Thanks, Marton
On 2017-02-01 08:47, Marton Balint wrote: > On Tue, 31 Jan 2017, Lucas Sandery wrote: >> On 2017-01-31 11:28, Marton Balint wrote: >>> On Tue, 31 Jan 2017, Lucas Sandery wrote: >>>> For a pure video tile effect, and enabling better integration of >>>> playback windows into other programs. It would improve the looks in >>>> many situations and avoid ugly hacks like this: >>>> http://stackoverflow.com/q/31465630/315024 >>>> >>> >>> Could you please add some documentation for the new option to >>> doc/ffplay.texi as well? >> >> The main patch has already been committed to master from my attempt >> via GitHub. >> >> I've attached another patch for documentation. >> > > Do you want your authorship to be > Lucas Sandery <lucas-sandery*users*noreply*github*com> > as in the patch, or simply > Lucas Sandery <lsandery*adam*com*au> > ? Use the GitHub one, I've already lost authorship of the main patch, anyway. Also, why put un-obfuscated email addresses in a public list?
On Wed, 1 Feb 2017, Lucas Sandery wrote: > On 2017-02-01 08:47, Marton Balint wrote: >> On Tue, 31 Jan 2017, Lucas Sandery wrote: >>> On 2017-01-31 11:28, Marton Balint wrote: >>>> On Tue, 31 Jan 2017, Lucas Sandery wrote: >>>>> For a pure video tile effect, and enabling better integration of >>>>> playback windows into other programs. It would improve the looks in >>>>> many situations and avoid ugly hacks like this: >>>>> http://stackoverflow.com/q/31465630/315024 >>>>> >>>> >>>> Could you please add some documentation for the new option to >>>> doc/ffplay.texi as well? >>> >>> The main patch has already been committed to master from my attempt >>> via GitHub. >>> >>> I've attached another patch for documentation. >>> >> >> Do you want your authorship to be >> Lucas Sandery <lucas-sandery*users*noreply*github*com> >> as in the patch, or simply >> Lucas Sandery <lsandery*adam*com*au> >> ? > > Use the GitHub one, I've already lost authorship of the main patch, anyway. No, your code is not yet committed to the ffmpeg master repository, I am not sure which github repo you are referring to. So you might still change your mind. Also I plan to squash your two patches into one. > Also, why put un-obfuscated email addresses in a public list? Sorry. On the other hand I question the usefulness of such obfuscations. Regards, Marton
From 24a487fba63313c59937ae8a8b91d0ed6a4f7244 Mon Sep 17 00:00:00 2001 From: Lucas Sandery <lucas-sandery@users.noreply.github.com> Date: Tue, 31 Jan 2017 10:01:40 +1030 Subject: [PATCH] Documentation for borderless playback windows Signed-off-by: Lucas Sandery <lucas-sandery@users.noreply.github.com> --- doc/ffplay.texi | 2 ++ ffplay.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 378a229d67..a76bed4663 100644 --- a/doc/ffplay.texi +++ b/doc/ffplay.texi @@ -62,6 +62,8 @@ see @ref{time duration syntax,,the Time duration section in the ffmpeg-utils(1) Seek by bytes. @item -nodisp Disable graphical display. +@item -noborder +Borderless window. @item -volume Set the startup volume. 0 means silence, 100 means no volume reduction or amplification. Negative values are treated as 0, values above 100 are treated diff --git a/ffplay.c b/ffplay.c index 6a426da33b..6325e6f999 100644 --- a/ffplay.c +++ b/ffplay.c @@ -3516,7 +3516,7 @@ static const OptionDef options[] = { { "t", HAS_ARG, { .func_arg = opt_duration }, "play \"duration\" seconds of audio/video", "duration" }, { "bytes", OPT_INT | HAS_ARG, { &seek_by_bytes }, "seek by bytes 0=off 1=on -1=auto", "val" }, { "nodisp", OPT_BOOL, { &display_disable }, "disable graphical display" }, - { "noborder", OPT_BOOL, { &borderless }, "borderless display" }, + { "noborder", OPT_BOOL, { &borderless }, "borderless window" }, { "volume", OPT_INT | HAS_ARG, { &startup_volume}, "set startup volume 0=min 100=max", "volume" }, { "f", HAS_ARG, { .func_arg = opt_format }, "force format", "fmt" }, { "pix_fmt", HAS_ARG | OPT_EXPERT | OPT_VIDEO, { .func_arg = opt_frame_pix_fmt }, "set pixel format", "format" }, -- 2.11.0.windows.3