From patchwork Sun Aug 26 06:23:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan X-Patchwork-Id: 10144 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp5132635jap; Sat, 25 Aug 2018 23:31:53 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY5o/owd4eUnYWJo3lbrQCBMr229ICG03cWcNWFIIh2o6mmEtNo0YP1Ag9pPfyTHDNX2fgm X-Received: by 2002:adf:90e9:: with SMTP id i96-v6mr5219301wri.146.1535265113303; Sat, 25 Aug 2018 23:31:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535265113; cv=none; d=google.com; s=arc-20160816; b=ZTjvTw3B4B4j9dDJ1cb0gna7Yuu0BGkN4/wMPwTGGfG2a9aMshZpjU5hci9TJ1DKEZ ndCx8XCCBaVQS5GEGeHIMI1nN0y36Pi/6INfPeiUudSfyosszh7ociXlQ97nON1Txfll IjvcLlKntxYNenwEVF30KIiwi+4G8BoxnprtbSe1DQjF+BCuGDjnFR9Oe79FhF+pUnXU HOp36xc4/UrpbjjfrSa9rgOEXWOP3IphHGEXR/wZBjZi7Lg7Gqm9ZC2864Aioi4YwxhE DDTtFjsQTm0YJgef9QKc7mXJYcmvIT0D0K/SIrZ04ppLIpy+gHDMqR2VlsADkUnfIjQv +z9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=QfcsODnu9P8pz5eoWmyRt8K+gplR9aUhIDw28lPnQtE=; b=zwrVeOfnH8kqo2Sq8i7TidUnASVIK85c5Pq4e3NHocIsZ0WZ31JTaf2P2wOgIbNP68 +iosNtudR17fiey+Zv0OXBtOXuN/9h6fbbI5r6V/hK5kgOqIk0lAnIOvoSfy7iUEZ+6o UGwzF3/HQJI55U84B9Xo0MGDiPWTvO/RWRY6kNn91ZBbf5PYZJbaqxfkvcBdsCgI1Uph o0o1YBgqaFgaD1z6fCJKIrzDXksjjLbLfYDyIXFVcX2uyV0m3HsJ4yzQV/Ta3bILoKBR K1Qegy9Zf8frCZxNXhcdMTLPifm517AuCQMnZQSg4dr8FijW2/WvoeqRd+E5+G2Ni85O SGIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=PbaUe6bV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g14-v6si7546630wrv.431.2018.08.25.23.31.52; Sat, 25 Aug 2018 23:31:53 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=PbaUe6bV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9900F689BF3; Sun, 26 Aug 2018 09:31:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08FDA688254 for ; Sun, 26 Aug 2018 09:31:41 +0300 (EEST) Received: by mail-pf1-f195.google.com with SMTP id h79-v6so5424651pfk.8 for ; Sat, 25 Aug 2018 23:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=CKuJ8UBRAkeNBQcJ2Rtnc9N5XK6BNr174qlniMTJJAM=; b=PbaUe6bVNxRSebGUeenrIjUZYHrnjSSRy0JmbjM23eo1T6SVyHkvdDP9kt0EGZ3xj1 HRspK/71SLsHvpVJLCMUkXTv7bst8lhoMevTYr+TZPHrrQLy9GLItGlyGvD5Ai1rWw4s zvWLwZYNGUu6wDxLTvmQqL6Pf96A6jXcrwv30XGTXYvTvJB+l3DBoj9Ue11rIhriQw+U 2gavy4J3BmF9bL1DMC2lKar7u4NqDlP8yMf8MJMNx7HfYwQ3f7Sz+fppWQ/WkD/SEvnP rTBfgcZeOGTIEtGc3BrNu2KMJjZXWpsP6LNyZu8m7oZEWFPnBgQsSvqo8CBtrvwgBKZA sJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=CKuJ8UBRAkeNBQcJ2Rtnc9N5XK6BNr174qlniMTJJAM=; b=NBo6qv+Xniki54Cd6FlkaDHtm/Dil7XYVxff2Sb+vFSFGxx5VtyiTZS3OAZ9oykIqT 01PtlJJFHFY5bXiM/3IPnrDaKNOHklEORLoSKBX+5I1QSdZaEywvDMBGEO2StxECXZ4c 6tvj3Pxa2j6rfkEOkUCXtrwuwE14mtggf64pPSYRzvq2PqBLNBVE/hAsh7gVeSx+hzEW UBHVWqdchOKM6RABZ+HaIfxEGPyMhlM6nCR61+95/K3L4QafYq82mayeSChAIyjQ25gP bYWeXQXWcw2eFnhUqI2vEUwUopkSSt9KSK6/cc8Y6ccFFbPjHM2YJ6EUanFkQevpdgyC mamw== X-Gm-Message-State: APzg51Aw8pBPQ9ZIMUODU4MEa9t2EKEXWn9/6sIWenBG/E2wUgZvsCHP cfNe+YlPKqAOcoVqtpgrVhXEv1rb X-Received: by 2002:a62:1605:: with SMTP id 5-v6mr8801180pfw.11.1535264601391; Sat, 25 Aug 2018 23:23:21 -0700 (PDT) Received: from [192.168.1.225] ([183.87.90.179]) by smtp.gmail.com with ESMTPSA id v22-v6sm17283041pfi.60.2018.08.25.23.23.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Aug 2018 23:23:20 -0700 (PDT) From: Gyan Doshi To: ffmpeg-devel@ffmpeg.org References: <63a22eb9-ce4a-c204-19fe-4704e03bbeb6@gmail.com> <29C6C12E-5A98-4A6A-A939-79676DEBACEE@gmail.com> <20180805084713.GA2662416@phare.normalesup.org> <24015cf1-ee4d-cade-35ea-0f2c70bfc4ba@gmail.com> <1210c1bb-1235-0a0b-0c88-c770bf4a56c1@gmail.com> <20180806143023.GA3510546@phare.normalesup.org> <971d4fe8-cb56-a68e-44d8-27968f22cb53@gmail.com> <20180807191747.GA8013@phare.normalesup.org> <11232d8c-f9d6-ad77-8ebf-f6ef0f2eeecb@gmail.com> Message-ID: Date: Sun, 26 Aug 2018 11:53:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <11232d8c-f9d6-ad77-8ebf-f6ef0f2eeecb@gmail.com> Content-Language: en-US Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: correct units for raw pts in -progress report X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 09-08-2018 10:09 AM, Gyan Doshi wrote: > > > On 08-08-2018 12:47 AM, Nicolas George wrote: >> Gyan Doshi (2018-08-08): >>> That will just defer the breaking change. >> >> That will leave people time to notice the change and allow old and new >> scripts to work during the transition. > > Will do it this way. Revised patch attached. Gyan From 397591ae236cd19f2c50772ea8f7288b80705c89 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 5 Aug 2018 12:34:21 +0530 Subject: [PATCH] ffmpeg: add correct field for raw pts in -progress report PTS is in microseconds, so correct field name is out_time_us. Old field out_time_ms kept for now - will be removed after a suitable transition period. Fixes #7345 --- fftools/ffmpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2459374f08..934dc71a74 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1794,9 +1794,11 @@ static void print_report(int is_last_report, int64_t timer_start, int64_t cur_ti if (total_size < 0) av_bprintf(&buf_script, "total_size=N/A\n"); else av_bprintf(&buf_script, "total_size=%"PRId64"\n", total_size); if (pts == AV_NOPTS_VALUE) { + av_bprintf(&buf_script, "out_time_us=N/A\n"); av_bprintf(&buf_script, "out_time_ms=N/A\n"); av_bprintf(&buf_script, "out_time=N/A\n"); } else { + av_bprintf(&buf_script, "out_time_us=%"PRId64"\n", pts); av_bprintf(&buf_script, "out_time_ms=%"PRId64"\n", pts); av_bprintf(&buf_script, "out_time=%s%02d:%02d:%02d.%06d\n", hours_sign, hours, mins, secs, us);