From patchwork Sat Dec 8 13:26:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan X-Patchwork-Id: 11337 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 7F8AD44DF69 for ; Sat, 8 Dec 2018 15:34:19 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB03668A97D; Sat, 8 Dec 2018 15:34:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5062C68A3A5 for ; Sat, 8 Dec 2018 15:34:03 +0200 (EET) Received: by mail-pg1-f171.google.com with SMTP id t13so2927587pgr.11 for ; Sat, 08 Dec 2018 05:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=jyKvPiT8Ekm2cYZqrc3TUv3ykQ2qCptq+8zmyZ+JFgQ=; b=tnZaMVh9Ke+4hGwBba5D5qKZNN48eHTlahoDLzP+/HCLmuCEZeXrDJt+gpGwwaCoaJ wxApwsU0ufbhpFVE+/aSD6z1dS+v2aZdW1V7XFdkdrPI0y21+8wYO8eVnt2GJSbungPB L0w9zf5McOD4a5uWTHqmqGh7A/b+CqE9F1p5X9AksUM3M9HLkzll2C+O9sB6jZaQPff4 C9ZxhCTWNA6HB+jiJ6z2oGtJ85gzpVJTl3+QOn01TAflITgDbLRjq9ekDlCS6taLj1cZ yuwwiQISE/YrH9lIVxGpTHBSYytoyZY8duONWfmONA8wsQq5Fj1RN/iR5aJIjSqjuFNP VEKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=jyKvPiT8Ekm2cYZqrc3TUv3ykQ2qCptq+8zmyZ+JFgQ=; b=TN6dTAve50gjHw3vWqbQh8lkDmtZHkZx059Qp3+jg2bTwJ76L9mBNnIdi1bxgpKLmi eGNLe3X+giI9bWIKOEB7LyqIxDQS9NePcuCfw2ZFjhEAKrtMs+2pmlphF7aVUkg0I3Bc fLiyF6gtLzMEpEVaOqKMY4LID8e8oVISU/ay9le1v4UyvEUNsGFW7Wy3eXvNrtUbJtoL QqADm06AdBU98IIaSt60UdRTtuNabW7lBF/Cg++FjBqyEaFsuc0LylFWTkYCca/im7XG c5fc9BgQ7VkQ0U/E6YLekFE89qb1jtM97PkF6spdRMLtDnOgnd4De64GxSdhW+YnCN8O jFIQ== X-Gm-Message-State: AA+aEWZM2w6wNLDvtFb1OKKfajzfs7utyaxWeEngnbrhGekvE+EvKb2C sJRYeZeLlJCCqplumxELR9XKIJJj X-Google-Smtp-Source: AFSGD/V+3EliM5+N3QmJkyO1drqulUx1I9SKlWc+iiY9wP0Mk3U95EzBM+lnXImYIszqd7v9VG2c9A== X-Received: by 2002:a63:b17:: with SMTP id 23mr5151061pgl.423.1544275574466; Sat, 08 Dec 2018 05:26:14 -0800 (PST) Received: from [192.168.1.224] ([27.106.98.134]) by smtp.gmail.com with ESMTPSA id 139sm17776174pfb.127.2018.12.08.05.26.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Dec 2018 05:26:13 -0800 (PST) To: FFmpeg development discussions and patches From: Gyan Doshi Message-ID: Date: Sat, 8 Dec 2018 18:56:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] ffmpeg-opt: mark stream disable options as output-only X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" I see users with these options set in front of input. Stream disabling for input requires -discard though one packet tends to get smuggled across. But that's for another patch. Gyan From f0e78555d6ea5510922e2d543c9b69dff7d480b5 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 8 Dec 2018 18:49:34 +0530 Subject: [PATCH] ffmpeg-opt: mark stream disable options as output-only -vn/an/sn/dn are only checked by open_output_file() --- fftools/ffmpeg_opt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index d4851a2cd8..d3b11cfb44 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -3522,7 +3522,7 @@ const OptionDef options[] = { "set the number of bits per raw sample", "number" }, { "intra", OPT_VIDEO | OPT_BOOL | OPT_EXPERT, { &intra_only }, "deprecated use -g 1" }, - { "vn", OPT_VIDEO | OPT_BOOL | OPT_OFFSET | OPT_INPUT | OPT_OUTPUT,{ .off = OFFSET(video_disable) }, + { "vn", OPT_VIDEO | OPT_BOOL | OPT_OFFSET | OPT_OUTPUT, { .off = OFFSET(video_disable) }, "disable video" }, { "rc_override", OPT_VIDEO | HAS_ARG | OPT_EXPERT | OPT_STRING | OPT_SPEC | OPT_OUTPUT, { .off = OFFSET(rc_overrides) }, @@ -3612,7 +3612,7 @@ const OptionDef options[] = { { "ac", OPT_AUDIO | HAS_ARG | OPT_INT | OPT_SPEC | OPT_INPUT | OPT_OUTPUT, { .off = OFFSET(audio_channels) }, "set number of audio channels", "channels" }, - { "an", OPT_AUDIO | OPT_BOOL | OPT_OFFSET | OPT_INPUT | OPT_OUTPUT,{ .off = OFFSET(audio_disable) }, + { "an", OPT_AUDIO | OPT_BOOL | OPT_OFFSET | OPT_OUTPUT, { .off = OFFSET(audio_disable) }, "disable audio" }, { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_audio_codec }, @@ -3634,7 +3634,7 @@ const OptionDef options[] = { "set the maximum number of channels to try to guess the channel layout" }, /* subtitle options */ - { "sn", OPT_SUBTITLE | OPT_BOOL | OPT_OFFSET | OPT_INPUT | OPT_OUTPUT, { .off = OFFSET(subtitle_disable) }, + { "sn", OPT_SUBTITLE | OPT_BOOL | OPT_OFFSET | OPT_OUTPUT, { .off = OFFSET(subtitle_disable) }, "disable subtitle" }, { "scodec", OPT_SUBTITLE | HAS_ARG | OPT_PERFILE | OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_subtitle_codec }, "force subtitle codec ('copy' to copy stream)", "codec" }, @@ -3690,7 +3690,7 @@ const OptionDef options[] = { /* data codec support */ { "dcodec", HAS_ARG | OPT_DATA | OPT_PERFILE | OPT_EXPERT | OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_data_codec }, "force data codec ('copy' to copy stream)", "codec" }, - { "dn", OPT_BOOL | OPT_VIDEO | OPT_OFFSET | OPT_INPUT | OPT_OUTPUT, { .off = OFFSET(data_disable) }, + { "dn", OPT_BOOL | OPT_VIDEO | OPT_OFFSET | OPT_OUTPUT, { .off = OFFSET(data_disable) }, "disable data" }, #if CONFIG_VAAPI