From patchwork Mon May 16 21:23:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 35799 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:a885:b0:7f:4be2:bd17 with SMTP id ca5csp1732840pzb; Mon, 16 May 2022 14:23:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxnCYX6ln2fXZMrJey/jR3Fezja2u4Kqokl6GDjUDA3RaVtTWcotJRyjsp7HyNwsSQzfcz X-Received: by 2002:a17:906:80d4:b0:6f3:bead:750c with SMTP id a20-20020a17090680d400b006f3bead750cmr17090348ejx.129.1652736224980; Mon, 16 May 2022 14:23:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652736224; cv=none; d=google.com; s=arc-20160816; b=vgfhk3KJL8LhO35cEtS78Tv5tgF3gQSFNKwavx5IkaOhfMN4q4zIkAfhJNQvQ+pW5/ k2BgLutfl8yWMzdg+UXXW2vzeZCbkwe7MZfstLWO6kuAN89ArVG7++k+rgx4OEJYfDiw mQpqah5dLL0464WAxuAAJI7E0IHX+NsdDLXGXMZkYvChside4c3E2O3tk6gmKjvFL8E+ Ffytr45hv8R4Jmle1USr/+0SlpnhBUmKRxN2E4asGEgkm0NmY0mg9ShfP7oaYkQtYqaK x4EfQA82T6psqVHh5T9RDdeDd0E8hKoGfM1Jgkq1rUdsDEjsDh/o1JmW8IVtVdbw97nn p0jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:mime-version:fcc:date:references :in-reply-to:message-id:from:dkim-signature:delivered-to; bh=fcTPqPQ8eAfrsE4k1++sEfhOghhCObP8iTjmiiXcScY=; b=OqKx6ZZB7bqNGKLRGD14BDQJivlg037wcKArn3zwYT5hn5SBYkpdR6reS0YKTrfOaO 8jY4WnvhQfrR+MLzhfUSsJGJ1r+eODuR1Wq5iw/pQFhAZ88Y5V/od7v9F4DcRdLl6MCN NAV2yslwjYi3egCnWBCzVuIIHDVsZo8jU8qBbDgfYEIiWXgYzY0yuSuHMR4ivkyKL3Q/ devrracpSoBgZcoSoEfzdt+E5gUOcs9jYcX5XSIAA1ayR06/uH1yEyF5x+rfLEty2nVI WMXKlGtfNe0EIqpdmTCfspo6+8h2rJRe8PNckzvoDfs7iQYA/N+UDZ5Og4Yo4O/r+Kr9 uy/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=g6i5+mHR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sd38-20020a1709076e2600b006e878a53334si533246ejc.363.2022.05.16.14.23.44; Mon, 16 May 2022 14:23:44 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=g6i5+mHR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CA1A68B445; Tue, 17 May 2022 00:23:34 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D11D68B18C for ; Tue, 17 May 2022 00:23:27 +0300 (EEST) Received: by mail-pj1-f41.google.com with SMTP id l20-20020a17090a409400b001dd2a9d555bso568562pjg.0 for ; Mon, 16 May 2022 14:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:in-reply-to:references:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=Y6vVbGWlzpT6MRuQ5PK9XPQyB0pfSbPHbNPuGRT+7ic=; b=g6i5+mHRRcb8bkmWQcPxoalbi6uNe3jx/qFkkYY4pmOzK3+sswbvlpomklY+DezAMF isHWyK4tmfC87dW7ml3VQvK71RMWpIaDzaa50l/8Z3Pt1gvalZ/O166BYSRFkJFB/TNG jgRW7bFDxPQ5KSvZuRUYrHHjxwBeU2mxoPZuO0mjtJnq6/i/r/oqjBnhVxu+UZ9NWw/6 WQM80fZgXAeKNzRV56r5515lCYK8GaDi1eYzhW4RpRZXxDV2G6TnAZuhQhnPsW98dpzG O2WYOvl/8vw42VPdSpTCbtFCki0Uz1bdQYFu+njKpFfHRl7j3Z1O13A2o5QE+P9Rqap8 1HyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:in-reply-to:references:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=Y6vVbGWlzpT6MRuQ5PK9XPQyB0pfSbPHbNPuGRT+7ic=; b=QZGlYcTNidObXDxnCmcGL8aS9kak4PFJC8FQJBTcTj93Sk3eFrV8JO5ydei7d+TSlR A09O8v1ru/FNOt9X08+hzrBXryU92z2N/6t/giHiLRudPKirtYsNgXuS0FMwMkJnHH7a KPGkKcrGvO90iUDUKGRnlyldSpD4lSvNVa9xeqGtjMIr3U6ZnQitUqMtQbmv8h+vIlWt Z8bJQGsrAOZt9i9pLPMwaWCS6W+4AwRvXymYLstErMjbyt8TY/FLDPDk0xfFp8p6L9n3 sKIGGWpNELeEoEMHgv3cHdOJfb8eEg1wia25Jfgg5Z3nT62Anq3hVtwog87X8R0xwrdr VLbQ== X-Gm-Message-State: AOAM533gfu+OYy+O0LgmbqQSVngWbcok8H0YosbsnIMnBrYbTOhwb3jW PDZSmoFG2rByf9GsEyPUuQoDyznqI5VoPw== X-Received: by 2002:a17:902:ecc8:b0:15e:9e46:cb7e with SMTP id a8-20020a170902ecc800b0015e9e46cb7emr19277657plh.111.1652736205889; Mon, 16 May 2022 14:23:25 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id r8-20020a170902ea4800b001618f5186f1sm1844870plg.80.2022.05.16.14.23.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 May 2022 14:23:25 -0700 (PDT) From: softworkz X-Google-Original-From: softworkz Message-Id: In-Reply-To: References: Date: Mon, 16 May 2022 21:23:22 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v3 1/2] avutil/wchar_filename, file_open: Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: CXrqd7piM4dy From: softworkz Signed-off-by: softworkz --- libavutil/file_open.c | 2 +- libavutil/wchar_filename.h | 166 +++++++++++++++++++++++++++++++++++++ 2 files changed, 167 insertions(+), 1 deletion(-) diff --git a/libavutil/file_open.c b/libavutil/file_open.c index cc302f2f76..57c5e78d51 100644 --- a/libavutil/file_open.c +++ b/libavutil/file_open.c @@ -45,7 +45,7 @@ static int win32_open(const char *filename_utf8, int oflag, int pmode) wchar_t *filename_w; /* convert UTF-8 to wide chars */ - if (utf8towchar(filename_utf8, &filename_w)) + if (get_extended_win32_path(filename_utf8, &filename_w)) return -1; if (!filename_w) goto fallback; diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 90f082452c..94f8ce54b5 100644 --- a/libavutil/wchar_filename.h +++ b/libavutil/wchar_filename.h @@ -40,6 +40,172 @@ static inline int utf8towchar(const char *filename_utf8, wchar_t **filename_w) MultiByteToWideChar(CP_UTF8, 0, filename_utf8, -1, *filename_w, num_chars); return 0; } + +/** + * Checks for extended path prefixes for which normalization needs to be skipped. + * see .NET6: PathInternal.IsExtended() + */ +static inline int path_is_extended(const wchar_t *path) +{ + if (path[0] == L'\\' && (path[1] == L'\\' || path[1] == L'?') && path[2] == L'?' && path[3] == L'\\') + return 1; + + return 0; +} + +/** + * Checks for a device path prefix. + * see .NET6: PathInternal.IsDevicePath() + */ +static inline int path_is_device_path(const wchar_t *path) +{ + if (path[0] == L'\\' && path[1] == L'\\' && path[2] == L'.' && path[3] == L'\\') + return 1; + + return 0; +} + +/** + * Performs path normalization by calling GetFullPathNameW(). + * see .NET6: PathHelper.GetFullPathName() + */ +static inline int get_full_path_name(wchar_t **ppath_w) +{ + int num_chars; + wchar_t *temp_w; + + num_chars = GetFullPathNameW(*ppath_w, 0, NULL, NULL); + if (num_chars <= 0) { + errno = EINVAL; + return -1; + } + + temp_w = (wchar_t *)av_calloc(num_chars, sizeof(wchar_t)); + if (!temp_w) { + errno = ENOMEM; + return -1; + } + + num_chars = GetFullPathNameW(*ppath_w, num_chars, temp_w, NULL); + if (num_chars <= 0) { + errno = EINVAL; + return -1; + } + + av_freep(ppath_w); + *ppath_w = temp_w; + + return 0; +} + +/** + * Normalizes a Windows file or folder path. + * Expansion of short paths (with 8.3 path components) is currently omitted + * as it is not required for accessing long paths. + * see .NET6: PathHelper.Normalize(). + */ +static inline int path_normalize(wchar_t **ppath_w) +{ + int ret; + + if ((ret = get_full_path_name(ppath_w)) < 0) + return ret; + + /* What .NET does at this point is to call PathHelper.TryExpandShortFileName() + * in case the path contains a '~' character. + * We don't need to do this as we don't need to normalize the file name + * for presentation, and the extended path prefix works with 8.3 path + * components as well + */ + return 0; +} + +/** + * Adds an extended path or UNC prefix to longs paths or paths ending + * with a space or a dot. (' ' or '.'). + * This function expects that the path has been normalized before by + * calling path_normalize() and it doesn't check whether the path is + * actually long (> MAX_PATH). + * see .NET6: PathInternal.EnsureExtendedPrefix() * + */ +static inline int add_extended_prefix(wchar_t **ppath_w) +{ + const wchar_t *unc_prefix = L"\\\\?\\UNC\\"; + const wchar_t *extended_path_prefix = L"\\\\?\\"; + const wchar_t *path_w = *ppath_w; + const size_t len = wcslen(path_w); + wchar_t *temp_w; + + /* We're skipping the check IsPartiallyQualified() because + * we expect to have called GetFullPathNameW() already. */ + if (len < 2 || path_is_extended(*ppath_w) || path_is_device_path(*ppath_w)) { + return 0; + } + + if (path_w[0] == L'\\' && path_w[1] == L'\\') { + /* unc_prefix length is 8 plus 1 for terminating zeros, + * we subtract 2 for the leading '\\' of the original path */ + temp_w = (wchar_t *)av_calloc(len - 2 + 8 + 1, sizeof(wchar_t)); + if (!temp_w) { + errno = ENOMEM; + return -1; + } + wcscpy(temp_w, unc_prefix); + wcscat(temp_w, path_w + 2); + } else { + // The length of extended_path_prefix is 4 plus 1 for terminating zeros + temp_w = (wchar_t *)av_calloc(len + 4 + 1, sizeof(wchar_t)); + if (!temp_w) { + errno = ENOMEM; + return -1; + } + wcscpy(temp_w, extended_path_prefix); + wcscat(temp_w, path_w); + } + + av_freep(ppath_w); + *ppath_w = temp_w; + + return 0; +} + +/** + * Converts a file or folder path to wchar_t for use with Windows file + * APIs. Paths with extended path prefix (either '\\?\' or \??\') are + * left unchanged. + * All other paths are normalized and converted to absolute paths. + * Longs paths (>= MAX_PATH) are prefixed with the extended path or extended + * UNC path prefix. + * see .NET6: Path.GetFullPath() and Path.GetFullPathInternal() + */ +static inline int get_extended_win32_path(const char *path, wchar_t **ppath_w) +{ + int ret; + size_t len; + + if ((ret = utf8towchar(path, ppath_w)) < 0) + return ret; + + if (path_is_extended(*ppath_w)) { + /* Paths prefixed with '\\?\' or \??\' are considered normalized by definition. + * Windows doesn't normalize those paths and neither should we. + */ + return 0; + } + + if ((ret = path_normalize(ppath_w)) < 0) + return ret; + + // see .NET6: PathInternal.EnsureExtendedPrefixIfNeeded() + len = wcslen(*ppath_w); + if (len >= MAX_PATH) { + if ((ret = add_extended_prefix(ppath_w)) < 0) + return ret; + } + + return 0; +} + #endif #endif /* AVUTIL_WCHAR_FILENAME_H */