From patchwork Fri Sep 22 06:20:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Hartwig X-Patchwork-Id: 5233 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.36.26 with SMTP id f26csp2821735jaa; Thu, 21 Sep 2017 23:20:35 -0700 (PDT) X-Received: by 10.28.161.2 with SMTP id k2mr2642424wme.118.1506061235864; Thu, 21 Sep 2017 23:20:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506061235; cv=none; d=google.com; s=arc-20160816; b=lGXTrDny9ajm8pb5zX+OleG17qJbBzzEUUME24dp8Jbg2aKhUgZwcAjYlLWRCS3NXR UTomcSXaheQ/fmWKTBvQ1UyTLpPeWrr7ELPeH8MlmLB+rDur260fe2eIC5IioOJa4Rnf xsfjBSxxlsSVigwcNkkpLuz1XGCXIbuM4qTVmvlr4fp0q0avLLc446PWVlQap+f3mc3g 2jnEbgvaykmLzoto/sjbAFMGVckiG1iEHpL9F/TGttDrbuBZ1X037reICkwMigAhmKwy 08LwvW5vhabTb6AqSVuAAscWNooY1e6sQyDbndczIlIthONcWGKLMmbD2I6NbqyIIpJz tkTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:dkim-signature:delivered-to :arc-authentication-results; bh=yXJwejPEvMYPq2Tvie5UvQCG+xBhHEgDCOBDD5rVlY4=; b=SqRPT3pbmXuP7duNrkD/UHiaEJ2cS3ZzrfQFlkJ1KH5flVFlajmhbPh6hlAu342uRz XXpLOqWUiJ8Q9T82FstVfxbMscmxMNDOstmWj1/bn1iIBy7pAnj27hUJDNMBWKFf9B2C kP5bwuqqp0geKPbxE3U1iwjKedUd4g18+ptTdfsG3Uq4NaNBjanasngFWzV0a8e9515h SLH0/6LDRqh6InLrRxi48XFH81ftt9N75F+IBBGWtDAbvs+3IbLfa4rMRaO613vlJMRl CIBhg3AOYJMYz9Lj2sCMV4holz+GgSLd0QBeqQvfvh3Yvg5PnNM21Z7bejjBLzPj78xw Xn3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=sQB5/aJC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i202si2562782wmf.169.2017.09.21.23.20.34; Thu, 21 Sep 2017 23:20:35 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=sQB5/aJC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EAEA2687EB0; Fri, 22 Sep 2017 09:20:23 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F26BE680D34 for ; Fri, 22 Sep 2017 09:20:17 +0300 (EEST) Received: by mail-wm0-f42.google.com with SMTP id q124so892403wmb.0 for ; Thu, 21 Sep 2017 23:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=OLykABTpfF8th0szHfTmMuiBc+hyLBNgB0TasfTuWGE=; b=sQB5/aJCo/ec728KUzgSCxObBGGbg0F/tn6uHNeAuRByEmAomYDFOpksanCKgfq+f/ 4g+xcHXs/dKHsUYEjjNgC+UMWdbLFySVqZn5TuH6fSS0zQybfJPG2qWQ9UPZx0mM7Gjm /N/1FBVcogHisW6iDwjFR4InFlfAbCsehw9xQQRvL/+yBKlID7pngdAfXJkqbRL7y3y4 jkOaVG+OcEgY6nXqVP6EfTWKrvdxqnZ6vK3M2dJDNZ3hpCvBPn5A53IzV2jQ0XmvBrgV jIDYwumpcUW1jxJpfMLyQPguPdiJtCFSiHoWS6sPWTwXulbkjneWSxJidf3iHj4MphZG +FdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=OLykABTpfF8th0szHfTmMuiBc+hyLBNgB0TasfTuWGE=; b=fG2tVe47ms3O+2BCBzYGCUQlMNsLQQSCL12pGNZYxZ7LSeB8Q68RFxKNmxdP8p0/BF 4ert/SBsz+KjG9Nqk3KYQUQVzvm+qYOs+401kbBQybOe6rj8dWPFoFSS9uYTfjzqa60L HCva+3uiCVEczqyne4JybnOnbIVxEpIoRuaQvaKqBjbnoy7cB0PiaI7K6vYG5xUqwt53 +5rupxZIMxTYMuoWCtKPBEAxYpVVO4D3eIWnhzNRqggXtkWVHub+pzsQp5AZ/CHwDWOv 5VFok1oCH2XHoabFTbpFsLQlC34XqjopT1jwvUs6t4lwrBbIKAd0n0G+Z+cs94nfes3S tCbw== X-Gm-Message-State: AHPjjUhusFA6ER6wAkISO2MT1JkGy34bsku6t/w7jA6ot7DkPwIowUWm r6rGvrHDcaACrOrVOhvXgyRkdjAS X-Google-Smtp-Source: AOwi7QAXr/DAHaGSOgIQXDlVAdcQFKyFUy8sUOrlAsIeOARPJU6aTYZJUS8k/+O8RKJy16+fpE1PxQ== X-Received: by 10.28.184.141 with SMTP id i135mr3036087wmf.143.1506061227258; Thu, 21 Sep 2017 23:20:27 -0700 (PDT) Received: from [192.168.188.80] (p4FEEAEC6.dip0.t-ipconnect.de. [79.238.174.198]) by smtp.gmail.com with ESMTPSA id d9sm4769208wrd.37.2017.09.21.23.20.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 23:20:26 -0700 (PDT) To: FFmpeg development discussions and patches References: <51c6bf9c-1ce2-b682-dc9e-08fbf8c3a6fc@gmail.com> <20170922050623.5ca2fc17@debian> From: Thomas Hartwig Message-ID: Date: Fri, 22 Sep 2017 08:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170922050623.5ca2fc17@debian> Content-Language: en-CA Subject: Re: [FFmpeg-devel] [PATCH] change of deprecated log to debug level X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Attached is the clean patchfile. I want to give some small background: the problem happens in javacpp. It looks like there is a problem handling pixelformats not correct at all when used for pixel grabbing. This is why I mentioned it in a streaming context. However this patch is a small workaround to this and really minimal. We will look more deeply into the wrapper to get rid of it but in the meantime.... Thanks Thomas On 22.09.2017 05:06, wm4 wrote: > On Thu, 21 Sep 2017 22:55:14 +0200 > Thomas Hartwig wrote: > >> The problem is this warning is flooding the console with deprecated >> warnings for every decoded frame. However decoding works well. This is >> an issue with an Axis camera H264 stream received via rtsp for instance. >> There are several complaints about it in the WEB for years now and I >> could not find a real solution for the underlying problem. It looks like >> vendors are not changing their encoding easily. ;-) >> >> >> --- >> libswscale/utils.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libswscale/utils.c b/libswscale/utils.c >> index dcab70..af4aa1 100644 >> --- a/libswscale/utils.c >> +++ b/libswscale/utils.c >> @@ -1182,7 +1182,7 @@ av_cold int sws_init_context(SwsContext *c, >> SwsFilter *srcFilter, >> c->dstRange |= handle_jpeg(&c->dstFormat); >> >> if(srcFormat!=c->srcFormat || dstFormat!=c->dstFormat) >> - av_log(c, AV_LOG_WARNING, "deprecated pixel format used, make >> sure you did set range correctly\n"); >> + av_log(c, AV_LOG_DEBUG, "deprecated pixel format used, make >> sure you did set range correctly\n"); >> >> if (!c->contrast && !c->saturation && !c->dstFormatBpp) >> sws_setColorspaceDetails(c, >> ff_yuv2rgb_coeffs[SWS_CS_DEFAULT], c->srcRange, >> -- >> 2.7.4 >> _______________________________________________ > > I'd rather have if we finally stopped using these pixfmts. They cause > nothing but problems to me. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > --- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index dcab70..af4aa1 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1182,7 +1182,7 @@ av_cold int sws_init_context(SwsContext *c, SwsFilter *srcFilter, c->dstRange |= handle_jpeg(&c->dstFormat); if(srcFormat!=c->srcFormat || dstFormat!=c->dstFormat) - av_log(c, AV_LOG_WARNING, "deprecated pixel format used, make sure you did set range correctly\n"); + av_log(c, AV_LOG_DEBUG, "deprecated pixel format used, make sure you did set range correctly\n"); if (!c->contrast && !c->saturation && !c->dstFormatBpp) sws_setColorspaceDetails(c, ff_yuv2rgb_coeffs[SWS_CS_DEFAULT], c->srcRange, -- 2.7.4