From patchwork Wed Feb 1 02:49:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Sandery X-Patchwork-Id: 2387 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp2240127vsb; Tue, 31 Jan 2017 18:53:17 -0800 (PST) X-Received: by 10.223.164.151 with SMTP id g23mr399227wrb.86.1485917597313; Tue, 31 Jan 2017 18:53:17 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z31si23085549wrz.203.2017.01.31.18.53.16; Tue, 31 Jan 2017 18:53:17 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C8C0680CAF; Wed, 1 Feb 2017 04:53:11 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from icp-osb-irony-out4.external.iinet.net.au (icp-osb-irony-out4.external.iinet.net.au [203.59.1.220]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A1D29680A0A for ; Wed, 1 Feb 2017 04:53:03 +0200 (EET) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2D8AQCvTJFY/2tRYIENUBoBAQEBAgEBAQEIAQEBAYQ0Kl+DV5txH5Mkgg+CDSqFeAKCeRYBAgEBAQEBAQGFcwEBAQEDI2YLDQQDAQIBKgICAk0IBg0GAgEBiXirQGiCJSaLDQEBAQEBAQQBAQEBAQETD4ZLggUIgmKEYwmCZoJfBZtXXIMTgniLF4JMiAOGKYsAh38mAoFKEwgRGYR0H4F0YgGIKQEBAQ X-IPAS-Result: A2D8AQCvTJFY/2tRYIENUBoBAQEBAgEBAQEIAQEBAYQ0Kl+DV5txH5Mkgg+CDSqFeAKCeRYBAgEBAQEBAQGFcwEBAQEDI2YLDQQDAQIBKgICAk0IBg0GAgEBiXirQGiCJSaLDQEBAQEBAQQBAQEBAQETD4ZLggUIgmKEYwmCZoJfBZtXXIMTgniLF4JMiAOGKYsAh38mAoFKEwgRGYR0H4F0YgGIKQEBAQ X-IronPort-AV: E=Sophos;i="5.33,317,1477929600"; d="scan'208,223";a="235997715" Received: from unknown (HELO [10.27.36.55]) ([129.96.81.107]) by icp-osb-irony-out4.iinet.net.au with ESMTP; 01 Feb 2017 10:53:03 +0800 To: FFmpeg development discussions and patches References: <137ead00-c5a5-2471-4ec8-42e5682e3f5b@adam.com.au> <394a59be-452d-c1fb-5280-481afb073bd8@adam.com.au> From: Lucas Sandery Message-ID: Date: Wed, 1 Feb 2017 13:19:31 +1030 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] Allow borderless playback windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 2017-02-01 12:34, Marton Balint wrote: > No, your code is not yet committed to the ffmpeg master repository, I > am not sure which github repo you are referring to. So you might still > change your mind. Also I plan to squash your two patches into one. I managed to stuff up (and misuse) my local repo. Attached an updated patch. Sorry for the noise, everyone. From a4b32dbb6715d42eff4b57cf2cbe8f2db2294baa Mon Sep 17 00:00:00 2001 From: Lucas Sandery Date: Wed, 1 Feb 2017 13:11:29 +1030 Subject: [PATCH] Allow borderless playback windows For a pure video tile effect, and enabling better integration of playback windows into other programs. It would improve the looks in many situations and avoid ugly hacks like this: http://stackoverflow.com/q/31465630/315024 Signed-off-by: Lucas Sandery --- doc/ffplay.texi | 2 ++ ffplay.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 378a229d67..a76bed4663 100644 --- a/doc/ffplay.texi +++ b/doc/ffplay.texi @@ -62,6 +62,8 @@ see @ref{time duration syntax,,the Time duration section in the ffmpeg-utils(1) Seek by bytes. @item -nodisp Disable graphical display. +@item -noborder +Borderless window. @item -volume Set the startup volume. 0 means silence, 100 means no volume reduction or amplification. Negative values are treated as 0, values above 100 are treated diff --git a/ffplay.c b/ffplay.c index 7ea172f8da..6325e6f999 100644 --- a/ffplay.c +++ b/ffplay.c @@ -321,6 +321,7 @@ static int subtitle_disable; static const char* wanted_stream_spec[AVMEDIA_TYPE_NB] = {0}; static int seek_by_bytes = -1; static int display_disable; +static int borderless; static int startup_volume = 100; static int show_status = 1; static int av_sync_type = AV_SYNC_AUDIO_MASTER; @@ -1265,6 +1266,8 @@ static int video_open(VideoState *is) window_title = input_filename; if (is_full_screen) flags |= SDL_WINDOW_FULLSCREEN_DESKTOP; + if (borderless) + flags |= SDL_WINDOW_BORDERLESS; window = SDL_CreateWindow(window_title, SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, w, h, flags); SDL_SetHint(SDL_HINT_RENDER_SCALE_QUALITY, "linear"); if (window) { @@ -3513,6 +3516,7 @@ static const OptionDef options[] = { { "t", HAS_ARG, { .func_arg = opt_duration }, "play \"duration\" seconds of audio/video", "duration" }, { "bytes", OPT_INT | HAS_ARG, { &seek_by_bytes }, "seek by bytes 0=off 1=on -1=auto", "val" }, { "nodisp", OPT_BOOL, { &display_disable }, "disable graphical display" }, + { "noborder", OPT_BOOL, { &borderless }, "borderless window" }, { "volume", OPT_INT | HAS_ARG, { &startup_volume}, "set startup volume 0=min 100=max", "volume" }, { "f", HAS_ARG, { .func_arg = opt_format }, "force format", "fmt" }, { "pix_fmt", HAS_ARG | OPT_EXPERT | OPT_VIDEO, { .func_arg = opt_frame_pix_fmt }, "set pixel format", "format" }, -- 2.11.0.windows.3