| Message ID | pull.20.v2.ffstaging.FFmpeg.1642729284250.ffmpegagent@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v2] libavutil/tests/md5: Avoid warnings | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| andriy/make_ppc | success | Make finished |
| andriy/make_fate_ppc | fail | Make fate failed |
| andriy/make_armv7_RPi4 | success | Make finished |
| andriy/make_fate_armv7_RPi4 | success | Make fate finished |
| andriy/make_aarch64_jetson | success | Make finished |
| andriy/make_fate_aarch64_jetson | success | Make fate finished |
On 1/20/2022 10:41 PM, softworkz wrote: > From: softworkz <softworkz@hotmail.com> > > Those are always showing up on Patchwork > when FATE tests are failing, covering > some possibly more useful information. > > Signed-off-by: softworkz <softworkz@hotmail.com> > --- > libavutil/tests/md5: Avoid warnings > > Those are always showing up on Patchwork when FATE tests are failing, > covering some possibly more useful information. > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v2 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20 > > Range-diff vs v1: > > 1: 3910d81fa1 ! 1: 4723054463 libavutil/tests/md5: Avoid warnings > @@ libavutil/tests/md5.c: int main(void) > { > uint8_t md5val[16]; > int i; > -+ > -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 > - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > +- volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > - // FIXME remove volatile once it has been fixed and all fate clients are updated > -+#else > -+ uint8_t in[1000]; > ++ > ++#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 > ++ volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > +#endif > ++ uint8_t in[1000]; > > for (i = 0; i < 1000; i++) > in[i] = i * i; > > > libavutil/tests/md5.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c > index 42e4538e0a..cca63d6507 100644 > --- a/libavutil/tests/md5.c > +++ b/libavutil/tests/md5.c > @@ -33,8 +33,11 @@ int main(void) > { > uint8_t md5val[16]; > int i; > - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > - // FIXME remove volatile once it has been fixed and all fate clients are updated > + > +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 1? > + volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > +#endif > + uint8_t in[1000]; > > for (i = 0; i < 1000; i++) > in[i] = i * i; > > base-commit: 7512293cf912c65fa657eab680afd5e18fd47603
> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James Almer > Sent: Friday, January 21, 2022 2:45 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] libavutil/tests/md5: Avoid warnings > > > > On 1/20/2022 10:41 PM, softworkz wrote: > > From: softworkz <softworkz@hotmail.com> > > > > Those are always showing up on Patchwork > > when FATE tests are failing, covering > > some possibly more useful information. > > > > Signed-off-by: softworkz <softworkz@hotmail.com> > > --- > > libavutil/tests/md5: Avoid warnings > > > > Those are always showing up on Patchwork when FATE tests are failing, > > covering some possibly more useful information. > > > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr- > ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v2 > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging- > 20/softworkz/submit_md5-v2 > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20 > > > > Range-diff vs v1: > > > > 1: 3910d81fa1 ! 1: 4723054463 libavutil/tests/md5: Avoid warnings > > @@ libavutil/tests/md5.c: int main(void) > > { > > uint8_t md5val[16]; > > int i; > > -+ > > -+#if defined(__clang__) && defined(__clang_major__) && > __clang_major__ < 4 > > - volatile uint8_t in[1000]; // volatile to workaround > http://llvm.org/bugs/show_bug.cgi?id=20849 > > +- volatile uint8_t in[1000]; // volatile to workaround > http://llvm.org/bugs/show_bug.cgi?id=20849 > > - // FIXME remove volatile once it has been fixed and all fate > clients are updated > > -+#else > > -+ uint8_t in[1000]; > > ++ > > ++#if 1 || defined(__clang__) && defined(__clang_major__) && > __clang_major__ < 4 > > ++ volatile // volatile to workaround > http://llvm.org/bugs/show_bug.cgi?id=20849 > > +#endif > > ++ uint8_t in[1000]; > > > > for (i = 0; i < 1000; i++) > > in[i] = i * i; > > > > > > libavutil/tests/md5.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c > > index 42e4538e0a..cca63d6507 100644 > > --- a/libavutil/tests/md5.c > > +++ b/libavutil/tests/md5.c > > @@ -33,8 +33,11 @@ int main(void) > > { > > uint8_t md5val[16]; > > int i; > > - volatile uint8_t in[1000]; // volatile to workaround > http://llvm.org/bugs/show_bug.cgi?id=20849 > > - // FIXME remove volatile once it has been fixed and all fate clients > are updated > > + > > +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ > < 4 > > 1? I'm an idiot... Thanks
diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c index 42e4538e0a..cca63d6507 100644 --- a/libavutil/tests/md5.c +++ b/libavutil/tests/md5.c @@ -33,8 +33,11 @@ int main(void) { uint8_t md5val[16]; int i; - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 - // FIXME remove volatile once it has been fixed and all fate clients are updated + +#if 1 || defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 + volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 +#endif + uint8_t in[1000]; for (i = 0; i < 1000; i++) in[i] = i * i;