diff mbox series

[FFmpeg-devel,v2] fftools/opt_common: add missing include of avf/version.h

Message ID pull.27.v2.ffstaging.FFmpeg.1652527083214.ffmpegagent@gmail.com
State New
Headers show
Series [FFmpeg-devel,v2] fftools/opt_common: add missing include of avf/version.h | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_armv7_RPi4 success Make finished
andriy/make_fate_armv7_RPi4 success Make fate finished

Commit Message

Matt Oliver May 14, 2022, 11:18 a.m. UTC
From: softworkz <softworkz@hotmail.com>

required for PRINT_LIB_INFO(avfilter...

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    fftools/opt_common: add missing include of avf/version.h
    
    MSVC compiler complains without this include
    
    v2: also include avfilter.h as suggested

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-27%2Fsoftworkz%2Fsubmit_version_include-v2
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-27/softworkz/submit_version_include-v2
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/27

Range-diff vs v1:

 1:  db6ab867b4 ! 1:  f011be1049 fftools/opt_common: add missing include of avf/version.h
     @@ fftools/opt_common.c
       #include "libavdevice/avdevice.h"
       #include "libavdevice/version.h"
       
     ++#include "libavfilter/avfilter.h"
      +#include "libavfilter/version.h"
      +
       #include "libswscale/swscale.h"


 fftools/opt_common.c | 3 +++
 1 file changed, 3 insertions(+)


base-commit: b90341d1d5585b7181873ac4d85a7c373eb3b2ae

Comments

Andreas Rheinhardt May 15, 2022, 4:35 p.m. UTC | #1
softworkz:
> From: softworkz <softworkz@hotmail.com>
> 
> required for PRINT_LIB_INFO(avfilter...
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>     fftools/opt_common: add missing include of avf/version.h
>     
>     MSVC compiler complains without this include
>     
>     v2: also include avfilter.h as suggested
> 
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-27%2Fsoftworkz%2Fsubmit_version_include-v2
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-27/softworkz/submit_version_include-v2
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/27
> 
> Range-diff vs v1:
> 
>  1:  db6ab867b4 ! 1:  f011be1049 fftools/opt_common: add missing include of avf/version.h
>      @@ fftools/opt_common.c
>        #include "libavdevice/avdevice.h"
>        #include "libavdevice/version.h"
>        
>      ++#include "libavfilter/avfilter.h"
>       +#include "libavfilter/version.h"
>       +
>        #include "libswscale/swscale.h"
> 
> 
>  fftools/opt_common.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index c303db4d09..55d86eeb19 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -51,6 +51,9 @@
>  #include "libavdevice/avdevice.h"
>  #include "libavdevice/version.h"
>  
> +#include "libavfilter/avfilter.h"
> +#include "libavfilter/version.h"
> +
>  #include "libswscale/swscale.h"
>  #include "libswscale/version.h"
>  
> 
> base-commit: b90341d1d5585b7181873ac4d85a7c373eb3b2ae

The commit message sounds as if this were a serious case of missing
include that hinders compilation, whereas it is more of a cosmetic fix.

- Andreas
diff mbox series

Patch

diff --git a/fftools/opt_common.c b/fftools/opt_common.c
index c303db4d09..55d86eeb19 100644
--- a/fftools/opt_common.c
+++ b/fftools/opt_common.c
@@ -51,6 +51,9 @@ 
 #include "libavdevice/avdevice.h"
 #include "libavdevice/version.h"
 
+#include "libavfilter/avfilter.h"
+#include "libavfilter/version.h"
+
 #include "libswscale/swscale.h"
 #include "libswscale/version.h"