diff mbox series

[FFmpeg-devel] avformat/libsrt: use a larger buffer for find_info_tag

Message ID tencent_2A522DEA9A2340B19A6C9F62ABA44E957008@qq.com
State Accepted
Commit 3721aaeaaae9f817abb843117ae8dae1dc280a7f
Headers show
Series [FFmpeg-devel] avformat/libsrt: use a larger buffer for find_info_tag | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

zhilizhao(赵志立) Aug. 14, 2021, 10:43 a.m. UTC
The upper limit of strlen(streamid) is 512. Use a larger buffer for
future proof, for example, deal with percent-encoding.
---
 libavformat/libsrt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

zhilizhao(赵志立) March 29, 2022, 2:21 a.m. UTC | #1
Ping.

> On Aug 14, 2021, at 6:43 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> The upper limit of strlen(streamid) is 512. Use a larger buffer for
> future proof, for example, deal with percent-encoding.
> ---
> libavformat/libsrt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> index e5701625b8..a66c85d3a2 100644
> --- a/libavformat/libsrt.c
> +++ b/libavformat/libsrt.c
> @@ -513,7 +513,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
> {
>     SRTContext *s = h->priv_data;
>     const char * p;
> -    char buf[256];
> +    char buf[1024];
>     int ret = 0;
> 
>     if (srt_startup() < 0) {
> -- 
> 2.31.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
mypopy@gmail.com March 29, 2022, 6:11 a.m. UTC | #2
On Tue, Mar 29, 2022 at 10:21 AM "zhilizhao(赵志立)"
<quinkblack@foxmail.com> wrote:
>
> Ping.
>
> > On Aug 14, 2021, at 6:43 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> >
> > The upper limit of strlen(streamid) is 512. Use a larger buffer for
> > future proof, for example, deal with percent-encoding.
> > ---
> > libavformat/libsrt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> > index e5701625b8..a66c85d3a2 100644
> > --- a/libavformat/libsrt.c
> > +++ b/libavformat/libsrt.c
> > @@ -513,7 +513,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
> > {
> >     SRTContext *s = h->priv_data;
> >     const char * p;
> > -    char buf[256];
> > +    char buf[1024];
> >     int ret = 0;
> >
> >     if (srt_startup() < 0) {
> > --
> > 2.31.1

LGTM, thx
Steven Liu March 30, 2022, 2:31 a.m. UTC | #3
> 2022年3月29日 下午2:11,mypopy@gmail.com 写道:
> 
> On Tue, Mar 29, 2022 at 10:21 AM "zhilizhao(赵志立)"
> <quinkblack@foxmail.com> wrote:
>> 
>> Ping.
>> 
>>> On Aug 14, 2021, at 6:43 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>> 
>>> The upper limit of strlen(streamid) is 512. Use a larger buffer for
>>> future proof, for example, deal with percent-encoding.
>>> ---
>>> libavformat/libsrt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
>>> index e5701625b8..a66c85d3a2 100644
>>> --- a/libavformat/libsrt.c
>>> +++ b/libavformat/libsrt.c
>>> @@ -513,7 +513,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
>>> {
>>>    SRTContext *s = h->priv_data;
>>>    const char * p;
>>> -    char buf[256];
>>> +    char buf[1024];
>>>    int ret = 0;
>>> 
>>>    if (srt_startup() < 0) {
>>> --
>>> 2.31.1
> 
> LGTM, thx

Applied as 3721aaeaaae9f817abb843117ae8dae1dc280a7f
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Thanks

Steven Liu
diff mbox series

Patch

diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
index e5701625b8..a66c85d3a2 100644
--- a/libavformat/libsrt.c
+++ b/libavformat/libsrt.c
@@ -513,7 +513,7 @@  static int libsrt_open(URLContext *h, const char *uri, int flags)
 {
     SRTContext *s = h->priv_data;
     const char * p;
-    char buf[256];
+    char buf[1024];
     int ret = 0;
 
     if (srt_startup() < 0) {