From patchwork Mon Jun 21 14:32:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 28589 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2042:0:0:0:0 with SMTP id z2csp2022766iod; Mon, 21 Jun 2021 07:33:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKEe5uNV1aXfJw867BOLmOQ/PyxBhob2M7nQJnhfnHNr30k5cvX2EHmKojIYkiwbkQV8kB X-Received: by 2002:aa7:cc87:: with SMTP id p7mr21631033edt.82.1624285998501; Mon, 21 Jun 2021 07:33:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624285998; cv=none; d=google.com; s=arc-20160816; b=I3/Zg5Z0x7/4KTkOyceykisGA293upkLJzdg5NjOD4lzM0f5Q0OD5msYNia0/Iz/RO T94dUKlHBte+bhSJkLMLhqz0JbDqYTQPK6RnAPlJGNj5OXbiISA+/YTPY5MHP5sekG0v tEiaFuBmMAAQSY5GtrWdkH2ZauGRK1ORzPs5NwTRo2BQ8dcyAtg20n/1lDITbmD1u9a/ TOkjVYR+grG30S8OYmEI3RF34SOYAgIQakhRcpLgKuKIW/wk/NDyJr8lsvR6wHw2612N /PeZ57Iz06LlW5A2KpEnti0CZIrKQe2PdRjqjFL731eyhmpolHqSufPKXKiNrxV5vEdo rKxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=hoXr7RiBDYJxhc3SzFrLM7ALfWQoXDzUwzDEhfJufEk=; b=yWPVy53R4ODZLl2Cmsl8FC9hCkqATKlso9WNCCkVdjU7JON48DhON6dn9aR2lYFpkc pSFQmSWxKZViuV+iXIOLx/f1K4zCiOU3PHXpafNWIo1h3xg1i9cPwQfRJPPxQefqEAyb wgMDwE1OLiHEUluXC9YboA73ooZw5t2EB65Lmzqm3OEQITqUpE8jb7ciHdbM8EjIDtol mxuM5yBDhQ/DUo76MZP+Pn/SVesdXoxICUUxQ2wbyZtvWkPoluTxg3YF+5LhPNnwanej kC2CPJtIpoBYQWs3cPIOJWAcy5b7fELtUM18VVbQxfB/CqxX4OLEITijcAUbXCbIuscs 8wNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=BNuZwF2B; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g12si12112822edp.580.2021.06.21.07.33.17; Mon, 21 Jun 2021 07:33:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=BNuZwF2B; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 69838689E50; Mon, 21 Jun 2021 17:33:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-251-66.mail.qq.com (out203-205-251-66.mail.qq.com [203.205.251.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5CE45680C28 for ; Mon, 21 Jun 2021 17:33:04 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1624285977; bh=cMi4kTxiYPw0lXqMUQrHVYqLBURlNe2V5CFRQbacYCI=; h=From:To:Cc:Subject:Date; b=BNuZwF2B3JeoXiRap2NukW+iGwQ061xW+XVmmt4EjC8FMAhmJ7TSaN4jtVZS2q8nz uuC+7jtg2wV1QADTLmd180YLJ5RBxTfpYK4NP8HOwoq3SpQ2OinqOLMRSyW5Yi1gL1 k+9RrKxgRYg5THp2zxsxNc+1KgfmRKa2t20EQ/T8= Received: from ZHILIZHAO-MB2.tencent.com ([119.123.133.172]) by newxmesmtplogicsvrszb6.qq.com (NewEsmtp) with SMTP id 837A58C7; Mon, 21 Jun 2021 22:32:55 +0800 X-QQ-mid: xmsmtpt1624285975tj5ku6lfr Message-ID: X-QQ-XMAILINFO: OX/AB0N/HPTvtZxH1cDKPUg70PM5xCzC0bZdPGNOIazgirTL9LDiDtYKYnikg+ RN2hAll1PmGb0VvzQRp4zeaf8XatTqMM55sWF5gLLBQdaU3mKOIc2us9qmnoSLCq+WbSdEegRilu Df5xthtNBmkEm0ywKDGM/eGPHxgaJ1XMic+JNE7XGB9JpB3tKG5CNLOsgCFciKiCydNUD2R6Dml3 Jx3AsDdyklWGsH4AOObsnxCoyj93G4joOleiw1zzYKUFML1hSS3+O8+YcYi8VUlvY0LevHWOZ2aL HfoY3bNntx0/XlQ4s68UjcpzS1YEkkcUVMOyWBi9ze77f+GrvY4vEOSi4KRK36f7pdpvy4xPwa7k DETS2CrcYE6TMaQwpF9rDGaN9uaiuJ8ZKXmAGyHs7hXgZghdKnkBPGGp5/TA5VKgLwS3LZQY62JV BrAUX3WcJuVIUyNixaYO1yQKlBt8bvYYubIaRBPgjbowAuHJAoJJdODNI/3Z9Fs5jb0JtzRiLw9r FZjLo0cH/lLSk0wc55Oo8fWy8f3e34gLmxiap1lVY6q26u6zJ5wxuB/xoFCYERe1zg8NWKBMDuLQ Gx7jK3sKazFAqsR3RbvPzAtEXeYbZwTLP2RzaLr69k8lea7qEaohWcvuZasyNtWQJbQtnoFWre8d fPWyxsd0qK935V+UZp+qPPMy3aTge2smhJEkXIfPeTu2bVwNWGR0TcQoAlltfdVeFA7Z/xY/blEp 8HXWxp3zQYhyE6RSh3rqtBByaxYoctz9Igqzw+7AextMzsMuwUVNeZbMwtSJx7SfCCBanBZM+/R/ 9Aq/Bzzc7/OTIzSrLzHYljKlJoKsD+xO8OXJLQloYoEg== From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 21 Jun 2021 22:32:49 +0800 X-OQ-MSGID: <20210621143249.91642-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/udp: fix check for pthread_cond_wait return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: OO/KRFeuP1wh POSIX errno is positive. We have strict_pthread_cond_wait to handle error code during development. --- libavformat/udp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 9b9d3de197..bbe5aecc46 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -550,9 +550,7 @@ static void *circular_buffer_task_tx( void *_URLContext) while (len<4) { if (s->close_req) goto end; - if (pthread_cond_wait(&s->cond, &s->mutex) < 0) { - goto end; - } + pthread_cond_wait(&s->cond, &s->mutex); len = av_fifo_size(s->fifo); }