| Message ID | tencent_4C0B9C291B21CF6C594B8832DB28668CF105@qq.com |
|---|---|
| State | Accepted |
| Commit | 9413bdc381112711a7beb6d6b8d8fc4b4ff6ca01 |
| Headers | show |
| Series | [FFmpeg-devel] avcodec/arm/hevc: remove duplicate mov of deblock neon | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, 16 Mar 2023, xufuji456 wrote: > --- > libavcodec/arm/hevcdsp_deblock_neon.S | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/arm/hevcdsp_deblock_neon.S b/libavcodec/arm/hevcdsp_deblock_neon.S > index 7cb7487ef6..ebcd056430 100644 > --- a/libavcodec/arm/hevcdsp_deblock_neon.S > +++ b/libavcodec/arm/hevcdsp_deblock_neon.S > @@ -107,7 +107,6 @@ > vshl.s16 q5, q5, #1 > vcgt.s16 q3, q0, q4 > > - vmovn.i16 d6, q3 > vshr.s16 q1, q0, #2 > vmovn.i16 d6, q3 > vcgt.s16 q5, q1, q5 > @@ -146,7 +145,6 @@ > vtrn.32 q2, q5 > vand q5, q2 > vneg.s16 q6, q7 > - vmovn.i16 d4, q5 > vmovn.i16 d4, q2 > vmov r8, s8 > > -- > 2.32.0 (Apple Git-132) LGTM, pushed. // Martin
On Thu, 16 Mar 2023, xufuji456 wrote: > --- > libavcodec/arm/hevcdsp_deblock_neon.S | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/arm/hevcdsp_deblock_neon.S b/libavcodec/arm/hevcdsp_deblock_neon.S > index 7cb7487ef6..ebcd056430 100644 > --- a/libavcodec/arm/hevcdsp_deblock_neon.S > +++ b/libavcodec/arm/hevcdsp_deblock_neon.S > @@ -107,7 +107,6 @@ > vshl.s16 q5, q5, #1 > vcgt.s16 q3, q0, q4 > > - vmovn.i16 d6, q3 > vshr.s16 q1, q0, #2 > vmovn.i16 d6, q3 > vcgt.s16 q5, q1, q5 > @@ -146,7 +145,6 @@ > vtrn.32 q2, q5 > vand q5, q2 > vneg.s16 q6, q7 > - vmovn.i16 d4, q5 > vmovn.i16 d4, q2 > vmov r8, s8 > > -- > 2.32.0 (Apple Git-132) This patch broke the fate-hevc tests (there is currently no checkasm coverage for this function), so I had to push a revert for it. Please do run the fate-hevc tests before submitting patches. // Martin
diff --git a/libavcodec/arm/hevcdsp_deblock_neon.S b/libavcodec/arm/hevcdsp_deblock_neon.S index 7cb7487ef6..ebcd056430 100644 --- a/libavcodec/arm/hevcdsp_deblock_neon.S +++ b/libavcodec/arm/hevcdsp_deblock_neon.S @@ -107,7 +107,6 @@ vshl.s16 q5, q5, #1 vcgt.s16 q3, q0, q4 - vmovn.i16 d6, q3 vshr.s16 q1, q0, #2 vmovn.i16 d6, q3 vcgt.s16 q5, q1, q5 @@ -146,7 +145,6 @@ vtrn.32 q2, q5 vand q5, q2 vneg.s16 q6, q7 - vmovn.i16 d4, q5 vmovn.i16 d4, q2 vmov r8, s8