From patchwork Sun Jul 26 05:30:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 21261 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4E27944AA41 for ; Sun, 26 Jul 2020 08:31:12 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1CEE768AF64; Sun, 26 Jul 2020 08:31:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F97568AF64 for ; Sun, 26 Jul 2020 08:31:04 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1595741458; bh=vy/YQpkHMviPxVIeHtfbkU+I4ZQ5czGMJdg7xREFs78=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OJmgvJ9x/5pJs5ypIaNACV2YGY8KktVsuX/Dvo/9KuFGAUDQmSFHHw2BUZuxqhcTs q/T7r6J43JL8JisxNqZFnFqmk7QYGWjLc772w+VY3dgFDx7rPxm+hm5BGUn6Qrl7nU 7ixRdYb07FUV1Yhs3XvyQ48HZiM5BJDHhpCvi72Q= Received: from localhost.localdomain ([27.46.106.24]) by newxmesmtplogicsvrszb6.qq.com (NewEsmtp) with SMTP id 7B81128F; Sun, 26 Jul 2020 13:30:56 +0800 X-QQ-mid: xmsmtpt1595741456t8q6s5f1c Message-ID: X-QQ-XMAILINFO: M/m4MOBkWHa1cOWXN+W358NH6ArRWeqfVEgHS3wmVJj6Qx2rLZsB8/vM0Fs3iS NG4sdbjzoH2OkgUAc5M3Z04pbmtiXdq2raDIK0gxkMsiBsuMPRyxK5RPyEWYEKXGTtvsfzL+Dfgt t7dd6cpPL53PYkRtg2oo4h9gRUTSCyWyrx25MicWbIg/vr4ih1TTqF4ILACnWVha4T5VsC84Q13k wg/Pelr4MRv+WBmgR6196/Wp4jcgpJrT77WjDZtm4ZCP0o5Ex6j+iCUQVM+6gV8gyLHfJX0nqykn EOP4QXf0KEEytHpfe+P39qbndkLAC1r5iQCtFX416o+CqhjlewXkZ+To+guHQ7/RmkXThSF62cZU RVd0dhBnsMH/VNgE7cszVxa7XBde7+Km68X5XtgPPwTaKc3c817kLbEA6tMN1t/t2MdjhWKnUMHE 0AASWM0x6Hxlji9y91sjvEyj8EYhoP/1NiyoEXCzPygTrfVxxLdG2/+ZSHo2ZbVCNBOj/21m3CNH xoM2oqOx2+I3DyxPh6xtxWUPdkFi5AIV8W/w/oe2lMb28iecmQUlNjXYCGK3Km+dTdZymRJ28Ad5 5eKGMMGNyWqARcdfo/X5nQKsqaCHXvtYff5r7UOfRElOQvhugioCCboIKlETsMlJ83DVoSaWULyC IuwBIbdf5PDY7PDe7Nl9U86rzrJdkTidOWMhoAymWfSeFRvBE5904rYHb+R9po1oN+9Q== From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Sun, 26 Jul 2020 13:30:54 +0800 X-OQ-MSGID: <20200726053054.267045-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/flvdec: Remove unnecessary initializations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" pre_tag_size is always reset by avio_rb32(). For AVFormatContext start_time, as the document says, "NEVER set this value directly: It is deduced from the AVStream values." --- fix commit subject libavformat/flvdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 08622739f3..31bdbbd5e9 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -747,7 +747,7 @@ static int flv_read_header(AVFormatContext *s) int flags; FLVContext *flv = s->priv_data; int offset; - int pre_tag_size = 0; + int pre_tag_size; /* Actual FLV data at 0xe40000 in KUX file */ if(!strcmp(s->iformat->name, "kux")) @@ -773,7 +773,6 @@ static int flv_read_header(AVFormatContext *s) av_log(s, AV_LOG_WARNING, "Read FLV header error, input file is not a standard flv format, first PreviousTagSize0 always is 0\n"); } - s->start_time = 0; flv->sum_flv_tag_size = 0; flv->last_keyframe_stream_index = -1;