From patchwork Mon Jan 9 12:50:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 39942 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp3065847pzb; Mon, 9 Jan 2023 04:50:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXuF0c1iQhE2Q4/KvQMm6chlKI8VQPm4Es1jN2cvlz4uMQ7MdIQRTILLYi0oL0PXO5bdOCzk X-Received: by 2002:a05:6402:ea0:b0:46f:68d0:76 with SMTP id h32-20020a0564020ea000b0046f68d00076mr45436192eda.34.1673268645099; Mon, 09 Jan 2023 04:50:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673268645; cv=none; d=google.com; s=arc-20160816; b=VLP8hY5NzKhxhUHICImFdwvcajWen2B3cY86RqkXwIbVSl1h52K+IrFKjfZRgdc7AP bDQEFz4njo8fyxSNrw8Ht5F9YgCKbVo5bLsiSuleQXo3nerCTzCMwxa+6zaxE6FkTNIS LLagQbu1mBvYBzw0ECpR8zhSt/xJfcAN42htCplQwxKxzKYVG0buQK7zq0IjL1dILo7M 88joJyFLV0mOF9jEcj8mjWAj/bzftw4x3HUNUtVQG8eO7FE83/fnH8nSO1ndzHB54prm i9TA4dCvzva/Vj7a0X+sdb4/ymynQ7FKPAuHrlKprXlllMMe49GEAX+V1abYoehjDAmr ZCKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to:date :to:from:message-id:dkim-signature:delivered-to; bh=o7xLkSE0qvJeAfTzkQwrqqJ35foDuZ0A4M0lJS6QLOk=; b=dIQPEkTn3sOwwG5cVMVA3Ih/GeCc5c0vKwx1Hbs2H2GAXjJlfNYGA4bTKXjjOoj7bI agIRubXOtF68ILrmmclDCoRoKQO8qaQL0qCi+oj5e+rbZ1m9ui8KNWQeXXuXO1VXn0Vo Ne+XjFKrlhPOMbTCeSe2BbNJDDjCFqLsvQvV75k2VPn2he6yOwJ1aSefY2FEeLFKaeOQ xQSrPhBMWnvcXxHYilUnV/KqqmzYHyCmy00i0Myr9y1nGH+9/JtxpMxWDhLmT+z4EZec 4rUF8ruwFiOqRoXX2VTKvNj6ywrwAU/9pEils3j8pDUN4IoEI4GcgnbHkNnAEEaGKtXQ D4pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=NwCRimyf; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g25-20020a170906595900b0084c46478993si7315128ejr.775.2023.01.09.04.50.44; Mon, 09 Jan 2023 04:50:45 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=NwCRimyf; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C6A6D68BCDD; Mon, 9 Jan 2023 14:50:24 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out162-62-58-216.mail.qq.com (out162-62-58-216.mail.qq.com [162.62.58.216]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BCF4368BB61 for ; Mon, 9 Jan 2023 14:50:16 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1673268613; bh=puD6RryxX4kRfnOscEu5puTgicxIGVvBIqLyGu5qVus=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NwCRimyfQ+OAmUiXYB/axDUh7U9nxBKkpi3UDFVxod60O3pZ8g16p9jbsDIUZ4+KY kJrrsXZmpdKVav+XpX8YQimFTVu9/koqniLBe3le26IvMEjtf0qb3wZgFvmdDEAyvz oa5dj/Tfs/pqiXYPYYq3nDOvVDBF4hlHVbAjikV4= Received: from ZHILIZHAO-MB2.tencent.com ([119.147.10.192]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id C898A4CD; Mon, 09 Jan 2023 20:50:09 +0800 X-QQ-mid: xmsmtpt1673268612tss3f5hmd Message-ID: X-QQ-XMAILINFO: MyIXMys/8kCt8xZmD2vRtvKXsVrWcEdpj2Ubc3yPNj/cosOuYHNFCvUISEEJXR SObnfy2vsxrdLD6CNTITUoYPO8mSCZ3HW1LcgLXiX3to1sLaeep+uI8bUwZOPsdfx4nmWqnn/Tb4 PTY72IOsY6FKq1VCxGMbCALwNGHJGiZo3SOacIDtoDrDfF6Zp1vZfBHOHNfV2fr5z6rWrX82fFEP M4O0uwNkj+YOutzi3IeZH2REGxEshHu14p4pcWwo7og7euxgmwIpvunE4LI+OFNKz7Sf6ORB72eq qD28Udu7EByAmzgHCTTrNWEzvBN1DTDXYu1DuEg07my+OTvDXrtFpfcAF5OnKpFd/6RqR256+G5i KfFXjWz169dWFjWxwUPVn2u+qL2vAoOvlk1/mnL8Ij+36eSALhZy7SNUAHNLdaXbAQDkwJczpbzI 6AGEgtr0j01p8gDRbvX/lCIGgxJOlnfuhFW9oyhrlKBbxfHZCq/Z5moycCvLCDKbkgIZ7TMx4YGQ gFWkvegFTD9x6Hd72Blhz61qYg6Qfq7FB9D6vyUxRtSZ/ukV6f97M5LOWYuIGhvbblxY+NqtOVS4 4DYjBKxvsa0T75+3mqtcDsh+Pm8SwY0BlWCk0FtBszV5wr0/CVOZc3aA3jEZho7k4n/nj3WC/NxU lKIwto1L5V/QK5F+eAFZW18ZvQvJo7hfhJh8L4c0iMkiyLWb7fQdbx7LZ/TUQxCAJ34s786UzZxe CapyoEHV95FtDToCjurgIh95IQfHMm6T4iSy4CwxKNvyL7Lg72NraX4kS0KMfqSM7FC3+xLSkvdN csCkT6P/fZ5qShzSghbr5p5WRc9Q7BmlQPJ7iHvNOm15ezN+Zr+JF+dUQ6ygBETDX7XoAKyGlssf XW0rOpdj/HX8+6c4UvHogQY4ydAl50K/zeRhQjnB22IuF7CSTnYOgjvk1eLlHE8+gxB5QfPGHj4C HejceZxiC/SAdGTOSzPebr0WsjLwhUHMnP1CFFvIOzVeQo4OkDMWkT8TPXMuqf1VtXPWZySYI= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 9 Jan 2023 20:50:07 +0800 X-OQ-MSGID: <20230109125008.13336-5-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230109125008.13336-1-quinkblack@foxmail.com> References: <20230109125008.13336-1-quinkblack@foxmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/5] avcodec/videotoolbox: fix documents of AVVideotoolboxContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nVBk6sEjrZZZ From: Zhao Zhili Since those fields will be overridden by videotoolbox_start(), they should never be set by user, it can trigger memory leaks otherwise. --- libavcodec/videotoolbox.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/videotoolbox.h b/libavcodec/videotoolbox.h index 3cd1d254ff..ba5eddbf46 100644 --- a/libavcodec/videotoolbox.h +++ b/libavcodec/videotoolbox.h @@ -57,7 +57,6 @@ typedef struct AVVideotoolboxContext { /** * Videotoolbox decompression session object. - * Created and freed the caller. */ VTDecompressionSessionRef session; @@ -79,13 +78,11 @@ typedef struct AVVideotoolboxContext { /** * CoreMedia Format Description that Videotoolbox will use to create the decompression session. - * Set by the caller. */ CMVideoFormatDescriptionRef cm_fmt_desc; /** * CoreMedia codec type that Videotoolbox will use to create the decompression session. - * Set by the caller. */ int cm_codec_type; } AVVideotoolboxContext;