diff mbox series

[FFmpeg-devel,1/2] avformat/hls: add AVFMT_NO_BYTE_SEEK flag

Message ID tencent_58B89F16424D09202CCDE24FB75523A77207@qq.com
State Accepted
Commit 92053aa26053b941a027a4fc56674d7d86ba1e58
Headers show
Series [FFmpeg-devel,1/2] avformat/hls: add AVFMT_NO_BYTE_SEEK flag | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Zhao Zhili March 15, 2022, 5:06 p.m. UTC
After d6ac6650b91, ffplay failed to seek HLS stream with AVSEEK_FLAG_BYTE
enabled by default.
---
 libavformat/hls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marton Balint March 20, 2022, 11:48 p.m. UTC | #1
On Wed, 16 Mar 2022, Zhao Zhili wrote:

> After d6ac6650b91, ffplay failed to seek HLS stream with AVSEEK_FLAG_BYTE
> enabled by default.
> ---
> libavformat/hls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 06bc46c23f..affff01529 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -2497,7 +2497,7 @@ const AVInputFormat ff_hls_demuxer = {
>     .long_name      = NULL_IF_CONFIG_SMALL("Apple HTTP Live Streaming"),
>     .priv_class     = &hls_class,
>     .priv_data_size = sizeof(HLSContext),
> -    .flags          = AVFMT_NOGENSEARCH | AVFMT_TS_DISCONT,
> +    .flags          = AVFMT_NOGENSEARCH | AVFMT_TS_DISCONT | AVFMT_NO_BYTE_SEEK,
>     .flags_internal = FF_FMT_INIT_CLEANUP,
>     .read_probe     = hls_probe,
>     .read_header    = hls_read_header,

Series LGTM, will apply.

Thanks,
Marton
diff mbox series

Patch

diff --git a/libavformat/hls.c b/libavformat/hls.c
index 06bc46c23f..affff01529 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -2497,7 +2497,7 @@  const AVInputFormat ff_hls_demuxer = {
     .long_name      = NULL_IF_CONFIG_SMALL("Apple HTTP Live Streaming"),
     .priv_class     = &hls_class,
     .priv_data_size = sizeof(HLSContext),
-    .flags          = AVFMT_NOGENSEARCH | AVFMT_TS_DISCONT,
+    .flags          = AVFMT_NOGENSEARCH | AVFMT_TS_DISCONT | AVFMT_NO_BYTE_SEEK,
     .flags_internal = FF_FMT_INIT_CLEANUP,
     .read_probe     = hls_probe,
     .read_header    = hls_read_header,