From patchwork Wed Nov 23 16:49:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 39394 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:999a:b0:a4:2148:650a with SMTP id ve26csp3918537pzb; Wed, 23 Nov 2022 08:50:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf4gy+oizrIHHivx8HUxayG/LDd2q3xTX3t7Mq30+Ca1nyzbf1oIlWTbDVcGFEQtV1Z06jcd X-Received: by 2002:a17:907:2143:b0:7ae:27ed:e90e with SMTP id rk3-20020a170907214300b007ae27ede90emr24154528ejb.224.1669222222485; Wed, 23 Nov 2022 08:50:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669222222; cv=none; d=google.com; s=arc-20160816; b=aB5+R1MZaCrVBrNVRpXk3NVWNKUs8mSSVIkVqcppN/evA/DsAPM5saQgHdFSe6VKug AuVxjcTuDkRSToBEIKzxiOXurEJXH4UH325Xn1klEvCzyrNGvxVzc4xQuMDm3TYzpg04 XdEq8V6PCMH8uUUiDLC+S2P+bwzPJX/6VJZSZDpzKmGhN3L1PQgQBD7yx7Ltb8MRKkgU JxnvC9UpnbGUm1Jh9K6RPdkC5/OYh2UBESUe21ElQMF3Mm91SmxNF/IP4ZhtfRMFhi8N F1dT7weGJaWgrr11ci0hYaJWzLzkEWFSrWlVKtsuLmCNngmhTSyVftpfDV8XMi7EBVTf kCZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to:date :to:from:message-id:dkim-signature:delivered-to; bh=zBwo9QQIB2ulkGb3NdrJRLiOSP3hxceAof/4j55ZbLY=; b=IK6ijZtX4wWg2cfD1MFAPK5mA/aB9OCjfmDGfE01wYYAOqd29U5DaXfdjGr3VPWOvP 9ghWUZ0Ybj8TrrPTj6iruX4LjbLgc2VRSiesK3bAMnIE7ecMkIqXYBEsnIdn9bD/rJRs bqKlppQNJJGIBUDTK7ZphwJqmq/5EdM7csUP9/N2oFYBLCECeQH3Flgn8KsHf+8xzNwc Jr8VYhS1WrPADxQIZeevaWH+SC5mCkG3b4WYDe3BpgQ6cQE3EAb/N/cpjPxj6y7MelWu yIc1UMe+NA0Y19tpMeeqPdJOAW66IRmbkvwZNC6Q3INwbvpTsriAW1oZ1nU4fkSUdD7V NLDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b="nS96/5bp"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ga34-20020a1709070c2200b0078dcddc1b8csi842743ejc.788.2022.11.23.08.50.21; Wed, 23 Nov 2022 08:50:22 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b="nS96/5bp"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0481D68B7D2; Wed, 23 Nov 2022 18:50:05 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com [203.205.221.239]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AD71368B155 for ; Wed, 23 Nov 2022 18:49:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1669222192; bh=LMCaTz3CyZR5VZSpnuZR3RBqVgSs0VBKSPApB9eOqqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nS96/5bpyyL5iun7Zk029Dftqcuslr5EqtCri9DZXOEI5gObjoLLhAYgM29Zf7N7d fGwTi3GHAKObTX6OsNpOJ5sMFCtGBLP3Tmg/65KdkJ1/S13axMFrG8SxMOO6GBkQpq sBvJB/Bei9uMO2kSNpoa1ipmveoxcx2LjjsnlCL4= Received: from localhost.localdomain ([113.118.113.114]) by newxmesmtplogicsvrszc1-0.qq.com (NewEsmtp) with SMTP id C7281E6D; Thu, 24 Nov 2022 00:49:50 +0800 X-QQ-mid: xmsmtpt1669222191t8fm7sfmf Message-ID: X-QQ-XMAILINFO: MyirvGjpKb1jY0yCLrIxh5DA//hfykW1ef1wIBXezqcpSyHTtFED8iN+v8Yd5Q eNl/j4Ud/o81E+qAndDPZD0IVNIYrHTkQSIl4dnOHtgwwUbEjBvbk0Tf3jloQGy3Ec/sBOJ5lKyt 2y0yMhR4c6GY3lMKk8JirXZkIkXwV6rxSmqgql6emDl8+lmkDeHTt2y7wUbHqQEp2Fk8NdTuTC/5 gI3ghP+XToMh0J+k4xGwOWgBTMAlolaEjSe1IwojuAEjlWj1xIwCewvLjUSACZbKdv0iIPsvIATg xiEW0GzKZcsrLGtUy9R4QyxKkz6NZ8bSmSB7f/VEVM+EzjtfxSgMzC7GSZquY2Ezi+3Cds6FOs8M uMQG7c+dZyFaxRHqV05l0w2f1Jw3cAIjkxYIdkaEwRT9uxq0UMeXzfRWbDItQRDm8FQbWUwUpRh3 pG/IlJVAyzBI5dhqJSS/pdAEjRcrptFCxW9StaRzvqd4AB23cp9GPYViZkuO17rZxUggN8ZkHtmz GLCZngbDki1lZa+Td9fOQyK0SoWBb1ASbKvb5AZVlFSzhfMURjht3Q6oabJuOOFpbSYZWFn4mpvR mGcKD6/762frMbvIp94san53OZ9eyKNF87lqmMxWi8Wkwvtwuq01RhW6X+AxP4xBWUGnVZbejiPK 8wj9xCk2zsS/K2yXP6f+7y84WfNsfgkaM1njqIPBTCAkr+yqdpUPIiNuxammBI5A1/5s5TYxtpkt xw3ldo/CiqaZDDLJuAstQ6XTKFDvVzc6x/8USiKThj2I9aFd2PZb2mNutSuBhH4WTEc+bV+p9I/5 JTIBWwFWOdQQwVcjDuoflOtGc4Es+CwUS44TXak+HjYYzdBnrzsbfalEib1SbEWtSm5xx6FV55qe Pk1xV7Yw8mTdkuJk9lV88Btdn2JiO6B1mQs0W2USdMj2pTqcMQ4WxPVwfzM6/05G/ZXD3L9r3Ee/ hzHzDcjp2plO6IOGqDbQ== From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 24 Nov 2022 00:49:26 +0800 X-OQ-MSGID: <20221123164926.25481-2-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221123164926.25481-1-quinkblack@foxmail.com> References: <20221123164926.25481-1-quinkblack@foxmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecenc: check missing Surface X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Du3rlFnQ/eY/ From: Zhao Zhili It's an invalid combination of Java MediaCodec with ANativeWindow. --- libavcodec/mediacodecenc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index 7cdde59945..a4390a9df6 100644 --- a/libavcodec/mediacodecenc.c +++ b/libavcodec/mediacodecenc.c @@ -167,6 +167,16 @@ static av_cold int mediacodec_init(AVCodecContext *avctx) av_log(avctx, AV_LOG_ERROR, "Missing hw_device_ctx or hwaccel_context for AV_PIX_FMT_MEDIACODEC\n"); goto bailout; } + /* Although there is a method ANativeWindow_toSurface() introduced in + * API level 26, it's easier and safe to always require a Surface for + * Java MediaCodec. + */ + if (!s->use_ndk_codec && !s->window->surface) { + ret = AVERROR(EINVAL); + av_log(avctx, AV_LOG_ERROR, "Missing jobject Surface for AV_PIX_FMT_MEDIACODEC. " + "Please note that Java MediaCodec doesn't work with ANativeWindow.\n"); + goto bailout; + } } for (int i = 0; i < FF_ARRAY_ELEMS(color_formats); i++) {