diff mbox series

[FFmpeg-devel,1/3] avformat/dashenc: enabling streaming automatically for ldash

Message ID tencent_8068427CA6AD3E3AC9C121B5286952007D0A@qq.com
State Accepted
Commit f6b90d5fef0bd2878227ab073f3ddae53c2e2147
Headers show
Series [FFmpeg-devel,1/3] avformat/dashenc: enabling streaming automatically for ldash
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

zhilizhao(赵志立) Oct. 21, 2021, 8:15 a.m. UTC
There is a little chance that user specified contradicted options
like -streaming 0 -ldash 1, however, it's more likely that user
didn't know or forgot to enable streaming for ldash. So enabling
streaming automatically to make the feature easier to use, similar
like enable FF_MOV_FLAG_FRAGMENT/EMPTY_MOOV/DEFAULT_BASE_MOOF and
so on for FF_MOV_FLAG_CMAF.
---
 libavformat/dashenc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

zhilizhao(赵志立) Nov. 4, 2021, 8:03 a.m. UTC | #1
Ping for the patch set.

> On Oct 21, 2021, at 4:15 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> There is a little chance that user specified contradicted options
> like -streaming 0 -ldash 1, however, it's more likely that user
> didn't know or forgot to enable streaming for ldash. So enabling
> streaming automatically to make the feature easier to use, similar
> like enable FF_MOV_FLAG_FRAGMENT/EMPTY_MOOV/DEFAULT_BASE_MOOF and
> so on for FF_MOV_FLAG_CMAF.
> ---
> libavformat/dashenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> index 06bbf36c95..0370a482fb 100644
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -1406,8 +1406,8 @@ static int dash_init(AVFormatContext *s)
>     }
> 
>     if (c->ldash && !c->streaming) {
> -        av_log(s, AV_LOG_WARNING, "LDash option will be ignored as streaming is not enabled\n");
> -        c->ldash = 0;
> +        av_log(s, AV_LOG_WARNING, "Enabling streaming as LDash is enabled\n");
> +        c->streaming = 1;
>     }
> 
>     if (c->target_latency && !c->streaming) {
> -- 
> 2.31.1
>
James Almer Nov. 5, 2021, 3:03 a.m. UTC | #2
On 11/4/2021 5:03 AM, "zhilizhao(赵志立)" wrote:
> Ping for the patch set.
> 
>> On Oct 21, 2021, at 4:15 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>
>> There is a little chance that user specified contradicted options
>> like -streaming 0 -ldash 1, however, it's more likely that user
>> didn't know or forgot to enable streaming for ldash. So enabling
>> streaming automatically to make the feature easier to use, similar
>> like enable FF_MOV_FLAG_FRAGMENT/EMPTY_MOOV/DEFAULT_BASE_MOOF and
>> so on for FF_MOV_FLAG_CMAF.
>> ---
>> libavformat/dashenc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>> index 06bbf36c95..0370a482fb 100644
>> --- a/libavformat/dashenc.c
>> +++ b/libavformat/dashenc.c
>> @@ -1406,8 +1406,8 @@ static int dash_init(AVFormatContext *s)
>>      }
>>
>>      if (c->ldash && !c->streaming) {
>> -        av_log(s, AV_LOG_WARNING, "LDash option will be ignored as streaming is not enabled\n");
>> -        c->ldash = 0;
>> +        av_log(s, AV_LOG_WARNING, "Enabling streaming as LDash is enabled\n");
>> +        c->streaming = 1;
>>      }
>>
>>      if (c->target_latency && !c->streaming) {
>> -- 
>> 2.31.1

Will apply the set.
diff mbox series

Patch

diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index 06bbf36c95..0370a482fb 100644
--- a/libavformat/dashenc.c
+++ b/libavformat/dashenc.c
@@ -1406,8 +1406,8 @@  static int dash_init(AVFormatContext *s)
     }
 
     if (c->ldash && !c->streaming) {
-        av_log(s, AV_LOG_WARNING, "LDash option will be ignored as streaming is not enabled\n");
-        c->ldash = 0;
+        av_log(s, AV_LOG_WARNING, "Enabling streaming as LDash is enabled\n");
+        c->streaming = 1;
     }
 
     if (c->target_latency && !c->streaming) {