From patchwork Thu Oct 21 08:15:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 31194 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2084:0:0:0:0 with SMTP id a4csp332531ioa; Thu, 21 Oct 2021 01:16:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXNdMmfB4B7LqUMGZZDkXwk+I8730wjF2X96JTAaRCfiO5GN9nwy9w9+r9dravZIV1Trhh X-Received: by 2002:a05:6402:510c:: with SMTP id m12mr5844304edd.33.1634804183666; Thu, 21 Oct 2021 01:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634804183; cv=none; d=google.com; s=arc-20160816; b=thGkOO8DX1zw2SJc2Z9dTS8AHGpcjk2G5BpR9GIM31oXdtu2hgAfnPZuJfcWrYh2Ui XSU5j2LIUOtGbuTC2sd31IsubXgz5ueg4G1khzx1Bx1hfQZ3bTXK/3zN6HZOp3dJGwzr zfxOLdROiewReWdsk8VENQFn9wLZhv3Q+XuMViv19MR6ZBH9ZmvR7pC/H2wZPh6e5k3c Fe6mMG3H03c5e9c+DMSxYICs9zPOmA4806f1UkSLzwXK46vqAD8+Ymyrqwzr4GTGmwIL y5SNdWFSrvQ6tkFONSshhkT8EpdoBdgepaMui0F6Aup/zsavtaQHLzGAl9TZMkg6GUDS Orqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=2ufF8Uzojo87zleU9qPUlaegeOf8DsimG/q+lvnTH0E=; b=Vgmrcm+PyNaDJihBFSrvcPgk5z4u5E64mFH8BQKoKyKQ4m6erjCGv3CY49EOYil8Ee 5COBJDsJRyCvr7e+6518eUYSRHtAVUDRr3rxfd9eVOftimdQ1Piqu2w8PZ3kV17r7WFj T9vQKTq1nfsEJS888335haHJkiaUpjhpgb3LQjEXgRflViIhFJJuUZxegHf78C8ZBy/X v37+KNjtaCZl19gB4RciUSRFq7CGqRpgCx9uVmM+Xc23+gIJBNVjhHaZs1Zil+2BdDYI F6rR0JRZYRy9VkmuV+FVs49eq30nqoOQGt3a20jH/L0OoAIdUUDxsxq2scP2lJD6ei5G 1+ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=wK4FwM2S; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sh15si6993716ejc.774.2021.10.21.01.16.00; Thu, 21 Oct 2021 01:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=wK4FwM2S; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5A5FB68A618; Thu, 21 Oct 2021 11:15:55 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-173.mail.qq.com (unknown [203.205.221.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7916C68A59F for ; Thu, 21 Oct 2021 11:15:47 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1634804143; bh=q/GoK8Vvu/UNhMAaBI9Tnlzy9KVvUv4mB/pdZtBXJ6c=; h=From:To:Cc:Subject:Date; b=wK4FwM2S7IfkoOsp8l5D05iqB615/IkcnPOspDUE5e5EXWg4vkOP0irPA1JAD1Ox2 wgcmSdJZPR6WPgWkhLvbPJUUhue/YN3gfIXsFCGmDS8OMt5pstQCPu3D9wJ4l1ZJIB 9wTwU/cqNSTZ76g87uDQW8rnzmEu0w3Xj/6vLcxU= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.61]) by newxmesmtplogicsvrsza28.qq.com (NewEsmtp) with SMTP id 3EA0628F; Thu, 21 Oct 2021 16:15:42 +0800 X-QQ-mid: xmsmtpt1634804142td3ebj5q0 Message-ID: X-QQ-XMAILINFO: MX+1SEN3H+wANOLvDC2eWuWbdmIvQa5ZvlpK9FVU9X+kQ9Cjw/6n3yTy7lCjvr C1stldj1bS1KDxKeMU4mJp7IvKESn8nQVA/xFxvJjrp8+PmTn17iYyYeCT+Vz8C3qJ9TVUgQkCNt +KJVnHYBsyXwROeYqszsIXzdAZ8KjAtA8rnye1uvwr64Jd/87yMgsHzNJYkQ70DqsvQ7a0ECVoQj MICclhbLe3n2tVWZHhr4LEn8XGmN3q6arCHXmL3fQd8+WJnqqcaj+6+nezB2UAbDEkmqsxIARhQl UsP+7h2carikrIB2HdAvzYpwxBvZBSR9xDvy1bcBzmVEuPQmnNynIJgVFIZrEEF2gH/BdxoQEKVL 26PEwR4H58fpUCz8rcHR5mLYIheq928Y725yCLNyMLmOg3VpGek9o6EE9wm5WePTWeyA8UixDSOf dt3+Avw0EnYl2jVcLesZTqYWNS3GYfv8lQRCIfR5Hx1X258Qb1gnEoz6Pocfre0CgQdgEN4cFb8a se3G7sfbS2wWXdBLjXeBwba//GJBtsm9Sh2qmmcla6CCmY15r/shXgAf2zG5Bje2aj+ts80pTN5D Hw7QAChuGZi9E91Y4ldD4YMAetT5LyHF8piYEb90VbO0WSSNNw63dMFeP673ac7mvmZizA7lHixg msneeNFZITW2j6GicOw3q2gYqggvXWsxj1ARBomw1zfqDKQRRPU1F3X1MCyxOrAtiZhod1gZOV8M hDOcdJNgSEgNXNqgnlwWPKqg7xnPQy6rnosYN3E47Kncu1p699w6dgsak3nIso0iYKnMZkVWL9PS lt3bpT2mvCIC49N4dsUQ5SNDMuuLJFO8V93PFzr/vI5aUfWUtDibdj From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 21 Oct 2021 16:15:30 +0800 X-OQ-MSGID: <20211021081532.81477-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] avformat/dashenc: enabling streaming automatically for ldash X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: juI/AFaa+iav There is a little chance that user specified contradicted options like -streaming 0 -ldash 1, however, it's more likely that user didn't know or forgot to enable streaming for ldash. So enabling streaming automatically to make the feature easier to use, similar like enable FF_MOV_FLAG_FRAGMENT/EMPTY_MOOV/DEFAULT_BASE_MOOF and so on for FF_MOV_FLAG_CMAF. --- libavformat/dashenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 06bbf36c95..0370a482fb 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1406,8 +1406,8 @@ static int dash_init(AVFormatContext *s) } if (c->ldash && !c->streaming) { - av_log(s, AV_LOG_WARNING, "LDash option will be ignored as streaming is not enabled\n"); - c->ldash = 0; + av_log(s, AV_LOG_WARNING, "Enabling streaming as LDash is enabled\n"); + c->streaming = 1; } if (c->target_latency && !c->streaming) {