From patchwork Tue Jul 16 02:49:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 50550 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c9c6:0:b0:482:c625:d099 with SMTP id o6csp140908vqt; Mon, 15 Jul 2024 19:50:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWKP02/Z15QfNLuH8/WKxglZMGtNcMM3mCg8ozWvfqtXFzeXe6NmX6FXeggYxZ5LjYPY8lCbbZvnusSt/oZaxJYFo0SPjr+kLc8Ew== X-Google-Smtp-Source: AGHT+IFrYtqzQywHhXnSSReHcfg+i9a/tynfO0pG3BUMoTbMIYeB2FN/IjE3d+nqHPECijK2AKiv X-Received: by 2002:a05:6000:4020:b0:367:8f29:f7b6 with SMTP id ffacd0b85a97d-368261dff58mr526262f8f.51.1721098223497; Mon, 15 Jul 2024 19:50:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721098223; cv=none; d=google.com; s=arc-20160816; b=N6F+YKz95SWbb4BFPkml6T/DC5CfHkZXXSRxyVfG9gn7T6Llmatqy8l5aYKR6kVUnP ZFb7l26fCQ0lQoRCuIPxC6tzM0m4Hz7n6MpQcCMVmyIiVezKpXdAnuK3CgHJzmiEA7pa uFlDvmIhUP4QgcdBCzTdyS+QNnlQQJJLiJEJl+OoZ6YG5Zz6hlkUWj8v6htVdyBj5WMq kDeHz4KT9aUBOfiul3RF8/6k2Nffp9f4jDeeY+3/q1TralWEHUCAqkQoht5HMOdLF1LN BOFXFYZbsQ/JxXO7w87nZwLDmKHrt3bUmEEq+IY/KOlDDkC08YkFu/hceaepanW0hsR0 DLFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=2dcR3F23iwlo3Dd4j667zV0qAv92t6e+CNlSlpR/lXU=; fh=HnHYuZ9XgUo86ZRXTLWWmQxhslYEI9B9taZ5X1DLFfc=; b=1HoQHsQ9dcLsSkXQiOyR26uSrsdt40+jVuuOsC9epdpOiZ31NTFeKmMJeGfm2my94j bJCk8h/vhhcLXPYVdcRnUrMO0PiyjCAbKapFlo1zXdXYsBULnk5Mx+vlyEScndBPPcfz RnZpBvEJfX9IQ+OHl0b33s6TNmFO8YIzDUPHVvohjSTk9ugl2L942rEvbIli5msOiEyI jO69Y7rYEd1MWGygG634aryUfcW0TiuO6z2U73BnwCXsITCLmbGM7tLfK0ROpfqcqgR1 ZZPOB1jGmwiB+NIyAVwC1WOnNlB3/SoTn76+Jb/1+/tWqPAV4N3WsjKZqGzo2Hpsb1D5 p7Ug==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=N2hRPQ7Y; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a79bc58e21fsi292821966b.10.2024.07.15.19.50.23; Mon, 15 Jul 2024 19:50:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=N2hRPQ7Y; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B70B68D9A9; Tue, 16 Jul 2024 05:50:19 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-205.mail.qq.com (out203-205-221-205.mail.qq.com [203.205.221.205]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0146368D67B for ; Tue, 16 Jul 2024 05:50:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1721098201; bh=UtWSU/9I6CeL/GZHWm0aMhzhQkPbjJZCdccCNmn1z64=; h=From:To:Cc:Subject:Date; b=N2hRPQ7YzRg2lrcLnWkPzONKphZqFeMOZ6KcMI6D+1iJYtvBuM9/j8Fctlh0YZNnJ 5PLnxARLegtlcHOVAy1Pe5ojUQmOEjTQsBFkGFoMM3U/70mJ7NpNnbq6l9YCrOslh/ 4R2zOLD5PNXyqyxKBDpOdxZy4ljnQw6UiLEADrvE= Received: from ZHILIZHAO-MB1.tencent.com ([119.147.10.193]) by newxmesmtplogicsvrsza29-0.qq.com (NewEsmtp) with SMTP id C7B91C67; Tue, 16 Jul 2024 10:49:59 +0800 X-QQ-mid: xmsmtpt1721098199thze55f9c Message-ID: X-QQ-XMAILINFO: MYkgkbEOhvKwt18+cFebUnYT98LnjQRSeFEaoSoJDHyuaKGgS9Iu1TlXj0XORa XOyRJ9GgCvyla5d+RJg0dkiduZRTtCjMXKGGUk+En77bI/BBs2E3W5I5b9fn/WsJsKtJIfwotzS/ 41DOvgRkWSpxhQVo9C7Sru3jHFdAqyhD65xHdw8/BRhvzQq6FfJFg6z8QXjdtwb+2D9dvXrS12NI lQ65/KLIlhSKNkDDK7mCZ4SHUazSJ92mJlcyi6OTJe9iqIIk5NscGYES4p2IaIqZHEqIf/U2kZ9P HTnGvjpLCO5PppepDjwnGJwLgF68az67JCCvsx7xtkpFD0BbOr8KbRMf2ecVG8reJg987JYQqh7Y zl8HDoJwf/vNuEWTNzZTm5rUyFF9OOmxMRen1g7wBYglZtXbvXb+CRAxZzfHEdSE/K0xEIcRyg+N FtaY7nk8QGQEpPsOwqVW/JVHyYFODE5dECtM3+6lDqCVWHKoamDJTnUBaSJNYl/w0MXG+aPg53HZ mdWcpbK7UMFchwI8BYqlfUZggMe0PSEmyPZPevjAsSwoBaXEdCh10ngJZZScA0AHCPhsPeRNWe9P 6VRtvcaW4x7dkQhLh5OALEVMWM/BGECLTg9SDGUniHkWg6V1E2LndOyjDgJEAFdlJTBp6Bzkbgp5 U1M/nCfeiV/rzxqX7QhB/QYImMe547jcdt2HNZ6xIAGj40MGKi8ccmCB9sfNCP+2k/WRKITVlTLV J/qy7dxug10J7INRmoddo4ND4f2m/fSJ+cP+ylFG4wJcFxrrZc8WGef+NyOCg8DREkHWmSvP5P5Z AcwBD2oFS0Y6W8TJI+6OBleBNSGSNztJ8rBMQAhO2rGDARNcNv5dFydfFo6KN7tLIjswxgRh9NQC eWI1GKGez77Akm93GetJ31WSvCeZHmbK1Gk0YMN8HhT+V9mcWvA3qfg3u+U2HA0Jhnz7I6nJr0EN PQ62ycwbtJc+OGCEZ9fnDOAt5gHJcgxXFXb9amYAw1ArCbnhWrxA== X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 16 Jul 2024 10:49:56 +0800 X-OQ-MSGID: <20240716024957.41421-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: rX+jrBQ06xgh From: Zhao Zhili If (y + i == vb_above) or (y + i == vb_below), the if body has no operation. --- libavcodec/vvc/filter_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/filter_template.c b/libavcodec/vvc/filter_template.c index 9b3a0e46f7..32777452b7 100644 --- a/libavcodec/vvc/filter_template.c +++ b/libavcodec/vvc/filter_template.c @@ -77,7 +77,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst, ptrdiff_t dst_stride, const uin const int is_near_vb_below = (y + i >= vb_pos) && (y + i <= vb_pos); const int is_near_vb = is_near_vb_above || is_near_vb_below; - if ((y + i < vb_pos) && ((y + i) >= vb_above)) { + if ((y + i < vb_pos) && ((y + i) > vb_above)) { p1 = (y + i == vb_pos - 1) ? p0 : p1; p3 = (y + i >= vb_pos - 2) ? p1 : p3; p5 = (y + i >= vb_pos - 3) ? p3 : p5; @@ -85,7 +85,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst, ptrdiff_t dst_stride, const uin p2 = (y + i == vb_pos - 1) ? p0 : p2; p4 = (y + i >= vb_pos - 2) ? p2 : p4; p6 = (y + i >= vb_pos - 3) ? p4 : p6; - } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) { + } else if ((y + i >= vb_pos) && ((y + i) < vb_below)) { p2 = (y + i == vb_pos ) ? p0 : p2; p4 = (y + i <= vb_pos + 1) ? p2 : p4; p6 = (y + i <= vb_pos + 2) ? p4 : p6;