From patchwork Wed Jun 12 17:35:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 49882 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c504:0:b0:460:55fa:d5ed with SMTP id c4csp646412vqq; Wed, 12 Jun 2024 10:36:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXGcRSApb7gpO7/Pt0mEewvGZjyIC2kxbL8QCgfPwUNCOr+bxbRMLY1gcuMFAYGBrODQETA0RiUMUASMOMZa22bizmRe2l5NlfdPg== X-Google-Smtp-Source: AGHT+IGYNeUN3RTme7RAtua5SFJjLWTYADkMwZZM17WevJrfa5Q9A57IxHnVxCUaQMc+X32FaYq/ X-Received: by 2002:a17:906:f24a:b0:a6f:2383:b852 with SMTP id a640c23a62f3a-a6f47f5897dmr128962266b.5.1718213778642; Wed, 12 Jun 2024 10:36:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718213778; cv=none; d=google.com; s=arc-20160816; b=ehuJUWMuwQ1g5xFW6RSW6McDn6L9929SaE7vLsw8uUykT2Hxz4pgs3pT68K18vFWw+ d5ucx/P8T3QoPxwo/wM2J/UZ2gyjRRQL1DdchESOuioSFtu7KPvh8jLm5jI2JNbqZh2P QAL+ll1eScIxmE4R+DkAftVxMoZDJF89J54K5FWC40Q91NxfrcfHQGXf7Q6Y2+BnjgKO PjvfJf5h5lxfAPteFfLb5FuGXuF9Y3jjAG0hFtcbqBeAoVWuvXKYDyNR31+1zlAbdk5W Kx04VMuINBRBtT8g9HyhcODZFWcxAB7njtGYRiBm/Fu6wBLNebgTMjlSgvm8NomscbwL ZsiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=Pzy+7YzcXU6V52um51MYngPO7Q0cg/JdhZUKmxj5J5E=; fh=HnHYuZ9XgUo86ZRXTLWWmQxhslYEI9B9taZ5X1DLFfc=; b=Nk3OxzWU6E1zcnAOzuf2KmbFs4igd4B8H+mUf6t/8/ht6vBdTYJZCzfD4CkE/swYsd IZ0hXhCcPW5Wy7GAW4xSZgnd3neeAxtChw/SPETqYpnLq3mvwequiNhT1DEcUdsYVqWV mUV+JrqbMGPwrPHBDJd1V1v+pH7GGUpAfbp/3NtBg/pGVDiqqWUu3AF7w7C42x1e02wp JgiP0O++mn//hvB5yhW/Z8nuqoY2le/jZqGvrhJN8YHbluvpr4IYqpwkf9ks16DRND9O ncZj5xT/PX2vYzA3F5Yw4vMZKperjxJNzETnLwoW2EWN4yf1IdIsvWy+Z1tM6nofRvBl W1Fg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=Lh4qOm+z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a6f0fc010b6si439673166b.878.2024.06.12.10.36.18; Wed, 12 Jun 2024 10:36:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=Lh4qOm+z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD8C868D93C; Wed, 12 Jun 2024 20:36:14 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-153.mail.qq.com (out203-205-221-153.mail.qq.com [203.205.221.153]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 224AF68D844 for ; Wed, 12 Jun 2024 20:36:06 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1718213756; bh=WyJZFp0PO+h4W/eZjCia1uMykJaHCWKbB11hc6wGKYA=; h=From:To:Cc:Subject:Date; b=Lh4qOm+zGW28iQ8Tc/In3vCrSEPs/JiHhVPiBlU0Me1lG0ouoDe3+PhYIYMgXb7J+ jdb2OHlQ/Anp/80ElmvfcUM0aWsa3slEs55JATMrqQRrtkhYQmDyaRu/f9w9hc84vF hah2Yo1Z+TCK0NTjRzgZhsJOb7LmSBolc7YHRwa4= Received: from ZHILIZHAO-MB1.tencent.com ([58.246.12.194]) by newxmesmtplogicsvrszc5-2.qq.com (NewEsmtp) with SMTP id 8F7166F5; Thu, 13 Jun 2024 01:35:55 +0800 X-QQ-mid: xmsmtpt1718213755tk09m3abf Message-ID: X-QQ-XMAILINFO: OGvgEoGelOUdHDi+M7QnSBmokZc3kyt8Hpm9wnCfV+FGDr5ZxLJjxkbECnj/H5 3kQz9ED/omg9r5TPsBf10T6PC/YIwQn3iydZ9m2pN7FMntdqd7NeWzZcJUuNQ7zUaF55Q/gU76lw obVELkfwCNMbKYN5IHi6LbEu8+qqav7JXLi02SoEwR7qLaymcN+9/t6WTbVFMyE6/Z49JMFK6SxF ITIwuvLdwtzAD587KRnZa23Fgy3JISAsaI3dxeU33iEzZUPSBM1wgR0IAoFQ2PW/FwAjhuTRsNxr pUW1YHlgV8wxwvJG82ezR1R5JA+9M91dGp44yEgGRCpHtBJ6OoJazZ9HR2+uBDQg7jmpKuig3aEI 6oM0FW8ChfpxYKa5W0LEj3An8Ukz/0hy6tvnHz/w6R/nhvD44RfSEtZScD5JDNEZwR9lKI6RTA9F vf/GB2SmzWFzY8XvFCNG3cmBbzh4wy+jOlt/EEocUuPsovJgwDNKE/dTm+/phNyUdrvMLpNpP/Lf UR5f5VH0CvqyfQUAz598QBqAweblGqdXZyatGoEJjGbiKZeBPXCOs5T6rIZxZS358sokrHJGHc+l +OaeWtFga9YD4G4NTxO/9hK5kxZ/OTOYOLbwkEg4Xi/KzY7Pm8LN4k7w11Y78gmZ1aSJ4iaMlkqf BmJuFP3VgoBmoZYYK+T4jLMbI95JYC5gvm41YupuBmLEmCmbf8h/UTqjysgBUtRLnsTbVMMOHe2T hoz19/bH/roDbRkXru7YubXOdNT8ZL9z5L6P554DMCpYgiU11OrvOZgwJ1tegDCAJDQuaMu3bmnV dnL9QTenU5AoVzANQ+cC6BU9ji57B8PC96MwnwRSZbxHGAifZ5caci7qKCeUqWeXGjkMDEnuYMAS XwIxy+baWxp7ITmvKr1x5SSiGLJgf64n8it2NXFCdUvJxPqh5XotXpmcsZJc/SEqewugWLNHz63e eddMbj3zscbneWGP9a6xpZ38i4hX5GVOtEhXbhuFiT02iJ4xVzuoacpbMXhxgXy8y1egFnFHg= X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 13 Jun 2024 01:35:53 +0800 X-OQ-MSGID: <20240612173553.91937-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0VaRuNL3TjWd From: Zhao Zhili The check should be >= 0, not > 0. The check itself is redundant since uninit only being called after init is success. --- tests/checkasm/checkasm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 28237b4d25..bbcc90f91f 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -814,8 +814,7 @@ static int bench_init(void) static void bench_uninit(void) { #if CONFIG_LINUX_PERF - if (state.sysfd > 0) - close(state.sysfd); + close(state.sysfd); #endif }