diff mbox series

[FFmpeg-devel] avformat/tests/imf: fix memleak

Message ID tencent_FE40249A0F9F19AB3A4E7F700E2DD89A0B08@qq.com
State New
Headers show
Series [FFmpeg-devel] avformat/tests/imf: fix memleak | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Zhao Zhili May 19, 2023, 5:40 p.m. UTC 
From: Zhao Zhili <zhilizhao@tencent.com>

It breaks fate test with asan.

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
 libavformat/tests/imf.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Zhao Zhili May 19, 2023, 12:20 p.m. UTC | #1 
> On May 20, 2023, at 01:40, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> It breaks fate test with asan.
> 
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> ---
> libavformat/tests/imf.c | 2 ++
> 1 file changed, 2 insertions(+)
> 

It has already been fixed. Please drop the patch.
Pierre-Anthony Lemieux May 19, 2023, 3:19 p.m. UTC | #2 
On Fri, May 19, 2023 at 5:21 AM "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>
>
> > On May 20, 2023, at 01:40, Zhao Zhili <quinkblack@foxmail.com> wrote:
> >
> > From: Zhao Zhili <zhilizhao@tencent.com>
> >
> > It breaks fate test with asan.
> >
> > Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> > ---
> > libavformat/tests/imf.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> It has already been fixed. Please drop the patch.

https://github.com/FFmpeg/FFmpeg/commit/dbe43bca25b84f2c2f5f713eeff5ab2dae89fc25

>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavformat/tests/imf.c b/libavformat/tests/imf.c
index cfd84fb8c8..ee2ca375bf 100644
--- a/libavformat/tests/imf.c
+++ b/libavformat/tests/imf.c
@@ -596,6 +596,8 @@  int main(int argc, char *argv[])
     printf("#### The following should emit errors ####\n");
     if (test_bad_resource_cpl_parsing(&cpl) != 0)
         ret = 1;
+    else
+        ff_imf_cpl_free(cpl);
     printf("#### End emission of errors ####\n");
 
     return ret;