From patchwork Tue Dec 5 15:59:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 44933 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:9153:b0:181:818d:5e7f with SMTP id x19csp428886pzc; Tue, 5 Dec 2023 08:00:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyg0sgLOaG3fl4TzmJ2q1I4osj8UTCYjt2aS6cLSQQ4jT3N9TwmJKRH9OCGw2vSwpdthwf X-Received: by 2002:a17:906:1003:b0:a1d:3858:9c66 with SMTP id 3-20020a170906100300b00a1d38589c66mr26844ejm.171.1701792012058; Tue, 05 Dec 2023 08:00:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701792012; cv=none; d=google.com; s=arc-20160816; b=If9X55K0SeWhMkTDKwrA873necWReCT8Eo14x9TMcxSJxt/1wI73dD6GVzgYd0neQs IWVeRPWzjJg2wUkkTdfnAImQKs8pdl6Tagp2Yl7j66+WC3Dcc/gTp5OSYMPlhF94M/uH K5c/PW3YqbY2Ef0YSJa+f4Rmj8/5jDgVAiZwWFmG8YBTyw1QO3Ir6/LW8EkzWKBW8Ljh FlzpklRkwszQTiJtFYzJbe4lYOdNQBp3y5qStu4rUjIvCNO/s05ryIuNyaJx1lDFm5A4 kYIb+5FF5GwZ4NdGwMGcq+izaPUgrUyvdor/JlLaKXtlyJfRcWKeyL95qwa3jE0aKzmR g4gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=G8vjolzsL6ulMjaUSYbht5gFyvs9619Jz7UaKWRTo5I=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=H1h3IS14g826dXCEQ4hR0tVAseKj9mc00WwqqkiLAXG4QCm4K3+SJO8jIVCcJecq5p THxB5smeXYE3GNwCjuuLe+h3tIdriDxfknTzfpUyUdeUvSSyHhTRwjClGODcW6V9B03V CFuCAFpRw3yerhbdiH4IonJR3HX3q5hfGV/karNni+2YiFbi0IkjqL4meX05ovBA5nz9 6nADzvRNINlSMzhQ1u9eO3Mu6Ljdvs2QnjpjuuyTZH4ww2uqJXvv5x8K9q8Vo+XoyI7R GvkYw6s3leZ+XE7jEPhJs2nTOAl0zG9CdbGgPB5uQDbGZSgOx5/OljsJ0CauiFb11uHO 410A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id oz30-20020a1709077d9e00b00a1c4138695dsi791395ejc.503.2023.12.05.08.00.11; Tue, 05 Dec 2023 08:00:12 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B67FE68CC45; Tue, 5 Dec 2023 18:00:07 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C51D268CA7F for ; Tue, 5 Dec 2023 18:00:00 +0200 (EET) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 0DCCFC00C0 for ; Tue, 5 Dec 2023 17:59:59 +0200 (EET) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 5 Dec 2023 17:59:59 +0200 Message-ID: <20231205155959.64778-1-remi@remlab.net> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] riscv: test for assembler support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: z3hvZic59srT This should fix the build on LLVM 16 and earlier, at the cost of turning all non-RVV optimisations off. --- Makefile | 6 +++--- configure | 5 ++++- ffbuild/arch.mak | 1 + libavcodec/riscv/Makefile | 16 ++++++++-------- libavcodec/riscv/ac3dsp_init.c | 2 ++ libavcodec/riscv/audiodsp_init.c | 2 ++ libavcodec/riscv/bswapdsp_init.c | 2 ++ libavcodec/riscv/pixblockdsp_init.c | 2 ++ libswscale/riscv/Makefile | 2 +- libswscale/riscv/rgb2rgb.c | 2 ++ tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 2 +- tests/checkasm/checkasm.h | 5 ++++- 13 files changed, 33 insertions(+), 16 deletions(-) diff --git a/Makefile b/Makefile index 78652c47bd..2fc3e538c1 100644 --- a/Makefile +++ b/Makefile @@ -93,10 +93,10 @@ ffbuild/.config: $(CONFIGURABLE_COMPONENTS) SUBDIR_VARS := CLEANFILES FFLIBS HOSTPROGS TESTPROGS TOOLS \ HEADERS ARCH_HEADERS BUILT_HEADERS SKIPHEADERS \ ARMV5TE-OBJS ARMV6-OBJS ARMV8-OBJS VFP-OBJS NEON-OBJS \ - ALTIVEC-OBJS VSX-OBJS RVV-OBJS MMX-OBJS X86ASM-OBJS \ + ALTIVEC-OBJS VSX-OBJS MMX-OBJS X86ASM-OBJS \ MIPSFPU-OBJS MIPSDSPR2-OBJS MIPSDSP-OBJS MSA-OBJS \ - MMI-OBJS LSX-OBJS LASX-OBJS OBJS SLIBOBJS SHLIBOBJS \ - STLIBOBJS HOSTOBJS TESTOBJS + MMI-OBJS LSX-OBJS LASX-OBJS RV-OBJS RVV-OBJS \ + OBJS SLIBOBJS SHLIBOBJS STLIBOBJS HOSTOBJS TESTOBJS define RESET $(1) := diff --git a/configure b/configure index d77c053226..7d2ee66000 100755 --- a/configure +++ b/configure @@ -2154,6 +2154,7 @@ ARCH_EXT_LIST_PPC=" " ARCH_EXT_LIST_RISCV=" + rv rvv " @@ -2679,7 +2680,8 @@ ppc4xx_deps="ppc" vsx_deps="altivec" power8_deps="vsx" -rvv_deps="riscv" +rv_deps="riscv" +rvv_deps="rv" loongson2_deps="mips" loongson3_deps="mips" @@ -6243,6 +6245,7 @@ elif enabled ppc; then elif enabled riscv; then + enabled rv && check_inline_asm rv '".option arch, +zbb\nrev8 t0, t1"' enabled rvv && check_inline_asm rvv '".option arch, +v\nvsetivli zero, 0, e8, m1, ta, ma"' elif enabled x86; then diff --git a/ffbuild/arch.mak b/ffbuild/arch.mak index 39d76ee152..23a3feb090 100644 --- a/ffbuild/arch.mak +++ b/ffbuild/arch.mak @@ -15,6 +15,7 @@ OBJS-$(HAVE_LASX) += $(LASX-OBJS) $(LASX-OBJS-yes) OBJS-$(HAVE_ALTIVEC) += $(ALTIVEC-OBJS) $(ALTIVEC-OBJS-yes) OBJS-$(HAVE_VSX) += $(VSX-OBJS) $(VSX-OBJS-yes) +OBJS-$(HAVE_RV) += $(RV-OBJS) $(RV-OBJS-yes) OBJS-$(HAVE_RVV) += $(RVV-OBJS) $(RVV-OBJS-yes) OBJS-$(HAVE_MMX) += $(MMX-OBJS) $(MMX-OBJS-yes) diff --git a/libavcodec/riscv/Makefile b/libavcodec/riscv/Makefile index 2d0e6c19c8..74381e3648 100644 --- a/libavcodec/riscv/Makefile +++ b/libavcodec/riscv/Makefile @@ -1,14 +1,14 @@ OBJS-$(CONFIG_AAC_DECODER) += riscv/aacpsdsp_init.o riscv/sbrdsp_init.o RVV-OBJS-$(CONFIG_AAC_DECODER) += riscv/aacpsdsp_rvv.o riscv/sbrdsp_rvv.o -OBJS-$(CONFIG_AC3DSP) += riscv/ac3dsp_init.o \ - riscv/ac3dsp_rvb.o +OBJS-$(CONFIG_AC3DSP) += riscv/ac3dsp_init.o +RV-OBJS-$(CONFIG_AC3DSP) +=riscv/ac3dsp_rvb.o OBJS-$(CONFIG_ALAC_DECODER) += riscv/alacdsp_init.o RVV-OBJS-$(CONFIG_ALAC_DECODER) += riscv/alacdsp_rvv.o -OBJS-$(CONFIG_AUDIODSP) += riscv/audiodsp_init.o \ - riscv/audiodsp_rvf.o +OBJS-$(CONFIG_AUDIODSP) += riscv/audiodsp_init.o +RV-OBJS-$(CONFIG_AUDIODSP) += riscv/audiodsp_rvf.o RVV-OBJS-$(CONFIG_AUDIODSP) += riscv/audiodsp_rvv.o -OBJS-$(CONFIG_BSWAPDSP) += riscv/bswapdsp_init.o \ - riscv/bswapdsp_rvb.o +OBJS-$(CONFIG_BSWAPDSP) += riscv/bswapdsp_init.o +RV-OBJS-$(CONFIG_BSWAPDSP) += riscv/bswapdsp_rvb.o RVV-OBJS-$(CONFIG_BSWAPDSP) += riscv/bswapdsp_rvv.o OBJS-$(CONFIG_EXR_DECODER) += riscv/exrdsp_init.o RVV-OBJS-$(CONFIG_EXR_DECODER) += riscv/exrdsp_rvv.o @@ -34,8 +34,8 @@ OBJS-$(CONFIG_LLVIDENCDSP) += riscv/llvidencdsp_init.o RVV-OBJS-$(CONFIG_LLVIDENCDSP) += riscv/llvidencdsp_rvv.o OBJS-$(CONFIG_OPUS_DECODER) += riscv/opusdsp_init.o RVV-OBJS-$(CONFIG_OPUS_DECODER) += riscv/opusdsp_rvv.o -OBJS-$(CONFIG_PIXBLOCKDSP) += riscv/pixblockdsp_init.o \ - riscv/pixblockdsp_rvi.o +OBJS-$(CONFIG_PIXBLOCKDSP) += riscv/pixblockdsp_init.o +RV-OBJS-$(CONFIG_PIXBLOCKDSP) += riscv/pixblockdsp_rvi.o RVV-OBJS-$(CONFIG_PIXBLOCKDSP) += riscv/pixblockdsp_rvv.o OBJS-$(CONFIG_UTVIDEO_DECODER) += riscv/utvideodsp_init.o RVV-OBJS-$(CONFIG_UTVIDEO_DECODER) += riscv/utvideodsp_rvv.o diff --git a/libavcodec/riscv/ac3dsp_init.c b/libavcodec/riscv/ac3dsp_init.c index 20f294f1de..92678ea810 100644 --- a/libavcodec/riscv/ac3dsp_init.c +++ b/libavcodec/riscv/ac3dsp_init.c @@ -29,10 +29,12 @@ void ff_extract_exponents_rvb(uint8_t *exp, int32_t *coef, int nb_coefs); av_cold void ff_ac3dsp_init_riscv(AC3DSPContext *c) { +#if HAVE_RV int flags = av_get_cpu_flags(); if (flags & AV_CPU_FLAG_RVB_ADDR) { if (flags & AV_CPU_FLAG_RVB_BASIC) c->extract_exponents = ff_extract_exponents_rvb; } +#endif } diff --git a/libavcodec/riscv/audiodsp_init.c b/libavcodec/riscv/audiodsp_init.c index 9ab59c011e..f606406429 100644 --- a/libavcodec/riscv/audiodsp_init.c +++ b/libavcodec/riscv/audiodsp_init.c @@ -33,6 +33,7 @@ void ff_vector_clipf_rvv(float *dst, const float *src, int len, float min, float av_cold void ff_audiodsp_init_riscv(AudioDSPContext *c) { +#if HAVE_RV int flags = av_get_cpu_flags(); if (flags & AV_CPU_FLAG_RVF) @@ -47,4 +48,5 @@ av_cold void ff_audiodsp_init_riscv(AudioDSPContext *c) c->vector_clipf = ff_vector_clipf_rvv; } #endif +#endif } diff --git a/libavcodec/riscv/bswapdsp_init.c b/libavcodec/riscv/bswapdsp_init.c index ed666c9b3a..d490c434e7 100644 --- a/libavcodec/riscv/bswapdsp_init.c +++ b/libavcodec/riscv/bswapdsp_init.c @@ -30,6 +30,7 @@ void ff_bswap16_buf_rvv(uint16_t *dst, const uint16_t *src, int len); av_cold void ff_bswapdsp_init_riscv(BswapDSPContext *c) { +#if HAVE_RV int flags = av_get_cpu_flags(); if (flags & AV_CPU_FLAG_RVB_ADDR) { @@ -42,4 +43,5 @@ av_cold void ff_bswapdsp_init_riscv(BswapDSPContext *c) c->bswap16_buf = ff_bswap16_buf_rvv; #endif } +#endif } diff --git a/libavcodec/riscv/pixblockdsp_init.c b/libavcodec/riscv/pixblockdsp_init.c index 3c623a9473..0584100cfc 100644 --- a/libavcodec/riscv/pixblockdsp_init.c +++ b/libavcodec/riscv/pixblockdsp_init.c @@ -45,6 +45,7 @@ av_cold void ff_pixblockdsp_init_riscv(PixblockDSPContext *c, AVCodecContext *avctx, unsigned high_bit_depth) { +#if HAVE_RV int cpu_flags = av_get_cpu_flags(); if (cpu_flags & AV_CPU_FLAG_RVI) { @@ -69,4 +70,5 @@ av_cold void ff_pixblockdsp_init_riscv(PixblockDSPContext *c, c->diff_pixels = ff_diff_pixels_rvv; } #endif +#endif } diff --git a/libswscale/riscv/Makefile b/libswscale/riscv/Makefile index 7b371d5a86..48afaf62aa 100644 --- a/libswscale/riscv/Makefile +++ b/libswscale/riscv/Makefile @@ -1,3 +1,3 @@ OBJS += riscv/rgb2rgb.o -OBJS += riscv/rgb2rgb_rvb.o +RV-OBJS += riscv/rgb2rgb_rvb.o RVV-OBJS += riscv/rgb2rgb_rvv.o diff --git a/libswscale/riscv/rgb2rgb.c b/libswscale/riscv/rgb2rgb.c index 4fa1f5afd9..e751e11075 100644 --- a/libswscale/riscv/rgb2rgb.c +++ b/libswscale/riscv/rgb2rgb.c @@ -42,6 +42,7 @@ void ff_yuyvtoyuv422_rvv(uint8_t *ydst, uint8_t *udst, uint8_t *vdst, av_cold void rgb2rgb_init_riscv(void) { +#if HAVE_RV int flags = av_get_cpu_flags(); #if (__riscv_xlen == 64) @@ -61,4 +62,5 @@ av_cold void rgb2rgb_init_riscv(void) } } #endif +#endif } diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 53742c93ae..2dda1f655b 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -68,7 +68,7 @@ CHECKASMOBJS-$(CONFIG_AVUTIL) += $(AVUTILOBJS) CHECKASMOBJS-$(ARCH_AARCH64) += aarch64/checkasm.o CHECKASMOBJS-$(HAVE_ARMV5TE_EXTERNAL) += arm/checkasm.o -CHECKASMOBJS-$(ARCH_RISCV) += riscv/checkasm.o +CHECKASMOBJS-$(HAVE_RV) += riscv/checkasm.o CHECKASMOBJS-$(HAVE_X86ASM) += x86/checkasm.o CHECKASMOBJS += $(CHECKASMOBJS-yes) checkasm.o diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 0a1285eca4..636dac5ad5 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -738,7 +738,7 @@ int main(int argc, char *argv[]) if (have_vfp(av_get_cpu_flags()) || have_neon(av_get_cpu_flags())) checkasm_checked_call = checkasm_checked_call_vfp; #endif -#if ARCH_RISCV +#if ARCH_RISCV && HAVE_RV struct sigaction act = { .sa_handler = checkasm_handle_signal, .sa_flags = 0, diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h index 11d2f7286f..749073d946 100644 --- a/tests/checkasm/checkasm.h +++ b/tests/checkasm/checkasm.h @@ -217,7 +217,7 @@ void checkasm_set_function(void *, sigjmp_buf); void *checkasm_get_wrapper(void); void checkasm_handle_signal(int signum); -#if (__riscv_xlen == 64) && defined (__riscv_d) +#if HAVE_RV && (__riscv_xlen == 64) && defined (__riscv_d) #define declare_new(ret, ...) \ int checked_call_signum = 0; \ sigjmp_buf checked_call_jb; \ @@ -227,6 +227,9 @@ void checkasm_handle_signal(int signum); (checked_call_signum = sigsetjmp(checked_call_jb, 1)) == 0 \ ? checked_call(__VA_ARGS__) \ : (checkasm_fail_signal(checked_call_signum), 0)) +#else +#define declare_new(ret, ...) +#define call_new(...) ((func_type *)func_new)(__VA_ARGS__) #endif #else #define declare_new(ret, ...)