From patchwork Wed Dec 20 12:42:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 45263 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5184:b0:194:e134:edd4 with SMTP id j4csp187724pzf; Wed, 20 Dec 2023 04:43:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4HTcT/HFw56ej3uGITn819ZqGJBi4zu06HtIsEa20tMb9oRfy4WUbvlOyIsBn4bDswK8G X-Received: by 2002:a05:6512:239a:b0:50e:4ec6:ed15 with SMTP id c26-20020a056512239a00b0050e4ec6ed15mr1043742lfv.107.1703076183682; Wed, 20 Dec 2023 04:43:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703076183; cv=none; d=google.com; s=arc-20160816; b=b/sMrNwGiOXtnkIbn7pMqVOa75ZrnGIoFIH4jSjMBZcFsEgb0cXsf+TTiMkffZbuDj t7zzPj+Y6q7aygZg0PijEIrqai+cc7ZhvO6noMu2/rItL5+KAIiTSPV09p+WLoi40OZa lcqcv72RtLA3IY1Iz0orwwzGN0Mv8YpBttWn35YPM+uJQEbI3kvo8OVuoBq9ute+jd+I ax43ZZHB3w5z6gkwlnQUPelIZBJvhilTu9ruy/FzT9dugqyNAtVpxQCcVMuQVsloI6p8 s3juq+OF772qE5J5gOS9G7g35I+5y/x5HADfY9Mw9COYgCjcbXD/iv1HBcTdlsyob0mD m7MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=5g9FwG/6WN/kFV6BeZ+umoXSgG8BoGC/rm4OaGPFh10=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=TD/+aU4GklVOU+DG49Fns10/fMpVAvb+g4iB59/7VEH7SA1pF88OtQshBc6lpYKrZt 5extHodkjigMT8PZRJ3L1XVRbHiTJCUodtN4JO6W7JlYxh1aFFe5Y9qI4V192PRZAqqW jzkrld1F2TgQtix9MrYbs/buou6h6f1XID9YLPnYPjnJnxFp66dK9jLad5yl2hRAfef6 HbEs63Hp5xG0eTGJpMk2UBJbOIhYaVmYtejzR3rCqDtdeYugClcab2nVXEdw7EZ40/Vz ud47lNoeREPnyWFV1ndwwIv1b4EOdFgXhxWcufcR+zGB2waQ+raxPT7Nww8lCV8ToXlV B+Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20230601.gappssmtp.com header.s=20230601 header.b=TEMJRjk9; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x25-20020a170906135900b00a232c41d6edsi3601053ejb.597.2023.12.20.04.43.02; Wed, 20 Dec 2023 04:43:03 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20230601.gappssmtp.com header.s=20230601 header.b=TEMJRjk9; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2ECAD68D212; Wed, 20 Dec 2023 14:42:59 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DCA9D68D181 for ; Wed, 20 Dec 2023 14:42:51 +0200 (EET) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2cc6d9b4c6aso44369871fa.3 for ; Wed, 20 Dec 2023 04:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1703076171; x=1703680971; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=IOOUPkmXK4pPBBj1GYhFbyQu8FI3vIItUPb9IzczmEU=; b=TEMJRjk9n3UVEaefznaOkXWKl3+ZISpeu3mC4kxJLZfc6tt5r6H5GNnl5aHqLNjWNm tExfn658Go7JX8+F7wF8BbF93ffqHfIWVrmpDr3BL+zgHomavoceDzq2aJpd+zZD6n3I lBtQlnGwPaQcjw1CF6VSHO34lfkbLd3kw+FYvbswhbWgMss9rmYMWwrGkp7+iUYiGkgl jOIgWv/WItwWkTppQ49L5Qb85jWOzfqU5msuDhVPloAFDtoj7Ygo6rgdFA1dOMdnIn6N 6WK17U76N5cWVfPsdfTly/ZeGkx+05IEl3iARAe4b9Etje+TN+jGTiRDGok9OINzfJMt 6t/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703076171; x=1703680971; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IOOUPkmXK4pPBBj1GYhFbyQu8FI3vIItUPb9IzczmEU=; b=hi8WWV2WNVbpKsuD9JVmNbamlUzyUWwUhUpsIr6KF8Jq6O17iexWtbn88d+4wVI5K1 DwIAUtqc4F6AN6N/A1C+h2x8qDnZI7KCiYD6A8gShUbUTfaHwRjVVn6/rrh6NDb5cKFu w8lJ+bnRm0tcF7UrhJ07FSpmBV+OnYMgAC/2R7wm+BlEvbrtm/482ojTnjxRz4mZda6v SvN7nN7HNdKdxrwMoFb2MHTz4PxBUjdmANVN/pr7X9lAg8JfRNWeW9GZ+DJe485Svm6y hufUe30ySvleXlA8ISM+6I0tFz3S2pgpSzhT6TIXV3G4DWLxKPzuliSCG+tZ/5YrkrZC Hbog== X-Gm-Message-State: AOJu0YxQJjDPCkKKaRWUEE/zyM/VU5/T9PcorIDWJ7xmP6R3mAJ6kxcL qG/pBzh+bsFNGeg9mM1BCfBagsZQd6JeLp1nMQXuJw== X-Received: by 2002:a2e:9792:0:b0:2cc:2fd5:dd2d with SMTP id y18-20020a2e9792000000b002cc2fd5dd2dmr100916lji.15.1703076170839; Wed, 20 Dec 2023 04:42:50 -0800 (PST) Received: from localhost (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id z5-20020a2ebcc5000000b002cc540b56f9sm1751839ljp.3.2023.12.20.04.42.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 04:42:50 -0800 (PST) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 20 Dec 2023 14:42:48 +0200 Message-Id: <20231220124248.2816809-1-martin@martin.st> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] configure: Disable inline assembly with nonlocal labels with LTO on Clang on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ayZI9IWfs8dB The file libavcodec/x86/mlpdsp_init.c uses inline assembly with nonlocal labels that are referenced outside of the assembly in C. This fails to link with LTO when built with Clang when targeting Windows. The root cause has been reported upstream at https://github.com/llvm/llvm-project/issues/76046. Fixes: https://trac.ffmpeg.org/ticket/10548 --- configure | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/configure b/configure index 7742ea4ba2..b4f7c2de66 100755 --- a/configure +++ b/configure @@ -7372,6 +7372,16 @@ if [ -n "$lto" ]; then check_cflags $lto check_ldflags $lto $cpuflags disable inline_asm_direct_symbol_refs + if test "$cc_type" = "clang"; then + # Clang's LTO fails on Windows, when there are references outside + # of inline assembly to nonlocal labels defined within inline assembly, + # see https://github.com/llvm/llvm-project/issues/76046. + case $target_os in + mingw32|win32) + disable inline_asm_nonlocal_labels + ;; + esac + fi fi enabled ftrapv && check_cflags -ftrapv