From patchwork Wed Jan 3 15:52:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuo Mi X-Patchwork-Id: 45461 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6623:b0:194:e134:edd4 with SMTP id n35csp7338471pzh; Wed, 3 Jan 2024 07:53:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5XT0FdU2wbu0QiBIeip/xMaykn9Fa5B6+ZIHax6bor8mr0V8Jpf6HV/tAce1xdNjxBIVI X-Received: by 2002:a50:8d55:0:b0:556:c872:188e with SMTP id t21-20020a508d55000000b00556c872188emr622461edt.69.1704297201166; Wed, 03 Jan 2024 07:53:21 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g32-20020a056402322000b005546ff2dcf3si10314520eda.141.2024.01.03.07.53.20; Wed, 03 Jan 2024 07:53:21 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="u4hf8p/C"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0BD1668C4DD; Wed, 3 Jan 2024 17:53:18 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01olkn2093.outbound.protection.outlook.com [40.92.53.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4478E68C4DD for ; Wed, 3 Jan 2024 17:53:11 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MEpHSRXxVrZNdNeVByEa91/GzlusQfUvDS6p+MEQb99AarwOXhtNMX5Kazq87yXDM3Pc7t/1fGp8kW+rx0oDHf8VMg7HhBO+p8hsrIaaCyagKy8cIknwfc0uanGw+aEsqKXkAEnqjyqScILww/vy/jrWwd9OVGyjIKF8mrXbmcMUfBkaalHT5HeX3Pw5YLdlTKX5Cu6bV6C8kzshYsKOQFnA0x2aBqMxjztZULdhlNkBnM3ukHpyGgExWgVugZPFnuPBMrbxFEroRAQjujwGiQ2REDXkuxLH6VX7lUJlDF4/16Mq4dcXVtKQ68a5/fBl8Th3LKxJCsntgnELNcT3rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LHPNMoPOmBQHbsyTeZOKC8KirzzGidRHfhds5kFEPHw=; b=eeOUbvuWZ5/7gPj+Ot+ONcMDUBwRijUVu+fg9seVg9eNfCOu7l8hyWDDqlJmPXSujtjwamcJ4y1znMLpzLefhQUmcdZ9JVEbyrW7yMBXXbf51U2RNHEr1cGFyjxYeTtKvNwtKKLRCveVqP/isbzCtRzVB5VQxOXb3hiOu924QwV0SXlSAIfW7lWEF2sSlvP/RSg1p0DkeWdNl46uVRPEdBZZQ/lr9sj/LSakMtHSG1ptu9hCNJFphgnTb2+LnqGi/L+gTvAVl6//sz11YifmM0vSiYDa5Ss6tkKa2U/opL/mLfy6vSfD1UgSHFlXYaEwmXlwpTBe+6DExpxjwKxQoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LHPNMoPOmBQHbsyTeZOKC8KirzzGidRHfhds5kFEPHw=; b=u4hf8p/C/scNcVz3pk596HU1XZvzzciaRt7MwY/vcrFdahNU977Ce0/cOpjRt2DC3KsrrbpYiMByfh4hl0eGr5f/jfO7gkpIguCZ53jh0bRqGjTBqkarnEHyPiQn3UNoaX6QE1XbgjiwJF/IOkrrhsXNlztUEcY+uJsemSAfbDHRZCDN7ZPt5kQaNuq6wik45nE89H7ZXLanA4qraTCzIlmUrwZpDccilf/aYx7Oc5Ia0/y8EYMwtXAsjWN0bHyQ/RR2OOMyUfw75uwI31wHEA7AFEBNcpgqP9KDCxy4cmXOU+O9esw19Od/XSQUNaPp6HRWhEY+ONjSUbZbeD9Jhg== Received: from TYSPR06MB6433.apcprd06.prod.outlook.com (2603:1096:400:47a::6) by JH0PR06MB6836.apcprd06.prod.outlook.com (2603:1096:990:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 15:53:06 +0000 Received: from TYSPR06MB6433.apcprd06.prod.outlook.com ([fe80::e139:fd7a:1b66:a3f7]) by TYSPR06MB6433.apcprd06.prod.outlook.com ([fe80::e139:fd7a:1b66:a3f7%7]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 15:53:05 +0000 From: Nuo Mi To: ffmpeg-devel@ffmpeg.org Date: Wed, 3 Jan 2024 23:52:52 +0800 Message-ID: X-Mailer: git-send-email 2.25.1 X-TMN: [4UfP4Xz4IUpak7LR5yyvFN/75qxZjVOt] X-ClientProxiedBy: SG2PR02CA0012.apcprd02.prod.outlook.com (2603:1096:3:17::24) To TYSPR06MB6433.apcprd06.prod.outlook.com (2603:1096:400:47a::6) X-Microsoft-Original-Message-ID: <20240103155252.19740-1-nuomi2021@gmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 2 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYSPR06MB6433:EE_|JH0PR06MB6836:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a117248-2a05-47f3-a079-08dc0c74130b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hg7wOGA/uoujd7FHkZvkToSuQxLqe+miYlGuqqKE0JWwEYsK+wBZTr+Cqp/UKJxcncNOLLsTJOgNr6oWq7wA+9WsnVJX92xP7AJQqFYqmfIEq0KuI29+8uzY5AszDeDBitHB9OeqjhMmufRTNtnNd43ECjsguMxAj9Z8JFuL+pP8O0w538fN9PuXWvrBzjK/LGURDKIYScNzeTnBWybiGjURX9EEHN1tXs4vGEi9vUNk8qhqtGFCiLsjKyt+wL6+KTVZ9Gj2eaxgSCqbFvAr28MOexqA+Mvyn+UJF/PVXOV390xScmyzQXvyjK+GEXC4NHJunnpiE2Q3Xou6EeDpOpZ0hPvwJyV+ZFVqEVQrZ1HrfJedEiT5eIkli7Yi3aXhwGq5ippiFJxKGgNtVfDnMSJce6JsAmZpYRSGP1VCjzFWg7LYNznMr73sRscK1aseQ4+Cxd9hUZoIBBIX1JUVIXu3K2lIXb7M2gKwR1vM2RheiNAcLdhzjtUa5k1FlWw1OrU5KZFoYj+ZQAq9423P0ylKRvhbnh/45RMpb0JEGgUkV1nR9jNzDurCshQLnGRiftWLI1zKh2/QjHIo490CBn1Up9Fdkfb2Gk0rsYysqbxwW+49rHqMJLESG/LfvZnh X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: eQC06XiwglODX+3C7HnH1QLIv1o1A4TKUu+8HaC4aaUGQOsnPWWUpdIJ7N3FqRvYiHRMFqDvMHSeB1VPeOBtO+MoOEe5qxBL3SKzhv0GqhmlNcMHL9aJ/wZyh39m7YUFHWS7I1wVRe3cAtlWE86agCUouYZN8epkoUhZf0W2aRY4NrEsmvQUrZPKJCpgUWraGpw4YOyZoj1ow68BgC+SmA4oi4XB0wkMw5r4C/Bzqiy2BAT3QW2hLuxvhpdm62Qhn4BXT4XYLRTXZX3bq7oGVka2c6+DttV69EvQxbbL5QMes4WLsZzl6BgaDkxc6z622rWUkAV58+lmkiX0er/hKaCKsIF8udvNU6UDGB6q+D+QaHeJoZg4aaJeNlVZVYNTGFiUkLdCjvlBafx1zc+L6ylm69PaOAqKpjUohhsxuOfC1q9+a/9s1ZCmUyfNIoCXj4M0bkswdMHxJCkqcfXXafx9X/+Xqgb3WUw14jwBzEfRmY4hauwt21iT+toiVU8foz2L6uJotpq/4Kwye4eHnUvQTETv741l6pJ28QMV2WfvF0U0BwKV9QR9sfOtZ4HiDc2xI7PEfj58lM5xK5vY5VqjUsnrZjKK9OGXYKWAFMCCjJq2W3b52SqebofRK6UFIjuCaBozGWOPcPYtVA/9YR/KKy/Gd9fy8cKuPaoQM0O9LxLuEKFBvyaBTpsGm1uhnozgZSOvvE5A7fvTM3Xc7LsBE5OBvAlzEsfELyKk1EntNrUF7TtcphEMcpJQnyI9pbabs5QU/mQ7XBUalnonFHUrqCiUQ5X0Kn1FUGJABndfMDfExtJipseQwzuX3g474paPyY7eg8+PIqGysjfUPoWm9rj0wv+LEWBp+wb50VOKGo7Iw55jlBFysLwdrP9pQCbmYeW5mSQVV2Qx4JWe0Fge1ylN587jdxfor5jd3PUSEITOhVvRH5CUz0qyl39GzGidpI/HXagkgQdzrwO072vO/dre93EtCTYMJ74Er+WQO235fXChQA2Np/bxBJtb1Y14+vVsyU9X7vRpSQT4BcLDH/dIgTAE3yJ1vjRAO0qDdzeVo+0J3iQbSUtuL756J8um2noYbMb6MwjDg8lQ39CFF/qcYVbty6tOKAi/bDMzcW+Pvo+ufSpaVzgDraVyPv5ofw+MYizwtl0ZVKaV9uH3sXGM8K2jTfnvBZdbWYdZETW6sCobNovh+KKnl9tZeXe22txQ9Ro4m8uCoUBYI7ebQDcmtmyZNlGpttomxDawaNMEaiFF/omBRAIfihQW X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a117248-2a05-47f3-a079-08dc0c74130b X-MS-Exchange-CrossTenant-AuthSource: TYSPR06MB6433.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 15:53:05.7991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6836 Subject: [FFmpeg-devel] [PATCH] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nuo Mi Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: BpU/PJAhR9O+ Thanks for the suggestion from Lynne. --- libavcodec/vvc/vvc_intra.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c index 43de312a71..214ad38c8c 100644 --- a/libavcodec/vvc/vvc_intra.c +++ b/libavcodec/vvc/vvc_intra.c @@ -552,6 +552,8 @@ static void itransform(VVCLocalContext *lc, TransformUnit *tu, const int tu_idx, if (chroma_scale) fc->vvcdsp.intra.lmcs_scale_chroma(lc, temp, tb->coeffs, w, h, cu->x0, cu->y0); + // TODO: Address performance issue here by combining transform, lmcs_scale_chroma, and add_residual into one function. + // Complete this task before implementing ASM code. fc->vvcdsp.itx.add_residual(dst, chroma_scale ? temp : tb->coeffs, w, h, stride); if (tu->joint_cbcr_residual_flag && tb->c_idx)