From patchwork Mon Feb 19 13:37:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 46367 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:dda5:b0:19e:cdac:8cce with SMTP id kw37csp1259465pzb; Mon, 19 Feb 2024 05:35:49 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWINumLahtNpwQzNKvumR6y1dPLqUIgoaOan6NKGDzGsLJbGIAj8xG9UjPZWeqD6ZSln1mzwqRacZpFuAIbq4a+uGs6Jt58edXFWA== X-Google-Smtp-Source: AGHT+IEILvocNFmE0+MSoUgjzn0U522ZFwBQPMGlSjUE+KMuWjGSdOiaLy5PVz8PNF4lAmt6/8Qa X-Received: by 2002:a17:906:f9d4:b0:a3e:d504:a46b with SMTP id lj20-20020a170906f9d400b00a3ed504a46bmr713461ejb.26.1708349748956; Mon, 19 Feb 2024 05:35:48 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id nb16-20020a1709071c9000b00a3ed1f9b51dsi253530ejc.501.2024.02.19.05.35.48; Mon, 19 Feb 2024 05:35:48 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=DyRT0dMQ; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8F81068D225; Mon, 19 Feb 2024 15:35:44 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2085.outbound.protection.outlook.com [40.92.90.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 115B068D225 for ; Mon, 19 Feb 2024 15:35:38 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6MdNbgjLYBy9gDLn4ZjZ9lmHER2PDxweB1jdqnh/Zp2c1aOpc9fDlKcdxSRq6wMvtKdIVMW7qQfWYyg8SxS+0RS1FlC2YfkQo0UIW3wPqc1xadxqvMswmR4b+kcztfduFDZ4ENf4N0JgIbTmWT1UXd7hVkUtpZ+oqU6EauaE8wOfGmw6cx8W2hwqKtoavcMqGtMNwxEVpUhswaexusnyizcj31JSXQOPJGhdxqjrNU72Omp4wdKJVYOFfUGo8p4a9A8v0ey8xDcOrZG8kSoSi3o+XUlprxU1Ur8zydeXDyDtbtsRN88iuznF2WEljRFBXRj3S90+MehDXl9feqrNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yejGwFlRVb3+WPu2qcFm3wcQqNkUhiMtpPqzSIdyfCk=; b=US/Pxkzglsx2VLMK3o6sfEgCiGvOzJuWIdpCrTW91Y892EHUfBZiVNFTAnnbWaOJs2vrqpUCKeduGKBXjXLK4xsLaQXwr+CzUhrrmF8uVoCNTT3tfn2yyejh+2nc53uysukhY+FSau8/VUfEW/qkt5enquHwY8oq5tW/I8ljjx4M7aFhW/XkEBe3sQiERKA3hIiPbVod/o4JV8u92ne5/yUjvZHAx24azaBeVTS98ATMM7E3hVBjV1Xhs1RMUC/EodZS2m6rJCdLd8Xn5n0jYMO1E/76uAgDa2ee4toZ7dHEu1B2uS1pIVBpzaUtdMix0Zyo3KNXVKtxpSV0jWQO4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yejGwFlRVb3+WPu2qcFm3wcQqNkUhiMtpPqzSIdyfCk=; b=DyRT0dMQm1GN5QHbhWnlnSdU2/hEkAWNgFLEr/qKsEe57gutMbW2lCv8BPHSEnnjUtnMqEQwUz7EYIl9NZltJr42Y/knvpZkd5dc/ou6xBAQFFIQtDeWT6g9sD9QpQIAhj32bU+WJTmjQGEnVDrp9mAJ4gKpDWJm5JgOTWvlYSBueF5N64Bf5p+htX1NNPi+JHT2/b30p0HQVHg4xmWL2oa3HcN5fb68iXQyO09ehzBqqy+Q34kM9cV2iXPOJp0/WmnnygSh7lOCoCKv0i6301avfceLubyPG3BTxNywpoqLjtu14r4y1Zu7NKW5mV4j3xYjd2BBg4+974PT3F63nw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0145.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:272::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.38; Mon, 19 Feb 2024 13:35:35 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7292.033; Mon, 19 Feb 2024 13:35:35 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 19 Feb 2024 14:37:26 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [PhtxiCHRMQYNFiD/zJ1tpbmrbesllofGac1AMLWwlmM=] X-ClientProxiedBy: ZR0P278CA0062.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240219133726.532421-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0145:EE_ X-MS-Office365-Filtering-Correlation-Id: 7862b95b-7963-47cf-dab2-08dc314fa6f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jIZcna5bLQ1Nul9Vh4OyBgPzFN6nQV39e4zQeph6ZE8crTmU04jomAl6T2JyHFnVXG3fwHo4ycOjWq90/SrClRgor2Q2lCR9EsgpUl0n04XXNmrvgkVH/EQgg9kK9FxXZc6uciCDdmYcOnTdDwc+62yl2v0FxxvY2P48M2PYztGm+1YEoGKWkc9/TxeEtAo2GMZvyBCMmyWtxdYCbHHJfTvVArUI21YtUKwF786xG6cxJYWbhGknwr3gwM6oXfnOLE2ZyxtuakS0ze6Ma5jSAWFPjdBiecMQB3EdDikhe+aTdi90BpRAct4pLx2q1XiZ6iFJQi4wP5XMF2gy2HTueVfPiELSU0rCpFrpLajKsITjRdY8tPVRFaNqWTM3ZBhmQ6CWyx6v8ZVQcpw73OCP6dlKwsemhCQKZynT14xlVTlqnr9udPMFDEn2UywpGyww0mMjpRsk3CNcc7q03X8a7D/FvhR2d8U1kkrZyL3PdW5lmNZvaqBT4ePIb7aFsaaExKg4DkD8Bzo2Lt6UPCmOtNYNyyUznzwtkMFpLj6Fe9uCCMGtOsBu5VRQotkm1A8k63rlce7aScyUrz/f0mnsFKqFCcpRpOeEHjaRUlJUn68Rl3hsxn6bPA9rcTZgxNRp X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SeMe/i9VTFR35ACZZysGZSL6lMs+YYJ8MYqEN4LDty4utJPdoKUs1jcfmaDudcnMx2qJfQqWz7eLIROFf6eHWT4kkFafud4WN2AdcI63eVPpA/CT6/NhhIbpaK8t34KL+zSjjpN0s4A3tGC65g/IDDyTKc51Kla9mY7wEha5iYgJrvjQdR6Le56tZWRxsSxbaSeg8PG6LvkXQISMjBaE9NqoWuMNSAjPkpomWV6CigS/wDx4TnohERg6GT6XeDZ62SjRz7yt9rn94ipCVOb+SjqsnIDOjxSjwi8Uu3/JIF/N0Zx4VSpgszSvwBHLu6MGyAFelbbyhgSboZvJSYkBoysn5A5bi+hlgPrJXpcYvipM5XWLRcq9KqqJlbkzyGal6DBXX9dGQ1afsVOUMBBVnlbsE7H05030Zq19weBU9QW24U/j32ju62GSd7X+D374KhSziHrpQIoK6JuiQ0BdH9mirD7cMoidIBK94U3gTeWferKEpYok44qNV7oafg3LnSr6EEgSN0DFSm3WNLv0kix+loEgtJYDrGXm5Eb50fvcvi+7e9PEUC6fGnQ8nMW0VEUg0XCmPgsEowpO1bZds5NROCeSt+MY2yX8LGxdX5ggjqInQlCmEid/sIGOwLkJ/ssDmC9u6SVl0AgcjKLG827hOOomHY07+Hw9czR3KRaLkxBW/TOZSv5m3QgGAvT7MXQYFf/7uTbMuKfdJfX6g6VFMvzAJ0ZDJHoBp664GoiPytt1n/liNqNdpyDsZax88fx9oFpYLGfv2RfdDTPNWnfxI3d4JLCUaDcFbH/XCYbzt7j2mthrdBdznF1YlfAPFU683OuPuRGOGEt2r8iPqO791tc4xkQjmucxLG9ApGEYemSD++onawpzD23HezJzNbfAbH2Quqbzs27T2lDjfBycgMjsck2hgUQr3OklZ/vWdBHWe49aj4CgysT++chqfZsRc7r+3GoGhzxKbOBHVVg3tF14hfx/IwnEuRhb/Xkcahqt/+qSMQCkZRZiah/UUbzjdkzm8pzsGgqKs14yacpLXbXPFYj3ayQ4d75+LZxiY3JUiVng5ieP/X4Clv23LLWF2zEMVXehdHx97/iNRJE+GmhD+Mx7/5wjfwFn4gpFVOX+RG3wPI7M7JE78OO+FRtPnWQjiRcPE4VNx+rodxCaIr90kWUhhJAE30wNVqbeY2V7pebDXaXGdcDjPPiRQW0jH2o9GztH9pubKiiUFK2S124L8NmYr2f8EpU0zvpm1aUlMdGioypbRyY2rYNx4Y9htQMVyxbkAiiasgy3Zg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7862b95b-7963-47cf-dab2-08dc314fa6f6 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 13:35:35.5328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0145 Subject: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: Don't leave out ... in calls to variadic macros X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: wbbJJbiWZL9B It is undefined behaviour (see C11, 6.10.3 (4); see also 14dd0a9057019e97ff9438f6cc1502f6922acb85). Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_vp8.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index eabdef358f..1f7e81cfe6 100644 --- a/libavcodec/cbs_vp8.c +++ b/libavcodec/cbs_vp8.c @@ -223,19 +223,19 @@ static int cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, GetBitContext *g #define SUBSCRIPTS(subs, ...) \ (subs > 0 ? ((int[subs + 1]){subs, __VA_ARGS__}) : NULL) -#define f(width, name) xf(width, name, 0) +#define f(width, name) xf(width, name, 0, ) // bool [de|en]coder methods. -#define bc_f(width, name) bc_unsigned_subs(width, DEFAULT_PROB, true, name, 0) -#define bc_s(width, name) bc_signed_subs(width, DEFAULT_PROB, name, 0) +#define bc_f(width, name) bc_unsigned_subs(width, DEFAULT_PROB, true, name, 0, ) +#define bc_s(width, name) bc_signed_subs(width, DEFAULT_PROB, name, 0, ) #define bc_fs(width, name, subs, ...) \ bc_unsigned_subs(width, DEFAULT_PROB, true, name, subs, __VA_ARGS__) #define bc_ss(width, name, subs, ...) \ bc_signed_subs(width, DEFAULT_PROB, name, subs, __VA_ARGS__) // bool [de|en]coder methods for boolean value and disable tracing. -#define bc_b(name) bc_unsigned_subs(1, DEFAULT_PROB, false, name, 0) -#define bc_b_prob(prob, name) bc_unsigned_subs(1, prob, false, name, 0) +#define bc_b(name) bc_unsigned_subs(1, DEFAULT_PROB, false, name, 0, ) +#define bc_b_prob(prob, name) bc_unsigned_subs(1, prob, false, name, 0, ) #define READ #define READWRITE read