From patchwork Fri Feb 23 19:08:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 46499 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c51b:b0:19e:cdac:8cce with SMTP id gm27csp88549pzb; Fri, 23 Feb 2024 11:21:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUhnBLkFJZyeixQuOD804zEng1XxzB5T6wGijlnUvavMWkVCnw7Rt/7XXJsKLZtMOEVvHApKH/gMu212tf3JisTw471+wFFZqUEBA== X-Google-Smtp-Source: AGHT+IFTGZj+kAsOlX50zu4Kzq4CE2f5x7PIXwJRNRqQKe38TnOt8HitZ5K6sY9nZYdzGACx52CZ X-Received: by 2002:a05:6512:484c:b0:512:9e5c:c849 with SMTP id ep12-20020a056512484c00b005129e5cc849mr378532lfb.68.1708716115992; Fri, 23 Feb 2024 11:21:55 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gs8-20020a1709072d0800b00a3e39a874dasi6216670ejc.889.2024.02.23.11.21.55; Fri, 23 Feb 2024 11:21:55 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=BmXMuNWG; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6489568C5EA; Fri, 23 Feb 2024 21:21:52 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2045.outbound.protection.outlook.com [40.92.74.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 00CAC68C05A for ; Fri, 23 Feb 2024 21:21:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KVfI1pVKwiZ4YekTIpR8NcmW2GyquJ8hG0aMhR34SPO4HpLVgo+faQsMQ7T9cLc9R+cybSH3tZv+IkbluJNWrTJ5U5ReBwN0Xl3rPLzTC3LtSk9KXRi0x9+wk1ypFWbrJS8P9jOitZfXEkWb2PWBWN39ttEJyzV9EqEMGceH4KTlkaR/uV2VGol673sD3mQp3WFq0xyLyWUVsXxLd3uEWf+cDg0chzHXplZJUmVs6fqTPVaniN2wpeZYrXjqJwi/MXz181PUEOEjCV4I/Np5EdW1dNfb6/JLu6dTmHML5Jwg+l4TFVe6yY3tpVMHZBQUZ/kCKf+eI1eaGceIEsDjcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMkvoXSYCDPycENHOigchd4FLF7sEKgkiMicweQBGOg=; b=oI3QgJc0PdVDu3okun6vR5Yegl3a2jugvaxRpfUjGXlVRnfVedtLmO4GLlhvzcoltFZ5bhCzIJtnAfWxnQwzr95q1V5FsOYljca+jIkByXkuqe/PRSEgwJn4WPeDyXaUPYtdRrvGWDTQofykGd5egCF3Hgm4QAC7E0EB0fjCfuSAqEdFYBu3wMLWpzKBZhhFy4TwezaS5L8WwDHvuxiMMkjdU/uR9Wi+9I1DKMD9Cz1kqy1MygtHMO8ARtpEu6l9u5XNrWp9c6VkglNhFJUxTm8w5ZtKkZ1kO4o4k4RwIyAcVwVgoFFRbph7RN/AXARa+WWPaGwgpDcokOKQffghzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMkvoXSYCDPycENHOigchd4FLF7sEKgkiMicweQBGOg=; b=BmXMuNWGBXNGyD0086/3Plp6YuUCoPymZlZKU4YE1v5kcIJvQt9EOf3cnLJlSbxCYA9oSO/pAG0woOzkzwIbC7plO6Q119yLU5qa+jEOgDPioO+BNMbFGuqTG9BclXFJYDzmT36z0xvjHGTk64UYAOw628iCHg4JtL6SG4nZflgxRAPdYNeAdKtzS/5+mB0uN0bXWNX/Irpv+FqhDMjquL6d1dO3LEKRvy+nW8hHIhSJ7g0h6SVRmeWpSjjZfNNyvjWCd6dlcz2oSvkvhOHgYm4LzC9dVBX9VMq9y7oXYFOEW9zOhh7JSlvK459No/ZGKiYGFx5Bi1oqrACjzAjC7w== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by AM8P250MB0310.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.22; Fri, 23 Feb 2024 19:06:44 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::ebdc:87bf:6f91:3ae5]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::ebdc:87bf:6f91:3ae5%7]) with mapi id 15.20.7316.023; Fri, 23 Feb 2024 19:06:44 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 23 Feb 2024 20:08:32 +0100 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [7Nfkqi4OHA1jOgSQKCbcNl9lB1l0cP26BtHOieAcGVY=] X-ClientProxiedBy: ZR0P278CA0088.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::21) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240223190832.3073967-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|AM8P250MB0310:EE_ X-MS-Office365-Filtering-Correlation-Id: e15c667f-5f69-4619-9104-08dc34a29368 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oi532b41Ldl9F+iUq7Hok3jn12xbIQ2jF5ejJKSbWFRrCHvsoXl8KB40+FTcoVYla8BGOX7EWvw9YS9aPeRhJvH8PiYW1qac18pWy1e56wp6KETGKrsC0R4OMXp+uTxggX9MsjN4jKtahb8zv5iMliGNj5/imu4FfYJ/EkggRWiIN1fmRfV4LQj8zm94vwADbCNDQy9yuQ+2+qO9Bk2KYBgXQY9CgxXX6U+1irrHbxQgiJjxHsAIZa6YUFK5mVryHr4yXcaUzmHW8chKZvZnnqtZKu+5P5JmwA3OxKd5P9Han2ybin4CiVnct1DPriK8bOToPsSHwZQ+UOK2+eZHICUYgirLm3cUngfVE0fjS/u6I2Y0+NcgcbS+K6XlxipHw2xOx+8Lb3oVCm4J6iUvLZF6PTJnwk3inMp+2m4B3vzkNrhpdFu72hEp82cVV45cvAZzXTXGLtdvfqSH01aStkfVwEadjdIM4zai+dJcjw2SpYRHmSEjkh527F2qKDjw8XUFr1E7W5M20/KVy6/GyC9Smxe+cY+oEAJnJ68BbkFiHWtBCr2v9gnvCutjGlrrBBOF3U3/s1jaat1bcQAAOwTMnIGbq6IjYhnOzk1k8AY= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9Yj6xWNVUC43ALvZKMnf+V45iZ+ulZKEYh+LdWzRRnwBNquWqlfvTjrtioszGPX8amTDTnDb7qOdvigFqd6QHMVB1R4w2swvIvPo57BIy10+i3vExaiut8P2dYU0ATB4VhowpL560nqEyynlmhitrgH5G++5m2KwDYEeJnavLBnIm6KoWdNgtS8iwBviXm1krAQEIAUldxYLWBckE7dO0GMOWuxKtM7qfYFOGzECNyVf5dR8ffmv9UCP/blDTH0M3bVIpp87RlwiN4J47eJ+lt1QLs+OomjIhUxmtezmYKtOfvMTf+MX8Ei8P1Z572fWb5qIey62HPlOqqao1mwvt5jjVKTTIO8FEixK4i0hzRVN4KdsRR2kt0V2W5tnfKdy9KDG1V+5TNl5crFBvLWb33lRX0WX5nnmpgGsQuxDAmLIDs0RsPV4Gk12K/G0iMNLtn8Ui562GTsem55nrIPxN9vs5zvHF+zKXeId9IBAU4wHhZ9+QLWCYK8nvAIeJlPX4C+J47hmv8AD7s1v5J9lXFK/q3OvL0wbZ8FhU4kNPCBF6/+JgEyoQ+Z2Z0rwi3f4A4pom9w5P4FD5V0Dhn/yrtWaAykIJyJR+4zLh4cl2eU0Pey/XJpeeeLE4eqyb69P+0Qb4M7wXw0Q3yXU5NVWgySx2dsO5rUPe0Zlch4dHoSLWP2F+6ynzKmx6poEkyMgLbZVNz6tX1fdDSEBe/iI2GgZPohND6pPUUebTROL2Xscpvq68Saq6PCzozLTtrF3hgrJqZZbfhaosY+MHqTjjORJiRwFVsE3sbW2RmgHc+5Fe0bvpznl6OqAGoDFnnqZBwgC9xQpxVK8qwLGTlCwKnhEpjOwFPIx/RphtACycwWn7nw+RBhxhv7k8VEdGc9nXUSwuUkVssRIpqZu06L6qVgHQPATd3UwulfMmm3eGYA2IAPl6IZ18uEsr3b6wuVoV/xRhGqSTg1hXEOkmpuRCPx2EH+uQllBleYhFis5KnuxPqb0Hc9nOHEegFDqCM3qaqPmbKFhKTHh7sHRynw+WwxxnAyB4lDBxhw0yC8wfZYR/99wLzcMQWce4/DS65ByLeAvWSPFD89bGMXQf3SUK8a6po0lKGhJg0k+chG7gslNMrp1NMprVb5BZKKCTKxJ6QzTzm0Kx+L2T0sxwlaOrSDs42NBJMZyov12srHEYW50bQ8McddEt925LMeB6BQlkAD/hOpdmcURJBkxXSI3wweF/0LgODZXFsVAr/M4tBkNGDPfGOOo+s/en9D+AkLlnCfuOeMGxsQmFjtoJ+b3rQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e15c667f-5f69-4619-9104-08dc34a29368 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 19:06:44.4353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0310 Subject: [FFmpeg-devel] [PATCH] configure: Disable linker warnings for common symbols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: V+LORYoZnSH2 Common symbols are not part of ISO-C and therefore not used by FFmpeg at all. Yet linker warnings to ensure it stays that way are nevertheless wrong, because the existence of common symbols does not imply that there is a bug in our code. More precisely, Clang's ASAN implementation uses a common symbol ___asan_globals_registered when used on Elf targets with the -fsanitize-address-globals-dead-stripping option; said option is the default since Clang 17 [1]. This leads to 1883 warnings about ___asan_globals_registered when linking here. (Even without that option there were warnings like _ZN14__interception10real_vforkE being overridden.) Said warning is also unnecessary: The proper way to ensure that our code is free of common symbols is to let the compiler enforce this. But this is already the default since GCC 10 and Clang 11, so there is no risk of introducing our own common symbols. [1]: https://reviews.llvm.org/D152604 Signed-off-by: Andreas Rheinhardt --- There is btw a second incompatibility between our configure script and Clang ASAN: Since version 16 it defaults to -fsanitize-address-use-odr-indicator and with this option set, it creates a __odr_asan_gen_FOO symbol for every object FOO in addition to the symbol FOO itself; configure therefore sets extern_prefix (used for ASM name mangling) to "__odr_asan_gen_". configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 197f762b58..108816bd1e 100755 --- a/configure +++ b/configure @@ -7337,7 +7337,6 @@ void (^block)(void); EOF # add some linker flags -check_ldflags -Wl,--warn-common check_ldflags -Wl,-rpath-link=:libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil enabled rpath && add_ldexeflags -Wl,-rpath,$libdir && add_ldsoflags -Wl,-rpath,$libdir test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic