From patchwork Sat Apr 13 06:35:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: LuMingYin X-Patchwork-Id: 48039 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:670b:b0:1a9:af23:56c1 with SMTP id wh11csp697891pzb; Fri, 12 Apr 2024 23:35:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVextmk2IkXohMMPuYMCDHG3vZzrojWZvch9NZOkg5206zCKKg4n2hBPrQUMJgQdlHghGNhEIMufx7xDOKIKfBsK+9wmSIPMi7dyQ== X-Google-Smtp-Source: AGHT+IHQmOAnM26GYMCgM7jATD7/+hjycgfsiqDB5QnR02QY/UTqtOzXw6OiMZHRsU2AeizyfHPO X-Received: by 2002:a17:906:f81a:b0:a51:cff5:cb91 with SMTP id kh26-20020a170906f81a00b00a51cff5cb91mr2732783ejb.31.1712990151234; Fri, 12 Apr 2024 23:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1712990151; cv=none; d=google.com; s=arc-20160816; b=skdDVIucRMot4GRBQSjfV0xpWkf56mTK7Wa1nyYdPXwmxJ+wrdV7mIpUCCYjlib1bs 3L5ls9B21nFutS+yx5KDUcoNS25U9Kvx3KaObouzIIzLUshp6KIjE3qQRRu9yJyXeA5x 1ORSHyvL2CrHzYBWpWnF8F/sU+eDEo/SCN2BN6KJGjHwOF3mxwV1r5I+g/SvTvhSyv/P h2xfRZdKRlwFUsLzvX/pll8NRtPu6vJjy9c4HSHIo9p/s4r+AKIq8WlTMvL8evEHVNQI FQFwUnKKIxj+yuyHBcAShT8ePr3CWehDtcjmMxaBUEVWYRfpsNxWeJgaxvvfogwnG2Mt jlNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=RAd+FvAru7/3IElS4E+3L/FfzP4PaL3hE/2qVr8XW1M=; fh=h93Jk9zXtjyzsFd9PKvKbdVr/RKQn4bW7LGFE3/Lh8E=; b=pSD19pABnnmn+eUMpS3LDT2Tcgk8c2wjZPeoKdkboXjbAnE72nrMXVrytDmDjW/qIz /7FVeCjD43PROtU3inR2UQhYzPRSxP/NPooxp3GrybcPeG9xlDJD2I8GYVTH/+D1h4Td 6pEP+yrkUEz4BUWNDtdWw+kt62kq39BLdJ7TolXar3kVpICyboNpYg4ap7PIqNQJYWgb hAaENDRwYbqS0fRq0W99qpp3GH+SazTi8PekD4Fm6YXAiVk/b5Nf/sFES6iwxZ0ST243 QNBDidIqD1ntqA0lW29aEKo+DqGJhiqg3b7B6kbIkFk8wbqbZFlGeRW/Fn+EpN2DWnVq tkDg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=JhkKhw2N; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qa38-20020a17090786a600b00a521459d2casi2516835ejc.831.2024.04.12.23.35.50; Fri, 12 Apr 2024 23:35:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=JhkKhw2N; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7BE968D29A; Sat, 13 Apr 2024 09:35:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7E7FB68C6BD for ; Sat, 13 Apr 2024 09:35:39 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=88jkX wyw8UoHG9jiTA7EQ6lxz46oCtdfWoQojsmWyiQ=; b=JhkKhw2NQ1goZO1/q+0x/ WZX1piHxWleK1xj7nLDBtm5VIavMboUuhd6yYRSimjxELpfnuHfkcACzW7dVp0OY svhqJdOTDYUNexwu52Wf01oACWUBoF/jk3wXxy6qeFIIY/2CjA19hXJvM6ScJ1hw R7BcGvp9nU+2h5XUtlLPoI= Received: from localhost.localdomain (unknown [111.198.54.11]) by gzga-smtp-mta-g2-2 (Coremail) with SMTP id _____wDnj5+0JxpmhEr9Aw--.47563S2; Sat, 13 Apr 2024 14:35:33 +0800 (CST) From: LuMingYin To: ffmpeg-devel@ffmpeg.org Date: Sat, 13 Apr 2024 14:35:29 +0800 Message-Id: <20240413063529.2270832-1-lumingyindetect@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wDnj5+0JxpmhEr9Aw--.47563S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKw1fKFyrtFy7AF4fWFW5GFg_yoW3GFgEya 9rJ34kZa4qgrnxJayYkFZ8JrZrGw1kCFWfJ3WfGrs5Xa4rurs0vrs7WryDJw1rXw4rArya kryaqF9FqwnF9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_5rcPUUUUU== X-Originating-IP: [111.198.54.11] X-CM-SenderInfo: poxpx0hj1l0vphwhu3i6rwjhhfrp/1tbiKR+-92VOCdQv2QACs8 Subject: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix a memory leak in libavformat/hlsenc.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: lumingyindetect@163.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4dUu2VSDOzFr In the function 'hls_write_trailer' in the file '/FFmpeg/libavformat/hlsenc.c', the variable named 'options' allocates a block of dynamic memory in the 'av_dict_set' function, which is not freed on error paths. Signed-off-by: LuMingYin --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index bde7230036..0e2843c6bc 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2757,6 +2757,7 @@ static int hls_write_trailer(struct AVFormatContext *s) filename = av_asprintf("%s", oc->url); } if (!filename) { + av_dict_free(&options); av_freep(&old_filename); return AVERROR(ENOMEM); }