From patchwork Thu Apr 18 05:42:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geoff Hill X-Patchwork-Id: 48123 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:ce4e:b0:1a9:af23:56c1 with SMTP id id14csp1473389pzb; Wed, 17 Apr 2024 22:42:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV6CyDsek5eDJ6osX3JxlaRyzNlU9KuGn6QbzfV2pF4TwuQJUYMGRrmm2UTSjvrf5CkSjUKT5MVEjnPVK4wrSMkzgagrAWZSZ6rsg== X-Google-Smtp-Source: AGHT+IF9pyXx5B79IYT2ulnvSxzwwhiiPUooz9kmt5na/ZuwAtlEGq7BfN5dgJkYb5o/pGE29I0Q X-Received: by 2002:a50:cc9d:0:b0:570:601d:507f with SMTP id q29-20020a50cc9d000000b00570601d507fmr856437edi.32.1713418953580; Wed, 17 Apr 2024 22:42:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713418953; cv=none; d=google.com; s=arc-20160816; b=rfM89+RUixeSqKh6q22fblFLXrAP9wfbOjA46es/NUq8nCEazuXXg23AMcvLVb/pUF ec7okHhXqWfgtdAYt+f9l2qgyFh5mlJzg8xkPINOl+3suvUgoAcXz95miVlWHjGZI8zI zpn4gopoQrErLSvoABU7s6vNdEGgcRBumyf9Zs97MIXwKw0ZkuFOCh1teGQB4SjtIDD0 qsz41z1xzLLRssqyLc4Z9SyhlomfdhQtzJjSr7oEQEJVJGfBUAZU/M6hymYXgdtOmVxr oYjkcwo5gc8NIXappxH6X9ElAXwUaH7sSny7OqTFxGLQ11+xsPbJ8wkrhxqiW8S08gJr ivVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:to:from:user-agent:mime-version :date:message-id:dkim-signature:delivered-to; bh=zOQlnmpP1u2gRYWAcW/+5WUeWZU5YoGNRBEyuHzaSFs=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=UogN5o5bCk3KtiuNxF6h0a+DoVIhJYxKNriPv4XyBOF3NYYXwmiqHPZSKsQNhtsrwa kgFrbVXFCCjEgIJDt0xeoDLv95NhRWVIjomBd2RYrjJez4+RKiBYiTdK8BIrhwULmtfi TLpHzoRFcDvMF5JOde1Lr7xLaD/qZoJC6XH+SevtwyZQtXB+GriuJQ0LftPUoq8eRMZZ uGzoIqpxb046kKD+zkL6Ln0B35+IWM1So0p1XIn6xKqeU9d0LGCK8HexqdC9h96Gh22E gq5avLoGFe1/6pU3MsSsSJkIyycIs/WaJw6i1lkHVMpv3xCUe+3fj4qOS6PjXwaEnxfb 5JWA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@geoffhill.org header.s=20220510 header.b=lfL7fIgw; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=geoffhill.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dy1-20020a05640231e100b0056e218c2ce2si428351edb.253.2024.04.17.22.42.32; Wed, 17 Apr 2024 22:42:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@geoffhill.org header.s=20220510 header.b=lfL7fIgw; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=geoffhill.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 29EBA68D396; Thu, 18 Apr 2024 08:42:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from riki.gfrh.net (riki.gfrh.net [52.40.11.205]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 03FDC68D33D for ; Thu, 18 Apr 2024 08:42:21 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geoffhill.org; s=20220510; t=1713418938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jH9T+ug5GZqWNA1lw3m55tdpjOE2dM64Td9Lif49bTo=; b=lfL7fIgw279X8NeciuLFIgCcLsZAzh3dR6tYaIMI41SRORYD1KILKeWxGo3OCqBAcfFK6B cjg5UtRKvxGky5/Prziskx6ckqGfirjjQAnkhsW3qzsgaRzWZIdaifwnfhoQ2RJT7PrNiT mG2gRUKnhJnVVmjr4gqcMLLddeVFPCw= Received: by riki.gfrh.net (OpenSMTPD) with ESMTPSA id eb66e98f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 18 Apr 2024 05:42:18 +0000 (UTC) Message-ID: Date: Wed, 17 Apr 2024 22:42:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Geoff Hill To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] avcodec/ac3: Remove unused fixed-point ARMv7 DSP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: hVCbK7IhurOi This diff removes 4 unused ARMv7 NEON fixed-point DSP functions. The function were originally moved here by 4958f35a2 (Dec 2013). After 9e05421db (Jan 2021), as part of the refactor of the AC3 DSP to consistently use 32-bit sample format in the encoder, these functions were removed from the DSP function table, but the ARMv7 implementations were kept. Signed-off-by: Geoff Hill --- libavcodec/arm/ac3dsp_neon.S | 63 ------------------------------------ 1 file changed, 63 deletions(-) diff --git a/libavcodec/arm/ac3dsp_neon.S b/libavcodec/arm/ac3dsp_neon.S index 89d0ae8048..dc829541aa 100644 --- a/libavcodec/arm/ac3dsp_neon.S +++ b/libavcodec/arm/ac3dsp_neon.S @@ -20,25 +20,6 @@ #include "libavutil/arm/asm.S" -function ff_ac3_max_msb_abs_int16_neon, export=1 - vmov.i16 q0, #0 - vmov.i16 q2, #0 -1: vld1.16 {q1}, [r0,:128]! - vabs.s16 q1, q1 - vld1.16 {q3}, [r0,:128]! - vabs.s16 q3, q3 - vorr q0, q0, q1 - vorr q2, q2, q3 - subs r1, r1, #16 - bgt 1b - vorr q0, q0, q2 - vorr d0, d0, d1 - vpmax.u16 d0, d0, d0 - vpmax.u16 d0, d0, d0 - vmov.u16 r0, d0[0] - bx lr -endfunc - function ff_ac3_exponent_min_neon, export=1 cmp r1, #0 it eq @@ -59,27 +40,6 @@ function ff_ac3_exponent_min_neon, export=1 pop {pc} endfunc -function ff_ac3_lshift_int16_neon, export=1 - vdup.16 q0, r2 -1: vld1.16 {q1}, [r0,:128] - vshl.s16 q1, q1, q0 - vst1.16 {q1}, [r0,:128]! - subs r1, r1, #8 - bgt 1b - bx lr -endfunc - -function ff_ac3_rshift_int32_neon, export=1 - rsb r2, r2, #0 - vdup.32 q0, r2 -1: vld1.32 {q1}, [r0,:128] - vshl.s32 q1, q1, q0 - vst1.32 {q1}, [r0,:128]! - subs r1, r1, #4 - bgt 1b - bx lr -endfunc - function ff_float_to_fixed24_neon, export=1 1: vld1.32 {q0-q1}, [r1,:128]! vcvt.s32.f32 q0, q0, #24 @@ -109,29 +69,6 @@ function ff_ac3_extract_exponents_neon, export=1 bx lr endfunc -function ff_apply_window_int16_neon, export=1 - push {r4,lr} - add r4, r1, r3, lsl #1 - add lr, r0, r3, lsl #1 - sub r4, r4, #16 - sub lr, lr, #16 - mov r12, #-16 -1: - vld1.16 {q0}, [r1,:128]! - vld1.16 {q2}, [r2,:128]! - vld1.16 {q1}, [r4,:128], r12 - vrev64.16 q3, q2 - vqrdmulh.s16 q0, q0, q2 - vqrdmulh.s16 d2, d2, d7 - vqrdmulh.s16 d3, d3, d6 - vst1.16 {q0}, [r0,:128]! - vst1.16 {q1}, [lr,:128], r12 - subs r3, r3, #16 - bgt 1b - - pop {r4,pc} -endfunc - function ff_ac3_sum_square_butterfly_int32_neon, export=1 vmov.i64 q0, #0 vmov.i64 q1, #0