From patchwork Sun Apr 21 23:06:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48204 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c906:b0:1a9:af23:56c1 with SMTP id gx6csp1952703pzb; Sun, 21 Apr 2024 16:07:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVJX+I49PGeVuFyzlodIlfXKi+vEQ4LxTB5h15WwGVscYGPBI5qLBF+R0Sg4K+UPwQBsEOZCdCwcm3hkYnIY8iXsq1SLCbt8mS2nw== X-Google-Smtp-Source: AGHT+IG2oAEdNMoBC3cE+8oVdFWW2ajE8CPnQUwedGK9CxK4mK9nQqw5MwPRxZKuP+DDuHybxmFO X-Received: by 2002:a2e:870b:0:b0:2da:b2c3:ba3b with SMTP id m11-20020a2e870b000000b002dab2c3ba3bmr5957154lji.24.1713740834182; Sun, 21 Apr 2024 16:07:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713740834; cv=none; d=google.com; s=arc-20160816; b=oJ52YyyW2J4fL+pPHNO+msRMvHXU5DjnGd4xo9rQC1NfYJJ9OGg8tQxHrPw2WoLqXc 1yFGCX7WkH70JedXyrGi81iEnNtrS/2TNFumZ33Tnf3wUnqzW2BQZaA5fMItxH2/7Ewc 9lkgMC56kBXILz8+NVBKhpwG+C8anZ8EK7QaTdJj3y+crOI80JkYLs4OKAmuMWMlsdI2 TXts5FJICKDU4MzEm4NpeAV0gN52e/oA3WmWx5fx6f4oWaoPm58aDmvNho2efZje9qyD QCtaLrQN0OVlUTKyKJB4HKGJsebf3snoBkwucnYhP0lEZ29ggWySryBW4zChg8i1zGce dMaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=IoWKEXJ5ui0ajqdCNNM/cqri2vQt/uW/uLjzF6O3bbs=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=Wl1MIgGiqbTJ1TswXQLk4uoZOPdXi8fG8cQ1d0HQb8RM7P0+iELQ2DV0sRajuiYQed dM8VeFZ2e1yHI6jIo9SxfUX2TPrWivFfzRmOqSgY9s+dy5Nqs8L7Opg5lb1CMM6yffBG oaupOumHdM1Gm0KzznZvMX+uHQnE4XES1NrBdXKrFiGrQZf/AJy4fwkgFQ0QRkMlHXO/ HOnPvUw5EMw4O580Wk+aGReCWvCaGfI7YLz9DYcZIHMXMCByuE2aRzFNxHPfG9F5mTou aGS61+N6YPMPn4vZRu2ktPOQD7Dug0AjmMHG7Aj5M7+SB2YR2ZY8fM/+Jif1HjSCLPgs wrFg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=VFINZ4kq; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id p9-20020a2e8049000000b002dd1153dc55si1285488ljg.605.2024.04.21.16.07.13; Sun, 21 Apr 2024 16:07:14 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=VFINZ4kq; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A9F268D294; Mon, 22 Apr 2024 02:07:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C628368AFCE for ; Mon, 22 Apr 2024 02:07:02 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2AC5060002 for ; Sun, 21 Apr 2024 23:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713740822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sL/TfHios7xDeclPAV/PmGS2W6/TcSuF2vfwJpEl0C4=; b=VFINZ4kqnrMWKmjWe4FWpGpiwcoeT9wqIM5Fl/bQq5e5Oftp1c9WDqdd2XHuhSGbEIvdk1 uumpUifdoyjJceXjnzB1r/GMtQCBxEtmeiv/zgDQKdYEOvOpHKA4122sPqLsjvIFu4fiQx 30niyJWt7gIHs2TonLCBMiGTfunN8uw3CssL3+t2JHOfakmxf9kJq5N6UVlrYmUu2fPSPp PhbB6gWGZvrDjVLFkOnFRPh4cC01Ny014HQarbybbAD61wkTUBfQhQzbh9CGSPQ3jynmQ+ eis/K/pOOX+bbfiqeaB1OAMYeUX2I7MfxVG3frGeuLnpz6aPYpSoXRhoDy9ZCg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 22 Apr 2024 01:06:59 +0200 Message-Id: <20240421230701.4178782-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/3] avfilter/signature_lookup: Fix 2 differences to the refernce SW X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ecyXRK/n5U91 Fixes: CID1403227 Division or modulo by float zero Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index ab7320d47f4..a3086b38cca 100644 --- a/libavfilter/signature_lookup.c +++ b/libavfilter/signature_lookup.c @@ -496,10 +496,10 @@ static MatchingInfo evaluate_parameters(AVFilterContext *ctx, SignatureContext * continue; /* matching sequence is too short */ if ((double) goodfcount / (double) fcount < sc->thit) continue; - if ((double) goodfcount*0.5 < FFMAX(gooda, goodb)) + if ((double) goodfcount*0.5 <= FFMAX(gooda, goodb)) continue; - meandist = (double) goodfcount / (double) distsum; + meandist = (double) distsum / (double) goodfcount; if (meandist < minmeandist || status == (STATUS_END_REACHED | STATUS_BEGIN_REACHED) || From patchwork Sun Apr 21 23:07:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48205 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c906:b0:1a9:af23:56c1 with SMTP id gx6csp1952759pzb; Sun, 21 Apr 2024 16:07:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUkeHKALYelcHL43QSzgdhIutJl9Ul94ebuVRKVn2fcX9Q/HtuMeg/+DR2rxyIYW+tVtBLmdj45Rq9Jm76hKZrNPqzIe2di6LC2AA== X-Google-Smtp-Source: AGHT+IF6HMTPwAWL7PYqYgD8gU/RQnWnIBdSH/GtnL68b33U5TwLkBw3Jtm9XO0M+6lz1pSKqYsK X-Received: by 2002:a5d:604d:0:b0:346:47d6:5d17 with SMTP id j13-20020a5d604d000000b0034647d65d17mr5266442wrt.57.1713740842318; Sun, 21 Apr 2024 16:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713740842; cv=none; d=google.com; s=arc-20160816; b=Cw+kxNPtlzRxShlS4CVuKs4yWt8TdsUGcIlMaFI4iFbkgs3SCJmC+Hdv8Me3Q7P26D Df6MXcROWT/pP0pJF8uJGx1po0rkqEQx4Ov6sxvfVMFpdIOm5LZlYGBSQTPDF6VxBjN5 LOBwIoDKqlrpzu9lA+uJhxyqIKkaz1gbplEZ0Lk/2pecTFCeCCc8QVFiHdPAWoIdESCF mCU5T66Lit+NQHYdiQI5+8IDymc15lavuFIIjM+gp2yWJHuo4mOE7X3tO4EK8N92iExS xdMI1q16EnDB3crjyhwylxTvoDNyMiSuTYPfLHmp1gflFyx18Bf9J5TY7ScTqud6qTSg U9Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=TKGB3YszTT+99iSGXto8npsVc8KEbIiKkvTiou7FSio=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=yxmFwDWh5WOwrngkCYEVNKdqEgQn21QGicy4lE+HhCijFZ/Y/nsvDQ03WWOI3VXQXR /iM5222pOvglchr9Fxy2EdAGi1/qzTL5hS9fb/vUTQ+CRefdSu7p9+8hqDRm39M0hmrg Mb6duG+TpnAKmVqKSsxh/u1GnHB3bwBETaEBo+VEPCeEBtpHJSOYKUNogH4DVpiZQmG+ 4n5Kac8JWAyrmwbyEoGU7jYCuua01lZd9KL3ONsp3+iKH/dQyIlAbonZiPqOKIKtzcpH jg5qHNTUhOO30RaMXdaHULsWtKyajvNQR1JdHw1ha6dQx/R/VCaWjuqr+79RWzyAeFnv Mtcg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=YOLHZ+Lh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dn10-20020a17090794ca00b00a558e3813cbsi3357646ejc.269.2024.04.21.16.07.21; Sun, 21 Apr 2024 16:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=YOLHZ+Lh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F71068D2A4; Mon, 22 Apr 2024 02:07:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0515E68D0B5 for ; Mon, 22 Apr 2024 02:07:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5946B40002 for ; Sun, 21 Apr 2024 23:07:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713740823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cv4o3fewE8KMD/ZIvzV2TU3C5BNNsCpDqk7cwj/9fDs=; b=YOLHZ+LhchTfkXx/JZdyXX/YkNcWb5hWwzIWDlYPH3mkgYzDeIY9aYKDJRu5n4TfLoXohV MG8zAYhXY2uSjR3MgtuvD30F1DOTmnJ9WjRmfsPoU/+dvj0MGYTa0BvZA0iOzNNSFU+pf/ dugDpmIt+BfUtvX3hGva+W4Sdh/Yp6LKuk8ACNmBiDCqoK5gunYn9z/qljz+CgH1yawpXj SR85d9RBndkThmATjfsKc6BnvDFxC1z2oUpP8c//WG86DfvyeKeKTBo3QJ0fKtaSlWOXSI LcTlbyvDeGs3j6jxMWe7GUnj9TZeGrIUP49s+XNj2OG59NDu+Pmp3olW42+SYA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 22 Apr 2024 01:07:00 +0200 Message-Id: <20240421230701.4178782-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240421230701.4178782-1-michael@niedermayer.cc> References: <20240421230701.4178782-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/3] avfilter/signature_lookup: Initialize bestmatch X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Ngg7QYo5rTP4 Fixes: CID1500345 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index a3086b38cca..dc0a2ef2b24 100644 --- a/libavfilter/signature_lookup.c +++ b/libavfilter/signature_lookup.c @@ -535,16 +535,14 @@ static MatchingInfo lookup_signatures(AVFilterContext *ctx, SignatureContext *sc { CoarseSignature *cs, *cs2; MatchingInfo *infos; - MatchingInfo bestmatch; + MatchingInfo bestmatch = {0}; MatchingInfo *i; cs = first->coarsesiglist; cs2 = second->coarsesiglist; /* score of bestmatch is 0, if no match is found */ - bestmatch.score = 0; bestmatch.meandist = 99999; - bestmatch.whole = 0; fill_l1distlut(sc->l1distlut); From patchwork Sun Apr 21 23:07:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48206 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c906:b0:1a9:af23:56c1 with SMTP id gx6csp1952812pzb; Sun, 21 Apr 2024 16:07:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWfG/DCvfGvOuPZgar68XUE8h9uSm7JPq6lYQiP2ThB5qQiQOxMneknX7YbmhNqeWgRS395DnMHfEalL/9PbhPFLSkMMFKsJj0/+Q== X-Google-Smtp-Source: AGHT+IGdLitjNqzwG5A5a/+P39bKSE6jHTTbxYxdo3XBhXdR61jg8gP3ndeuEUsu/KaAqMfRn3jB X-Received: by 2002:a17:907:7216:b0:a55:b2a5:dfb1 with SMTP id dr22-20020a170907721600b00a55b2a5dfb1mr1374491ejc.3.1713740850102; Sun, 21 Apr 2024 16:07:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713740850; cv=none; d=google.com; s=arc-20160816; b=stY74+KWKqKZXazhjQRtjzJcE4BAihKlPVWQJuYKo01Ih61y7vBMnxZmQULbwSR99l P8UAMJtLMQXJZcj57shO6t7ps6Hn3GfJsU//rtS+TKYWKBXnj+q9hdH5veHz4ALfinI6 rhHkjaC+EXiFIe9DUYOsXYsaZAaBX7q6Wlq6k1KQ5Pga+9g3lgo8TwsPqw1QAPtDYEf5 DyGH0ps3A0NKq8XJWUcdEFyy05X92IT0zDNFN+hUXAYuwBIMDVJcoNSHopsw9Bigc9Gl D+Uh0fyWiKn9R9GDy8G4/KQDlke8SWLRT7QAlS9ZZZtd887jrVwszfq6trK3teETENxO LmZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=snVB4PU8ewJN8esfrCDRtS0K24XEK2+L/cDaAf4tVP4=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=IpvuxjjVOuJN0mDnzYHk4bwll4tGRsRkMPnuFul6hMYwt/lgykgm/eI1a+eqZyfPAD 6hzqDY71L+pEhUwnDymaFgHwoRRExVDet+cbofTCn5YC2B+mClW4yavIDcykm3Qp61un CrWymZ5YyJo/W89gC44VT+HzIbJ3ACDEs9Yfq3cKGBcG1oo6ls4IQxGLqbkBL7UWbC1X WrHjBeEOvv20nzQvqc6Ab8yTJWSDTKYlxYB5hEguXRR/Gz7UJw2Rhok/+Jhw/hNnE8cN 4t1sK9k4FNe5+++Vw0tg61N91tziwoH97mBr3vmtncIbnon/mzHwwyNJyE1wbZJe+sc0 PNWw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=UEDKBq5h; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m27-20020a170906259b00b00a55bd8ec4f5si5158ejb.745.2024.04.21.16.07.29; Sun, 21 Apr 2024 16:07:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=UEDKBq5h; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9631B68D2A7; Mon, 22 Apr 2024 02:07:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 48F0168D164 for ; Mon, 22 Apr 2024 02:07:05 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id A89B4E0002 for ; Sun, 21 Apr 2024 23:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713740824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zjp2St20XTTvH58q82ftfP32vGuIl1EMk0TOrOfEIi8=; b=UEDKBq5hBegJXDt1CMVanZSZuzeg7vnQAMAw9fOffkwpir3fB5RT9LfKZONEa6QH+kQLvO AH7vN/cw1vaW+xiYvUEqugcF0OxNAMNPWMrWUXHrQjdYagd+qCvdk41nVNdgwFANOqPgNa PWHdwzdE8xsiSiweyQ0+FQTS7WqrNkO8NFZiEsyoowcdvfotupqeMzgAOurH8l6OchtJ7q WozYH3eJrPPlhd2tC4wx5I6qSfkWfzShodut7BFPFCnVnB9GxagfQ0EFhMqygOz/oDWXSm B8fXArPUa4/aU0PL3D/LqwemtJFTVZkNAf+/iQ6+W0++HogYqiFPg/cedywohQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 22 Apr 2024 01:07:01 +0200 Message-Id: <20240421230701.4178782-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240421230701.4178782-1-michael@niedermayer.cc> References: <20240421230701.4178782-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/3] avfilter/signature_lookup: Dont copy uninitialized stuff around X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: RjJq552yxz3+ Fixes: CID1403238 Uninitialized pointer read Fixes: CID1403239 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index dc0a2ef2b24..380723e92a4 100644 --- a/libavfilter/signature_lookup.c +++ b/libavfilter/signature_lookup.c @@ -448,14 +448,14 @@ static MatchingInfo evaluate_parameters(AVFilterContext *ctx, SignatureContext * } if (tolerancecount > 2) { - a = aprev; - b = bprev; if (dir == DIR_NEXT) { /* turn around */ a = infos->first; b = infos->second; dir = DIR_PREV; } else { + a = aprev; + b = bprev; break; } }