From patchwork Wed Apr 24 01:45:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48239 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:2d06:b0:1a9:af23:56c1 with SMTP id tw6csp363155pzb; Tue, 23 Apr 2024 18:45:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW/MuiOwGYGlMeQ3bXZk62J0EHdnrMWxZNW42AbcjpczLUfgfgyAclMys3Ka8dX5EuY7q/qPPckRTWRMwCPiKOMibe0jhKrykf0sg== X-Google-Smtp-Source: AGHT+IHXf95HS/63IRsO7+HSlKK/ZdoFm66THJ7lMiU8yF8G7s+HXIU3Jh1Q187cSX326nTqyzUo X-Received: by 2002:a05:6512:284:b0:51a:e3f7:14ac with SMTP id j4-20020a056512028400b0051ae3f714acmr787539lfp.4.1713923135661; Tue, 23 Apr 2024 18:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713923135; cv=none; d=google.com; s=arc-20160816; b=beSE9LH5bxqiJPB2IkhqMNMHqCqrlrIYrLAON6huFL3LV3jUv8RMmPggIg29jYpVpj cW+X/Fq2u9Av5GqbRedcgjK4GGJ473VBQlPGcWxb0ZhFlW+RmOU+/NBjc6HM+yxD3vz7 +MGeKG4ZMmfE44UfYj3W+Fuz3OWtkBo8lUxOtlw9OrabyPCFgYV6BYH6pdcmh4G4bqHL EGTQK90iqtsE3Y91az6oUNHfrmlzG0yb9e/ultV3Xq80oSBsbCMhL/EtxhOuzH6/9YlA okyh26MQQx2VHeng4+aKjJHso48yCEO+7aXXBcnADIxpKHIGELcMi6da5/ON6r4LgPlU l3Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=JAIyiF7Jb7IFkbZUMQRHAG2NMcmtMfUIQnyR1A+5dJY=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=hq01flOvbk0UyJ6Fb1YokVcEurLqf6cf8iJmosKd5fChlJfv6tXst0MxI/HvqdMUBh pJ1/4AXudFhJK07MrLtI3nzVrxy/g+0eJYPK1Ht4m7XJ/IrQkLYgxcHlDcc22Ripxyu5 AGkG0ZtBwn3xJgFHyvVGzLNRznWTmnzMA9M6xVs+v0hsvdapq7RP9HK7v52iaW9F529a 8jK4zEkx5zowPz733mGbqqimQbjYvQXLidA+/szLXnJHtbqxQ+PAdJzz/q243dExko3z 4FcIls4ZWvW4au0S6OfHUFtu8TNooBBcRRFjkh21wyTJcpJeB5aXKo7EXpxo6TU0l1Aw 33oA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=IRKTv5MC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id jz8-20020a170906bb0800b00a55aee4bea1si3676788ejb.97.2024.04.23.18.45.35; Tue, 23 Apr 2024 18:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=IRKTv5MC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4F64F68CD4B; Wed, 24 Apr 2024 04:45:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B32B68D248 for ; Wed, 24 Apr 2024 04:45:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3CD2820002 for ; Wed, 24 Apr 2024 01:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713923123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BzH0QSjPMSMwz8xqe2mT5wcv78aDLMjqdWfXJ7JAFxs=; b=IRKTv5MCExORQlrd+BLIo6fMVneG4d3B8ci7uKyYIIvz2tiMp7SVfRNIYGtveFRVhMjmdo fqzpXxWllBaCMiKVAGa0eupgy6h+nm9ElxKlduAUHnRMrvJn05v1iIiCx5QF5p9To42sBF JcUVy3whLNXu2C9oINupQMMQh+XMfrOCjhZag+Pf73KbKXDs380tg0LG6fJvI11BFW3HCu oWFBWpy1JGJGbdJ0FFcCjCy+AuWGIotjybNm8jBYWWN7Wt+8gRQzaxaZIKOUCM++WdlRJ9 S0LppCLRwq9c4VAdRrve4l7SIQ2aXLkgoBCvkVSAMvn9aZc/4Xf8BFf0KNyezQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 24 Apr 2024 03:45:18 +0200 Message-ID: <20240424014522.4015429-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/5] doc/examples/demux_decode: Simplify loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: XzmRu5mW09Qi Fixes: CID1463550 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/demux_decode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/examples/demux_decode.c b/doc/examples/demux_decode.c index f26611d8f4f..64f5547bc43 100644 --- a/doc/examples/demux_decode.c +++ b/doc/examples/demux_decode.c @@ -138,11 +138,9 @@ static int decode_packet(AVCodecContext *dec, const AVPacket *pkt) ret = output_audio_frame(frame); av_frame_unref(frame); - if (ret < 0) - return ret; } - return 0; + return ret; } static int open_codec_context(int *stream_idx, From patchwork Wed Apr 24 01:45:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48240 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:2d06:b0:1a9:af23:56c1 with SMTP id tw6csp363231pzb; Tue, 23 Apr 2024 18:45:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWVfOEvBekIb76DQe5g7a3btbFWj6hUOF0nidyZv2QigW5QikooGxErKv2EpnRyCmnvwCTq6QKZDwv6kM5V25OBwL/CVrkZGx6UkA== X-Google-Smtp-Source: AGHT+IEl10ClCJt4oMmof4YOyqjVOjVuDNRxG+GA5rPEs3URAm/QVKkORQ7VYwufhnnEy2m07Haf X-Received: by 2002:a5d:5347:0:b0:345:603f:cd96 with SMTP id t7-20020a5d5347000000b00345603fcd96mr634114wrv.5.1713923146078; Tue, 23 Apr 2024 18:45:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713923146; cv=none; d=google.com; s=arc-20160816; b=QUWpFNEdETwHbRJ3NOzWsXFhZIE1ONmHi5oGtRMi55w0WnpPws3Z95aQL6RUQL/QzB fu+chIIcuhd1X4bbH98wHcjJLItmVA/BxPtrf8214UhkwJo4RE4Gpf1eg7M8ra+SFY/q A+oGILzR7fjZuxXSpAB8xYi0yCO6cx1yBWB0C09dEJlsADBDA7UnPO2QTiWrc68aVI2+ dXGscaDDlOkuE0/GRHgfknt1Fq4xa33BGDLOtAadcfK5+eEJlpkbUfABKOKbOXkN57GY XwLlyXHAGDR3ko/UzPiRcmkKNWiAxJGtJ09EgDoUWkiFgqdMQL8Sl3zZW72BMfZZcCrs OttA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=bhuxQ8J3mWEGgS93UTNOzvVur54zjFkDQgvPp2OWysA=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=LTZco7wc3yt6elCFi9OmaJh7GT6PbZjX5m8G1v94FiVGFNh7aVMxmqg4TRyFOB1XdK aulNjK3Z/PujruKLcopnBQOFMp6lvneiBELpcDg+IA28lgECcbQfapZqto03kX1hDGTP iwqgW20D78Q2ou4WzmbPNl9aQRqskG8ezGO9jpepTS3Z9RPHxaBoHqx6ylLzn9FFCBR5 n8fJ9PZcffgmzauZP1wl5aKxS5jiczCllwKTia7tojJ9+Ezzdmwge2AHK9J0TRoIfwfw mSlIUsOnuQMTZbciESWMh+V9VVtHoQ1nZ2uztFb5MUjfktnPHPqynLZ52BEDJhSzmi8A 8xMA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=Fa6izMMS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id mb21-20020a170906eb1500b00a5533761bf5si7958215ejb.694.2024.04.23.18.45.45; Tue, 23 Apr 2024 18:45:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=Fa6izMMS; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A709F68D248; Wed, 24 Apr 2024 04:45:32 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0A2C668D2AF for ; Wed, 24 Apr 2024 04:45:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 64B3D1BF203 for ; Wed, 24 Apr 2024 01:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713923124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRAih5cLbq4712otlsfe2xANFgmlMmOLV8knehv5gag=; b=Fa6izMMSGJLi/Fp7j46Cj5j7K4XYeNINtJTBRlTs4Lj+yGrPBW5zUyYQpDJ0Azdlz+x/FI poCnlKgRcfHKtkLcCxIhBN70VpFL7TUjPQO/Y8h5F46PE59Qey+4E1GSZiKh2uI1fgD22S 3Nk0i47btixFYzXvfRo6//znUunKZXgOhPokl6iTOP09ngoxgw34/A6ee0u2B6cMQjMfpe EPA0QFsAInFyhpn+u2EczxkEyT0RFdoDmDeYX/jqg7jKFDC+Jtzvm6pxhDwqXmnWoxRwS4 FnaX7oD4oi/EW9KK7/i0N2WBZ6YAjG9DpAoxVcEScfEFrPanZpJg2ZOb08dFpA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 24 Apr 2024 03:45:19 +0200 Message-ID: <20240424014522.4015429-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240424014522.4015429-1-michael@niedermayer.cc> References: <20240424014522.4015429-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/5] doc/examples/qsv_transcode: Simplify loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: wf6d3yp88an0 Fixes: CID1428858(2/2) Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/qsv_transcode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c index 8e7d2899f12..a4440a3403f 100644 --- a/doc/examples/qsv_transcode.c +++ b/doc/examples/qsv_transcode.c @@ -335,10 +335,8 @@ static int dec_enc(AVPacket *pkt, const AVCodec *enc_codec, char *optstr) fail: av_frame_free(&frame); - if (ret < 0) - return ret; } - return 0; + return ret; } int main(int argc, char **argv) From patchwork Wed Apr 24 01:45:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48241 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:2d06:b0:1a9:af23:56c1 with SMTP id tw6csp363284pzb; Tue, 23 Apr 2024 18:45:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXvCxI80VWkeb4AggfzHxbtaOYuOWoANITB/wji+o9IHwHC+vW/QknatoB0ESAWpaWNaOFUUqXjEm0ZhT1Iy9nMW9dYDZmblQ00Qg== X-Google-Smtp-Source: AGHT+IHSLnlSp3gmwolW8zb7WFLefNeB6uJjcPfXi+2PPS07OymB3IUYjY/uP2sFyruJhK7QcOK5 X-Received: by 2002:a17:906:cb8f:b0:a52:6bbd:595d with SMTP id mf15-20020a170906cb8f00b00a526bbd595dmr609895ejb.7.1713923154983; Tue, 23 Apr 2024 18:45:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713923154; cv=none; d=google.com; s=arc-20160816; b=FnOjr5Z3BUlk93MUvvh+dHy/+nnrw3IXJU+zHkSc6Qd12bd1NMnk3gZTM+fbg5ZgUI ltQ9/d1AuyH5IYGjm9/jhZqLJScBTPRegDRGC2nFTr6B+w/v1SQ51dIomHCpppwUaIvY T/XfGf8SOK0VGrtzDAD9UjTYOPizlNMqaG1ADQRnT4fdP6hQI0iaP7D7f+DaKDTOaULs YYp/OOqY7nvymXObiXYhGFfhdaj/w+PTNTuNXawz336ixai1CsRZ2RptxW0yVJulfXTj HzthQlpeTozddph4G+LYp8+d8VJBRo452gFJCO+ftEeRBCn8kzk/Iy1EeAOKs184jTXB q/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=fUVP7/P2RtTPZhsOAuQrwnHIz0hhnwgO29y3Ouc907U=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=ERMP+bHjr/QL11Zb8Pdn/akfR7+Btm2qefnF+dQUKwOwWkqxMsCeV3xZboddLD0yeR 1KQ0AmF6rcd/phii+bpblTTjVN4W0LSxyeC1xkEiMvY3y1lkPPsUNFtYRaUlEtkbMBgz 6DiF85NaFJMokhJVVGV67i+6DnPQ4iPMYdZ7yYQhtmUWdns0YXAc1fcO8KiuXUXBB/5v vzKpaK4+PoK9U5GYKv784zmNhKqaHlhr2yLdTzD+649cBK7HaMQIhBCDlqTVmd48XKyf YcyKhxWYui+7lqNVLWH4nVSF7O0k8zE27IijcmGS7TzcteVwupYKuSLk7fu+JZWYNHXV EaqQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=GP2kkqu4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id lj25-20020a170906f9d900b00a5891ca29c1si213337ejb.283.2024.04.23.18.45.54; Tue, 23 Apr 2024 18:45:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=GP2kkqu4; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF43E68D3E6; Wed, 24 Apr 2024 04:45:33 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AA5B468D2AF for ; Wed, 24 Apr 2024 04:45:25 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 15E941BF204 for ; Wed, 24 Apr 2024 01:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713923125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3oeqmIeTbHkVCq3EnL3pNWZO3zBPG+tG1rFMfl+odp0=; b=GP2kkqu4ONWJ8jf7ooZhlDMAcGSX3m2RpnW4HP17eXOpWzom94soGQrLX8Hs/mUH1+4iBl fJ32SCCPEI0qIswlkGOd90xhgx1gpSkPtbikG1vVus3OaQjsc8s7KW9zuHFj6s2tCkyPXf ynG0vQNgC5BxPnSl/r7Z4NW0aobtH0bEPw+6wlTOFzfUW2c2VgcHtfsqli9Z25gunkz9+H UURMyrITp1O30RKyHacMhUYVL33c4PmIH4Bv5eWBfz2Bcj70c3dxcoTjoJdLYBfCTdUD7O lxrEjzeuIhHqzwqGaFYW7HaRId3MOHdu4IkYge6f5Jn9Lb5ij2DUMzpz2W/Vyw== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 24 Apr 2024 03:45:20 +0200 Message-ID: <20240424014522.4015429-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240424014522.4015429-1-michael@niedermayer.cc> References: <20240424014522.4015429-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/5] doc/examples/vaapi_transcode: Simplify loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0HqOhc9xDRTB Fixes: CID1428858(1/2) Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/vaapi_transcode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c index 8367cb30404..e1b7a438836 100644 --- a/doc/examples/vaapi_transcode.c +++ b/doc/examples/vaapi_transcode.c @@ -215,10 +215,8 @@ static int dec_enc(AVPacket *pkt, const AVCodec *enc_codec) fail: av_frame_free(&frame); - if (ret < 0) - return ret; } - return 0; + return ret; } int main(int argc, char **argv) From patchwork Wed Apr 24 01:45:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48242 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:2d06:b0:1a9:af23:56c1 with SMTP id tw6csp363345pzb; Tue, 23 Apr 2024 18:46:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX0DnjXYp7ZzhlF6i9Rc/+Hskv7Zdv4dCZJkpCqF2hAIWVIrm8SkSFk+7k41C6155P1scXWHN4iE6YI/909Ey6Em6bll/rO7JTjoA== X-Google-Smtp-Source: AGHT+IExLGYCEccSmAvk1LzvaF7ZwcIhZYKfUqCezTJpR5M8s3IWqZ4GPzOxto1wQ1uelJQmPHml X-Received: by 2002:a05:6512:284:b0:519:592d:adcd with SMTP id j4-20020a056512028400b00519592dadcdmr685376lfp.3.1713923164515; Tue, 23 Apr 2024 18:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713923164; cv=none; d=google.com; s=arc-20160816; b=HJIHV0qFeGhTcj/Qy5tFtsrGJyiinWGhD+3HMMpJFlJqWk5igH7TmCdBkRBP8Go2Tm XJRndQWS8gZaR3CXmhIB3pEYsV+jBUpw+Zi1jrcAsA9BuL+WemCf1Kvpgh+kBBps9ViA RJk1maU56onpBVNmGNZWj5m00CinHX8H0xBPYlmiyj2pQ2GJN71DeR4M1EiBW/beF2U4 c8AtbvVClSTzT1lGkItr7/K+PuOdgedY1Koa7ui0S+t/SeQ7uL6+XWJMB0FbjlikXLx3 8o49OP9M1DvtX1YQ4tmLZ671ufVB9s0o+oWUvLrdE73UBXY+lp/XgOEWo0xENccF7L5r 2A3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=LQ4bJ9p3kGIu6brIJ9JTRpRYEd6H7dmIn2gpMmGWAwk=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=pY5zAB8pGPkO6BGUqiDNeqDDWPRViMN1T3CPnjpaHJH5+0PWsn0OyXwbRDzDfFMOyZ zwb66YHC066RCb1hik+R05UWR9IEjsyUYzUlLGg6k6FoH3DDuDyS3nv1YXlPUOA46Ar+ WID82q9/D70Fu5yyxGq1IgX2Ye6lQac1vpyOjV7+sPJ8SXKXFACMnWTDMOScurP3zV7j rdZ+Hs/ra8v7mSoaVxh1N1pj9tOl+hU8aA0dNqQoXD9V/jlAfhFzhd4iTJ5t1CiLPzNX oAfsRsdytRqKJV1gV8j4p2+98Trwzv2qAT04+r7+04LAbkTVHrl+W6S8RkbBG5VJwCR0 K64A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="BgvRr/IJ"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n16-20020ac242d0000000b00515bbfb49e0si4295455lfl.321.2024.04.23.18.46.03; Tue, 23 Apr 2024 18:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="BgvRr/IJ"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 418A568D3F8; Wed, 24 Apr 2024 04:45:36 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ED2DB68D3C1 for ; Wed, 24 Apr 2024 04:45:26 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 24D361C0002 for ; Wed, 24 Apr 2024 01:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713923126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ToFhd9uyxTZtWv/0Ozu+fstrU7aJJJ3d7JJ6xRV1ZYk=; b=BgvRr/IJXQxuqjnsYkwDnVgc5lW8ZRhD7L/zmVw8pdbarj2GpVofpfLmDsw2T+gX/lLgUn w3wkLesXt0h4kUkQmJ8GhnWMxjiLaRnKmb9JI+ZXC2XSyXbVrNJqBoS74PtzHe3SRZHu3B an5mrUWwukXFnXvM0YUYx4wN9TlKGPfRaMUweoukQ9SyJGtiG+nc4ayqxsLIsf4Lkb7q5u isKvJrpJcUiW113PQaDfU3N4LWa/MUfxrdIeszhLEh+4+qNiaTI2KnqFcelK0cRMWKZl4v dKb2oGE4EFVC2BC7W1p1GhUbw7RgAdSQbS4W1v9BNdNXueHcUP70KMmHyDkDtQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 24 Apr 2024 03:45:21 +0200 Message-ID: <20240424014522.4015429-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240424014522.4015429-1-michael@niedermayer.cc> References: <20240424014522.4015429-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: yB9JZXgWXyXs Fixes: CID1517022 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/qsv_transcode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c index a4440a3403f..8e843ddd84c 100644 --- a/doc/examples/qsv_transcode.c +++ b/doc/examples/qsv_transcode.c @@ -76,8 +76,7 @@ static int str_to_dict(char* optstr, AVDictionary **opt) if (value == NULL) return AVERROR(EINVAL); av_dict_set(opt, key, value, 0); - } while(key != NULL); - return 0; + } while(1); } static int dynamic_set_parameter(AVCodecContext *avctx) From patchwork Wed Apr 24 01:45:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 48243 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:2d06:b0:1a9:af23:56c1 with SMTP id tw6csp363394pzb; Tue, 23 Apr 2024 18:46:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXk0aJYUkEDXZ6AWp7XT39544Mx8TziOineVkLBVY48vHHLFIXobV4RfK6/iRPxrf+XADwR4LTlfl5LMbbOOpfi5uplpbAZNg/UXg== X-Google-Smtp-Source: AGHT+IGzMNGERqSIcmizEGp3MmPI19Xa6+V8qXyeuaeNHLQwcz1nd3amuAN+Da61gW8cuqRpESGV X-Received: by 2002:ac2:5dd7:0:b0:519:1a91:30cc with SMTP id x23-20020ac25dd7000000b005191a9130ccmr713287lfq.4.1713923172341; Tue, 23 Apr 2024 18:46:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713923172; cv=none; d=google.com; s=arc-20160816; b=diV7vxYuE9lGmBaRyIPvj+IHnBstlHuhblUBuOqzDQiVNvSGV1My9vu+9vxF1cJMCG f34cjxfRKN5pGgcIZ4du5kSmlBUDKXSnAV1/K3QT2WifEvaq94LiLpK2klvGW+J8k8wd uEQK7iuNu3YNhZgkwU6MzwXaEqurrQEBDi+R9S7VZmpCMzyIFiuMZ4dBHQRP5OfM7MSm agY9YUzdNzVGOy2M9Nz1k1nPYPRWJYTpEmJMCCxbiOw0514G2qMWkAqpvqe0LGWwNbj7 NCdQOb35WcRThnzwBeuK7HBYaS1zWqA/fBx/fKNwGkN37W6fHAVMe/KMw9uRYEoV+XJk In6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=cZ/jGy9Qqm+x1tqQ/dVSYVZ7dBtFJBAAlzBgvxXRk34=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=LGlkFhv3SG2IRfTXp4LbJLc/3YOoQQprB6jjgkooE++ZEyyM1qKMzJlX1VZCRV/pLc ufAGWMv6uRP+KMaAyot2vOKTMysmMRCCwy9LCsKND2AWqAKyXUUfwlqqicPsSyDz3Y9L 6fwwDJVSxRVd+iIeYZY/noYUBHQHTeBjSUd5vsf+lTOB8h4qBqrGOPXgDwfT5wA3qyJr e37X3VQ5+EyLRrJF2L5IFCiBFGvSgKVOKeJxFi9JdVIsro+PtMZDGHurOrKUe2uJE2Tj Tjo1T+8NmpC6AakCrOLbsfm5EiJdYNTyJSNxsg+iWL8XxIfcWFYBvwVI0qzBzg7bE3vP mJlg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=GZi6hsM7; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m27-20020a50999b000000b00571e987f608si5163500edb.410.2024.04.23.18.46.11; Tue, 23 Apr 2024 18:46:12 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=GZi6hsM7; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4CAC168D40B; Wed, 24 Apr 2024 04:45:37 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0ED6E68D3D5 for ; Wed, 24 Apr 2024 04:45:28 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 42ED740003 for ; Wed, 24 Apr 2024 01:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1713923127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jImoc3n9tAKVrp2ULXNQXMMBO95Mk8/9UOXNca1qO5Y=; b=GZi6hsM7ySnsz28tvtyiS72ChzRKZHtL/osXpsVxkiiK0GRkTh/h7Y0/l+/XE6PqLC+hBh foCmHS1k2QPOoHIMUJRTOyl3xrJrQOVN76CUqCPuQTzFSvI8DoKvYPVBXOBlQ+Ktt4eaSy lBjTuJxRsDG8/YguwD3OAzdc0WDJ0O34B9A9umwmYSzhcSjRlrCNJU7PUgAOwNYGq+9FTG udEZ0vw7oaNKBI5+GG3S3PYW4n2p/MzVRJuldi+stJMIoNvtpR5BdoWE9p9xGbR7WaOt+4 ayqJiEsIz2lKgzr0A2zVnuOt/HKOmP+CVIbQlzhulRkaDHBjnptlnOSD0mgjqA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 24 Apr 2024 03:45:22 +0200 Message-ID: <20240424014522.4015429-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240424014522.4015429-1-michael@niedermayer.cc> References: <20240424014522.4015429-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 5/5] doc/examples/qsv_transcode: Initialize pointer before free X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Ux7FzSYYXxa1 Fixees: CID1517023 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- doc/examples/qsv_transcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/qsv_transcode.c b/doc/examples/qsv_transcode.c index 8e843ddd84c..665a76af2ed 100644 --- a/doc/examples/qsv_transcode.c +++ b/doc/examples/qsv_transcode.c @@ -342,7 +342,7 @@ int main(int argc, char **argv) { const AVCodec *enc_codec; int ret = 0; - AVPacket *dec_pkt; + AVPacket *dec_pkt = NULL; if (argc < 5 || (argc - 5) % 2) { av_log(NULL, AV_LOG_ERROR, "Usage: %s "