From patchwork Tue Apr 30 17:36:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 48433 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5007:b0:1a9:af23:56c1 with SMTP id n7csp1159320pza; Tue, 30 Apr 2024 10:37:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWRmi2hHwgpHez3BwaVIDJ+0YPwKFHcXnIFT/6nDxtVkhxlqOx8SxJC4s3MmDaVIWahmKJs2GwdO0wfbcq5Ch3d5boPjQNqpYUz7Q== X-Google-Smtp-Source: AGHT+IFQPxetPRFqr7va+j+UI01risdg0xeEHBYdV/1e4nV9dZqnN/AYP7i2vebt9r/C0DXAkazF X-Received: by 2002:a17:907:1047:b0:a58:d757:6cfe with SMTP id oy7-20020a170907104700b00a58d7576cfemr335910ejb.6.1714498648952; Tue, 30 Apr 2024 10:37:28 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hh15-20020a170906a94f00b00a55a8a66b8dsi12273174ejb.932.2024.04.30.10.37.05; Tue, 30 Apr 2024 10:37:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=DXd5ZXN9; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3EB0568D5C3; Tue, 30 Apr 2024 20:37:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2034.outbound.protection.outlook.com [40.92.66.34]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E7EDA68D53E for ; Tue, 30 Apr 2024 20:36:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=InIO7VBZJQP9MnrofeEr2y8ofgJxfswi2iQX8ommplE5PggWslp4mrfm+c/eEzyeG0YOz9u+Hmu2QtIeiXYUuF7bAiqzmkBgCqnvbiS7VvawDmejjbrHKAAeaR5FftUXew7GnYe2EabqZo6AX1eMFiYLzTBaKdbt3mkC0bg0YG4oKzs5Ep9jDyqxTwBuII+dU8oJ8Cc9LdQuLGFm2uG9l4otDDUFW698linrjY2oDHmNE7nNMSFm3/T/KvwgWpYxDT1leyBSbHp25+Z1nrC2H373gO1UIiuGY8WAqWEKYJcCTJkrJC+LOMU4lFA42R9rhoXc6TlmdkKpg26rWEm4bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F/LE5/neO4CZno66X4HNxPH6wzPkqakpe/PMwX5ZDos=; b=dTDdG4RpshGRGW4R6mTKmU5b3yaZ+p53rawBjFLSl82l1HH36mDqZivMoPTMq3RCcGYTF7ChIPqPZl1FVUg1T3KBnLg2dMEonWvsRQ1+OzeqaiHZVc/bifK9bWE///HAqepToJI6m974HR1sPWRpKf0SotB8vkbOtqvZty760hTO1YNLsXna1h6XSgxMgTkHxKpLOrGmW4O3sf+c1BvXA8LDr9zwHH4Bu59kIeH5drsyTgjbbGBpS8xGVm9U4QRXhRx1k5OFImuHDPia/dqLOPwBYqIxEA2tOgFxoAxYyOfPtulcWmg6rg6vOpM0zkIojkSV5zI5YNOUA/yJ7ti4iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F/LE5/neO4CZno66X4HNxPH6wzPkqakpe/PMwX5ZDos=; b=DXd5ZXN9iH3dY4ENAiTqSaTis1BxT0Le9LkS9ouB81au5q5pEUtM6qKTYcvQmnBtwBfrbQCOXP4V7kkct7VWI6kikaxmmCMm53hnzN47hLXWn+8MX5Wm+S7pLCFEktM6BEzT8w9QlLa0mgRcqh9bMqtKmTwpM1yahjhjxlLe9qcCpUpw2BM/3UlfvExe7NyeSLIDDsZwMJHLQHuU68h/C6alIaHKFQXnxK26GhVS19rT1opLr3NQr4HvesubClF6w+uC9Z+UX7Fj49sfL13jS36iisSHd+F0ROF4Ta7mC0/c9acnoVVu/K5fr5Do5rd+IGU+qxB2Y1jEw1FqsmB+kg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0389.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:328::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Tue, 30 Apr 2024 17:36:52 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Tue, 30 Apr 2024 17:36:52 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 30 Apr 2024 19:36:45 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [Cf2XlEJOGsZa8HAJ9Kr7/+0g9ZvSjSmhhrU0ntYlCgw=] X-ClientProxiedBy: ZR0P278CA0046.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240430173645.3737677-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0389:EE_ X-MS-Office365-Filtering-Correlation-Id: b4ea3853-5cc6-4c01-dfde-08dc693c1f34 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|3412199016|440099019|1710799017; X-Microsoft-Antispam-Message-Info: KDlJ6p+FlosuRR7c4pcmcO/AA9V5vXRuJJARDHBZWFBi8JxrW4aTMsQ6x06JZmlWO+ohjNBY0wOn8/4lscLEpPeKzuY71oMXwwTJ6fe0UKX26FAO6vHHdCMbmjvNRODn9Hi4BqqDj8hn/OUtTyPaWTClKRZshySz2obXZyAVs6aEL5WoLhcibtTf8CDcKHHUVew6mOG+6GyR7tbDwAwI9O5PUtD7SGIQpaWZL9JoTqeZGVxyFPNIL6mfJx2lUDrIwaBmPkn5YA2qSUARLIm5vHb8jdeL6fL8f5c0IyFFId2rwYirsZR5wAf2ATaZjlsm0NL0krKBcURPaE56YdCgDH0q0HJhIZy60H38GNJI6HYWWr/9kp23wa0CrVhyJQ50mtatRSCvF5f4AMCWjYpf8mfDB1iO1BdKmxbgmimb2GFz98VdQQy0/8ZGsC38S6xCstrQzOl4EiFYk0K1UxAr4KLUjA0Bj90P6Dbvn0p5VUHMUhI69rcHQJSS0GE1mRkWQBcnATr3OCTomWCua//6u6nQmobtRvQZxmImq5h28YjWK0TCTtj+y9bkYOG6pEoaVsCpk2bjtTJVJ5NCYbXhTxQQyIrKehyevNpQNI8I3ym1EuatLJy7kfVIqFVaLm9P X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZFLa9k4bZUEaz34MpMlxPPdF20N491uThmiH+2/OytDAv4N13VOHQqP5GFLB1E+YysxDSpc20aBWt2IQB0Ia0Hs8rLzWTV7eMNr2ibH3PKeK5KzAytvsTE1gaFOq8v5NXyExYWzJyXFlb4js+4YaBDANyg+Fujo+ltbDg743mnKzuw4WS/ZScnyN1UsGXQiH+G2b3U+FcME/Af2xJJLgL6q5E+hkE++g6Qp+TuOV9x+bPG66aC2uSKAc40G4lqm2q5EOE/V7CnudhZ3TYEV+Z/z/YSgaGxvbb0yGSqj9urLMLUtgiQOLfV5Dvfk4N75FZdzljDHAFwlHCL5AMBeJ82mUjAasmKHB+ZdoX75MxUNW6aBKULZgn35TLGZ23qcaryb30IuxXdg4NA4P9iUWKIOGx0hjsgmqgqLQbchR7xVEIXLiog/qT39Wr7w06y9OOxetblXKBsAJ1v8C0h2QLToQlfFwZhhsZsCOYHRWuKZOXjL+IQTe+6xgxJR8NtQELaXLffByAYk9hBbXN/nGPs882mok0/cJoPDMatWiwA6H2wXlAMOlwInVEOMDTmFXiq4XTjVdurGDrvjJ59DYXV1Idfu5MmYVOEK5PTqrggpAVDk5Sdhiaey57t1eBbb6ySjFQ/HiOi0HBvc0ppe6eRISwgrTwcHmNlHh0G5KKSIOEIiE6L7bSU9hLjRl30V58LozS+bWNGtiX72yvbmd6cuA4P1kim5ipWsYX0/C80dQkgW5F3Mzlu2zVmLnh3wmm0Eh37WxowKnB3CBgpx2nBiojfDItY3evtnN0qZEs21Nv265ir9lcSTwE2C5UZwLAFlp+t5jP8Vn5dbaBHC3rxNUG2pydroRO0JT+OVMJhPmYJDOvMgo3jgsw0SVq/1hm5+6E72076LPKHdf/9ibl94blX9XaZCsebj/jCMSNahVYvig23lezE5/y7b+cj3kVuD9OiKYp0m0miopT9NBFUny1zawOakDLs5jNyq40xJssoOV9seOZFiGybkc3zO+AM2fTTSwwht6fNeBmkCCawcNtNFDDYEh7oHV3VRmMgdQNFKi0bUn2PRhMHXA9SpSdQEnVJN7e79FV7oSGhAxrtkBAiwNtNjh0kM/e3Ke2DINbHj4JjCRqyayhAYi4leRuV3PFqneZteBnD2WMkBHUYtQNupShyuLEu4Pv8r9ALyZG4UkpfW6SjvkDNF9piBQi9HLX/fKY7qtaoHu5+FI886YPFB2EMWJbuLNuucNFqxf55pS3+CR/3y5EXiynUGMhP1z+i36D1LhDmZszXJPBw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4ea3853-5cc6-4c01-dfde-08dc693c1f34 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 17:36:52.5749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0389 Subject: [FFmpeg-devel] [PATCH] avcodec/x86/vp3dsp_init: Set correct function pointer, fix crash X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: q5GaFCIeoRiI Regression since fd172185580c1ccdcfb90bbfdb59fa806fad3117; triggered by vp4/KTkvw8dg1J8.avi in the FATE suite, but not when running fate as this code is not used when the bitexact flag is set. Bisecting done by ami_stuff, patch from user Mika Fischer in ticket #10027 (which this commit fixes). Signed-off-by: Andreas Rheinhardt --- libavcodec/x86/vp3dsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/vp3dsp_init.c b/libavcodec/x86/vp3dsp_init.c index f54fa57b3e..edac1764cb 100644 --- a/libavcodec/x86/vp3dsp_init.c +++ b/libavcodec/x86/vp3dsp_init.c @@ -53,7 +53,7 @@ av_cold void ff_vp3dsp_init_x86(VP3DSPContext *c, int flags) if (!(flags & AV_CODEC_FLAG_BITEXACT)) { c->v_loop_filter = c->v_loop_filter_unaligned = ff_vp3_v_loop_filter_mmxext; - c->h_loop_filter = c->v_loop_filter_unaligned = ff_vp3_h_loop_filter_mmxext; + c->h_loop_filter = c->h_loop_filter_unaligned = ff_vp3_h_loop_filter_mmxext; } }