From patchwork Sun May 12 23:11:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 48831 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:3a48:b0:1af:fc2d:ff5a with SMTP id zu8csp27595pzb; Sun, 12 May 2024 16:11:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXyAlQWgAtljQAgcBh5Dlz8AhcQZfspl6LyxGvFNb52GF9jULpHZN+kNNqPfIOvt0xhNv1qKvC8APcRG8bMrEo/yF1ss7jfpZlb/w== X-Google-Smtp-Source: AGHT+IFto+cODaeGlqknlg12gXh1hFjtsr5sEunKCyjFcUDu1UpLm6TMWk5jfoDDJ8PtVsj+uhjB X-Received: by 2002:a05:651c:543:b0:2e0:9646:8512 with SMTP id 38308e7fff4ca-2e52016b443mr58650701fa.31.1715555500377; Sun, 12 May 2024 16:11:40 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5733c32d00esi4279470a12.463.2024.05.12.16.11.39; Sun, 12 May 2024 16:11:40 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=XKtGOhYj; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEBEE68D5DA; Mon, 13 May 2024 02:11:35 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2060.outbound.protection.outlook.com [40.92.66.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E387168D3C5 for ; Mon, 13 May 2024 02:11:28 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fuvFsdFEdRJjzzAPbTcttQyET0QCJZgRKVUKRYv7z5wKRnmGu0b3TxqshPF5b+1uTyXar0B2Orcl6WuVEWYYG9Ae6qNLmzw5HwFkNzV9lsl6S5KOquuTCPwFHKGT4mk4pNAkk4y80PVs/5U0RJ+WlJc8jZvOjnxk8mzI27NpRjkvq5rh53M0orND+D1M58oxh/hWnFqkhDbwfRnh+MlEOTktsYKtusoRSrQptQaAEp0vosB52V4lFPP4XKqJ3NPzQNXaotSgLhi5spmB46JZ59j6TKYuoUz89tU8N4nY1smsqU0jPP0pCeqY7qmS+fYD65QYW/laqPybvaY6wl68Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMyWQ0XdGeVG/Obfa58p4nOgCKb+6BuWCpmsO0xJjH0=; b=UK+xCgYrMOseuZEi0d+8cS7S0qCZiqMpor352yYElCdcXAtypYBhvTvXhUXyHCFdRwAg0JOctfzNaII9eE84Xl/jX89nW69ThuzoAa/Sra1vlJG+fFwZ88R95CDG9PQogT8Bzr3Zb/R38lyG1OgBArLmp0yRcLToAZMsl2U5MMiEsj7RG2c6zN13JZc6BrMJM5oETNUFmxWQuuJv1sfwYjy2OwtaiYn4YctRZkd0tAtvsoJpcufkzxnaRXlG60DmH+mKUCfezZB7aQ1a0gOcURyN64ERmJORHL45CgpRGqArFepWLp093EM8Vo3biV4pUVEcLxNPlyio0924bDv2Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMyWQ0XdGeVG/Obfa58p4nOgCKb+6BuWCpmsO0xJjH0=; b=XKtGOhYjYe5FJIhgDT5jybYfSh8/yz0XFfswrFtExdV0WZdwoYHB7/QRsfLM4B3zjhWbC52MbusriIaGA6bNDMHaq61XesvwMxbpinf34tvTUTUesqoeVwselKk7xiypYF3c3eKIs2IWoszZE1rjYZORU6MPeBRT3l1JuW/uCm8ES1GyDPVA9vQMFBzok8HGBUYM95rGyk5ULE1pJtpjkJq+eWZLhKA0tCwHTqucn73kkGymxH53StRIfmqqMa9UbWFsp+Srm+zgR7sfWcWxzQpXcJ9NXXabYXPHrQEhw5OSMGruwlYHwmsKNoKrDxZjsMcC2j+lLeqcH0HrFVGIkw== Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) by DU2P250MB0208.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:279::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Sun, 12 May 2024 23:11:26 +0000 Received: from GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614]) by GV1P250MB0737.EURP250.PROD.OUTLOOK.COM ([fe80::d6a1:e3af:a5f1:b614%7]) with mapi id 15.20.7544.052; Sun, 12 May 2024 23:11:26 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 13 May 2024 01:11:19 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [ABA3qXi7bzao2gLYGjtFR9BRsCKcy6TGh6nwJ6SHiyQ=] X-ClientProxiedBy: ZR0P278CA0080.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::13) To GV1P250MB0737.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:8e::17) X-Microsoft-Original-Message-ID: <20240512231119.2999513-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1P250MB0737:EE_|DU2P250MB0208:EE_ X-MS-Office365-Filtering-Correlation-Id: dbcb9a36-d124-4470-8c89-08dc72d8d940 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1710799017; X-Microsoft-Antispam-Message-Info: fTQJnqSUQHlFqzIIPw7TIGhCTJvo4G8X7umLyr6P7yj9q/HpBlaZD7NsLWbELAnZ6jFTy+rc4umkZdKuI8U7tBpse1OIik+UpXfkrlUodR7+dph+zFMRHhTZGGfIZNTO3EJKWfWMMvD1xPBQ3vP/+4q78OTAj9FUA667A40hzWlI9fkBCcTNFe5pLIGpYYIisv3ciNoJkW2SY1YYwTTQ4IizO8SmPWa15oe08U0tFEpFlAytDghfg9lKpp6vyFIZVBeNLQ9tNbqx6GGYkkjQSC+4sAFhM3mRzxnOP1QKFD9LR5f3DSADTb5bwaCMhJZhn70pEOjd3bFDZGi7C3Pwf8HRck0mKBDjn7blyQtSPamkzIQRSS/ArEVBW4NZh0TF0rhBx4hfs1chMs9KGwt4/5N32wh3jZj1tGq5LL4/fvjqANz32/QpVSA8sfJ323N1F2wWbrhA/m3t0SVOvtgd7tLRANOCforbSa2F837L5RJRJzbAfSVQ/m62z2pgB8o2ZOEIRDPeEkn6a0iAoeX6u2/fE9CCEjwqgh4vXAgygMkDIJQwnNJ6pz8ejFlnCaV+jgW70GjA95fpvCWCP8SDG142SCjjAhAE901Xo8SbkNL8GpNqhve/OuQocokWtuTj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: n22JoNr4g0k/F9hfgxb0a6D+pIRyUE32/l08WZSIT221kkcGWybBqZlRallroXc7zPCuS462iMSugNG75ZAlPwPpXJ9OJpIVMYXHd9uE+5m34a9hjaiTOrWRXL3/oC0sGrTuuLxvNYUGZjiYJDu98BX/ehxNCeMeTD17xficP8ddWExJK6r2eFKb2qFq4j2Mx8HBj+gxDsPwMDEiN+pgn2DDDCwGkSIRNQ0HXAFnv2911KIt3aY6wV7RJ08JMq4Dt/xirau7G/JhAvvN6MPj7RYfTH4UT76KFIQVoIOzSsgHlVGWzZE9X86TKnNwFjZHUMkVSLPFzrX5vGHfOn3WDcxj0RCMC7HcBBrBi08JIgUDsSAKLkhxUofWhpcfsfjLWbNLfJnPk7JM+pdynGVKM6cOe25PLAnSC9C9AbPgEPZ4WQiwvZuhSgvbB1z2zpHw5zgc9E58Z4nOOGPBldxdHLLsly4Xp3G0NIbmgXA+Mo4BGF+FhjjgrOd0kvHuZTszVtzUj19AQUTEm14Kgg2lDZSqUXfTF+UVSuJ6z6pQxnzHGZzbo5nNkjwVMBvi15M7zsVOZBNt1dUo8BDbnYODU+AVhynQ5XQEVHlfXmlPk1gjpS7tNFrHJIfXJomytF0f6/HkuV0zWO0+HJJHZGI72T1ZmVQHtngNovUgU2llI4DohnoJ805+78fiHLBmVOxPYTMzRg8T/rVr3rbZfFUuQIpet5cBH2wjh71g5C7NmjcF4+TbbCmah/6Y1vP+vtgc2sWv/PHNZEYOLdP8Kn+YxlOAOLzCuZ0okjrg/otsgOzu0ZY6Mo8QlGUuZPbk034VljTOMoIGCD1F8fZnDx67bcW5ItsUC3UJmt5f9JO3WZoZSepBpa8Aqp2gQsvuechNJF3G1jaNYpz3QF5DW8auGfQTIGBmGuPjRiBn+DCBJI260jErP8GUmlIpIjUZNDIpF/4qRdE995od8MgXCTVaG9H4Agkqs/LUFDsUjnlIGHHpjtZ7qQjMeqH30x75nMSO5lzijIVUNBHeasQwRwnN6ukawnSnpozwdfAuJkMMaeGyK4Q67gljoRT/0BqpuT3aVOneRryAT5CtBtOoDV+rc4JoB0JGaaYJgcSo2A+OU46usLzerOcwlowIgEHQHhPL/uhcxdMtPOTIxFit/xkDPIR+gHOLY7VOwAdngz0f4DarkQnE36CLfoXEUJv943ZwXO/h/gkDab6rJQiSjEaudtGvEMWIU63imKYPVeaLPHuM+e6jqEgpOKR+TY9FhAlJSN/Ox37yFIlzK32XwzY9lA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbcb9a36-d124-4470-8c89-08dc72d8d940 X-MS-Exchange-CrossTenant-AuthSource: GV1P250MB0737.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2024 23:11:26.5337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0208 Subject: [FFmpeg-devel] [PATCH] tests/checkasm/llauddsp: Avoid UB integer overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: hDnz+SDa9d7P The only multiplicators used in scalarproduct_and_madd_* are -1, 0 and +1. Yet it is of type int and the checkasm test uses the complete range of int for it, leading to overflows that don't happen for actual users. Fix this by using a more reasonable range for mul: Given that it is used in v1[i] += v3[i] * mul with v1 being a 16bit integer, it makes no sense to use values for mul that don't fit into 16bit. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/llauddsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/llauddsp.c b/tests/checkasm/llauddsp.c index e6eab589b2..969166baca 100644 --- a/tests/checkasm/llauddsp.c +++ b/tests/checkasm/llauddsp.c @@ -49,7 +49,7 @@ static void check_scalarproduct_and_madd_int16(LLAudDSPContext *c) randomize_buf(v1, BUF_SIZE); randomize_buf(v2, BUF_SIZE); randomize_buf(v3, BUF_SIZE); - mul = rnd(); + mul = (int16_t)rnd(); if (check_func(c->scalarproduct_and_madd_int16, "scalarproduct_and_madd_int16")) { @@ -84,7 +84,7 @@ static void check_scalarproduct_and_madd_int32(LLAudDSPContext *c) randomize_buf(v1, BUF_SIZE); randomize_buf(v2, BUF_SIZE); randomize_buf(v3, BUF_SIZE); - mul = rnd(); + mul = (int16_t)rnd(); if (check_func(c->scalarproduct_and_madd_int32, "scalarproduct_and_madd_int32")) {