From patchwork Tue May 21 13:51:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Dekker" X-Patchwork-Id: 49101 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:3a48:b0:1af:fc2d:ff5a with SMTP id zu8csp5245729pzb; Tue, 21 May 2024 06:51:45 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW6Ueb+rI9asMmNdegQGBMw7vWfZZpVy09lbuyjnuyZbTT7s1xYpMb3S7EbRKmePjYakqT/GwD8cZRbAOmqGyfzFxX6o4jqNFg8kA== X-Google-Smtp-Source: AGHT+IHU5u6xei8Ij6TURlrq36J4LoUd2occfSX5aOcwEbutharC7bgMp50iSOC1sx+7TEG7BZ17 X-Received: by 2002:a17:906:d10a:b0:a59:b498:3ae5 with SMTP id a640c23a62f3a-a5a2d676354mr2845732666b.67.1716299505265; Tue, 21 May 2024 06:51:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716299505; cv=none; d=google.com; s=arc-20160816; b=Ted+u4F+sYY6zlaUDg1/f1DIjX0Ti7ZMt+RopOYUT2jrvNaTY1eTLRp699TT1ehPdF 3qxFBRGAM+C6QRz0iJZ3NRwOfDidUfZi5oR4afRuNwRpZabEf931wGxjfvUPz4oFas+O Hux1nDsKW/7s9guyBYiTnPD6M2JQAJRqNi4e8sTlx/oXYaLGbFdaxoarEBCDoihgBeeY jczJ8Vr59XiRXSjEDkiue9A/L+LSZD32iKwQvP716tZCkonlUhR//lDmXQIWFfYSEk08 UnBegqyBJ8E/BxvGHChbi0BENE78GfUK2OhfBdgZItJR22DwbfF3UWwP18LMJUs7eZnv I5Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:feedback-id:dkim-signature:dkim-signature:delivered-to; bh=izP+Gpz/Riyv/37Psnz/lnU8E+VYAvDLOHolf51ZUvY=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=HmfsLdMmGDyQAlDt8FZ6Sk/dfHjkVopdu9tTGhpOHYSyGyGZBvBBqTDRVXRzGcPBVP BNhcMqj7ybnGEtL6Re2T69L+MPEFcAWMuwfTV/LbyTahTib3DyX26MLirZCmFPz/Lvk4 gz0dDfv1YbHypEJQput1U7WP1+n+6RxSLCOBETW0tXc1F+RDeY8LbIT8Pv/TzbMsRdFf qr7i6pZT540XdPUY2jsB/nrwkcblyBbwNZGTxhbpuqpXxpmdoV6JIEqBU7lgQzDJECGM enElAj+MgjO8aijRvuxioVHxZV2at4j7sIFOU4WHXoAwZkqLH5bMyQniNPoH24bFVawF qdsQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm2 header.b=SoUUD4Kq; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=qSlZlDOm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a17be675dsi1444792066b.731.2024.05.21.06.51.30; Tue, 21 May 2024 06:51:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@itanimul.li header.s=fm2 header.b=SoUUD4Kq; dkim=neutral (body hash did not verify) header.i=@messagingengine.com header.s=fm1 header.b=qSlZlDOm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5D3DF68D2EE; Tue, 21 May 2024 16:51:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from wfhigh8-smtp.messagingengine.com (wfhigh8-smtp.messagingengine.com [64.147.123.159]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0BBB968D21C for ; Tue, 21 May 2024 16:51:19 +0300 (EEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 6DC8C1800180 for ; Tue, 21 May 2024 09:51:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 21 May 2024 09:51:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1716299477; x= 1716385877; bh=7SMMBHmWQlqKCyczfCZMmzxklzt7dTIB/ywZhcfe3yw=; b=S oUUD4Kqy3wkOlQiVG0v2sTk7mhEcev3i9e+7tpn6O/76mVD5gn6//AG46lVW4qkk Oii7m25wdhgOlmJCCeXYAs3i+YXKJDIJZI0cM8wTGAOAqu29AFlwzX6xOkbhux/9 SjSyY03VTHIY1CJBnBkwvk2Mmy9Cfhfk0QqGruoTxSsnTd/L92DzJLv7Wf6rRMSP lMVKPaASemnlrU9gOiFJ9iNa9uNS0Sq4O/DtkPYtoM4/aAH5J0PvBYg5FGdHOdXG hzW96KIBAMD5NzyoWfrMeAw/eD5FksLeyoT9f0gqPBo0dK3j0tl5fZ1U1Rqcl2dt nsZuGmkIedKkZIGyUMbnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1716299477; x=1716385877; bh=7SMMBHmWQlqKC yczfCZMmzxklzt7dTIB/ywZhcfe3yw=; b=qSlZlDOmgLX8ZQDlQTI6NbzUM5u+8 PBAjG64g/roUgcac28T2SjGbPYmukU4hdn21VaLC5nhc5pXihZePLQlD43WSSP7b 2mCnN9Qo61ta8eyHjWx4JarHwmaMwgiJUIqMyvVXrGgp5KahOss1kqhQjqAwdmF+ xpWYo6vhVabjuzzR9xC192Hi31CzkzvDBr6FFjLcsHmsfII08eQrvyKkmgwRGGLb R7J3OiJ1vjYdES4j6NoZQRFiQaATj3qIOvaY2kVqcDzGMDeFEamVXB/I+WcqFQsN wXRZao5td8uMkI780mmBjnbtd32rps8W00Nxxrv4QTcCHpsRh3VFxHftw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeivddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepfdflrdcuffgvkhhkvghrfdcuoehjuggvkhesihhtrghnihhm uhhlrdhliheqnecuggftrfgrthhtvghrnhepgedvhfffuddugeehveeikeeifeefgfevff ektdehkeeifefhveeuteeufefhteetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepjhguvghksehithgrnhhimhhulhdrlhhi X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 21 May 2024 09:51:16 -0400 (EDT) From: "J. Dekker" To: ffmpeg-devel@ffmpeg.org Date: Tue, 21 May 2024 15:51:14 +0200 Message-ID: <20240521135114.40265-1-jdek@itanimul.li> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: PPiizNVRgQjN Some timers on certain device and test combinations can produce noisy results, affecting the reliability of performance measurements. One notable example of this is the Canaan K230 RISC-V development board. An option to adjust the number of samples by an exponent (--runs) has been added, allowing developers to increase the sample count for more reliable results. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 16 +++++++++++++++- tests/checkasm/checkasm.h | 7 ++++--- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 31ca9f6e2b..669f2be9c1 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -72,6 +72,9 @@ void (*checkasm_checked_call)(void *func, int dummy, ...) = checkasm_checked_call_novfp; #endif +/* Trade-off between speed and accuracy */ +uint64_t bench_runs = 1U << 10; + /* List of tests to invoke */ static const struct { const char *name; @@ -820,7 +823,7 @@ static void bench_uninit(void) static int usage(const char *path) { fprintf(stderr, - "Usage: %s [--bench] [--test=] [--verbose] [seed]\n", + "Usage: %s [--bench] [--runs=] [--test=] [--verbose] [seed]\n", path); return 1; } @@ -867,6 +870,17 @@ int main(int argc, char *argv[]) state.test_name = arg + 7; } else if (!strcmp(arg, "--verbose") || !strcmp(arg, "-v")) { state.verbose = 1; + } else if (!strncmp(arg, "--runs=", 7)) { + l = strtoul(arg + 7, &end, 10); + if (*end == '\0') { + if (l > 30) { + fprintf(stderr, "checkasm: error: runs exponent must be within the range 0 <= 30\n"); + usage(argv[0]); + } + bench_runs = 1U << l; + } else { + return usage(argv[0]); + } } else if ((l = strtoul(arg, &end, 10)) <= UINT_MAX && *end == '\0') { seed = l; diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h index 07fcc751ff..e05053cbf6 100644 --- a/tests/checkasm/checkasm.h +++ b/tests/checkasm/checkasm.h @@ -167,7 +167,7 @@ extern AVLFG checkasm_lfg; static av_unused void *func_ref, *func_new; -#define BENCH_RUNS 1000 /* Trade-off between accuracy and speed */ +extern uint64_t bench_runs; /* Decide whether or not the specified function needs to be tested */ #define check_func(func, ...) (checkasm_save_context(), func_ref = checkasm_check_func((func_new = func), __VA_ARGS__)) @@ -336,10 +336,11 @@ typedef struct CheckasmPerf { av_unused const int sysfd = perf->sysfd;\ func_type *tfunc = func_new;\ uint64_t tsum = 0;\ - int ti, tcount = 0;\ + uint64_t ti, tcount = 0;\ uint64_t t = 0; \ + const uint64_t truns = bench_runs;\ checkasm_set_signal_handler_state(1);\ - for (ti = 0; ti < BENCH_RUNS; ti++) {\ + for (ti = 0; ti < truns; ti++) {\ PERF_START(t);\ tfunc(__VA_ARGS__);\ tfunc(__VA_ARGS__);\