From patchwork Thu May 23 01:17:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49154 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734448vqf; Wed, 22 May 2024 18:18:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUYA/SCoWB3jq9tmRzV43fzmKRI+dtV++a7WPfH6+afQsn59UwR4EKnPiundPF77O+zLgdidthO/WsujBd6FbtY2lxmIE5LXvxA7w== X-Google-Smtp-Source: AGHT+IGymZuh0z/+5Lsr2m9Pz8nShnAlhlDIi211LOKqm6Rs4sRHoWRu2oPi0wBow8gQMRBj8L3W X-Received: by 2002:a17:906:4941:b0:a59:c28a:7eb4 with SMTP id a640c23a62f3a-a62280d4f1dmr214738466b.44.1716427091602; Wed, 22 May 2024 18:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427091; cv=none; d=google.com; s=arc-20160816; b=La70FrXluwC9yylCDJFtb5KNf1RhoWyQJI/4rqwOLCnqMlgxdzU3PkrZ7gEoJKvGqM CRv/zqzNBRDPX+B+uiPV2j+iOCpNXSNloi9lnUJK1NipJMCU5kcCjo5qE5uesyGTGsbY gV7Q5I/NwdJv/8VbfY1eYvuZuVeZikwVSFRvUIPAxy/xuiOx0Va6g4fqbQil+74CaIk8 Wu5Y0m+jPGip5Z3jJVwDk5SiO3kovrVIE1JPiMdEVnHzu1sGaLvJ5PmNevWlOjuoQs6U y9fJoknNbKsTfE1Qu03RVQU2ZbQSaR8v7oaN9KScN6SiXimQNOT9IADTBuJDgv14S76g ACkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=zrZDocMg6rns52HSOnDhZQNPh26OJkvAeQvnzDPsLi8=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=v5QFW8zwpgj0yXtnaYcgBcnXd/9hrze+JVDAPQWGmmg6tRqw83JBpe0pDC+vXrnb5K QgqDC4QzFXCi1U8z3d6EnC0qoMxmdcL3R6r4wVCKAK2HiyM+W6PVD/PtH0e2lxMK65+6 MmJVivf6kGz2vasWfKTozhkY1kDtSxQHcri7pGMkigsdsZy4ld6smA41Ml0UCu5DpCW/ wKwYbNXcbXZm8/IPrFHlwll771B83B7esBiZeHawv8ShaX8N5/LWv1DkFHHHiql1fbDA 3xAKtb0tS/2/OD2rdMR0CkOVWIXRGMfZOET6/W5YtQrpdq6Wjxnomw0vn/sSKDFTqmwK zMGQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=cYRwtdZi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a17be6dc0si1612127366b.778.2024.05.22.18.18.11; Wed, 22 May 2024 18:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=cYRwtdZi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A4E6768D432; Thu, 23 May 2024 04:18:07 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC3C768D26B for ; Thu, 23 May 2024 04:18:00 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8CFF520002 for ; Thu, 23 May 2024 01:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vVAF6IP7ITBS1YSMtV71q+WK6lrXQe9bCzabDbDRVV8=; b=cYRwtdZi4gXhT2nkdeDDZPc/ihbAOiH3izUni3IDl3JhG9vYU2d3VSKc+XMUIqIHZHLtyM GG+smGpjW+Qh1ktLY99vpsurcnU64Tg1/wpwGf1WkcL1vKXUcS/2Hs+Urc7GmmpP4yQo4U fg8e+qepa98Rdn9oKoEpAmcvdXHOhBmr36U56CaVVgqsuaOI26Ud7W5/h7qgsgn/y3IS/j +uP0dbxRCYNKkaD3XeMnSiRBaaDLxGkrmzqe/PZlOEc4Q004z9D0HmVfljt2jKT52AZ7Rm 9bRwW1Y1oF/o1wtvVKh5rAfx8G3V9iurO3fiOA9pDT2jA9Vzr9tAKnpSMDTvIA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:52 +0200 Message-ID: <20240523011758.2434580-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/7] avdevice/pulse_audio_enc: Use av_rescale() to avoid integer overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4vcZcKu5J/In Fixes: CID1503075 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/pulse_audio_enc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavdevice/pulse_audio_enc.c b/libavdevice/pulse_audio_enc.c index 3e2cc91f697..80136d1e20c 100644 --- a/libavdevice/pulse_audio_enc.c +++ b/libavdevice/pulse_audio_enc.c @@ -471,10 +471,11 @@ static av_cold int pulse_write_header(AVFormatContext *h) s->nonblocking = (h->flags & AVFMT_FLAG_NONBLOCK); if (s->buffer_duration) { - int64_t bytes = s->buffer_duration; - bytes *= st->codecpar->ch_layout.nb_channels * st->codecpar->sample_rate * - av_get_bytes_per_sample(st->codecpar->format); - bytes /= 1000; + int64_t bytes = av_rescale(s->buffer_duration, + st->codecpar->ch_layout.nb_channels * + (int64_t)st->codecpar->sample_rate * + av_get_bytes_per_sample(st->codecpar->format), + 1000); buffer_attributes.tlength = FFMAX(s->buffer_size, av_clip64(bytes, 0, UINT32_MAX - 1)); av_log(s, AV_LOG_DEBUG, "Buffer duration: %ums recalculated into %"PRId64" bytes buffer.\n", From patchwork Thu May 23 01:17:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49155 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734497vqf; Wed, 22 May 2024 18:18:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXdByCu9FqLOx4l6F7V4LUZUy3Iz9qT0vkj/MZP6xh7qSo9uCVKz+jCiToL1uMCYq+Z6kZDZM+r6gsy7b6hGQUm9HDLLvRBkKHlow== X-Google-Smtp-Source: AGHT+IF1j4NTUUXxXjPXUThl07E1TlL1XWjoS9EfI4KzukMvV2dHEiJEkbcvL4N8YDV3P+DkxK85 X-Received: by 2002:a19:2d17:0:b0:51f:8ad:673f with SMTP id 2adb3069b0e04-526c1d97438mr1838862e87.5.1716427101413; Wed, 22 May 2024 18:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427101; cv=none; d=google.com; s=arc-20160816; b=hmJNa66mGJ62b7ygovKqRh3Vii8C0mMYz6Jq+ExWvyKWuAPAcOiHs91GDtEQmnBXyD Hx1sGeGyWKSaIQD18xuCwC0n1SNwXNbAXUiX8YDr3nX5q8j92NPvO5UJggcp4/uieT3I 38p2+rSp0oIpAPPPoAWrjHGBv7P3+fuGq+STzpIEUYmQRrXv57ahu3F/IYidU8uSyssl 5U9jORESzzJJMIcUwgTtBNLw3rR3rePOCb0P5+yJ2C2zsG/bn7zyGnE7bqcQz76II2Va aLQQi/6c9cv9BDpQxSYq2wYGtPNi/49lLbBEVBOy4Ea2MKXNBbOtZd3UA+NiWghpOi4Q GOSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=UYSghcv6eYmenhvZtGwSVsYRvzz9YVonBvZWmBTUSKI=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=VhbO9suyY4q3oE9Jjy7lXfThLDgRCjz6LMO8EmFutcfnoj6ZfdigWOEX4r4GOL/kIE 2NoSAQ4R0NbVLn15NhBIQCshrUHkSwZf0T4SLpOfsOqKxuzOe/YcFTzt6Mz5DQEueYGS 9sEQQ7SSF23lfGiG/96kouT4xj0EzM4iHjCxCrKQ0ecLDX3doWUa7hZY9ZiInb+2mLCs /Vn/TgJPkjrHGRMzVW1b4A6l49IeVTdibl4xtXFug354j350CPnMUBL9b30J3So+YVT9 0brO6wo59OVTJbxOd5LChgEm7QVJZ1n3PWK9S0vFknlgM7WJDj9i3K5khrhwAmOUN3aC PkTw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="Zu8y3v8/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a17ba55ebsi1613882866b.610.2024.05.22.18.18.21; Wed, 22 May 2024 18:18:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="Zu8y3v8/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A447F68D41C; Thu, 23 May 2024 04:18:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4739568D26B for ; Thu, 23 May 2024 04:18:01 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 74D0260002 for ; Thu, 23 May 2024 01:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxzF1WaXs7DItuJLYzxrcW+ENYljawMAkj/uM/70iHI=; b=Zu8y3v8/pv35dl+Fc8eB/Q4z1ARtqecwYbCfWq7TdjVwCEFEiF6V/CWm5Ys30jGjHxDLW1 9X1xoAN5d9dwwX4zOqcdcWNg1Wz0/S/wEn8OVoeQExKwTuRlISTfKG4x9vuxZ6IPRgpAdF yazcVJ1MSCYL7kgsO+3RQA+TzH2D8DuATjGyWLLYxMy92CPAo8fPhip06gNxUVGQtOlsTu SFMM0w4xVOGxaYX2Ug50+fZOwp2amjuOcqg1jF4vfeJECJQTMQpadLDJmk8Hx20A2U8wsQ l6etiFCAnSbM1Hne+Ht11fttbTP9MVYODs3/q2F7ExtyPdva1eu9HNqO8maCAA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:53 +0200 Message-ID: <20240523011758.2434580-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523011758.2434580-1-michael@niedermayer.cc> References: <20240523011758.2434580-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/7] avformat/ac4dec: Check remaining space in ac4_probe() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vOovLZYaxB7U Fixes: CID1538298 Untrusted loop bound Fixes: undefined behavior Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/ac4dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/ac4dec.c b/libavformat/ac4dec.c index f647f557ccd..dc6638de3a4 100644 --- a/libavformat/ac4dec.c +++ b/libavformat/ac4dec.c @@ -43,6 +43,8 @@ static int ac4_probe(const AVProbeData *p) size += 4; if (buf[1] == 0x41) size += 2; + if (left < size) + break; max_frames++; left -= size; buf += size; From patchwork Thu May 23 01:17:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49156 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734536vqf; Wed, 22 May 2024 18:18:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUtzz6gB3qs1+Wo+JCYE543FVn40zFzhO/Hm/f6fC8cNleSgpaxBIrog1oEZZV3GWLIFcNSSY7Jn0urPzrZ/XwasQOvLz4Te9pRzw== X-Google-Smtp-Source: AGHT+IGwbHvzCQ1pOwkQzD277kKO90pXLii27NSMV2ECEXKnA/4aW1JsboscHWH57np91eWJv2l3 X-Received: by 2002:a50:d4d2:0:b0:56e:238e:372c with SMTP id 4fb4d7f45d1cf-57832c1a8b2mr1888322a12.26.1716427109953; Wed, 22 May 2024 18:18:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427109; cv=none; d=google.com; s=arc-20160816; b=sIrGNs3K4v405A08QlToGQ0XECBCeFZlWywSg/VwlQVCK8dKrhRmI9ty+oETl3rW0J EMy6Z7Slh9lALg/ubODYxwCkq7PQ9kBGyAfqnNZRCkb3jmyxyMNUtZ+2goaUIKjUyyKl V/xywKx+yLUCGHgAf3e4P6EfqFiKWd2HwUMNiX4vfGa3CUTVZGZ1rJY0PUZrfn7bN0aU vGRweo9WojtFu2O579zTtJx0/uADJFrzyFl2Jb/dKKcbP+kzbnFWRyIok/+NSdmnTUYO VbDhlxnLbOfONVfciJXGFBZR7JdSGSjoveyEMBErLt5rQlMHhpqOCpLT2KQEL+DGXuI6 FL+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=6diUFbe6G54a6k2gCnsbMhB38L2XagquIxlvS0yLL1E=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=zrCRb+xhG7YvV+ed1bB1HXxFfEpue4LBmMrZnuERRpYhvg0eSTK1gW51v91l/MhLEW WXnUjMnvtJBhQp4qC5GiTBchCGq1Bi+4oLsHQTfhCV1zImSbbLJUgwGPoTmJdBZSXjrY 3Fv3PRI92aM4q4M5eJzd3krgcUpic6SMFV+h7qaV/RyT/VMNS61a0esgyBylYGiitWLp wg5BOLrzbxSO+1gC3uIhJ5SmGS3TrrgoWdkAj1UQaycTLJ9DoC3gRrs0gfpm+u6es/MA skObA9SXjSHz5Y9w4bA1JQFCwVyFtaJo1BBd4EXf8CvtRiIPx7OICK3GNc/vhKtqkvIQ vMMQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=fK50c0Q3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5784291f5fdsi368530a12.184.2024.05.22.18.18.29; Wed, 22 May 2024 18:18:29 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=fK50c0Q3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE6FA68D47F; Thu, 23 May 2024 04:18:10 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1B1768D1BC for ; Thu, 23 May 2024 04:18:01 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 251C460003 for ; Thu, 23 May 2024 01:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cm+1CZn0nmr9lbbn1AGaoDPjAJSXPQI7tRyK7wQvGiY=; b=fK50c0Q3MqYhVC4WsiRh44cw69wU8cXOnB0d6J0YuRmmiATnmw1Nzek78PZLlbfonb+mJy XTVsvWX8LvUoglpm3ggDwVFAJnt1thenI59D8JVUHzGVvnpl5fWC/5EK8ifzRs3XSbZ5qQ FNdTCL4B+FWWzNWLxYZ64jfUH+RmSbVysKYzHaSIxlYWop7VsOq3cytTA8ZLJbHzfxaI6I 7fTsX2/HIiMeUWF5/1ZcDlmnf+TDHiRzBMCSUd1A/tW+3Rt0GKQC94bUrfcnEbHr0EM7th LQotqE/0Oso0VwEV3sCGAKJV/LDsqfiFBh4WBHNqoWR0jwI9fL7gLRxFyvCyKg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:54 +0200 Message-ID: <20240523011758.2434580-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523011758.2434580-1-michael@niedermayer.cc> References: <20240523011758.2434580-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/7] avformat/ape: Use 64bit for final frame size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: z6nJEatMcaWz Fixes: CID1505963 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/ape.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index c0e3e9f4fe6..f86ca5e894c 100644 --- a/libavformat/ape.c +++ b/libavformat/ape.c @@ -292,7 +292,7 @@ static int ape_read_header(AVFormatContext * s) final_size -= final_size & 3; } if (file_size <= 0 || final_size <= 0) - final_size = ape->finalframeblocks * 8; + final_size = ape->finalframeblocks * 8LL; ape->frames[ape->totalframes - 1].size = final_size; for (i = 0; i < ape->totalframes; i++) { From patchwork Thu May 23 01:17:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49157 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734586vqf; Wed, 22 May 2024 18:18:39 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVWAEMVZNQBvVHK+UUaw5okJ2pGobG/rsTL5zEQ7XxIr9rtCc2vN/pYsYTqrdnofgWXc9WatuBRHMyZ4ycIUOAYAFF6eZ736RtMHw== X-Google-Smtp-Source: AGHT+IHLUJZHrL54tFfiSJ2enmlcSfFgsF+HSywJcKUAJe2zH8aOSh71UYZE9pccKDpbmArzQuGb X-Received: by 2002:a17:906:a2da:b0:a5c:fd35:df3d with SMTP id a640c23a62f3a-a622814343cmr224885766b.61.1716427118693; Wed, 22 May 2024 18:18:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427118; cv=none; d=google.com; s=arc-20160816; b=a3PGttG0qvWWuiNRP6W3ncnPR8Xmj8ae6vgsWN59QH6ZjzAkLSpvyQ2hpvtiQr6xX0 r7Crh86urq0HmzEsxVZyBJg2G20lLfmbMMzthYxUxZKBUcrFNmGNBUiL68sZXoglrwkj 5XIL1Tc2AG1zAMiwDqpo/HgCQvCDoQrfRwomULeT/07pB8zJ2Qk0LGOc6n8NVf57FuXX G3JLk/QgUz2h+IKJKjzLqmPM+r7N4zDggDJDecq+q1BVjwHAb4us+eBM6ZXKaX6Zbjwm 2eJu3iSNGI5W2zH2xoirajT4Rnb0MFmCxZvRTZUNGdB+6KAH9k1sXCtF5Qic9XnEYT9r zM2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=8Px6h/Ho0oli7BbeXKw0FOjuiCY7LZKmiYk2VGJDnqY=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=0o9N9qX+71hIEvDyhqTKMgrQ3ywtWMfZ6HX9jWsuoYNryHnZsOIAfKh6koUpBl4ekQ Yvouce9SrhLah7eLc9WIkwyyss2uSsokuCK9bzh/cT8hfAT+xRCIxVLpdupuBnCd87Ft euaUDins/GXxASu8e8USvIEjDHKCMuxt5LGoPuLuPMoMfMzMJ6IKoKxp7ecVLbH9T0mf nNpPpQ17QSFRc9lrPbovgypi60/6JTREqrH0K0C4+68GWj2bApBqPvfDnahuVf0HZZyz kiWTB3WZPTvTC1KWHpnc6OpPdTLe3hHo5M9ELfi2jnkRdmDUVsppQ4dZLVYRKn5OgNIP z/Iw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=GZgt3I7d; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a619678924bsi361520966b.272.2024.05.22.18.18.38; Wed, 22 May 2024 18:18:38 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=GZgt3I7d; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C2EB68D487; Thu, 23 May 2024 04:18:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 56FB468D41C for ; Thu, 23 May 2024 04:18:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 85169FF803 for ; Thu, 23 May 2024 01:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lSPmJNvB4Iu6Gz/uUauVzqCWIIge36qt4ldqIgCt0hI=; b=GZgt3I7dYYYBK4ano2TRGIKgZtQOfPVrJR3FHi/1vJ+dJlw8RqneuYsKFHejWLxv4brxNw 8WPXnb6hJDTjr3AABpmC2AGxPzjU+CNl3uz3LgX1haQl1FIW0FRFNWpM4TVflXrR0ZgDvp BrjRsDolR5AmQJv7HAcPKJG4SWV18/8fJ1RCIj9Olg+ldH1zU4fknWsa4fb3MZHn3yBlV9 lEWHGdZTd+NC5z0kfn8bhqpUdbeMlPTPrJjYcoPA+0XQZrMLQ+lW/hfmgZI3tBUQvdpKzZ U8DB0F1TNNq+M8tv0FnlUGABzI5WvjEkFDR3iOkBELkmEukCFF+GNZo7sbeKEw== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:55 +0200 Message-ID: <20240523011758.2434580-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523011758.2434580-1-michael@niedermayer.cc> References: <20240523011758.2434580-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 4/7] avformat/argo_asf: Use 64bit in offset intermediate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: PQfsFa4vss4z Fixes: CID1467435 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/argo_asf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 61bfc6de1fc..e08f029f80c 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -259,7 +259,7 @@ static int argo_asf_seek(AVFormatContext *s, int stream_index, return -1; offset = asf->fhdr.chunk_offset + ASF_CHUNK_HEADER_SIZE + - (block * st->codecpar->block_align); + block * (int64_t)st->codecpar->block_align; if ((offset = avio_seek(s->pb, offset, SEEK_SET)) < 0) return offset; From patchwork Thu May 23 01:17:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49158 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734618vqf; Wed, 22 May 2024 18:18:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCULwkGJPE6F8JNqy7qkzeAal5fKSlYcSMg2gSr4jeMJ34/lcTN6mN60bmbKTrlty2mG2tBTwPKfk/C4StLh3rkKWwiyYg+PeY8ELg== X-Google-Smtp-Source: AGHT+IFh3gQy7tFaohUA2cL+tyZIAMOXHl09IwIFqKMH+I37hcUIYv+TvIcaNn+lyZAnsKi6RUri X-Received: by 2002:a2e:720c:0:b0:2e4:f8e:3a64 with SMTP id 38308e7fff4ca-2e949518e3emr21831881fa.30.1716427127118; Wed, 22 May 2024 18:18:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427127; cv=none; d=google.com; s=arc-20160816; b=yaBVwPWJfBDPyic6jjpFuH4kfPcxHh25oOXfFxV3xcSDRRjQx+pmf5eXO5eqVx2iXB kQZOD0EB8ZFexFIcl873rx7aW+ayw6TfnS4WU6aKf7euA3dz5zbIZDj9PYzJfFdSxyuH Y7xABtmHUQ7h/IU0dk7JE4PDc2NFoprRDbRgCHVVTf2UwwMz3GvbYwBgItdLZbIRm+/C Q9ZMb0GZ8Q+fw0zBFZZFX6dXxRz/s6duMt72GDiJVZVDRKbSHa2r7WdiwZ06StAWWupY JwFeMFX8HpZ7X0Xnl0haVAz/XJOW0tySjMVQYrCD8RRtDfpwNZXCObissZxi4OKo/y9V 7Wmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=lsuudjnuT1QCf9sE4v94ENjFN1OLtS4JhP2WASqw0HQ=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=MkpVroJ9wGGGUD8NhOrWL5SPa3yK3rB5tWZN38fVMepxYx1+/J+g1wQ8VXCAfUKLMh oy22e7POw+lMq1d3Jxii3g3LnWK2PNh9sKdkTWrL7Nkzal2NRY6EPlcnPPqOp4/ZiLCH IqjUWc3DVOf0rNrfxrr8pAw1TWfYlB20OL1Yr8ZjCUrtzatMDcCtHT2ydWXpSxiI+ygb myq0jbROzgl4JzF+Y7bOci7PxUTSta1HLNyGLagwEkVTi3k0O35eNESZlzdyCbEJf+qy QRfcw78bwLlA/AesJsms8L6FVnv1VCG5XD/Q96K2X8XbxWxFqu0xb9yySgkwVlVbAgSy /aMg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=nTPDSKFf; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5733c2d5cbbsi15283246a12.307.2024.05.22.18.18.46; Wed, 22 May 2024 18:18:47 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=nTPDSKFf; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C8EC68D41D; Thu, 23 May 2024 04:18:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42CA068D229 for ; Thu, 23 May 2024 04:18:04 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 6E4B01C0004 for ; Thu, 23 May 2024 01:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9K4fHZld7xlSc2of2uaMGY1q3X7QZlD70/vZtNiU0h4=; b=nTPDSKFfVqjdekFZKN2rgAYYEaExKTAIaRSqL7k84NSBTz47ORtJYvXq36PnNUryCHY/7/ Qt73if4zAS6iGRyIOyKxxmTFPYAIADTW8bux5pJ7D19xniPZf7B/oh/KuBe2xCGsl6Y7S9 XXJigDdFRwbzz6yHrA/4UmrjMQIxY0TCbah0juGPORcdJafhBL8W0ds2W1P8A0LPZd2EtF DpIPVyZH6WwkINJpsI3OaG6ANWq+1SWpV4NC0PHhiAMKX7r9rrs/0pQtX8C3KsW8/0hG/0 iS5wAJ7n3cQ/ZxE5Z3YJpwTDWAyxVTvIM6cGQrGjKbSSGb7AiHMIp8FTDc/otA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:56 +0200 Message-ID: <20240523011758.2434580-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523011758.2434580-1-michael@niedermayer.cc> References: <20240523011758.2434580-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 5/7] avformat/asfdec_f: Use 64bit for preroll computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: w/orFsfWVytz Fixes: CID1500342 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/asfdec_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index fcc2b98a2c4..2441cadb444 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -675,7 +675,7 @@ static int asf_read_marker(AVFormatContext *s) avio_rl64(pb); // offset, 8 bytes pres_time = avio_rl64(pb); // presentation time - pres_time = av_sat_sub64(pres_time, asf->hdr.preroll * 10000); + pres_time = av_sat_sub64(pres_time, asf->hdr.preroll * 10000LL); avio_rl16(pb); // entry length avio_rl32(pb); // send time avio_rl32(pb); // flags From patchwork Thu May 23 01:17:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49159 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734664vqf; Wed, 22 May 2024 18:18:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVDvXUroPA3P4MAYqOVsYb4BGrmCweFxOmMY1fXnwOVHMaoretLlESaDwwtlZ1D8xLXLi7G0q13590fkH8BzVKlX+rwjmsiNszfvw== X-Google-Smtp-Source: AGHT+IE95ggYjpBuvt7BctGojuX6tsOGHBNtWYX4+KLHSvGbZt+T7uCdpgLfeeTUjyZ1arXHYhsM X-Received: by 2002:a17:906:3391:b0:a59:c807:72d3 with SMTP id a640c23a62f3a-a623e922f4fmr57153666b.17.1716427136342; Wed, 22 May 2024 18:18:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427136; cv=none; d=google.com; s=arc-20160816; b=E9y7PtqH8t9+31CduNRerBOVRj3TqGJfIxGdI00YRvSpjyvkdj9xoOlOQh2Qp5fAL/ Z3xn6TEQ05y8oI+3C0PquRzbwLdll5ENKTG3q1JekXnWz2qoqSChmSV15rVUpv5ArZB0 qA5tI2H6FeKDEUrF2dupqZQqlxn+tvTTw/R79u63TD5e587bcdgJIx0/Z58k97e7kuxZ LI50HFI0/y+kbZszoG/Gv2fS/XIGYhFRXDsQer0s+CU5RFYy+sh3DikFaX0MLCYEmJGC 5TuVPkQ4cMIpv2qQKPjokUtJ/wrDt5bf97hQudzYP9ObyBbA0vuTM87X1/rAWg2BOpXq ALVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=rYnHNY8SbH22C+gFcIouBeq1KC8p4Y9SVtYB1S5FlY4=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=cvmpK/kHwbPfrcxjiKDohtBkVklnf/coYGR990eXlo7NeEBqXQs4bHup1D1WrNKVMR aRWsa05qmTwWTYFD3WqHrG88c2X1pJHRProd2P6rVDqESo6OAbv8OWe4SRHNYiH84IiG 2gLh3RmRjw5W+WNo+u/BWSd2BVLBbWnC8cqSJGDqbAeuk/Qy0LblGhlk2px/3w5Qk5Lz iQl6mcY2gre8Kfee4/jSOKVK+Op567P9cag5gBvFbiCjC1n1wZZh9Ebjmj498ULMHgnL 1uzMmMu6qHPhQSSm8IaFKdIjbNFVa3KzAq3BfRaQ4l/lnvtqjyCmFwl9lREbmHaECdYb Aa1A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=bdyD5zwM; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a5a17b21bb5si1535846866b.346.2024.05.22.18.18.55; Wed, 22 May 2024 18:18:56 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=bdyD5zwM; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B19968D4A8; Thu, 23 May 2024 04:18:14 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6636168D48B for ; Thu, 23 May 2024 04:18:07 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AEC111BF203 for ; Thu, 23 May 2024 01:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=67NfwdmY1JD375pYxg/cqbokBvUmiiK3D5wBVbMABGQ=; b=bdyD5zwMjB79c/4S797ewHboHZK/Z8WvVdeZBeh3Jk5+7oq/PLRC95s4467jyR8FmtF2id fuyqypt41VFzVpesp6OUiYtx27+gL40YESHAu0jkZ1xiv+5nfNabfGs3YbZgceaC84sAp6 iBYqqaTLFS+qLI9aFKQ/BJXFPKlkdzec/wu+YZ1RJ2QpHAW5D6krhn2syjaUbcW8pGz98w AW4Ens7kJnMN7xebPZCF7MQyL05wdxP0OfPwIzMoFSKLPzR4YZuGnRAuw9XKSJFIUf5CaX obYbzA4o0zw4gO4pTPCZjgKOXXZsLs/Ii+RZ3pAcj57A66JLkOdyrcdkMUDKVA== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:57 +0200 Message-ID: <20240523011758.2434580-6-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523011758.2434580-1-michael@niedermayer.cc> References: <20240523011758.2434580-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 6/7] avcodec/sga: Make it clear that the return is intentionally not checked X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: D1/KdAqSVwWq Related: CID1473496 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/sga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sga.c b/libavcodec/sga.c index 0f42cf912b2..618df000ada 100644 --- a/libavcodec/sga.c +++ b/libavcodec/sga.c @@ -73,7 +73,7 @@ static int decode_palette(GetByteContext *gb, uint32_t *pal) return AVERROR_INVALIDDATA; memset(pal, 0, 16 * sizeof(*pal)); - init_get_bits8(&gbit, gb->buffer, 18); + (void)init_get_bits8(&gbit, gb->buffer, 18); for (int RGBIndex = 0; RGBIndex < 3; RGBIndex++) { for (int index = 0; index < 16; index++) { From patchwork Thu May 23 01:17:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49160 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp734710vqf; Wed, 22 May 2024 18:19:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUFfKzHRH+L/WNCiL7+tBMc5H9Zg4THnHHie+oz6+WzszXKvdiubyQaUfR9A4xhPuUaUaU6mtIIfsBaQJA3knVRCcTEBA6M27drbw== X-Google-Smtp-Source: AGHT+IGKQ53nD1HSCzoA4qJBExNaIcEEeZJCwl4o8DXFgpjqNIT7R/VtLDqj/r7pkZ15fvZd2obV X-Received: by 2002:a50:cc8f:0:b0:572:a731:dd16 with SMTP id 4fb4d7f45d1cf-57832c2cf0bmr2126635a12.28.1716427144912; Wed, 22 May 2024 18:19:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716427144; cv=none; d=google.com; s=arc-20160816; b=BDW/AHt0CKAYTL+E3WKYBv44O2DLu3MBjzodhxgIUy0XvksSx7LE/1NKWqps03rave PcYagwRB1pYm9s1gEU/xX7hLnguKmrI188aQro66IiptKKN2Yn3CxPrZ+dNrGJCE8NdA 9vRyGGSpyJjuEG4Pqkpa9wwc+K0e1Kec3bfuMD1STh5hd5hhi1k0Nildlc8ocnYHbbBY 7v3t9xaKOUfWIvSvdvfdqQdBXFZiIdz2q5RebsB/LhbHFDhRlMF9oOxBu2A3m9ZcYZ+S sJs/iWjm34PxjUTUsSDMYAa4knVxRULaglw0meP55vcZRkl33hpXAiVr9Ue3b4PViNwA cqrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=aPbPfMdAlPn8BQbPgT+C6QIEWif2xb+lTVZXYCflXos=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=w8vp3UBIySxoVbX1jCHzqJtE0GJyfBy0py4kYm6kS0UiJIxok3Mi++wnBYnQnoA0av y+C/evNBwMUFnXfjSoX8FZUEQeUqAmtpzmS4tQDGQ44qRZL6c7AJZICtTyKAmV7ytPzE s51Tjyhb6Xlp6mU5Jf102sFcX5XKRD39puyvTD1/ArIBNktJESsCQOcH21LKsfmTX4vq dQWIfUD/NuOqdRM9whS9rpoxKMjhFk6urCK9niPz4VUyDQ+TI7BnOvTO8bDIn1BcW4gP DgxUzvZgEEnjX/C4WXg+uDh+fQGzYiA/UEX7bbVYQh4nRcErRH/dgXA7c+n2k4pOvFjN JeVA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=LfJgUaT7; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5751dff15ebsi6672301a12.120.2024.05.22.18.19.04; Wed, 22 May 2024 18:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=LfJgUaT7; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F73E68D4B6; Thu, 23 May 2024 04:18:15 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F319568D495 for ; Thu, 23 May 2024 04:18:07 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5EDB960002 for ; Thu, 23 May 2024 01:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1716427087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/skFGDtqgH3xabZv3ahV1eGEGhHqjpiGx4jefal7R6U=; b=LfJgUaT7M2WvR8QMy3aD0VvJNMDxgeq3lkmrW2101qI8p9wt6mwSsPHMchDk9S3AUZevQ7 v7m1rhXf42JXzk/hyuJt7w2+4f8Wm6v1FIOP2RfqCPMVKdHfkP8RXBe7KPNtBgkMJ9KN5Z Nz48dkj5TlNHfI0oBbrlWOlsOxvqy1S3FK4akB9A23KQlmTfUkrLJEEJgxlzhu+KnSw7jA l85/l81QCFZiieBh2Is0cUqSz5o/6tey4ZPpikVLqwkOiIN0SRTa6TEqQzLZSIQjs/ikgl ALaJBTMKiLbl7qkFfvuDNHFtT1xEbu2bD10I9Tgy0UW/vUM+j/gEdkuulpJH6g== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 03:17:58 +0200 Message-ID: <20240523011758.2434580-7-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240523011758.2434580-1-michael@niedermayer.cc> References: <20240523011758.2434580-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: Make it clear that the return is intentionally not checked X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: VRIDxsM7wrqg Helps: CID1518967 Unchecked return value Helps: CID1518968 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/bitstream_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tests/bitstream_template.c b/libavcodec/tests/bitstream_template.c index ef59845154d..d8cf980bee1 100644 --- a/libavcodec/tests/bitstream_template.c +++ b/libavcodec/tests/bitstream_template.c @@ -74,7 +74,7 @@ int main(int argc, char **argv) for (unsigned i = 0; i < SIZE; i++) buf[i] = av_lfg_get(&lfg); - bits_init8 (&bc, buf, SIZE); + (void)bits_init8 (&bc, buf, SIZE); init_put_bits(&pb, dst, SIZE); /* use a random sequence of bitreading operations to transfer data