From patchwork Fri May 24 17:28:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49206 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp1895495vqf; Fri, 24 May 2024 10:29:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVy5QDB+fpKjEURp0mmqIJoczw6/282qLK9GAGzXAIoycdLBS4sMTyrc2+JcYaYfa/qZnzNtJCoJLtpBaqlWPgQkOGL0gTHyj3tWA== X-Google-Smtp-Source: AGHT+IEwvi7ou+zrQP34wiMn6zFsw2wxotRBXBRZ6mHig3yVfdxnrABSWmVorZWDTxnjl+yDurmu X-Received: by 2002:a17:906:63ca:b0:a59:a9c5:e73b with SMTP id a640c23a62f3a-a62647ce012mr184608766b.46.1716571748444; Fri, 24 May 2024 10:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716571748; cv=none; d=google.com; s=arc-20160816; b=w8aODkkvbTH6fs8iyiE1dGdZT/Q50PH/lKQujq6COoCCaeD+n5m3894rvL1d/o7/wz EkEMaohtG4vpTTG55Nf1J7JXtiLD509zrCnj7DUNfqZ5SpSqK5/ta887pmDZibrkL9gr HyJC1BFaADL/TGk7xDj0NhgAIBUV9QosWKrAK9bK1vyP36zTEmuzvkNTrI7Z7Ob+cRd9 ifMJqho25lOSlh6RkEQkUXtR+C34B5+LDAzwyg6JPIkNjHIjXWcI8BZD7ibuI1mlRCdv ACmxA0naQP80phHN9ISyrJzwyGIL7KFjhJ+AuOShFpEz9K/GulQUFD0HYyuWD8n8YfkE dVOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=byfJmaDE3U/kcarI3YgiWMJNOF12hHrHUdjXZQTbDpA=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=CaQ9fThzAkOOhQxP8KnOKar8ML5tvVLwr4Cr9+pQ8NXLcszsAwNcphlB2QBJlxegdM rf1wki0mSg0I6ogrgroJonv2NYJP1U3s7YDz7x+MxAsHG5Dqu1y4t8zE/OVKq14D1Xoo YdSNEB8Z5ZEy0otHgbALTC/+eBlLKuLL9twqvU7zfeIoze5TWt+pV22hGbf8INhzY1bd ++fvIZ7gvWiByLo90RumSHkknD/dg5klo/iyxWTIwbF6RVBjT1X+yX2xFoGfXZkk0ut7 0a2vcxfCRrMH8NANbsP/nRTUw3e6ly/4Psq/vYFF5jDabzCkR4JwR4GIeHfSBI7XbFPA 95yw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626cc36e1dsi95528066b.335.2024.05.24.10.29.07; Fri, 24 May 2024 10:29:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AE1E68D575; Fri, 24 May 2024 20:29:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 79E0468D503 for ; Fri, 24 May 2024 20:28:57 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 107ABC006E for ; Fri, 24 May 2024 20:28:57 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 24 May 2024 20:28:56 +0300 Message-ID: <20240524172856.33666-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/flacdsp: do not assume maximum R-V VL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: J8wDMMzALEhT This loop correctly assumes that VLMAX=16 (4x128-bit vectors with 32-bit elements) and 32 >= pred_order > 16. We need to alternate between VL=16 and VL=t2=pred_order-16 elements to add up to pred_order. The current code requests AVL=a2=pred_order elements. In QEMU and on thte K230 hardware, this sets VL=16 as we need. But the specification merely guarantees that we get: ceil(AVL / 2) <= VL <= VLMAX. For instance, if pred_order equals 27, we could end up with VL=14 or VL=15 instead of VL=16. So instead, request literally VLMAX=16. --- libavcodec/riscv/flacdsp_rvv.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/riscv/flacdsp_rvv.S b/libavcodec/riscv/flacdsp_rvv.S index 60c9d03344..da8756a2f9 100644 --- a/libavcodec/riscv/flacdsp_rvv.S +++ b/libavcodec/riscv/flacdsp_rvv.S @@ -56,11 +56,11 @@ func ff_flac_lpc32_rvv, zve64x vle32.v v16, (a0) sh2add a0, a2, a0 1: - vsetvli zero, a2, e32, m4, ta, ma + vsetvli t1, zero, e32, m4, ta, ma vwmul.vv v24, v8, v16 vsetvli zero, t2, e32, m4, tu, ma vwmacc.vv v24, v12, v20 - vsetvli zero, a2, e64, m8, ta, ma + vsetvli t1, zero, e64, m8, ta, ma vredsum.vs v24, v24, v0 lw t0, (a0) addi a4, a4, -1