From patchwork Sat May 25 11:58:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49253 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2269268vqf; Sat, 25 May 2024 04:59:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVjsqMUVp82R+m6eSwL8bMyjSzkdQqzh+SVDm+b6Tal+QRSiruE6SMjqsIF1e/1Ajgxcy2t9Kefv/sV6JqZNDYL4+R6G22RxtYSrQ== X-Google-Smtp-Source: AGHT+IFb72nq5pAMAsZ/XZB08hGfNhLLkPefyaxjGpTWAPgnOcdy6TS3biRMyScQmeHBSQ+zFFnn X-Received: by 2002:a17:906:1851:b0:a59:a0b6:638 with SMTP id a640c23a62f3a-a626512943amr292050666b.61.1716638344977; Sat, 25 May 2024 04:59:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716638344; cv=none; d=google.com; s=arc-20160816; b=YmklPRDgQUZV3vWKUxafWz19JPyjo79Tr0qvEtiYBvl9yZvm0ovyg3jHTxNwYGTJfm ewXr+AtJQRoC+Y+r2tAYUcutuyaSfge11yIjBdT8xvTo0xjbuzcsSvOXBXIRfBCt50yC mHVEnFptnndmlyjFOcEbYxPY5ja2ES5oIqjQklCUlxf5au+Z2UIR/Y38gMzbImPDGp9P VCR0LFg9js9Iu2t823XfAj5V9B5R4YdKhMyF6S+kt7yH2uoMzPK0eQ8jCJPD0n5Qp1iz 7Yt38XwP5WDm9qzj7+zhUlZbWzQtH/cF55Xe5rsGoKHxRQIQMtqYEpyRTTrlv1JsIhOf odlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=C9BdJfL5S4FLujmjL8i0cUQN9Li2K4hjBoPpdcpSTOE=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=Nrnit35WKA8QVN049Jnhn0Yr22sb+2ESrxMvxcNXAeJWQnj4FOATYCFZ+GMSsAs700 PJVi6PirUvlleeg9gqmtV2sJEIzpl2iIg7zVTDFYW8fXQT3b/1M3lOiE59+SIyzTLVRg 4amwJP7oGjFc2dTOPCmNQC6/dTXR5hd/AEClE0BgVYQ7QOYvrkTAxarVZb6uzix/6mPt F2AHcSQOBbxuBZy6Fk/3q4OyLNgeQ8F45s0HciuMjOcSddJC73BicvGsFQMqpNVYvHjW 1qWzVmm5JBY87+dQSaAxb5IJ1gWldL6CmlT/Taeq9ergmVNBIiereCPKsbFszGq2R8bm Ck0w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626cc66671si176124966b.577.2024.05.25.04.59.04; Sat, 25 May 2024 04:59:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A136B68D558; Sat, 25 May 2024 14:59:01 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3001268D2A2 for ; Sat, 25 May 2024 14:58:54 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 67CFAC006B for ; Sat, 25 May 2024 14:58:53 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Sat, 25 May 2024 14:58:53 +0300 Message-ID: <20240525115853.63379-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm/lpc: test compute_autocorr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: xEmFPESLrwva -- Change since previous version: - Disable test on x86, since the x86 optimisation fails with a suspiciously large and regular error with 10-20% probability. --- tests/checkasm/lpc.c | 54 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..38810325ac 100644 --- a/tests/checkasm/lpc.c +++ b/tests/checkasm/lpc.c @@ -16,6 +16,7 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +#include "libavutil/avassert.h" #include "libavutil/mem_internal.h" #include "libavcodec/lpc.h" @@ -57,10 +58,50 @@ static void test_window(int len) bench_new(src, len, dst1); } +#if !ARCH_X86 +static void test_compute_autocorr(ptrdiff_t len, int lag) +{ + LOCAL_ALIGNED(32, double, src, [5000 + 2 + MAX_LPC_ORDER]); + LOCAL_ALIGNED(16, double, dst0, [MAX_LPC_ORDER + 1]); + LOCAL_ALIGNED(16, double, dst1, [MAX_LPC_ORDER + 1]); + + declare_func(void, const double *in, ptrdiff_t len, int lag, double *out); + + av_assert0(lag >= 0 && lag <= MAX_LPC_ORDER); + + for (int i = 0; i < MAX_LPC_ORDER; i++) + src[i] = 0.; + + src += MAX_LPC_ORDER; + + for (ptrdiff_t i = 0; i < len; i++) { + src[i] = (double)rnd() / (double)UINT_MAX; + } + + call_ref(src, len, lag, dst0); + call_new(src, len, lag, dst1); + + for (size_t i = 0; i < lag; i++) { + if (!double_near_abs_eps(dst0[i], dst1[i], EPS)) { + fprintf(stderr, "%zu: %- .12f - %- .12f = % .12g\n", + i, dst0[i], dst1[i], dst0[i] - dst1[i]); + fail(); + break; + } + } + + bench_new(src, len, lag, dst1); +} +#endif + void checkasm_check_lpc(void) { LPCContext ctx; - int len = rnd() % 5000; + int len = 2000 + (rnd() % 3000); +#if !ARCH_X86 + static const int lags[] = { 10, 30, 32 }; +#endif + ff_lpc_init(&ctx, 32, 16, FF_LPC_TYPE_DEFAULT); if (check_func(ctx.lpc_apply_welch_window, "apply_welch_window_even")) { @@ -72,6 +113,15 @@ void checkasm_check_lpc(void) test_window(len | 1); } report("apply_welch_window_odd"); - ff_lpc_end(&ctx); + +#if !ARCH_X86 + for (size_t i = 0; i < FF_ARRAY_ELEMS(lags); i++) { + ff_lpc_init(&ctx, len, lags[i], FF_LPC_TYPE_DEFAULT); + if (check_func(ctx.lpc_compute_autocorr, "autocorr_%d", lags[i])) + test_compute_autocorr(len, lags[i]); + report("compute_autocorr_%d", lags[i]); + ff_lpc_end(&ctx); + } +#endif }