From patchwork Sat May 25 17:52:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49261 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2422268vqf; Sat, 25 May 2024 10:52:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX9q04AoY6WW2RWTAJdQrB8IGCodADav1rhka3xRWnEnuLAZcjNj2Lg5eYsgzw0tby/D1iAB9C1wdhdHMEkKF6QWlOidiWAMmC8Ww== X-Google-Smtp-Source: AGHT+IFSYdbTGFEhwVnZFrs6EEVlmDrLEEnnPG3WVEDY0LzGCF6SYHs2y7O2ZJYHQeDMyl1TXonc X-Received: by 2002:a19:8c08:0:b0:523:4e0a:7399 with SMTP id 2adb3069b0e04-52964ca8ba0mr2932792e87.39.1716659575639; Sat, 25 May 2024 10:52:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716659575; cv=none; d=google.com; s=arc-20160816; b=nryQqjATa4qHi7O7/vX67fZftpbRjc6nBb6dyUwm/QeRUWHfYrUut6RgeXiXswbqx6 KksOIGpqEjskwAaPCRUMeMmv6VkM42sso8DrKHLshDSAfMTijjMbQexXFPaTJfbAF7hf zA2/7du/ScC6dUjxBPJ80rM8Ry309bX17llNCApscfmKv7Q6wSc2+I/XLCp3Cu6SNRtL rCaXS8UppH24mRizQ9algwYsA2h1mEl72xQvlq923SeJCEY0bls0zmeMszWrYmwrXqEp oOyAjVDck7vlUDhxMhQkiTAh5dbQUlLiQeGxxYE1/LZI/0ykedHQRp7LPc39XtACEtm6 Vkpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=7qWgkuAGTsFBRL1vyr4itgsNUyvA4HUAn1DfwGUk/sE=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=DsPH+E/cZojgBMJ5IWDf1hCbYdOSFXUKuYwiRgtk9fGwR+1vbfHrVNRHXiL7VUwXd5 5cMVZlJnaDmOVXVEmj1ngJhBvaQSeCsjsNbuYsYASCi76uqbh9WsMMTsH9VVCJxneMsw xNg1ALsQ+840q8lBrQn0j0Opi7gK7ghDwNbsczsKoMyk4po3EFurnOfFlDImzxDaeDBu UOnS75jl1ZuGqVpG+NKVCjGpGNuiqEyPndF7rdtq3dJ7VImBK4h7mXsmse+RuXYAn/l8 4FFZ6UTJX26jO7oeLoaZugLh5lZTDg0G1vYLLenbfPTPfk8IjXlRrpxjByVfyLHQw63P EhDQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626c801217si197696766b.80.2024.05.25.10.52.55; Sat, 25 May 2024 10:52:55 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84CFE68D589; Sat, 25 May 2024 20:52:52 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2223D68D4D6 for ; Sat, 25 May 2024 20:52:45 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 8601EC006B for ; Sat, 25 May 2024 20:52:44 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Sat, 25 May 2024 20:52:44 +0300 Message-ID: <20240525175244.92412-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/sbrdsp: fix inverted boundary check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0EljxiJhe/jj 128-it is the maximum, not the minimum here. Larger vector sizes can result in reads past the end of the noise value table. This partially reverts commit cdcb4b98b7f74d87a6274899ff70724795d551cb. --- libavcodec/riscv/sbrdsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/riscv/sbrdsp_init.c b/libavcodec/riscv/sbrdsp_init.c index d3bafa961e..6c17b12ae0 100644 --- a/libavcodec/riscv/sbrdsp_init.c +++ b/libavcodec/riscv/sbrdsp_init.c @@ -52,7 +52,7 @@ av_cold void ff_sbrdsp_init_riscv(SBRDSPContext *c) c->sum_square = ff_sbr_sum_square_rvv; c->hf_gen = ff_sbr_hf_gen_rvv; c->hf_g_filt = ff_sbr_hf_g_filt_rvv; - if (ff_rv_vlen_least(128)) { + if (ff_get_rv_vlenb() <= 16) { c->hf_apply_noise[0] = ff_sbr_hf_apply_noise_0_rvv; c->hf_apply_noise[2] = ff_sbr_hf_apply_noise_2_rvv; if (flags & AV_CPU_FLAG_RVB_BASIC) {