From patchwork Tue May 28 19:57:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49334 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:8f0d:0:b0:460:55fa:d5ed with SMTP id i13csp196791vqu; Tue, 28 May 2024 12:57:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVivSP+GLZxPQRdXBotND+057CIr1EDA3PHxUOmEA6YpHpB/h7VZVd37R9rR8/cjkg0WwfgbXYccxz36Lz1Oj53LIl1yXMNH/tenw== X-Google-Smtp-Source: AGHT+IHaZUj1NVM2ro9Mu/g1s8r0HS+K/8T8ZjuHFAvO8ibKlbqONk3blFmPsIR2qpHhqqQZPM5e X-Received: by 2002:a17:907:7751:b0:a5a:8aea:343f with SMTP id a640c23a62f3a-a626511574amr742681266b.6.1716926268477; Tue, 28 May 2024 12:57:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716926268; cv=none; d=google.com; s=arc-20160816; b=jvAc7fI8XyvaaEHFUDeRBttbXUeToLattRov3CusGyvEovWh/JAT8yzYrM468V+uJJ NNcEv281uNJgDao7PEMMQG9Ovmkok9QPFUkkrP/JV6xrqE/oahX1KDcvNpp/kmouc5O+ iy/BrxJfSn0ELyA49oP3FVSPa49ecVkfjCEp9SOGun91065/oP6hnyc0wU9qIJVCgcZF 5AdTRnaAz9a7g/+1gqFaXnZrlFnScO36p392n81KqNRP3/uHAvbX4XviZ8M4MsWrbHYz v3pXJ/c6i/kEBznTlJ6ESF+DT8l72Dh941unCVD2nGLq1DSbHnmzFMOoKzY//HRDfVga i6rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=fcUqOyHEW8r/LsNld+rawZhZ5wNy4rQEAUHNktBlEQo=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=FoAeIArXfd3G9IETPF0p6p4kwuQ9Egp/TrojDpXs7p5nah0tkwxRz11vG+0QuHyyuE qEYO0Pn7XtaVdUOL2rGDEuwo4c01WdAXWs+W1cEzcaRbm5lPY8k451OVFd6AfAxkqJm1 QFuvosnW/iIqlgXj96KyZWn3+bWTmoCdIiR7wmqbdEY2CJTylRBDH+sDLPtTwl8K8OYg JwwXEub+tBI5lxm8CTIEkiSROGLVJ2Oot1DghWFSX5k86TS4e5rMY61vcXl3ih5Bw15S 0blgDmGehLKmBKJjKHlkegi7w6FLNSF/h36IjpfshRzebi9b/AonvAT69jp2Z6/asXey QCJg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a6350325f66si76360966b.115.2024.05.28.12.57.47; Tue, 28 May 2024 12:57:48 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A54F68D504; Tue, 28 May 2024 22:57:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D382668D24A for ; Tue, 28 May 2024 22:57:37 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id EF407C00A2 for ; Tue, 28 May 2024 22:57:36 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 28 May 2024 22:57:36 +0300 Message-ID: <20240528195736.62519-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm: add linear least square tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: iV+LrsKDUOFe --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/lls.c | 110 ++++++++++++++++++++++++++++++++++++++ tests/fate/checkasm.mak | 1 + 5 files changed, 114 insertions(+) create mode 100644 tests/checkasm/lls.c diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 1dc770e9da..6eb94d10d5 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -71,6 +71,7 @@ CHECKASMOBJS-$(CONFIG_SWSCALE) += $(SWSCALEOBJS) AVUTILOBJS += av_tx.o AVUTILOBJS += fixed_dsp.o AVUTILOBJS += float_dsp.o +AVUTILOBJS += lls.o CHECKASMOBJS-$(CONFIG_AVUTIL) += $(AVUTILOBJS) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 97c9b9fdd4..d7aa2a9c09 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -254,6 +254,7 @@ static const struct { #if CONFIG_AVUTIL { "fixed_dsp", checkasm_check_fixed_dsp }, { "float_dsp", checkasm_check_float_dsp }, + { "lls", checkasm_check_lls }, { "av_tx", checkasm_check_av_tx }, #endif { NULL } diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h index a42645c4ae..211d7f52e6 100644 --- a/tests/checkasm/checkasm.h +++ b/tests/checkasm/checkasm.h @@ -105,6 +105,7 @@ void checkasm_check_huffyuvdsp(void); void checkasm_check_idctdsp(void); void checkasm_check_jpeg2000dsp(void); void checkasm_check_llauddsp(void); +void checkasm_check_lls(void); void checkasm_check_llviddsp(void); void checkasm_check_llviddspenc(void); void checkasm_check_lpc(void); diff --git a/tests/checkasm/lls.c b/tests/checkasm/lls.c new file mode 100644 index 0000000000..96c97cd7a3 --- /dev/null +++ b/tests/checkasm/lls.c @@ -0,0 +1,110 @@ +/* + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with FFmpeg; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#include +//#include + +#include "libavutil/lls.h" +//#include "libavutil/internal.h" +//#include "libavutil/mem.h" +//#include "libavutil/mem_internal.h" + +#include "checkasm.h" + +#define LEN 256 + +#define randomize_buffer(buf) \ +do { \ + int i; \ + double bmg[2], stddev = 10.0, mean = 0.0; \ + \ + for (i = 0; i < LEN; i += 2) { \ + av_bmg_get(&checkasm_lfg, bmg); \ + buf[i] = bmg[0] * stddev + mean; \ + buf[i + 1] = bmg[1] * stddev + mean; \ + } \ +} while(0); + +static void test_update(LLSModel *lls, const double *var) +{ + double refcovar[MAX_VARS][MAX_VARS]; + declare_func(void, LLSModel *, const double *); + + call_ref(lls, var); + + for (size_t i = 0; i < MAX_VARS; i++) + for (size_t j = 0; j < MAX_VARS; j++) + refcovar[i][j] = lls->covariance[i][j]; + + memset(lls->covariance, 0, sizeof (lls->covariance)); + call_new(lls, var); + + for (size_t i = 0; i < lls->indep_count; i++) + for (size_t j = i; j < lls->indep_count; j++) + if (!double_near_abs_eps(refcovar[i][j], lls->covariance[i][j], + 2 * DBL_EPSILON)) { + fprintf(stderr, "%zu, %zu: %- .12f - %- .12f = % .12g\n", i, j, + refcovar[i][j], lls->covariance[i][j], + refcovar[i][j] - lls->covariance[i][j]); + fail(); + } + + bench_new(lls, var); +} + +#define EPS 0.2 +static void test_evaluate(LLSModel *lls, const double *param, int order) +{ + double refprod, newprod; + declare_func_float(double, LLSModel *, const double *, int); + + refprod = call_ref(lls, param, order); + newprod = call_new(lls, param, order); + + if (!double_near_abs_eps(refprod, newprod, EPS)) { + fprintf(stderr, "%- .12f - %- .12f = % .12g\n", + refprod, newprod, refprod - newprod); + fail(); + } + + if (order == lls->indep_count) + bench_new(lls, param, order); +} + +void checkasm_check_lls(void) +{ + static const unsigned char counts[] = { 8, 12, MAX_VARS, }; + + for (size_t i = 0; i < FF_ARRAY_ELEMS(counts); i++) { + LOCAL_ALIGNED_32(double, var, [MAX_VARS]); + LOCAL_ALIGNED_32(double, param, [MAX_VARS]); + LLSModel lls; + + avpriv_init_lls(&lls, counts[i]); + randomize_buffer(var); + randomize_buffer(param); + + if (check_func(lls.update_lls, "update_lls_%d", counts[i])) + test_update(&lls, var); + for (size_t j = 0; j <= i; j++) + if (check_func(lls.evaluate_lls, "evaluate_lls_%d_%d", counts[i], + counts[j])) + test_evaluate(&lls, param, counts[j]); + } + report("lls"); +} diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak index 8d2705165a..9490aef154 100644 --- a/tests/fate/checkasm.mak +++ b/tests/fate/checkasm.mak @@ -28,6 +28,7 @@ FATE_CHECKASM = fate-checkasm-aacencdsp \ fate-checkasm-idctdsp \ fate-checkasm-jpeg2000dsp \ fate-checkasm-llauddsp \ + fate-checkasm-lls \ fate-checkasm-llviddsp \ fate-checkasm-llviddspenc \ fate-checkasm-lpc \